[HACKERS] Changes to stringinfo.c

2013-10-26 Thread David Rowley
Hi, I'm just looking at the changed code in commit 3147acd63e0135aff9a6c4b01d861251925d97d9 and I'm wondering if we should perhaps test the performance of this before assuming too much that it is an improvement. I'm a bit concerned that now if there is not enough space in the buffer that we only

Re: [HACKERS] Pattern matching operators a index

2013-10-26 Thread Amit Kapila
On Wed, Oct 9, 2013 at 4:20 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 09.10.2013 13:24, Soroosh Sardari wrote: Now my question is: Is Postgre using btree for pattern matching query for varchar or other character string types? If it does, how i implement it for my new type?

Re: [HACKERS] Changes to stringinfo.c

2013-10-26 Thread Tom Lane
David Rowley dgrowle...@gmail.com writes: I'm just looking at the changed code in commit 3147acd63e0135aff9a6c4b01d861251925d97d9 and I'm wondering if we should perhaps test the performance of this before assuming too much that it is an improvement. I'm a bit concerned that now if there is not

Re: [HACKERS] RULE regression test fragility?

2013-10-26 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: [ patch for \a\t mode in rules and sanity_check output ] Committed with some minor adjustment of the comments. +1 (but what are those silly parens in pg_seclabels definition?), That's because it contain several UNION ALLs and ruleutils makes sure

Re: [HACKERS] RULE regression test fragility?

2013-10-26 Thread Andres Freund
On 2013-10-26 11:27:19 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: [ patch for \a\t mode in rules and sanity_check output ] Committed with some minor adjustment of the comments. Thanks. +1 (but what are those silly parens in pg_seclabels definition?), That's

Re: [HACKERS] RULE regression test fragility?

2013-10-26 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2013-10-26 11:27:19 -0400, Tom Lane wrote: +1 (but what are those silly parens in pg_seclabels definition?), That looks weird to me too, but it's surely not the fault of this patch. Maybe we should take a look at exactly what ruleutils is doing

Re: [HACKERS] RULE regression test fragility?

2013-10-26 Thread Andres Freund
On 2013-10-26 12:25:40 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2013-10-26 11:27:19 -0400, Tom Lane wrote: +1 (but what are those silly parens in pg_seclabels definition?), That looks weird to me too, but it's surely not the fault of this patch. Maybe we

Re: [HACKERS] proposal: lob conversion functionality

2013-10-26 Thread Noah Misch
On Fri, Oct 25, 2013 at 03:35:05PM +0200, Pavel Stehule wrote: 2013/10/24 Heikki Linnakangas hlinnakan...@vmware.com On 22.10.2013 13:55, Pavel Stehule wrote: 2013/10/21 Noah Mischn...@leadboat.com If you're prepared to change the function names and add the subset-oriented functions, I

Re: [HACKERS] Changes to stringinfo.c

2013-10-26 Thread David Rowley
On Sun, Oct 27, 2013 at 3:04 AM, Tom Lane t...@sss.pgh.pa.us wrote: David Rowley dgrowle...@gmail.com writes: I'm just looking at the changed code in commit 3147acd63e0135aff9a6c4b01d861251925d97d9 and I'm wondering if we should perhaps test the performance of this before assuming too much

Re: [HACKERS] high-dimensional knn-GIST tests (was Re: Cube extension kNN support)

2013-10-26 Thread Gordon Mohr
On 10/23/13 9:05 PM, Alvaro Herrera wrote: Gordon Mohr wrote: Thanks for this! I decided to give the patch a try at the bleeding edge with some high-dimensional vectors, specifically the 1.4 million 1000-dimensional Freebase entity vectors from the Google 'word2vec' project:

[HACKERS] PL/Python: domain over array support

2013-10-26 Thread Rodolfo Campero
The attached patch add support of domains over arrays to PL/Python (eg: CREATE DOMAIN my_domain AS integer[]). Basically it just uses get_base_element_type instead of get_element_type in plpy_typeio.c, and uses domain_check before returning a sequence as array in PLySequence_ToArray whenever

Re: [HACKERS] high-dimensional knn-GIST tests (was Re: Cube extension kNN support)

2013-10-26 Thread Gordon Mohr
On 10/23/13 9:05 PM, Alvaro Herrera wrote: Gordon Mohr wrote: Thanks for this! I decided to give the patch a try at the bleeding edge with some high-dimensional vectors, specifically the 1.4 million 1000-dimensional Freebase entity vectors from the Google 'word2vec' project: