Re: [HACKERS] dpkg-buildpackage fails on 9.2.6 on ubuntu 12.04.3 LTS

2013-12-17 Thread imagene...@gmail.com
Resolved. Regression test outputs for name and enum can be replaced with generated out. On Tue, Dec 17, 2013 at 12:17 AM, imagene...@gmail.com imagene...@gmail.com wrote: This is resolved by running dpkg-buildpackage with postgres and dpkg-buildpackage -rsudo with the postgresql source folder

Re: [HACKERS] Why no INSTEAD OF triggers on tables?

2013-12-17 Thread Marko Tiikkaja
On 12/17/13, 4:53 AM, Robert Haas wrote: Well, I'm specifically thinking of master partition tables. In that case, we really want an INSTEAD OF trigger. /me scratches head. So, put a BEFORE trigger, and make it return NULL. Same effect, different notation. But it's not the same effect at

Re: [HACKERS] Changeset Extraction Interfaces

2013-12-17 Thread Andres Freund
On 2013-12-16 23:01:16 -0500, Robert Haas wrote: On Sat, Dec 14, 2013 at 12:37 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-12-14 11:50:00 -0500, Robert Haas wrote: Well, it still seems to me that the right way to think about this is that the change stream begins at a certain

Re: [HACKERS] [PATCH] Negative Transition Aggregate Functions (WIP)

2013-12-17 Thread David Rowley
On Mon, Dec 16, 2013 at 9:36 PM, Hannu Krosing ha...@2ndquadrant.comwrote: On 12/16/2013 08:39 AM, David Rowley wrote: Any other ideas or +1's for any of the existing ones? +1, inverse good :) In the attached patch I've renamed negative to inverse. I've also disabled the inverse

Re: [HACKERS] Extension Templates S03E11

2013-12-17 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: Right. I think a lot of the tension comes from people being unconvinced that the existing extension feature is an ideal model for this sort of use-case. Extensions were mainly designed around the notion of a .so The effort here is all about extending the

Re: [HACKERS] Optimize kernel readahead using buffer access strategy

2013-12-17 Thread KONDO Mitsumasa
Hi, I fixed the patch to improve followings. - Can compile in MacOS. - Change GUC name enable_kernel_readahead to readahead_strategy. - Change POSIX_FADV_SEQUNENTIAL to POISX_FADV_NORMAL when we select sequential access strategy, this reason is later... I tested simple two access

Re: [HACKERS] [bug fix] pg_ctl always uses the same event source

2013-12-17 Thread MauMau
From: Amit Kapila amit.kapil...@gmail.com Few minor things: 1. evtHandle = RegisterEventSource(NULL, *event_source? event_source: DEFAULT_EVENT_SOURCE); In this code, you are trying to access the value (*event_source) and incase it is not initialised, it will not contain the value and could

[HACKERS] [bug fix] connection service file doesn't take effect with ECPG apps

2013-12-17 Thread MauMau
Hello, I've found a small bug of ECPG and attached a patch. I tested the fix with 9.4. I'd like the fix to be back-ported. [Problem] The ECPG app runs the statement: EXEC SQL CONNECT TO 'tcp:postgresql://?service=my_service'; I want this app to connect to any database based on the

Re: [HACKERS] Optimize kernel readahead using buffer access strategy

2013-12-17 Thread Simon Riggs
On 17 December 2013 11:50, KONDO Mitsumasa kondo.mitsum...@lab.ntt.co.jp wrote: Unpatched PG is faster than patched in A and B query. It was about 1.3 times faster. Result of A query as expected, because patched PG cannot execute readahead at all. So cache cold situation is bad for patched PG.

Re: [HACKERS] logical changeset generation v6.8

2013-12-17 Thread Andres Freund
On 2013-12-16 00:53:10 -0500, Robert Haas wrote: Yes, I think we could mostly reuse it, we'd probably want to add a field or two more (application_name, sync_prio?). I have been wondering whether some of the code in replication/logical/logical.c shouldn't be in replication/slot.c or

Re: [HACKERS] logical changeset generation v6.8

2013-12-17 Thread Robert Haas
On Tue, Dec 17, 2013 at 7:48 AM, Andres Freund and...@2ndquadrant.com wrote: On 2013-12-16 00:53:10 -0500, Robert Haas wrote: Yes, I think we could mostly reuse it, we'd probably want to add a field or two more (application_name, sync_prio?). I have been wondering whether some of the code

Re: [HACKERS] Why no INSTEAD OF triggers on tables?

2013-12-17 Thread Robert Haas
On Tue, Dec 17, 2013 at 3:27 AM, Marko Tiikkaja ma...@joh.to wrote: On 12/17/13, 4:53 AM, Robert Haas wrote: Well, I'm specifically thinking of master partition tables. In that case, we really want an INSTEAD OF trigger. /me scratches head. So, put a BEFORE trigger, and make it return

Re: [HACKERS] pg_rewarm status

2013-12-17 Thread Robert Haas
On Tue, Dec 17, 2013 at 12:09 AM, Amit Kapila amit.kapil...@gmail.com wrote: I have used pg_prewarm during some of work related to Buffer Management and other performance related work. It is quite useful utility. +1 for reviving this patch for 9.4 Any other votes? -- Robert Haas

Re: [HACKERS] Useless Replica Identity: NOTHING noise from psql \d

2013-12-17 Thread Robert Haas
On Mon, Dec 16, 2013 at 7:25 AM, Andres Freund and...@2ndquadrant.com wrote: On 2013-12-14 17:43:36 +0100, Andres Freund wrote: On 2013-12-14 11:27:53 -0500, Tom Lane wrote: In HEAD: regression=# \d pg_depend Table pg_catalog.pg_depend Column| Type | Modifiers

Re: [HACKERS] Changeset Extraction Interfaces

2013-12-17 Thread Robert Haas
On Tue, Dec 17, 2013 at 4:31 AM, Andres Freund and...@2ndquadrant.com wrote: On 2013-12-16 23:01:16 -0500, Robert Haas wrote: On Sat, Dec 14, 2013 at 12:37 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-12-14 11:50:00 -0500, Robert Haas wrote: Well, it still seems to me that the

Re: [HACKERS] SSL: better default ciphersuite

2013-12-17 Thread Robert Haas
On Sun, Dec 15, 2013 at 5:10 PM, James Cloos cl...@jhcloos.com wrote: For reference, see: https://wiki.mozilla.org/Security/Server_Side_TLS for the currently suggested suite for TLS servers. ... But for pgsql, I'd leave off the !PSK; pre-shared keys may prove useful for some. And RC4,

Re: [HACKERS] Proposal: variant of regclass

2013-12-17 Thread Robert Haas
On Mon, Dec 16, 2013 at 8:22 PM, Tatsuo Ishii is...@postgresql.org wrote: static Datum regclass_gut(char *class_name_or_oid, bool raiseError); static List *stringToQualifiedNameList_gut(const char *string, bool raiseError); Please spell that as guts not gut. Thanks. I see. regclass_gut

Re: [HACKERS] stuck spinlock

2013-12-17 Thread bricklen
On Mon, Dec 16, 2013 at 6:46 AM, Tom Lane t...@sss.pgh.pa.us wrote: Andres Freund and...@2ndquadrant.com writes: Hard to say, the issues fixed in the release are quite important as well. I'd tend to say they are more important. I think we just need to release 9.3.3 pretty soon. Yeah.

Re: [HACKERS] Extension Templates S03E11

2013-12-17 Thread Stephen Frost
* Dimitri Fontaine (dimi...@2ndquadrant.fr) wrote: OTOH, for a set of pure-SQL objects, it's not necessary that there be a canonical text file somewhere, and we have in principle complete knowledge of the objects' semantics as well as the ability to dump-and-restore into newer PG versions.

Re: [HACKERS] patch: make_timestamp function

2013-12-17 Thread Pavel Stehule
Hello updated patch time zone type functions are overloaded now postgres=# select '1973-07-15 08:15:55.33+02'::timestamptz; timestamptz --- 1973-07-15 07:15:55.33+01 (1 row) postgres=# SELECT make_timestamptz(1973, 07, 15, 08, 15, 55.33, 2);

Re: [HACKERS] commit fest 2013-11 final report

2013-12-17 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: Committers should now try to get the Ready for Committer queue cleared. I'm still hacking on the WITHIN GROUP patch, and will look at the planner indexes thing after that's done. That leaves 8 patches that haven't been reviewed. If you take a look,

Re: [HACKERS] patch: make_timestamp function

2013-12-17 Thread Jim Nasby
On 12/15/13, 12:59 PM, Pavel Stehule wrote: Why wouldn't we have a version that optionally accepts the timezone? That mirrors what you can currently do with a cast from text, and having to set the GUC if you need a different TZ would be a real PITA. It is not bad idea. What will be

Re: [HACKERS] pg_rewarm status

2013-12-17 Thread Jim Nasby
On 12/17/13, 8:34 AM, Robert Haas wrote: On Tue, Dec 17, 2013 at 12:09 AM, Amit Kapila amit.kapil...@gmail.com wrote: I have used pg_prewarm during some of work related to Buffer Management and other performance related work. It is quite useful utility. +1 for reviving this patch for 9.4 Any

Re: [HACKERS] 9.3 reference constraint regression

2013-12-17 Thread Alvaro Herrera
Andres Freund wrote: On 2013-12-16 17:43:37 -0300, Alvaro Herrera wrote: Alvaro Herrera wrote: This POC patch changes the two places in HeapTupleSatisfiesUpdate that need to be touched for this to work. This is probably too simplistic, in that I make the involved cases return

Re: [HACKERS] patch: make_timestamp function

2013-12-17 Thread Pavel Stehule
2013/12/17 Jim Nasby j...@nasby.net On 12/15/13, 12:59 PM, Pavel Stehule wrote: Why wouldn't we have a version that optionally accepts the timezone? That mirrors what you can currently do with a cast from text, and having to set the GUC if you need a different TZ would be a real PITA.

Re: [HACKERS] patch: make_timestamp function

2013-12-17 Thread Alvaro Herrera
Pavel Stehule escribió: but AT TIME ZONE allows double (but decimal parts is ignored quietly) postgres=# select make_time(10,20,30) at time zone '+10.2'; timezone - 23:20:30-10 so I propose (and I implemented) a variant with int as time zone and we can (if we would)

Re: [HACKERS] pg_rewarm status

2013-12-17 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: Amit Kapila amit.kapil...@gmail.com wrote: I have used pg_prewarm during some of work related to Buffer Management and other performance related work. It is quite useful utility. +1 for reviving this patch for 9.4 Any other votes? Where I would have

Re: [HACKERS] SSL: better default ciphersuite

2013-12-17 Thread Bruce Momjian
On Tue, Dec 17, 2013 at 09:51:30AM -0500, Robert Haas wrote: On Sun, Dec 15, 2013 at 5:10 PM, James Cloos cl...@jhcloos.com wrote: For reference, see: https://wiki.mozilla.org/Security/Server_Side_TLS for the currently suggested suite for TLS servers. ... But for pgsql, I'd leave

Re: [HACKERS] pg_rewarm status

2013-12-17 Thread Robert Haas
On Tue, Dec 17, 2013 at 11:02 AM, Jim Nasby j...@nasby.net wrote: On 12/17/13, 8:34 AM, Robert Haas wrote: On Tue, Dec 17, 2013 at 12:09 AM, Amit Kapila amit.kapil...@gmail.com wrote: I have used pg_prewarm during some of work related to Buffer Management and other performance related

Re: [HACKERS] patch: make_timestamp function

2013-12-17 Thread Tom Lane
Alvaro Herrera alvhe...@2ndquadrant.com writes: Yeah, I think a constructor should allow a text timezone. Yes. I think a numeric timezone parameter is about 99% useless, and if you do happen to need that behavior you can just cast the numeric to text no? regards, tom

Re: [HACKERS] patch: make_timestamp function

2013-12-17 Thread Pavel Stehule
2013/12/17 Tom Lane t...@sss.pgh.pa.us Alvaro Herrera alvhe...@2ndquadrant.com writes: Yeah, I think a constructor should allow a text timezone. Yes. I think a numeric timezone parameter is about 99% useless, and if you do happen to need that behavior you can just cast the numeric to text

Re: [HACKERS] ANALYZE sampling is too good

2013-12-17 Thread Heikki Linnakangas
On 12/17/2013 12:06 AM, Jeff Janes wrote: On Mon, Dec 9, 2013 at 3:14 PM, Heikki Linnakangas hlinnakan...@vmware.comwrote: I took a stab at using posix_fadvise() in ANALYZE. It turned out to be very easy, patch attached. Your mileage may vary, but I'm seeing a nice gain from this on my

Re: [HACKERS] patch: make_timestamp function

2013-12-17 Thread Pavel Stehule
2013/12/17 Alvaro Herrera alvhe...@2ndquadrant.com Pavel Stehule escribió: but AT TIME ZONE allows double (but decimal parts is ignored quietly) postgres=# select make_time(10,20,30) at time zone '+10.2'; timezone - 23:20:30-10 so I propose (and I implemented) a

Re: [HACKERS] row security roadmap proposal

2013-12-17 Thread Robert Haas
On Mon, Dec 16, 2013 at 3:12 PM, Gregory Smith gregsmithpg...@gmail.com wrote: On 12/16/13 9:36 AM, Craig Ringer wrote: - Finish and commit updatable security barrier views. I've still got a lot of straightening out to do there. I don't follow why you've put this part first. It has a lot of

Re: [HACKERS] Patch: show xid and xmin in pg_stat_activity and pg_stat_replication

2013-12-17 Thread Robert Haas
On Tue, Dec 17, 2013 at 9:58 AM, Christian Kruse christ...@2ndquadrant.com wrote: Hi, attached you will find a patch for showing the current transaction id (xid) and the xmin of a backend in pg_stat_activty and the xmin in pg_stat_replication. This may be helpful when looking for the cause

Re: [HACKERS] patch: make_timestamp function

2013-12-17 Thread Pavel Stehule
Hello 2013/12/17 Pavel Stehule pavel.steh...@gmail.com 2013/12/17 Tom Lane t...@sss.pgh.pa.us Alvaro Herrera alvhe...@2ndquadrant.com writes: Yeah, I think a constructor should allow a text timezone. Yes. I think a numeric timezone parameter is about 99% useless, and if you do

Re: [HACKERS] Extension Templates S03E11

2013-12-17 Thread Dimitri Fontaine
Stephen Frost sfr...@snowman.net writes: My thinking is that if we invent a new mechanism for extensions that are not managed like contribs, we will find out that only contribs are going to be using extensions. That's only accurate if the new mechanism supports .so's, which seems unlikely to

Re: [HACKERS] planner missing a trick for foreign tables w/OR conditions

2013-12-17 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Dec 16, 2013 at 6:59 PM, Tom Lane t...@sss.pgh.pa.us wrote: The hard part is not extracting the partial qual. The hard part is trying to make sure that adding this entirely-redundant scan qual doesn't catastrophically degrade join size

Re: [HACKERS] patch: make_timestamp function

2013-12-17 Thread Bruce Momjian
On Tue, Dec 17, 2013 at 06:07:38PM +0100, Pavel Stehule wrote: Hello 2013/12/17 Pavel Stehule pavel.steh...@gmail.com 2013/12/17 Tom Lane t...@sss.pgh.pa.us Alvaro Herrera alvhe...@2ndquadrant.com writes: Yeah, I think a constructor should allow a text

Re: [HACKERS] pg_rewarm status

2013-12-17 Thread Jeff Janes
On Tue, Dec 17, 2013 at 8:02 AM, Jim Nasby j...@nasby.net wrote: On 12/17/13, 8:34 AM, Robert Haas wrote: On Tue, Dec 17, 2013 at 12:09 AM, Amit Kapila amit.kapil...@gmail.com wrote: I have used pg_prewarm during some of work related to Buffer Management and other performance related

Re: [HACKERS] Extension Templates S03E11

2013-12-17 Thread Stephen Frost
* Dimitri Fontaine (dimi...@2ndquadrant.fr) wrote: Stephen Frost sfr...@snowman.net writes: My thinking is that if we invent a new mechanism for extensions that are not managed like contribs, we will find out that only contribs are going to be using extensions. That's only accurate if

Re: [HACKERS] Why no INSTEAD OF triggers on tables?

2013-12-17 Thread Josh Berkus
On 12/16/2013 07:53 PM, Robert Haas wrote: So, put a BEFORE trigger, and make it return NULL. Same effect, different notation. NOT the same: Master partition table with BEFORE trigger: josh=# insert into a ( id, val ) values ( 23, 'test' ), ( 24, 'test'), (25,'test'); INSERT 0 0 ^^^

Re: [HACKERS] patch: make_timestamp function

2013-12-17 Thread Michael Weber
There are also timezones off by 15 minutes (although only a few, mainly Nepal). The only integer representation I've ever seen is in 15 minutes units. http://www.timeanddate.com/time/time-zones-interesting.html On Tue, Dec 17, 2013 at 12:33 PM, Bruce Momjian br...@momjian.us wrote: On Tue,

Re: [HACKERS] Minor comment improvement

2013-12-17 Thread Bruce Momjian
On Fri, Dec 13, 2013 at 06:53:02PM +0900, Etsuro Fujita wrote: This is a small patch a bit improving a comment in src/backend/commands/copy.c. Thanks, applied. -- Bruce Momjian br...@momjian.ushttp://momjian.us EnterpriseDB http://enterprisedb.com +

Re: [HACKERS] Extension Templates S03E11

2013-12-17 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Stephen Frost sfr...@snowman.net writes: That's only accurate if the new mechanism supports .so's, which seems unlikely to be the case. Really? Yes, really. So now, you don't need anymore to have file system write privileges into a central

Re: [HACKERS] planner missing a trick for foreign tables w/OR conditions

2013-12-17 Thread Robert Haas
On Tue, Dec 17, 2013 at 12:28 PM, Tom Lane t...@sss.pgh.pa.us wrote: I had been thinking it would fall down if there are several OR conditions affecting different collections of rels, but after going through the math again, I'm now thinking I was wrong and it does in fact work out. As you

Re: [HACKERS] Extension Templates S03E11

2013-12-17 Thread Josh Berkus
On 12/16/2013 11:44 AM, Tom Lane wrote: Right. I think a lot of the tension comes from people being unconvinced that the existing extension feature is an ideal model for this sort of use-case. Extensions were mainly designed around the notion of a .so with some SQL datatype/function/etc

Re: [HACKERS] Extension Templates S03E11

2013-12-17 Thread Simon Riggs
On 13 December 2013 18:42, Stephen Frost sfr...@snowman.net wrote: * Jeff Davis (pg...@j-davis.com) wrote: For what it's worth, I think the idea of extension templates has good conceptual integrity. Extensions are external blobs. To make them work more smoothly in several ways, we move them

Re: [HACKERS] row security roadmap proposal

2013-12-17 Thread Simon Riggs
On 16 December 2013 14:36, Craig Ringer cr...@2ndquadrant.com wrote: - Decide on and implement a structure for row-security functionality its self. I'm persuaded by Robert's comments here, that whatever we expose must be significantly more usable than a DIY on top of views (with the fix for

Re: [HACKERS] Extension Templates S03E11

2013-12-17 Thread Stephen Frost
* Simon Riggs (si...@2ndquadrant.com) wrote: I keep seeing people repeat I don't like blobs as if that were an objection. There is no danger or damage from doing this. I can't see any higher beauty that we're striving for by holding out. Why not allow the user to choose XML, JSON, YAML, or

Re: [HACKERS] preserving forensic information when we freeze

2013-12-17 Thread Robert Haas
On Wed, Dec 11, 2013 at 5:25 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Andres Freund escribió: What's your plan to commit this? I'd prefer to wait till Alvaro's freezing changes get in, so his patch will look the same in HEAD and 9.3. But I think he plans to commit soon. Yes, I do.

Re: [HACKERS] Extension Templates S03E11

2013-12-17 Thread Heikki Linnakangas
On 12/17/2013 08:32 PM, Stephen Frost wrote: * Simon Riggs (si...@2ndquadrant.com) wrote: My only personal interest in this is to stimulate the writing of further extensions, which is fairly clearly hampered by the overhead required for packaging. I'm not convinced of that but I agree that we

[HACKERS] processing time zone

2013-12-17 Thread Pavel Stehule
I had to write obscure code for processing time zone and using it for timestamptz Datum make_timestamptz_at_timezone(PG_FUNCTION_ARGS) { Timestamp timestamp; text *zone; int tz; chartzname[TZ_STRLEN_MAX + 1]; char

Re: [HACKERS] row security roadmap proposal

2013-12-17 Thread Simon Riggs
On 17 December 2013 17:03, Robert Haas robertmh...@gmail.com wrote: On Mon, Dec 16, 2013 at 3:12 PM, Gregory Smith gregsmithpg...@gmail.com wrote: On 12/16/13 9:36 AM, Craig Ringer wrote: - Finish and commit updatable security barrier views. I've still got a lot of straightening out to do

Re: [HACKERS] SSL: better default ciphersuite

2013-12-17 Thread Adrian Klaver
On 12/17/2013 08:26 AM, Bruce Momjian wrote: On Tue, Dec 17, 2013 at 09:51:30AM -0500, Robert Haas wrote: On Sun, Dec 15, 2013 at 5:10 PM, James Cloos cl...@jhcloos.com wrote: For reference, see: https://wiki.mozilla.org/Security/Server_Side_TLS for the currently suggested suite for TLS

Re: [HACKERS] pg_rewarm status

2013-12-17 Thread Robert Haas
On Tue, Dec 17, 2013 at 3:31 PM, MauMau maumau...@gmail.com wrote: Any other votes? +1 Some customers requested: 1. fill the database cache with frequently accessed data before starting or resuming service for their users (for the first time or after maintenance work), so that they can

Re: [HACKERS] SSL: better default ciphersuite

2013-12-17 Thread Marko Kreen
On Tue, Dec 17, 2013 at 11:26:13AM -0500, Bruce Momjian wrote: On Tue, Dec 17, 2013 at 09:51:30AM -0500, Robert Haas wrote: I'm starting to think we should just leave this well enough alone. We can't seem to find two people with the same idea of what would be better than what we have now.

Re: [HACKERS] SSL: better default ciphersuite

2013-12-17 Thread Gavin Flower
On 18/12/13 05:26, Bruce Momjian wrote: On Tue, Dec 17, 2013 at 09:51:30AM -0500, Robert Haas wrote: On Sun, Dec 15, 2013 at 5:10 PM, James Cloos cl...@jhcloos.com wrote: For reference, see: https://wiki.mozilla.org/Security/Server_Side_TLS for the currently suggested suite for TLS

Re: [HACKERS] pg_rewarm status

2013-12-17 Thread MauMau
From: Robert Haas robertmh...@gmail.com On Tue, Dec 17, 2013 at 12:09 AM, Amit Kapila amit.kapil...@gmail.com wrote: I have used pg_prewarm during some of work related to Buffer Management and other performance related work. It is quite useful utility. +1 for reviving this patch for 9.4 Any

Re: [HACKERS] pg_rewarm status

2013-12-17 Thread Josh Berkus
On 12/17/2013 06:34 AM, Robert Haas wrote: On Tue, Dec 17, 2013 at 12:09 AM, Amit Kapila amit.kapil...@gmail.com wrote: I have used pg_prewarm during some of work related to Buffer Management and other performance related work. It is quite useful utility. +1 for reviving this patch for 9.4

[HACKERS] GiST support for inet datatypes

2013-12-17 Thread Emre Hasegeli
Hi, Attached patch adds GiST support to the inet datatypes with two new operators. Overlaps operator can be used with exclusion constraints. Is adjacent to operator is just the negator of it. Index uses only the network bits of the addresses. Except for the new operators and is contained within,

Re: [HACKERS] SSL: better default ciphersuite

2013-12-17 Thread Marko Kreen
On Sun, Dec 15, 2013 at 05:10:38PM -0500, James Cloos wrote: MK == Marko Kreen mark...@gmail.com writes: PE == Peter Eisentraut pete...@gmx.net writes: PE Any other opinions on this out there? For reference, see: https://wiki.mozilla.org/Security/Server_Side_TLS for the currently

Re: [HACKERS] planner missing a trick for foreign tables w/OR conditions

2013-12-17 Thread Simon Riggs
On 17 December 2013 17:28, Tom Lane t...@sss.pgh.pa.us wrote: So at this point I'm pretty much talked into it. We could eliminate the dependence on indexes entirely, and replace this code with a step that simply tries to pull single-base-relation quals out of ORs wherever it can find one.

Re: [HACKERS] planner missing a trick for foreign tables w/OR conditions

2013-12-17 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Dec 17, 2013 at 12:28 PM, Tom Lane t...@sss.pgh.pa.us wrote: (I wonder if it'd be worth inserting a check that there's not already a manually-generated equivalent clause, too ...) Sounds a little too clever IMHO. The argument for doing it is

Re: [HACKERS] planner missing a trick for foreign tables w/OR conditions

2013-12-17 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: What surprises me is we don't have an API that allows an FDW to decide what it can accept or not. It seems strange to have a unilateral decision by our planner about what another planner is capable of. Uh, what? There's certainly missing features in

Re: [HACKERS] [PATCH] SQL assertions prototype

2013-12-17 Thread Josh Berkus
On 11/15/2013 05:41 AM, Heikki Linnakangas wrote: A fundamental problem with this is that it needs to handle isolation reliable, so that the assertion cannot be violated when two concurrent backends do things. Consider the example from the manual, which checks that a table has at least one

Re: [HACKERS] 9.3 reference constraint regression

2013-12-17 Thread Alvaro Herrera
Alvaro Herrera wrote: Well, it would help if those cases weren't dead code. Neither heap_update nor heap_delete are ever called in the no wait case at all. Only heap_lock_tuple is, and I can't see any misbehavior there either, even with HeapTupleBeingUpdated returned when there's a

Re: [HACKERS] [bug fix] multibyte messages are displayed incorrectly on the client

2013-12-17 Thread Bruce Momjian
On Fri, Dec 13, 2013 at 10:41:17PM +0900, MauMau wrote: [Cause] While the session is being established, the server cannot use the client encoding for message conversion yet, because it cannot access system catalogs to retrieve conversion functions. So, the server sends messages to the client

Re: [HACKERS] [PATCH] SQL assertions prototype

2013-12-17 Thread Kevin Grittner
Josh Berkus j...@agliodbs.com wrote: On 11/15/2013 05:41 AM, Heikki Linnakangas wrote: A fundamental problem with this is that it needs to handle isolation reliable, so that the assertion cannot be violated when two concurrent backends do things. Consider the example from the manual, which

Re: [HACKERS] [PATCH] SQL assertions prototype

2013-12-17 Thread Andrew Dunstan
On 12/17/2013 04:42 PM, Kevin Grittner wrote: Josh Berkus j...@agliodbs.com wrote: On 11/15/2013 05:41 AM, Heikki Linnakangas wrote: A fundamental problem with this is that it needs to handle isolation reliable, so that the assertion cannot be violated when two concurrent backends do things.

Re: [HACKERS] [PATCH] SQL assertions prototype

2013-12-17 Thread Gavin Flower
On 18/12/13 10:48, Andrew Dunstan wrote: On 12/17/2013 04:42 PM, Kevin Grittner wrote: Josh Berkus j...@agliodbs.com wrote: On 11/15/2013 05:41 AM, Heikki Linnakangas wrote: A fundamental problem with this is that it needs to handle isolation reliable, so that the assertion cannot be

Re: [HACKERS] Extension Templates S03E11

2013-12-17 Thread Simon Riggs
On 17 December 2013 17:54, Tom Lane t...@sss.pgh.pa.us wrote: So now, you don't need anymore to have file system write privileges into a central place owned by root, it can be anywhere else, Modern OSes have security checks that can prevent loading libraries from random places. This is

Re: [HACKERS] Extension Templates S03E11

2013-12-17 Thread Simon Riggs
On 17 December 2013 18:32, Stephen Frost sfr...@snowman.net wrote: * Simon Riggs (si...@2ndquadrant.com) wrote: I keep seeing people repeat I don't like blobs as if that were an objection. There is no danger or damage from doing this. I can't see any higher beauty that we're striving for by

Re: [HACKERS] Extension Templates S03E11

2013-12-17 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: On 17 December 2013 18:32, Stephen Frost sfr...@snowman.net wrote: I have no idea where you're going with this, but I *do* object to sticking an SQL script which defines a bunch of objects into a catalog table *right next to where they are properly

Re: [HACKERS] commit fest 2013-11 final report

2013-12-17 Thread Peter Eisentraut
On 12/17/13, 10:19 AM, Tom Lane wrote: Perhaps we should just move all the Needs Review and RFC patches forward to the next fest, so we don't forget about them? This was done the last few times, but it has caused some controversy. One problem was that a number of patches arrived in this commit

Re: [HACKERS] Extension Templates S03E11

2013-12-17 Thread Simon Riggs
On 17 December 2013 23:42, Tom Lane t...@sss.pgh.pa.us wrote: We aim to have the simplest implementation that meets the stated need and reasonable extrapolations of that. Text in a catalog table is the simplest implementation. That is not a reason to reject it, especially when we aren't

Re: [HACKERS] [PATCH] SQL assertions prototype

2013-12-17 Thread Josh Berkus
On 12/17/2013 01:42 PM, Kevin Grittner wrote: Josh Berkus j...@agliodbs.com wrote: Going back over this patch, I haven't seen any further discussion of the point Heikki raises above, which seems like a bit of a showstopper. Heikki, did you have specific ideas on how to solve this? Right now

[HACKERS] [PATCH] Doc fix for VACUUM FREEZE

2013-12-17 Thread Maciek Sakrejda
VACUUM FREEZE sets both vacuum_freeze_min_age and vacuum_freeze_table_age to 0, but only the former is documented. This patch notes that the other setting is also affected.

Re: [HACKERS] [PATCH] Doc fix for VACUUM FREEZE

2013-12-17 Thread Maciek Sakrejda
(now with patch--sorry about that) diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml index eb71581..5f03343 100644 --- a/doc/src/sgml/ref/vacuum.sgml +++ b/doc/src/sgml/ref/vacuum.sgml @@ -100,8 +100,9 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] ANALYZE [ replaceable

Re: [HACKERS] pg_rewarm status

2013-12-17 Thread KONDO Mitsumasa
(2013/12/18 5:33), Robert Haas wrote: Sounds like it might be worth dusting the patch off again... I'd like to request you to add all_index option and usage_count option. When all_index option is selected, all index become rewarm nevertheless user doesn't input relation name. And usage_count

Re: [HACKERS] Optimize kernel readahead using buffer access strategy

2013-12-17 Thread KONDO Mitsumasa
(2013/12/17 21:29), Simon Riggs wrote: These are interesting results. Good research. Thanks! They also show that the benefit of this is very specific to the exact task being performed. I can't see any future for a setting that applies to everything or nothing. We must be more selective. This

Re: [HACKERS] Logging WAL when updating hintbit

2013-12-17 Thread Amit Kapila
On Fri, Dec 13, 2013 at 7:57 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/13/2013 07:55 AM, Sawada Masahiko wrote: On Fri, Dec 13, 2013 at 1:51 PM, Dilip kumar dilip.ku...@huawei.com wrote: On 04 December 2013, Sawada Masahiko Wrote I have modified the patch base on your

Re: [HACKERS] [bug fix] pg_ctl always uses the same event source

2013-12-17 Thread Amit Kapila
On Tue, Dec 17, 2013 at 5:33 PM, MauMau maumau...@gmail.com wrote: From: Amit Kapila amit.kapil...@gmail.com Few minor things: event_source here is a global static char array, so it's automatically initialized with zeros and safe to access. Right, I had missed that point. 2. minor

Re: [HACKERS] Logging WAL when updating hintbit

2013-12-17 Thread Michael Paquier
On Wed, Dec 18, 2013 at 11:22 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Fri, Dec 13, 2013 at 7:57 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Thanks, committed with some minor changes: Should this patch in CF app be moved to Committed Patches or is there something left for

Re: [HACKERS] Problem with displaying wide tables in psql

2013-12-17 Thread Sameer Thakur
On Wed, Dec 11, 2013 at 11:13 PM, Sergey Muraviov sergey.k.murav...@gmail.com wrote: Hi. I've improved the patch. It works in expanded mode when either format option is set to wrapped (\pset format wrapped), or we have no pager, or pager doesn't chop long lines (so you can still use the

Re: [HACKERS] row security roadmap proposal

2013-12-17 Thread Craig Ringer
On 12/18/2013 01:03 AM, Robert Haas wrote: On Mon, Dec 16, 2013 at 3:12 PM, Gregory Smith gregsmithpg...@gmail.com wrote: On 12/16/13 9:36 AM, Craig Ringer wrote: - Finish and commit updatable security barrier views. I've still got a lot of straightening out to do there. I don't