Re: [HACKERS] pg_class.relpages/allvisible probably shouldn't be a int4

2014-05-11 Thread Peter Geoghegan
On Fri, May 9, 2014 at 1:50 PM, Andres Freund and...@2ndquadrant.com wrote: And adding a proper unsigned type doesn't sound like a small amount of work. Perhaps not, but it's overdue. We ought to have one. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Compression of full-page-writes

2014-05-11 Thread Sameer Thakur
Hello, What kind of error did you get at the server crash? Assertion error? If yes, it might be because of the conflict with 4a170ee9e0ebd7021cb1190fabd5b0cbe2effb8e. This commit forbids palloc from being called within a critical section, but the patch does that and then the assertion error

Re: [HACKERS] [v9.5] Custom Plan API

2014-05-11 Thread Simon Riggs
On 8 May 2014 22:55, Tom Lane t...@sss.pgh.pa.us wrote: We're past the prototyping stage and into productionising what we know works, AFAIK. If that point is not clear, then we need to discuss that first. OK, I'll bite: what here do we know works? Not a damn thing AFAICS; it's all

Re: [HACKERS] 9.5: UPDATE/DELETE .. ORDER BY .. LIMIT ..

2014-05-11 Thread Simon Riggs
On 11 May 2014 07:37, Amit Kapila amit.kapil...@gmail.com wrote: Tom Lane has explained these problems in a very clear manner in his below mail and shared his opinion about this feature as well. http://www.postgresql.org/message-id/26819.1291133...@sss.pgh.pa.us I don't have Tom's

Re: [HACKERS] pg_class.relpages/allvisible probably shouldn't be a int4

2014-05-11 Thread Andres Freund
On 2014-05-10 23:21:34 -0700, Peter Geoghegan wrote: On Fri, May 9, 2014 at 1:50 PM, Andres Freund and...@2ndquadrant.com wrote: And adding a proper unsigned type doesn't sound like a small amount of work. Perhaps not, but it's overdue. We ought to have one. Maybe. But there's so many

Re: [HACKERS] 9.5: UPDATE/DELETE .. ORDER BY .. LIMIT ..

2014-05-11 Thread Andres Freund
On 2014-05-11 10:33:10 +0200, Simon Riggs wrote: On 11 May 2014 07:37, Amit Kapila amit.kapil...@gmail.com wrote: Tom Lane has explained these problems in a very clear manner in his below mail and shared his opinion about this feature as well.

Re: [HACKERS] 9.5: UPDATE/DELETE .. ORDER BY .. LIMIT ..

2014-05-11 Thread Rukh Meski
On Sun, May 11, 2014 at 10:33 AM, Simon Riggs si...@2ndquadrant.com wrote: On 11 May 2014 07:37, Amit Kapila amit.kapil...@gmail.com wrote: Tom Lane has explained these problems in a very clear manner in his below mail and shared his opinion about this feature as well.

Re: [HACKERS] 9.5: UPDATE/DELETE .. ORDER BY .. LIMIT ..

2014-05-11 Thread Simon Riggs
On 11 May 2014 11:18, Andres Freund and...@2ndquadrant.com wrote: On 2014-05-11 10:33:10 +0200, Simon Riggs wrote: On 11 May 2014 07:37, Amit Kapila amit.kapil...@gmail.com wrote: Tom Lane has explained these problems in a very clear manner in his below mail and shared his opinion about

Re: [HACKERS] Compression of full-page-writes

2014-05-11 Thread Simon Riggs
On 30 August 2013 04:55, Fujii Masao masao.fu...@gmail.com wrote: My idea is very simple, just compress FPW because FPW is a big part of WAL. I used pglz_compress() as a compression method, but you might think that other method is better. We can add something like FPW-compression-hook for

Re: [HACKERS] pg_class.relpages/allvisible probably shouldn't be a int4

2014-05-11 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2014-05-10 23:21:34 -0700, Peter Geoghegan wrote: On Fri, May 9, 2014 at 1:50 PM, Andres Freund and...@2ndquadrant.com wrote: And adding a proper unsigned type doesn't sound like a small amount of work. Perhaps not, but it's overdue. We ought to

Re: [HACKERS] 9.5: UPDATE/DELETE .. ORDER BY .. LIMIT ..

2014-05-11 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: On 11 May 2014 11:18, Andres Freund and...@2ndquadrant.com wrote: I don't know. I'd find UPDATE/DELETE ORDER BY something rather useful. Perhaps if an index exists to provide an ordering that makes it clear what this means, then yes. The $64

Re: [HACKERS] postgresql.auto.conf read from wrong directory

2014-05-11 Thread Tom Lane
Amit Kapila amit.kapil...@gmail.com writes: In above scenario, I think you are expecting it should use /data2/postgresql.auto.conf and that is what you have mentioned up-thread. The way to handle it by server is just to forbid setting this parameter by Alter System or the user himself should

Re: [HACKERS] postgresql.auto.conf read from wrong directory

2014-05-11 Thread Tom Lane
Amit Kapila amit.kapil...@gmail.com writes: This problem occurs because we don't have the value of data_directory set in postgresql.conf by the time we want to parse .auto.conf file during server start. The value of data_directory is only available after processing of config files. To fix

Re: [HACKERS] postgresql.auto.conf read from wrong directory

2014-05-11 Thread Tom Lane
I wrote: I think what probably has to happen is that ProcessConfigFile shouldn't be internally responsible for reading the auto file at all, but that we do that via two separate calls to ProcessConfigFile, one for the main file and then one for the auto file; and during initial startup,

Re: [HACKERS] imprecise pg_basebackup documentation about excluded files

2014-05-11 Thread Magnus Hagander
On Sat, May 10, 2014 at 3:33 AM, Peter Eisentraut pete...@gmx.net wrote: The pg_basebackup documentation says that only regular files and directories are allowed in the data directory. But it is more correct that any other files are skipped. Attached is a patch to correct that. I also

Re: [HACKERS] pg_class.relpages/allvisible probably shouldn't be a int4

2014-05-11 Thread Andres Freund
On 2014-05-11 12:24:30 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-05-10 23:21:34 -0700, Peter Geoghegan wrote: On Fri, May 9, 2014 at 1:50 PM, Andres Freund and...@2ndquadrant.com wrote: And adding a proper unsigned type doesn't sound like a small amount

Re: [HACKERS] 9.5: UPDATE/DELETE .. ORDER BY .. LIMIT ..

2014-05-11 Thread Andres Freund
On 2014-05-11 12:47:21 -0400, Tom Lane wrote: Another idea is that the main reason we do things like this is the assumption that for UPDATE, ModifyTable receives complete new rows that only need to be pushed back into the table (and hence have to already match the rowtype of the specific child

Re: [HACKERS] postgresql.auto.conf read from wrong directory

2014-05-11 Thread Robert Haas
On Sun, May 11, 2014 at 3:20 PM, Tom Lane t...@sss.pgh.pa.us wrote: I wrote: I think what probably has to happen is that ProcessConfigFile shouldn't be internally responsible for reading the auto file at all, but that we do that via two separate calls to ProcessConfigFile, one for the main

[HACKERS] [PATCH] empty xml values

2014-05-11 Thread Peter Eisentraut
While looking into this report http://www.postgresql.org/message-id/cf48ccfb.65a9d%tim.k...@gmail.com I noticed that we don't accept empty values as xml content values, even though this should apparently be allowed by the spec. Attached is a patch to fix it (which needs updates to xml_1.out,

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-05-11 Thread Bruce Momjian
On Sun, May 4, 2014 at 11:12:57AM -0400, Tom Lane wrote: Stephen Frost sfr...@snowman.net writes: * Abhijit Menon-Sen (a...@2ndquadrant.com) wrote: 1. I wish it were possible to prevent even the superuser from disabling audit logging once it's enabled, so that if someone gained superuser

Re: [HACKERS] [v9.5] Custom Plan API

2014-05-11 Thread Kouhei Kaigai
On 8 May 2014 22:55, Tom Lane t...@sss.pgh.pa.us wrote: We're past the prototyping stage and into productionising what we know works, AFAIK. If that point is not clear, then we need to discuss that first. OK, I'll bite: what here do we know works? Not a damn thing AFAICS; it's all

Re: [HACKERS] postgresql.auto.conf read from wrong directory

2014-05-11 Thread Amit Kapila
On Mon, May 12, 2014 at 12:50 AM, Tom Lane t...@sss.pgh.pa.us wrote: Since this bug would block testing of ALTER SYSTEM by a nontrivial population of users, I felt it was important to get it fixed before beta, so I went to try and fix it as above. It turns out that reading the two config