Re: [HACKERS] psql \watch versus \timing

2014-08-18 Thread Michael Paquier
On Thu, Aug 14, 2014 at 11:10 PM, Fujii Masao masao.fu...@gmail.com wrote: Attached patch changes \watch so that it displays how long the query takes if \timing is enabled. I didn't refactor PSQLexec and SendQuery into one routine because the contents of those functions are not so same. I'm

Re: [HACKERS] delta relations in AFTER triggers

2014-08-18 Thread Amit Khandekar
On 15 August 2014 04:04, Kevin Grittner kgri...@ymail.com wrote: Amit Khandekar amit.khande...@enterprisedb.com wrote: The execution level itself was almost trivial; it's getting the tuplestore reference through the parse analysis and planning phases that is painful for me. I am not sure why

Re: [HACKERS] proposal for 9.5: monitoring lock time for slow queries

2014-08-18 Thread Pavel Stehule
2014-08-18 7:42 GMT+02:00 Alvaro Herrera alvhe...@2ndquadrant.com: Pavel Stehule wrote: 2014-08-13 15:22 GMT+02:00 MauMau maumau...@gmail.com: I didn't mean performance statistics data to be stored in database tables. I just meant: * pg_stat_system_events is a view to show data

Re: [HACKERS] Index-only scans for GIST

2014-08-18 Thread Anastasia Lubennikova
Updated patch * Compiler, merge and regression fails checked * Regression tests was impoved * GiST and amcanreturn docs updated -- Best regards, Lubennikova Anastasia indexonlyscan_gist2.patch Description: Binary data indexonlyscan_gist_docs.patch Description: Binary data -- Sent via

Re: [HACKERS] pg_receivexlog and replication slots

2014-08-18 Thread Fujii Masao
On Mon, Aug 18, 2014 at 2:38 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Fri, Aug 15, 2014 at 5:17 PM, Michael Paquier michael.paqu...@gmail.com wrote: Thanks for your review. On Fri, Aug 15, 2014 at 12:56 AM, furu...@pm.nttdata.co.jp wrote: At consistency with pg_recvlogical,

Re: [HACKERS] pg_receivexlog and replication slots

2014-08-18 Thread Fujii Masao
On Mon, Aug 18, 2014 at 3:48 PM, Fujii Masao masao.fu...@gmail.com wrote: On Mon, Aug 18, 2014 at 2:38 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Fri, Aug 15, 2014 at 5:17 PM, Michael Paquier michael.paqu...@gmail.com wrote: Thanks for your review. On Fri, Aug 15, 2014 at 12:56

Re: [HACKERS] pg_receivexlog and replication slots

2014-08-18 Thread Michael Paquier
On Mon, Aug 18, 2014 at 3:48 PM, Fujii Masao masao.fu...@gmail.com wrote: On Mon, Aug 18, 2014 at 2:38 PM, Michael Paquier michael.paqu...@gmail.com wrote: - IDENTIFY_SYSTEM checks were incorrect (even in HEAD). The following check was done but in 9.4 this command returns 4 fields:

Re: [HACKERS] psql \watch versus \timing

2014-08-18 Thread Fujii Masao
On Mon, Aug 18, 2014 at 3:19 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Aug 14, 2014 at 11:10 PM, Fujii Masao masao.fu...@gmail.com wrote: Attached patch changes \watch so that it displays how long the query takes if \timing is enabled. I didn't refactor PSQLexec and

[HACKERS] how to understand these macro defines such as ObjectIdAttributeNumber in sysattr.h?

2014-08-18 Thread 土卜皿
hi, all I am so sorry for asking some questions like this! Recently, for understanding postgresql's optimizer, I read and debug the source code. these two days, I read these macros in sysattr.h: ... #define ObjectIdAttributeNumber (-2) ... and the relative codes, but I still did not know

Re: [HACKERS] psql \watch versus \timing

2014-08-18 Thread Michael Paquier
On Mon, Aug 18, 2014 at 4:12 PM, Fujii Masao masao.fu...@gmail.com wrote: On Mon, Aug 18, 2014 at 3:19 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Aug 14, 2014 at 11:10 PM, Fujii Masao masao.fu...@gmail.com wrote: Attached patch changes \watch so that it displays how long the

Re: [HACKERS] how to understand these macro defines such as ObjectIdAttributeNumber in sysattr.h?

2014-08-18 Thread Michael Paquier
On Mon, Aug 18, 2014 at 4:42 PM, 土卜皿 pengcz.n...@gmail.com wrote: Recently, for understanding postgresql's optimizer, I read and debug the source code. these two days, I read these macros in sysattr.h: ... #define ObjectIdAttributeNumber (-2) ... and the relative codes, but I still

Re: [HACKERS] Index-only scans for GIST

2014-08-18 Thread Heikki Linnakangas
On 08/17/2014 07:15 PM, Anastasia Lubennikova wrote: 2014-08-07 0:30 GMT+04:00 Heikki Linnakangas hlinnakan...@vmware.com: * I'm getting two regression failures with this (opr_sanity and join). opr_sanity failure is corrected. But there is remain question with join. I check the latest

Re: [HACKERS] how to understand these macro defines such as ObjectIdAttributeNumber in sysattr.h?

2014-08-18 Thread 土卜皿
hi, Michael thanks a lot! your reminding lead me go a step forward! the 7 attributes are system attributes of some table such as pg_class, pg_type. but now I have a new question: where and when using these system attributes? 2014-08-18 15:57 GMT+08:00 Michael Paquier

Re: [HACKERS] [BUGS] BUG #9652: inet types don't support min/max

2014-08-18 Thread Asif Naeem
Thank you for sharing updated patch. With latest 9.5 source code, patch build is failing with following error message i.e. /Applications/Xcode.app/Contents/Developer/usr/bin/make -C catalog schemapg.h cd ../../../src/include/catalog '/opt/local/bin/perl' ./duplicate_oids 3255 make[3]: ***

Re: [HACKERS] pg_receivexlog --status-interval add fsync feedback

2014-08-18 Thread furuyao
Thanks for the review! One question is why reply_fsync is defined as volatile variable? Sorry I could not understand reason of that. It was affected to time_to_abort -- since it is unnecessary, it deletes. Currently patch modifies argument of some function (e.g., Handle CopyStream, Process

Fwd: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2014-08-18 Thread Rahila Syed
According to the measurement result, the amount of WAL generated in Multiple Blocks in one run than that in Single Block in one run. So ISTM that compression of multiple blocks at one run can improve the compression ratio. Am I missing something? Sorry for using unclear terminology. WAL generated

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-08-18 Thread Greg Stark
On Tue, Aug 5, 2014 at 3:41 AM, Noah Misch n...@leadboat.com wrote: This remains open for 9.4. Your proposal to revert the feature in 9.4 and fix it in 9.5 sounds reasonable. Ok, I've gone ahead and done this. I'm sorry for the delays and confusion. On Thu, Jul 10, 2014 at 04:15:35PM +0100,

[HACKERS] PQgetssl() and alternative SSL implementations

2014-08-18 Thread Heikki Linnakangas
In order to support alternatives to OpenSSL, we need to wean off applications from using PQgetssl(). To do that, we have to provide an alternative API to get the same information. PQgetSSL() returns a pointer directly to the OpenSSL private struct, and you can do anything with that. We cannot

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-08-18 Thread Michael Paquier
On Mon, Aug 18, 2014 at 8:30 PM, Greg Stark st...@mit.edu wrote: On Tue, Aug 5, 2014 at 3:41 AM, Noah Misch n...@leadboat.com wrote: This remains open for 9.4. Your proposal to revert the feature in 9.4 and fix it in 9.5 sounds reasonable. Ok, I've gone ahead and done this. I'm sorry for

Re: [HACKERS] ALTER TABLESPACE MOVE command tag tweak

2014-08-18 Thread Stephen Frost
* Peter Eisentraut (pete...@gmx.net) wrote: On 8/17/14 5:19 PM, Stephen Frost wrote: Alvaro, all, * Stephen Frost (sfr...@snowman.net) wrote: As mentioned, I'll add this to the ALTER TABLE documentation and remove it from the TABLESPACE docs. That's not done yet but I should have time

Re: [HACKERS] [PATCH] Incremental backup: add backup profile to base backup

2014-08-18 Thread Heikki Linnakangas
On 08/18/2014 03:04 AM, Marco Nenciarini wrote: Hi Hackers, This is the first piece of file level incremental backup support, as described on wiki page https://wiki.postgresql.org/wiki/Incremental_backup It is not yet complete, but I wish to share it on the list to receive comments and

Re: [HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-08-18 Thread Robert Haas
On Sat, Aug 16, 2014 at 3:28 AM, Noah Misch n...@leadboat.com wrote: Nice algorithm. Thanks. I'd be afraid that a secondary mechanism that mostly-but-not-really works could do more harm by allowing us to miss bugs in the primary, pipe-based locking mechanism than the good it would

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-08-18 Thread Greg Stark
On Mon, Aug 18, 2014 at 12:55 PM, Michael Paquier michael.paqu...@gmail.com wrote: I imagine that you also need to fix the release notes accordingly. Patch attached for master and REL9_4_STABLE. Thanks. Done for 9.4 but the patch is still in master. In fact it's the most recent version and I'm

Re: [HACKERS] [PATCH] Incremental backup: add backup profile to base backup

2014-08-18 Thread Heikki Linnakangas
On 08/18/2014 08:05 AM, Alvaro Herrera wrote: Marco Nenciarini wrote: To calculate the md5 checksum I've used the md5 code present in pgcrypto contrib as the code in src/include/libpq/md5.h is not suitable for large files. Since a core feature cannot depend on a piece of contrib, I've moved

Re: [HACKERS] [PATCH] Incremental backup: add backup profile to base backup

2014-08-18 Thread Arthur Silva
On Mon, Aug 18, 2014 at 10:05 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 08/18/2014 08:05 AM, Alvaro Herrera wrote: Marco Nenciarini wrote: To calculate the md5 checksum I've used the md5 code present in pgcrypto contrib as the code in src/include/libpq/md5.h is not suitable

Re: [HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-08-18 Thread Noah Misch
On Mon, Aug 18, 2014 at 09:01:20AM -0400, Robert Haas wrote: On Sat, Aug 16, 2014 at 3:28 AM, Noah Misch n...@leadboat.com wrote: I'd be afraid that a secondary mechanism that mostly-but-not-really works could do more harm by allowing us to miss bugs in the primary, pipe-based locking

[HACKERS] After switching primary server while using replication slot.

2014-08-18 Thread Sawada Masahiko
Hi all, After switching primary serer while using repliaction slot, the standby server will not able to connect new primary server. Imagine this situation, if primary server has two ASYNC standby servers, also use each replication slots. And the one standby(A) apply WAL without problems. But

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

2014-08-18 Thread Heikki Linnakangas
I didn't follow the original discussions, but now that I look at this I have to wonder: Why does pg_basebackup -T create the symlink pointing to the wrong location in the first place, only to fix it later? Wouldn't it make a lot more sense to create it correctly in the first place? - Heikki

Re: [HACKERS] how to understand these macro defines such as ObjectIdAttributeNumber in sysattr.h?

2014-08-18 Thread Tom Lane
=?UTF-8?B?5Zyf5Y2c55q/?= pengcz.n...@gmail.com writes: where and when using these system attributes? http://www.postgresql.org/docs/devel/static/ddl-system-columns.html regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] pg_receivexlog --status-interval add fsync feedback

2014-08-18 Thread Sawada Masahiko
On Mon, Aug 18, 2014 at 7:55 PM, furu...@pm.nttdata.co.jp wrote: Thanks for the review! One question is why reply_fsync is defined as volatile variable? Sorry I could not understand reason of that. It was affected to time_to_abort -- since it is unnecessary, it deletes. Currently patch

Re: [HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-08-18 Thread Baker, Keith [OCDUS Non-JJ]
Robert, Tom, and others, Glad to see good discussion and progress on the locking topic! My proof of concept code (steps a though e below) avoided any reading or writing to the pipe (and associated handling of SIGPIPE), it just relied on postmaster open of PIPE with ENXIO to indicate all is

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-08-18 Thread Michael Paquier
On Mon, Aug 18, 2014 at 10:02 PM, Greg Stark st...@mit.edu wrote: On Mon, Aug 18, 2014 at 12:55 PM, Michael Paquier michael.paqu...@gmail.com wrote: Done for 9.4 but the patch is still in master. In fact it's the most recent version and I'm still pretty convinced it's a good patch. If this

Re: [HACKERS] pg_shmem_allocations view

2014-08-18 Thread Robert Haas
On Fri, Aug 15, 2014 at 4:20 AM, Andres Freund and...@2ndquadrant.com wrote: On 2014-08-15 11:12:11 +0300, Marti Raudsepp wrote: Hi On Thu, May 8, 2014 at 4:28 PM, Andres Freund and...@2ndquadrant.com wrote: Ok. A new version of the patches implementing that are attached. Including a couple

Re: [HACKERS] pg_shmem_allocations view

2014-08-18 Thread Andres Freund
On 2014-08-18 11:56:44 -0400, Robert Haas wrote: On Fri, Aug 15, 2014 at 4:20 AM, Andres Freund and...@2ndquadrant.com wrote: On 2014-08-15 11:12:11 +0300, Marti Raudsepp wrote: Hi On Thu, May 8, 2014 at 4:28 PM, Andres Freund and...@2ndquadrant.com wrote: Ok. A new version of the

Re: [HACKERS] Function to know last log write timestamp

2014-08-18 Thread Robert Haas
On Fri, Aug 15, 2014 at 7:17 AM, Fujii Masao masao.fu...@gmail.com wrote: On Fri, Aug 15, 2014 at 3:40 AM, Andres Freund and...@2ndquadrant.com wrote: On 2014-08-14 14:37:22 -0400, Robert Haas wrote: On Thu, Aug 14, 2014 at 2:21 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-08-14

Re: [HACKERS] Support for N synchronous standby servers

2014-08-18 Thread Robert Haas
On Fri, Aug 15, 2014 at 8:28 AM, Fujii Masao masao.fu...@gmail.com wrote: Now that we discuss the interactions with other parameters. Another thing that I am wondering about now is: what should we do if we specify s_s_num to a number higher than the elements in s_s_names? Currently, the patch

Re: [HACKERS] pg_shmem_allocations view

2014-08-18 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2014-08-18 11:56:44 -0400, Robert Haas wrote: I fully agree with the idea of exposing the amount of free memory in the shared memory segment (as discussed in other emails); that's critical information. But I think exposing address space layout

Re: [HACKERS] pg_shmem_allocations view

2014-08-18 Thread Andres Freund
On 2014-08-18 12:27:12 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-08-18 11:56:44 -0400, Robert Haas wrote: I fully agree with the idea of exposing the amount of free memory in the shared memory segment (as discussed in other emails); that's critical

Re: [HACKERS] [PATCH] Incremental backup: add backup profile to base backup

2014-08-18 Thread Alvaro Herrera
Heikki Linnakangas wrote: On 08/18/2014 08:05 AM, Alvaro Herrera wrote: We already have the FNV checksum implementation in the backend -- can't we use that one for this and avoid messing with MD5? (I don't think we're looking for a cryptographic hash here. Am I wrong?) Hmm. Any user

Re: [HACKERS] pg_shmem_allocations view

2014-08-18 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2014-08-18 12:27:12 -0400, Tom Lane wrote: Should we consider putting it into an extension rather than having it in the core system? That would offer some additional protection for production systems, which really shouldn't have much need for

Re: [HACKERS] pg_shmem_allocations view

2014-08-18 Thread Andres Freund
On 2014-08-18 12:33:44 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-08-18 12:27:12 -0400, Tom Lane wrote: Should we consider putting it into an extension rather than having it in the core system? That would offer some additional protection for production

Re: [HACKERS] Reporting the commit LSN at commit time

2014-08-18 Thread Robert Haas
On Fri, Aug 15, 2014 at 9:54 AM, Tom Lane t...@sss.pgh.pa.us wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-08-14 12:21:38 -0400, Robert Haas wrote: And what does that actually do? Send back a result-set, or a new protocol message? What I was thinking of was to return COMMIT

Re: [HACKERS] pg_shmem_allocations view

2014-08-18 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2014-08-18 12:33:44 -0400, Tom Lane wrote: Well, we could have the implementation code in those modules but not provide any SQL-level access to it without installing an extension. The only extra thing visible in the .h files would be a function

Re: [HACKERS] pg_shmem_allocations view

2014-08-18 Thread Robert Haas
On Mon, Aug 18, 2014 at 12:00 PM, Andres Freund and...@2ndquadrant.com wrote: Unfortunately, that information also has some security implications. I'm sure someone trying to exploit any future stack-overrun vulnerability will be very happy to have more rather than less information about the

Re: [HACKERS] pg_shmem_allocations view

2014-08-18 Thread Andres Freund
On 2014-08-18 12:41:58 -0400, Robert Haas wrote: On Mon, Aug 18, 2014 at 12:00 PM, Andres Freund and...@2ndquadrant.com wrote: Unfortunately, that information also has some security implications. I'm sure someone trying to exploit any future stack-overrun vulnerability will be very happy

Re: [HACKERS] GIST create index very very slow

2014-08-18 Thread Robert Haas
On Fri, Aug 15, 2014 at 5:59 PM, worthy7 worthy@gmail.com wrote: CREATE INDEX USING GIST(timerange); On 1.3 million rows this took only 30 seconds. on 70 million its already taken over a day. I swear it didn't take this long on version 9.3 Is there some kind of known bug with GIST? CPU

Re: [HACKERS] Reporting the commit LSN at commit time

2014-08-18 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Aug 15, 2014 at 9:54 AM, Tom Lane t...@sss.pgh.pa.us wrote: Au contraire: it will break any piece of code that is expecting a COMMIT command tag to look like exactly COMMIT and not COMMIT something. Well, I remember debating this with you once

Re: [HACKERS] pg_shmem_allocations view

2014-08-18 Thread Robert Haas
On Mon, Aug 18, 2014 at 12:46 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-08-18 12:41:58 -0400, Robert Haas wrote: On Mon, Aug 18, 2014 at 12:00 PM, Andres Freund and...@2ndquadrant.com wrote: Unfortunately, that information also has some security implications. I'm sure someone

Re: [HACKERS] pg_shmem_allocations view

2014-08-18 Thread Andres Freund
On 2014-08-18 12:50:27 -0400, Robert Haas wrote: On Mon, Aug 18, 2014 at 12:46 PM, Andres Freund and...@2ndquadrant.com wrote: You realize that you can pretty much recompute the offsets from the sizes of the individual allocations anyway? Sure, if you know the segment base. Do you?

Re: [HACKERS] pg_shmem_allocations view

2014-08-18 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: I wouldn't mind having a MemoryContextStats()-type function that could be used to print this information out by attaching to the backend with gdb, but the utility of exposing it at the SQL level seems very marginal to me. +1 for doing it like that.

Re: [HACKERS] Reporting the commit LSN at commit time

2014-08-18 Thread Robert Haas
On Mon, Aug 18, 2014 at 12:49 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Fri, Aug 15, 2014 at 9:54 AM, Tom Lane t...@sss.pgh.pa.us wrote: Au contraire: it will break any piece of code that is expecting a COMMIT command tag to look like exactly COMMIT

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2014-08-18 Thread Robert Haas
On Mon, Aug 18, 2014 at 7:19 AM, Rahila Syed rahilasye...@gmail.com wrote: According to the measurement result, the amount of WAL generated in Multiple Blocks in one run than that in Single Block in one run. So ISTM that compression of multiple blocks at one run can improve the compression ratio.

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2014-08-18 Thread Andres Freund
On 2014-08-18 13:06:15 -0400, Robert Haas wrote: On Mon, Aug 18, 2014 at 7:19 AM, Rahila Syed rahilasye...@gmail.com wrote: According to the measurement result, the amount of WAL generated in Multiple Blocks in one run than that in Single Block in one run. So ISTM that compression of multiple

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2014-08-18 Thread Robert Haas
On Thu, Jul 3, 2014 at 3:58 PM, Rahila Syed rahilasye...@gmail.com wrote: Updated version of patches are attached. Changes are as follows 1. Improved readability of the code as per the review comments. 2. Addition of block_compression field in BkpBlock structure to store information about

Re: [HACKERS] pg_shmem_allocations view

2014-08-18 Thread Robert Haas
On Mon, Aug 18, 2014 at 12:51 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-08-18 12:50:27 -0400, Robert Haas wrote: On Mon, Aug 18, 2014 at 12:46 PM, Andres Freund and...@2ndquadrant.com wrote: You realize that you can pretty much recompute the offsets from the sizes of the

Re: [HACKERS] Reporting the commit LSN at commit time

2014-08-18 Thread Alvaro Herrera
Robert Haas wrote: Moreover, even if somebody is (rather oddly, IMV) checking for command_tag == COMMIT, it's not going to be a difficult change to check for command_tag == COMMIT or substr(command_tag,0,7) == COMMIT . That's a level of incompatibility that would certainly deserve mention

Re: [HACKERS] pg_shmem_allocations view

2014-08-18 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: I thought you were printing actual pointer addresses. If you're just printing offsets relative to wherever the segment happens to be mapped, I don't care about that. Well, that just means that it's not an *obvious* security risk. I still like the

Re: [HACKERS] pg_shmem_allocations view

2014-08-18 Thread Andres Freund
On 2014-08-18 13:27:07 -0400, Tom Lane wrote: I still like the idea of providing something comparable to MemoryContextStats, rather than creating a SQL interface. The problem with a SQL interface is you can't interrogate it unless (1) you are not already inside a query and (2) the client is

Re: [HACKERS] pg_dump refactor patch to remove global variables

2014-08-18 Thread Robert Haas
On Fri, Aug 15, 2014 at 7:30 PM, Joachim Wieland j...@mcknight.de wrote: Attached is a patch that doesn't add any new functionality or features, all it does is get rid of the global variables that pg_dump.c is full of. I think this is an excellent idea. -- Robert Haas EnterpriseDB:

Re: [HACKERS] pg_shmem_allocations view

2014-08-18 Thread Robert Haas
On Mon, Aug 18, 2014 at 1:27 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: I thought you were printing actual pointer addresses. If you're just printing offsets relative to wherever the segment happens to be mapped, I don't care about that. Well, that just

Re: [HACKERS] Reporting the commit LSN at commit time

2014-08-18 Thread Greg Stark
On 15 Aug 2014 14:54, Tom Lane t...@sss.pgh.pa.us wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-08-14 12:21:38 -0400, Robert Haas wrote: And what does that actually do? Send back a result-set, or a new protocol message? What I was thinking of was to return COMMIT X/X

Re: [HACKERS] Reporting the commit LSN at commit time

2014-08-18 Thread Greg Stark
On 18 Aug 2014 20:05, Greg Stark st...@mit.edu wrote: Having it in the commit message guarantees the client never has to deal with strange states like I know this transaction committed but I know when Sigh. Typing on the phone. But I *don't* know when

Re: [HACKERS] GIST create index very very slow

2014-08-18 Thread Heikki Linnakangas
On 08/18/2014 07:47 PM, Robert Haas wrote: I think something's missing from your report, though, because if there is 3.5 Mb/s of write I/O and only 8 b/s of file growth, nearly all of the writes are doing something other than extending that file. Hmm. Sounds like it's churning through

Re: [HACKERS] [PATCH] Incremental backup: add backup profile to base backup

2014-08-18 Thread Heikki Linnakangas
On 08/18/2014 07:33 PM, Alvaro Herrera wrote: Heikki Linnakangas wrote: On 08/18/2014 08:05 AM, Alvaro Herrera wrote: We already have the FNV checksum implementation in the backend -- can't we use that one for this and avoid messing with MD5? (I don't think we're looking for a cryptographic

Re: [HACKERS] Hokey wrong versions of libpq in apt.postgresql.org

2014-08-18 Thread Joshua D. Drake
On 08/12/2014 10:26 AM, Steve Crawford wrote: On 08/07/2014 04:30 PM, Joshua D. Drake wrote: Hello, I know this has been brought up before: http://www.postgresql.org/message-id/20140724080902.ga28...@msg.df7cb.de For reference, libpq and packaging issues discussed here as well:

Re: [HACKERS] GIST create index very very slow

2014-08-18 Thread Greg Stark
On Mon, Aug 18, 2014 at 5:47 PM, Robert Haas robertmh...@gmail.com wrote: Sounds pretty weird I recall GIST being really slow in the distant past in cases where the page split choices were really bad. Is timerange an interval? Or a Range?I wonder if the pagesplit function for some of the newish

Re: [HACKERS] PQgetssl() and alternative SSL implementations

2014-08-18 Thread Greg Stark
On Mon, Aug 18, 2014 at 12:54 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: server_cert_valid: Did the server present a valid certificate? yes or no Is this just whether the signature verifies? Or whether the chain is all verified? Or whether the chain leads to a root in the

Re: [HACKERS] Reporting the commit LSN at commit time

2014-08-18 Thread Craig Ringer
On 08/19/2014 01:03 AM, Robert Haas wrote: 2. I agree that it's not good to have this get controlled by a GUC. If the behavior change is big enough that it's going to break clients, adding a GUC isn't a sufficient remedy. If it's not, adding a GUC is unnecessary. There's plenty of agreement

Re: [HACKERS] pg_receivexlog --status-interval add fsync feedback

2014-08-18 Thread furuyao
Thank you for updating the patch. I did not get error with applying, and compiling. It works fine. I think this function code has no problem. Could you please submit patch to commit fest app? Thanks for the review! As you pointed out, submitted patch to commit fest app. Regards, --

[HACKERS] New Model For Role Attributes and Fine Grained Permssions

2014-08-18 Thread Brightwell, Adam
Hi All, This is a proof-of-concept patch for a new model around role attributes and fine grained permissions meant to alleviate the current over dependence on superuser. This is not yet complete and only serves as a proof-of-concept at this point, but I wanted to share it in the hopes of

Re: [HACKERS] [PATCH] Incremental backup: add backup profile to base backup

2014-08-18 Thread Amit Kapila
On Mon, Aug 18, 2014 at 6:35 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 08/18/2014 08:05 AM, Alvaro Herrera wrote: Marco Nenciarini wrote: To calculate the md5 checksum I've used the md5 code present in pgcrypto contrib as the code in src/include/libpq/md5.h is not suitable

Re: [HACKERS] strncpy is not a safe version of strcpy

2014-08-18 Thread Noah Misch
On Fri, Aug 15, 2014 at 11:26:55PM -0400, Noah Misch wrote: Barring objections, I will commit your latest patch with some comments about why truncation is harmless for those two particular calls. Done. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] Improvement of versioning on Windows, take two

2014-08-18 Thread Noah Misch
Committed after making several fixes, notably: On Thu, Aug 14, 2014 at 03:59:57PM +0900, Michael Paquier wrote: --- a/src/test/isolation/Makefile +++ b/src/test/isolation/Makefile @@ -6,12 +6,15 @@ subdir = src/test/isolation top_builddir = ../../.. include

Re: [HACKERS] Improvement of versioning on Windows, take two

2014-08-18 Thread Michael Paquier
On Tue, Aug 19, 2014 at 12:34 PM, Noah Misch n...@leadboat.com wrote: Committed after making several fixes, notably: Thanks a lot, especially for the additional comments. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

2014-08-18 Thread Amit Kapila
On Mon, Aug 18, 2014 at 7:50 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: I didn't follow the original discussions, but now that I look at this I have to wonder: Why does pg_basebackup -T create the symlink pointing to the wrong location in the first place, only to fix it later? Good

Re: [HACKERS] pg_receivexlog and replication slots

2014-08-18 Thread Michael Paquier
On Mon, Aug 18, 2014 at 4:01 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Mon, Aug 18, 2014 at 3:48 PM, Fujii Masao masao.fu...@gmail.com wrote: On Mon, Aug 18, 2014 at 2:38 PM, Michael Paquier michael.paqu...@gmail.com wrote: And now looking at your patch there is additional