Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-08-23 Thread Michael Paquier
On Sat, Aug 23, 2014 at 3:32 AM, Alvaro Herrera wrote: > Great. Pushed. Thanks for the patch. There is a typo in what has been pushed. Patch attached. -- Michael diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index d37534e..1bb46ea 100644 --- a/src/backend/comm

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-08-23 Thread Fabrízio de Royes Mello
On Sat, Aug 23, 2014 at 8:53 AM, Michael Paquier wrote: > > On Sat, Aug 23, 2014 at 3:32 AM, Alvaro Herrera > wrote: > > Great. Pushed. Thanks for the patch. > There is a typo in what has been pushed. Patch attached. > Thanks... I fixed that in my last patch to change 'loggedness' to 'persiste

Re: [HACKERS] Parallel Sequence Scan doubts

2014-08-23 Thread Craig Ringer
On 08/21/2014 02:47 PM, Haribabu Kommi wrote: > Corrected subject. > > Hi Hackers, > > Implementation of "Parallel Sequence Scan" I think you mean "Parallel Sequential Scan". Scanning a sequence in parallel doesn't make much sense. > 1."Parallel Sequence Scan" can achieved by using the backgro

Re: [HACKERS] proposal: rounding up time value less than its unit.

2014-08-23 Thread Tom Lane
Tomonari Katsumata writes: > This patch rounds up the value when only it's less than required unit. > .. > Although my original complaint is fixed, I'm worried about this change will > make users confusing. Indeed. I have not understood why you are insisting on "round up" semantics. Wouldn't it

Re: [HACKERS] proposal: rounding up time value less than its unit.

2014-08-23 Thread David G Johnston
Tom Lane-2 wrote > Tomonari Katsumata < > t.katsumata1122@ > > writes: >> This patch rounds up the value when only it's less than required unit. >> .. >> Although my original complaint is fixed, I'm worried about this change >> will >> make users confusing. > > Indeed. I have not understood why

Re: [HACKERS] proposal: rounding up time value less than its unit.

2014-08-23 Thread Tom Lane
David G Johnston writes: > Tom Lane-2 wrote >> Indeed. I have not understood why you are insisting on "round up" >> semantics. Wouldn't it make more sense for the behavior to be "round to >> nearest"? That would get rid of any worries about treating zero >> specially. > Wasn't the goal that al

Re: [HACKERS] Removing dependency to wsock32.lib when compiling code on WIndows

2014-08-23 Thread Noah Misch
On Fri, Aug 22, 2014 at 04:58:47PM +0900, Michael Paquier wrote: > Looking more into that, I am seeing that MinGW-32 is failing to find socket > at configure, contrary to MinGW-64. > > Here is what happens for MinGW-64 at configure: > configure:7638: checking for library containing socket > [...]

Re: [HACKERS] change alter user to be a true alias for alter role

2014-08-23 Thread Tom Lane
Jov writes: > I make the v2 of the patch,use Tom's advice. > But I can't make ROLE and USER in the keyword list,it is hard to solve the > conflict,or rewrite many gram rules. This patch seems to be trying to make ROLE and USER interchangeable *everywhere* in the grammar, which is moving the goalp

Re: [HACKERS] proposal: rounding up time value less than its unit.

2014-08-23 Thread Greg Stark
On Sat, Aug 23, 2014 at 9:38 PM, Tom Lane wrote: > > Ah. Okay, but then what's wrong with the original proposal of "use ceil() > instead of floor()"? Basically I think the idea of treating fractions > less than one differently from fractions greater than one is bogus; nobody > will ever find tha

Re: [HACKERS] proposal: rounding up time value less than its unit.

2014-08-23 Thread David G Johnston
Tom Lane-2 wrote > David G Johnston < > david.g.johnston@ > > writes: >> Tom Lane-2 wrote >>> Indeed. I have not understood why you are insisting on "round up" >>> semantics. Wouldn't it make more sense for the behavior to be "round to >>> nearest"? That would get rid of any worries about trea

Re: [HACKERS] Parallel Sequence Scan doubts

2014-08-23 Thread Haribabu Kommi
On Sun, Aug 24, 2014 at 1:11 AM, Craig Ringer wrote: > On 08/21/2014 02:47 PM, Haribabu Kommi wrote: >> Implementation of "Parallel Sequence Scan" > > I think you mean "Parallel Sequential Scan". Sorry for not being clear, Yes it is parallel sequential scan. >> 1."Parallel Sequence Scan" can ac

Re: [HACKERS] Parallel Sequence Scan doubts

2014-08-23 Thread Craig Ringer
On 08/24/2014 09:40 AM, Haribabu Kommi wrote: > Any suggestions? Another point I didn't raise first time around, but that's IMO quite significant, is that you haven't addressed why this approach to fully parallel seqscans is useful and solves real problems in effective ways. It might seem obviou

Re: [HACKERS] [BUGS] BUG #9652: inet types don't support min/max

2014-08-23 Thread Haribabu Kommi
On Mon, Aug 18, 2014 at 8:12 PM, Asif Naeem wrote: > Thank you for sharing updated patch. With latest 9.5 source code, patch > build is failing with following error message i.e. > >> /Applications/Xcode.app/Contents/Developer/usr/bin/make -C catalog >> schemapg.h >> cd ../../../src/include/catalog

[HACKERS] Missing comment block at the top of streamutil.h and receivelog.h

2014-08-23 Thread Michael Paquier
Hi all, As mentioned in $subject, the header files in src/bin/pg_basebackup do not have a comment block at the top and do not have any copyright text. Any reason for that? Shouldn't we have something for consistency with the other files like in the patch attached? Regards, -- Michael diff --git

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2014-08-23 Thread Amit Kapila
On Tue, Aug 19, 2014 at 4:27 PM, Amit Kapila wrote: > > Few more comments: > Some more comments: 1. I could see one shortcoming in the way the patch has currently parallelize the work for --analyze-in-stages. Basically patch is performing the work for each stage for multiple tables in concu