[HACKERS] Customized Options Threshold Error

2014-11-14 Thread furuyao
Hi, When we specify a value which exceeds valid range in Customized Options , its behavior is different from Parameter Interaction via Configuration File behavior. In case of Parameter Interaction via Configuration File, it finish with FATAL error when it get threshold error. But in Customized

Re: [HACKERS] alter user/role CURRENT_USER

2014-11-14 Thread Kyotaro HORIGUCHI
Hi, this is revised version. Kyotaro HORIGUCHI wrote: - Storage for new information The new struct NameId stores an identifier which telling what it logically is using the new enum NameIdTypes. I think NameId is a bad name for this. My point is that NameId, as it stands, might be

Re: [HACKERS] using custom scan nodes to prototype parallel sequential scan

2014-11-14 Thread David Rowley
On 14 November 2014 20:37, Jim Nasby jim.na...@bluetreble.com wrote: On 11/12/14, 1:54 AM, David Rowley wrote: We'd also need to add some infrastructure to merge aggregate states together for this to work properly. This means that could also work for avg() and stddev etc. For max() and

Re: [HACKERS] using custom scan nodes to prototype parallel sequential scan

2014-11-14 Thread Simon Riggs
On 14 November 2014 07:37, Jim Nasby jim.na...@bluetreble.com wrote: On 11/12/14, 1:54 AM, David Rowley wrote: On Tue, Nov 11, 2014 at 9:29 PM, Simon Riggs si...@2ndquadrant.com mailto:si...@2ndquadrant.com wrote: This plan type is widely used in reporting queries, so will hit the

Re: [HACKERS] using custom scan nodes to prototype parallel sequential scan

2014-11-14 Thread Simon Riggs
On 14 November 2014 01:51, David Rowley dgrowle...@gmail.com wrote: When I mentioned this, I didn't mean to appear to be placing a road block.I was just bringing to the table the information that COUNT(*) + COUNT(*) works ok for merging COUNT(*)'s sub totals, but AVG(n) + AVG(n) does not.

Re: [HACKERS] Unintended restart after recovery error

2014-11-14 Thread Antonin Houska
Fujii Masao masao.fu...@gmail.com wrote: On Thu, Nov 13, 2014 at 8:30 AM, Robert Haas robertmh...@gmail.com wrote: It's true that if the startup process dies we don't try to restart, but it's also true that if the checkpointer dies we do try to restart. I'm not sure why this specific situation

[HACKERS] PostgreSQL doesn't stop propley when --slot option is specified with pg_receivexlog.

2014-11-14 Thread furuyao
Hi, pg_ctl stop does't work propley, if --slot option is specified when WAL is flushed only it has switched. These processes still continue even after the posmaster failed:pg_receivexlog, walsender and logger. How to reproduce: 1.Start PostgreSQL 2.Create slot 3.Specify --slot option to

Re: [HACKERS] Size of regression database

2014-11-14 Thread Alvaro Herrera
Tom Lane wrote: I was testing backwards compatibility of pg_dumpall just now, and was somewhat astonished to notice the size of the output for the regression database compared to what it was not too long ago: -rw-rw-r--. 1 tgl tgl 4509135 Nov 13 16:19 dumpall.83 -rw-rw-r--. 1 tgl tgl

Re: [HACKERS] using custom scan nodes to prototype parallel sequential scan

2014-11-14 Thread Kouhei Kaigai
On 14 November 2014 07:37, Jim Nasby jim.na...@bluetreble.com wrote: On 11/12/14, 1:54 AM, David Rowley wrote: On Tue, Nov 11, 2014 at 9:29 PM, Simon Riggs si...@2ndquadrant.com mailto:si...@2ndquadrant.com wrote: This plan type is widely used in reporting queries, so will hit

Re: [HACKERS] EXPLAIN ANALYZE output weird for Top-N Sort

2014-11-14 Thread Jeremy Harris
On 14/11/14 00:46, Simon Riggs wrote: Limit (cost= rows=20 width=175) (actual time= rows=20 loops=1) - Sort (cost= rows=568733 width=175) (actual time= rows=20 loops=1) Sort Method: top-N heapsort Going off on a tangent, when I was playing with a merge-sort

Re: [HACKERS] using custom scan nodes to prototype parallel sequential scan

2014-11-14 Thread David Rowley
On Fri, Nov 14, 2014 at 1:27 PM, Simon Riggs si...@2ndquadrant.com wrote: On 12 November 2014 00:54, Robert Haas robertmh...@gmail.com wrote: Interestingly, I have a fairly solid idea of what proisparallel is, but I have no clear idea what CONTAINS NO SQL is or why it's relevant. I would

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

2014-11-14 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: Noah Misch n...@leadboat.com writes: On Thu, Nov 13, 2014 at 08:24:36PM -0500, Stephen Frost wrote: Agreed. I'll take care of both and we'll make sure the new role attributes being added will do the same for upgrades also. That would make

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

2014-11-14 Thread Noah Misch
On Fri, Nov 14, 2014 at 08:35:25AM -0500, Stephen Frost wrote: * Tom Lane (t...@sss.pgh.pa.us) wrote: Noah Misch n...@leadboat.com writes: On Thu, Nov 13, 2014 at 08:24:36PM -0500, Stephen Frost wrote: Agreed. I'll take care of both and we'll make sure the new role attributes being

Re: [HACKERS] Customized Options Threshold Error

2014-11-14 Thread Tom Lane
furu...@pm.nttdata.co.jp writes: When we specify a value which exceeds valid range in Customized Options , its behavior is different from Parameter Interaction via Configuration File behavior. In case of Parameter Interaction via Configuration File, it finish with FATAL error when it get

Re: [HACKERS] Teaching pg_dump to use NOT VALID constraints

2014-11-14 Thread Alvaro Herrera
Peter Eisentraut wrote: On 11/13/14 5:07 AM, Simon Riggs wrote: On 13 November 2014 00:20, Jim Nasby jim.na...@bluetreble.com wrote: Isn't the real use-case here that if constraints were valid when you dumped then we shouldn't have to *any* re-validate when we load? (Though, we'd have

Re: [HACKERS] EXPLAIN ANALYZE output weird for Top-N Sort

2014-11-14 Thread Tom Lane
Jeremy Harris j...@wizmail.org writes: On 14/11/14 00:46, Simon Riggs wrote: Limit (cost= rows=20 width=175) (actual time= rows=20 loops=1) - Sort (cost= rows=568733 width=175) (actual time= rows=20 loops=1) Sort Method: top-N heapsort Going off on a tangent, when I was

Re: [HACKERS] REINDEX CONCURRENTLY 2.0

2014-11-14 Thread Andres Freund
On 2014-11-14 02:04:00 -0600, Jim Nasby wrote: On 11/13/14, 3:50 PM, Andres Freund wrote: Having been responsible for a site where downtime was a 6 figure dollar amount per hour, I've spent a LOT of time worrying about lock problems. The really big issue here isn't grabbing an exclusive lock;

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

2014-11-14 Thread Stephen Frost
* Noah Misch (n...@leadboat.com) wrote: On Fri, Nov 14, 2014 at 08:35:25AM -0500, Stephen Frost wrote: Personally, I'm leaning towards the first as it's less clutter in the output of psql. I'd agree for a new design, but I see too little to gain from changing it now. Today's behavior is

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

2014-11-14 Thread Tom Lane
Stephen Frost sfr...@snowman.net writes: * Noah Misch (n...@leadboat.com) wrote: I'd agree for a new design, but I see too little to gain from changing it now. Today's behavior is fine. To clarify- you mean with the changes described- using usesuper for rolreplication and rolbypassrls

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

2014-11-14 Thread Noah Misch
On Fri, Nov 14, 2014 at 11:24:20AM -0500, Tom Lane wrote: Stephen Frost sfr...@snowman.net writes: * Noah Misch (n...@leadboat.com) wrote: I'd agree for a new design, but I see too little to gain from changing it now. Today's behavior is fine. To clarify- you mean with the changes

Re: [HACKERS] REINDEX CONCURRENTLY 2.0

2014-11-14 Thread Andres Freund
On 2014-11-13 11:41:18 -0500, Robert Haas wrote: On Wed, Nov 12, 2014 at 7:31 PM, Andres Freund and...@2ndquadrant.com wrote: But I think it won't work realistically. We have a *lot* of infrastructure that refers to indexes using it's primary key. I don't think we want to touch all those

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

2014-11-14 Thread Stephen Frost
* Noah Misch (n...@leadboat.com) wrote: On Fri, Nov 14, 2014 at 11:24:20AM -0500, Tom Lane wrote: Stephen Frost sfr...@snowman.net writes: * Noah Misch (n...@leadboat.com) wrote: I'd agree for a new design, but I see too little to gain from changing it now. Today's behavior is

Re: [HACKERS] alternative model for handling locking in parallel groups

2014-11-14 Thread Andres Freund
Hi, On 2014-11-13 15:59:11 -0500, Robert Haas wrote: Discussion of my incomplete group locking patch seems to have converged around two points: (1) Everybody agrees that undetected deadlocks are unacceptable. (2) Nobody agrees with my proposal to treat locks held by group members as mutually

Re: [HACKERS] tracking commit timestamps

2014-11-14 Thread Robert Haas
On Thu, Nov 13, 2014 at 6:55 PM, Simon Riggs si...@2ndquadrant.com wrote: On 13 November 2014 21:24, Robert Haas robertmh...@gmail.com wrote: On Thu, Nov 13, 2014 at 8:18 AM, Simon Riggs si...@2ndquadrant.com wrote: Ordering transactions in LSN order is very precisly the remit of the existing

Re: [HACKERS] Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

2014-11-14 Thread Robert Haas
On Thu, Nov 13, 2014 at 6:32 PM, Tom Lane t...@sss.pgh.pa.us wrote: What's bothering me is that I see this in pg_dumpall output from a 9.4 or earlier database: ALTER ROLE postgres WITH SUPERUSER INHERIT CREATEROLE CREATEDB LOGIN REPLICATION NOBYPASSRLS; What about leaving out NOBYPASSRLS

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-11-14 Thread Robert Haas
On Fri, Nov 14, 2014 at 2:55 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Fri, Nov 14, 2014 at 9:11 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Nov 13, 2014 at 10:37 PM, Amit Kapila amit.kapil...@gmail.com wrote: I have mentioned that this can be usable for Linux users as

Re: [HACKERS] Add CREATE support to event triggers

2014-11-14 Thread Robert Haas
On Thu, Nov 13, 2014 at 7:45 AM, Andres Freund and...@2ndquadrant.com wrote: Right. And that's why it's cool that logical decoding can operate through DDL differences. The apply side might not be able to cope with what pops out, but that's not logical decoding's fault, and different

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-11-14 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Nov 14, 2014 at 2:55 AM, Amit Kapila amit.kapil...@gmail.com wrote: OTOH, if that is okay, then I think we can avoid few #ifdef WIN32 that this patch introduces and can have consistency for this operation on both linux and Windows. Having one

Re: [HACKERS] Add CREATE support to event triggers

2014-11-14 Thread Andres Freund
On 2014-11-14 12:38:52 -0500, Robert Haas wrote: This is basically the same problem as multi-master replication conflicts, except with DDL. Resolving replication conflicts is not a very easy thing to get right even if you're only concerned about the rows in the tables. It's probably

Re: [HACKERS] PostgreSQL doesn't stop propley when --slot option is specified with pg_receivexlog.

2014-11-14 Thread Fujii Masao
On Fri, Nov 14, 2014 at 7:22 PM, furu...@pm.nttdata.co.jp wrote: Hi, pg_ctl stop does't work propley, if --slot option is specified when WAL is flushed only it has switched. These processes still continue even after the posmaster failed:pg_receivexlog, walsender and logger. I could

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-11-14 Thread Robert Haas
On Fri, Nov 14, 2014 at 1:15 PM, Tom Lane t...@sss.pgh.pa.us wrote: Generally I'd be in favor of avoiding platform-dependent code where possible, but that doesn't represent a YES vote for this particular patch. It looks pretty messy in a quick look, even granting that the #ifdef WIN32's would

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-11-14 Thread Alvaro Herrera
Amit Kapila wrote: 2. Symlink file format: oid linkpath 16387 E:\PostgreSQL\tbs Symlink file will contain entries for all the tablspaces under pg_tblspc directory. I have kept the file name as symlink_label (suggestion are welcome if you want some different name for this file). I think

Re: [HACKERS] PostgreSQL doesn't stop propley when --slot option is specified with pg_receivexlog.

2014-11-14 Thread Andres Freund
On 2014-11-15 03:25:16 +0900, Fujii Masao wrote: On Fri, Nov 14, 2014 at 7:22 PM, furu...@pm.nttdata.co.jp wrote: Hi, pg_ctl stop does't work propley, if --slot option is specified when WAL is flushed only it has switched. These processes still continue even after the posmaster

Re: [HACKERS] Size of regression database

2014-11-14 Thread Alvaro Herrera
Alvaro Herrera wrote: Tom Lane wrote: I was testing backwards compatibility of pg_dumpall just now, and was somewhat astonished to notice the size of the output for the regression database compared to what it was not too long ago: -rw-rw-r--. 1 tgl tgl 4509135 Nov 13 16:19 dumpall.83

Re: [HACKERS] printing table in asciidoc with psql

2014-11-14 Thread Szymon Guz
On 14 November 2014 20:57, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Is anyone going to submit a new version of this patch? Hi Alvaro, due to family issues I will not be able to work on it for the next 10 days. regards, Szymon

Re: [HACKERS] TODO request: log_long_transaction

2014-11-14 Thread Jim Nasby
On 11/7/14, 1:19 PM, Michael Banck wrote: Am Montag, den 27.10.2014, 19:29 + schrieb Thom Brown: On 27 October 2014 19:21, Josh Berkusj...@agliodbs.com wrote: I just realized that there is one thing we can't log currently: transactions which last more than #ms. This is valuable

Re: [HACKERS] EXPLAIN ANALYZE output weird for Top-N Sort

2014-11-14 Thread Jeremy Harris
On 14/11/14 14:54, Tom Lane wrote: Jeremy Harris j...@wizmail.org writes: On 14/11/14 00:46, Simon Riggs wrote: Limit (cost= rows=20 width=175) (actual time= rows=20 loops=1) - Sort (cost= rows=568733 width=175) (actual time= rows=20 loops=1) Sort Method: top-N heapsort

Re: [HACKERS] New storage parameter pages_per_range not mentioned in CREATE INDEX doc

2014-11-14 Thread Alvaro Herrera
Michael Paquier wrote: Hi all, The new storage parameter pages_per_range is missing in the documentation of CREATE INDEX. The patch attached corrects that. Thanks! Pushed. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-11-14 Thread Peter Eisentraut
On 11/13/14 4:33 PM, Peter Eisentraut wrote: Is this still relevant after this commit? commit fb05f3ce83d225dd0f39f8860ce04082753e9e98 Author: Peter Eisentraut pete...@gmx.net Date: Sat Feb 22 13:38:06 2014 -0500 pg_basebackup: Add support for relocating tablespaces I believe

[HACKERS] Idle transaction cancel/timeout and SSL revisited

2014-11-14 Thread Alex Shulgin
Hello Hackers, After reading up through archives on the two $subj related TODO items I'm under impression that the patches[1,2] didn't make it mainly because of the risk of breaking SSL internals if we try to longjump out of the signal handler in the middle of a blocking SSL read and/or if we try

Re: [HACKERS] Idle transaction cancel/timeout and SSL revisited

2014-11-14 Thread Andres Freund
Hi, On 2014-11-15 00:11:36 +0300, Alex Shulgin wrote: After reading up through archives on the two $subj related TODO items I'm under impression that the patches[1,2] didn't make it mainly because of the risk of breaking SSL internals if we try to longjump out of the signal handler in the

Re: [HACKERS] Idle transaction cancel/timeout and SSL revisited

2014-11-14 Thread Alex Shulgin
Andres Freund and...@2ndquadrant.com writes: On 2014-11-15 00:11:36 +0300, Alex Shulgin wrote: After reading up through archives on the two $subj related TODO items I'm under impression that the patches[1,2] didn't make it mainly because of the risk of breaking SSL internals if we try to

Re: [HACKERS] Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

2014-11-14 Thread Robert Haas
On Fri, Nov 14, 2014 at 2:51 PM, Stephen Frost sfr...@snowman.net wrote: * Robert Haas (robertmh...@gmail.com) wrote: On Thu, Nov 13, 2014 at 6:32 PM, Tom Lane t...@sss.pgh.pa.us wrote: What's bothering me is that I see this in pg_dumpall output from a 9.4 or earlier database: ALTER ROLE

Re: [HACKERS] On the warpath again about ill-considered inclusion nests

2014-11-14 Thread Stephen Frost
All, * Stephen Frost (sfr...@snowman.net) wrote: * Tom Lane (t...@sss.pgh.pa.us) wrote: Well, if you *only* move RowSecurityDesc and not RowSecurityPolicy, okay, but that seems a bit useless/inconsistent if I'm reading it right that RowSecurityDesc contains a List of RowSecurityPolicy

Re: [HACKERS] initdb -S and tablespaces

2014-11-14 Thread Andres Freund
On 2014-10-30 14:30:28 +0530, Abhijit Menon-Sen wrote: Here's a proposed patch to initdb to make initdb -S fsync everything under pg_tblspc. It introduces a new function that calls walkdir on every entry under pg_tblspc. This is only one approach: I could have also changed walkdir to follow

Re: [HACKERS] END_OF_RECOVERY shutdowns and ResetUnloggedRelations()

2014-11-14 Thread Andres Freund
On 2014-10-27 16:09:30 +0530, Abhijit Menon-Sen wrote: At 2014-09-25 22:41:18 +0200, and...@2ndquadrant.com wrote: On 2014-09-24 17:06:05 +0530, Abhijit Menon-Sen wrote: 1. Move the call to ResetUnloggedRelations(UNLOGGED_RELATION_INIT) to earlier in StartupXLOG. 2. Inside

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

2014-11-14 Thread Noah Misch
On Fri, Nov 14, 2014 at 11:47:49AM -0500, Stephen Frost wrote: On Fri, Nov 14, 2014 at 11:24:20AM -0500, Tom Lane wrote: I think Noah is arguing for leaving the pg_dumpall queries as they stand. I disagree, but he's entitled to his opinion. Ah, ok. I'm impartial, but I do note that

Re: [HACKERS] tracking commit timestamps

2014-11-14 Thread Simon Riggs
On 14 November 2014 17:12, Robert Haas robertmh...@gmail.com wrote: We are not talking about loading 20 new requirements on top of this patch; that would be intolerable. We're talking about adding one additional piece of information that has been requested multiple times over the years. The

[HACKERS] Useless dead struct in parse_func.h

2014-11-14 Thread Peter Geoghegan
It looks like commit 0e99be1c removed the final real use of the struct InhPaths. Attached patch removes it entirely. -- Peter Geoghegan diff --git a/src/include/parser/parse_func.h b/src/include/parser/parse_func.h index b9b06ae..4423bc0 100644 --- a/src/include/parser/parse_func.h +++

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

2014-11-14 Thread Stephen Frost
* Noah Misch (n...@leadboat.com) wrote: On Fri, Nov 14, 2014 at 11:47:49AM -0500, Stephen Frost wrote: rolcreaterole uses usesuper, while rolreplication and rolbypassrls do not. Noah- would you argue that we should change rolcreaterole, which has this behavior in all released branches

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

2014-11-14 Thread Noah Misch
On Fri, Nov 14, 2014 at 08:39:28PM -0500, Stephen Frost wrote: * Noah Misch (n...@leadboat.com) wrote: So, if you desire to make this consistent, I recommend using rolreplication's treatment as the gold standard. That is to say, when dumping from an older version, set to false any of

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

2014-11-14 Thread Stephen Frost
* Noah Misch (n...@leadboat.com) wrote: On Fri, Nov 14, 2014 at 08:39:28PM -0500, Stephen Frost wrote: I don't see the point in including them for --clean..? --clean states that DROP commands would be added, not that existing roles would be adjusted in some way. It does state that, but

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-11-14 Thread Amit Kapila
On Sat, Nov 15, 2014 at 2:21 AM, Peter Eisentraut pete...@gmx.net wrote: On 11/13/14 4:33 PM, Peter Eisentraut wrote: Is this still relevant after this commit? commit fb05f3ce83d225dd0f39f8860ce04082753e9e98 Author: Peter Eisentraut pete...@gmx.net Date: Sat Feb 22 13:38:06 2014

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-11-14 Thread Alvaro Herrera
Michael Paquier wrote: Btw, perhaps this diff should be pushed as a different patch as this is a rather different thing: - if (heapRelation-rd_rel-relpersistence == RELPERSISTENCE_UNLOGGED + if (indexRelation-rd_rel-relpersistence == RELPERSISTENCE_UNLOGGED

Re: [HACKERS] New storage parameter pages_per_range not mentioned in CREATE INDEX doc

2014-11-14 Thread Alvaro Herrera
Michael Paquier wrote: Hi all, The new storage parameter pages_per_range is missing in the documentation of CREATE INDEX. The patch attached corrects that. Ah BTW I had pushed this earlier today. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: [HACKERS] Useless dead struct in parse_func.h

2014-11-14 Thread Alvaro Herrera
Peter Geoghegan wrote: It looks like commit 0e99be1c removed the final real use of the struct InhPaths. Attached patch removes it entirely. I didn't verify the claim about 0e99be1c, but I pushed it anyway. Thanks. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] tracking commit timestamps

2014-11-14 Thread Steve Singer
On 11/14/2014 08:21 PM, Simon Riggs wrote: The requested information is already available, as discussed. Logical decoding adds commit ordering for *exactly* the purpose of using it for replication, available to all solutions. This often requested feature has now been added and doesn't need to be

Re: [HACKERS] New storage parameter pages_per_range not mentioned in CREATE INDEX doc

2014-11-14 Thread Michael Paquier
On Sat, Nov 15, 2014 at 1:27 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: Hi all, The new storage parameter pages_per_range is missing in the documentation of CREATE INDEX. The patch attached corrects that. Ah BTW I had pushed this earlier today. Thanks. --

Re: [HACKERS] WAL format and API changes (9.5)

2014-11-14 Thread Michael Paquier
On Fri, Nov 14, 2014 at 5:31 PM, Michael Paquier michael.paqu...@gmail.com wrote: 3) pg_xlogdump does not seem to work: $ pg_xlogdump 0001000D pg_xlogdump: FATAL: could not find a valid record after 0/D00 This one is a bad manipulation from my side. Please forget this

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-11-14 Thread Amit Kapila
On Sat, Nov 15, 2014 at 12:03 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Amit Kapila wrote: 2. Symlink file format: oid linkpath 16387 E:\PostgreSQL\tbs Symlink file will contain entries for all the tablspaces under pg_tblspc directory. I have kept the file name as

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-11-14 Thread Amit Kapila
On Sat, Nov 15, 2014 at 12:01 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, Nov 14, 2014 at 1:15 PM, Tom Lane t...@sss.pgh.pa.us wrote: Generally I'd be in favor of avoiding platform-dependent code where possible, but that doesn't represent a YES vote for this particular patch. It