[HACKERS] Re: Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs

2015-01-06 Thread Atri Sharma
On Tuesday, January 6, 2015, Amit Langote langote_amit...@lab.ntt.co.jp wrote: On 06-01-2015 PM 04:26, Atri Sharma wrote: On Tue, Jan 6, 2015 at 12:43 PM, Amit Langote langote_amit...@lab.ntt.co.jp javascript:; wrote: Though, I have no strong opinion on whether one thing is good or the

Re: [HACKERS] Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs

2015-01-06 Thread Amit Langote
On 06-01-2015 PM 04:26, Atri Sharma wrote: On Tue, Jan 6, 2015 at 12:43 PM, Amit Langote langote_amit...@lab.ntt.co.jp wrote: Though, I have no strong opinion on whether one thing is good or the other or whether they cover some particular use case all the same. Perhaps you can say that

Re: [HACKERS] Re: [COMMITTERS] pgsql: Change how first WAL segment on new timeline after promotion is

2015-01-06 Thread Andres Freund
On 2015-01-06 13:46:57 -0500, Robert Haas wrote: On Tue, Jan 6, 2015 at 8:22 AM, Andres Freund and...@2ndquadrant.com wrote: I've attached attached, for posterities sake, the last version of that script. I think we should have at least some of these tests in the tap tests. I'd not used that

Re: [HACKERS] Possible typo in create_policy.sgml

2015-01-06 Thread Peter Geoghegan
On Tue, Jan 6, 2015 at 11:25 AM, Stephen Frost sfr...@snowman.net wrote: Looks reasonable to me. Amit, does this read better for you? If so, I can handle making the change to the docs. The docs also prominently say: The security-barrier qualifications will always be evaluated prior to any

Re: [HACKERS] INSERT ... ON CONFLICT UPDATE and RLS

2015-01-06 Thread Peter Geoghegan
On Tue, Jan 6, 2015 at 9:39 AM, Robert Haas robertmh...@gmail.com wrote: I think the INSERT .. ON CONFLICT UPDATE shouldn't be able to attempt an update unless the UPDATE policies of the table are such that a regular UPDATE would find the affected row. The post-image of the row needs to

Re: [HACKERS] tracking commit timestamps

2015-01-06 Thread Robert Haas
On Tue, Jan 6, 2015 at 2:58 AM, Michael Paquier michael.paqu...@gmail.com wrote: So, we would need additional information other than the node ID *and* the timestamp to ensure proper transaction commit ordering on Windows. That's not cool and makes this feature very limited on this platform.

Re: [HACKERS] pg_rewind in contrib

2015-01-06 Thread Peter Eisentraut
I applaud the ingenuity on all levels in this patch. But it seems to me that there is way too much backend knowledge encoded and/or duplicated in a front-end program. If this ends up shipping, it's going to be a massively popular tool. I see it as a companion to pg_basebackup. So it should

Re: [HACKERS] Re: [COMMITTERS] pgsql: Change how first WAL segment on new timeline after promotion is

2015-01-06 Thread Robert Haas
On Tue, Jan 6, 2015 at 8:22 AM, Andres Freund and...@2ndquadrant.com wrote: I've attached attached, for posterities sake, the last version of that script. I think we should have at least some of these tests in the tap tests. I'd not used that framework because I wanted to test back to 9.1, but

Re: [HACKERS] Possible typo in create_policy.sgml

2015-01-06 Thread Stephen Frost
Robert, Amit, * Robert Haas (robertmh...@gmail.com) wrote: I don't think that's a typo, although it's not particularly well-worded IMHO. I might rewrite the whole paragraph like this: A policy limits the ability to SELECT, INSERT, UPDATE, or DELETE rows in a table to those rows which match

Re: [HACKERS] Updating copyright notices to 2015 for PGDG

2015-01-06 Thread Stefan Kaltenbrunner
On 01/06/2015 04:19 PM, Bruce Momjian wrote: On Sat, Jan 3, 2015 at 01:45:37PM -0800, David Fetter wrote: On Sat, Jan 03, 2015 at 09:54:16PM +0900, Michael Paquier wrote: Hi all, Shouldn't we update the copyright notices to 2015 for PGDG like in 7e04792? I mean those things mainly:

Re: [HACKERS] parallel mode and parallel contexts

2015-01-06 Thread Simon Riggs
On 6 January 2015 at 16:33, Robert Haas robertmh...@gmail.com wrote: These comments don’t have any explanation or justification OK, I rewrote them. Hopefully it's better now. Thanks for new version and answers. * Transaction stuff strikes me as overcomplicated and error prone. Given there

Re: [HACKERS] Updating copyright notices to 2015 for PGDG

2015-01-06 Thread Bruce Momjian
On Tue, Jan 6, 2015 at 08:46:19PM +0100, Stefan Kaltenbrunner wrote: I will run the script today. I didn't do it earlier because I want to be current on reading community email before doing it. hmm is it intentional that the commit also changed other files? looks like the commited

Re: [HACKERS] Updating copyright notices to 2015 for PGDG

2015-01-06 Thread Stefan Kaltenbrunner
On 01/06/2015 10:12 PM, Alvaro Herrera wrote: Bruce Momjian wrote: On Tue, Jan 6, 2015 at 08:46:19PM +0100, Stefan Kaltenbrunner wrote: I will run the script today. I didn't do it earlier because I want to be current on reading community email before doing it. hmm is it intentional that

Re: [HACKERS] Turning recovery.conf into GUCs

2015-01-06 Thread Josh Berkus
On 01/06/2015 01:22 PM, Peter Eisentraut wrote: That said, there is a much simpler way to achieve that specific functionality: Expose all the recovery settings as fake read-only GUC variables. See attached patch for an example. I have no objections to that idea in principle. As long as it

Re: [HACKERS] INSERT ... ON CONFLICT UPDATE and RLS

2015-01-06 Thread Peter Geoghegan
Another issue that I see is that there is only one resultRelation between the INSERT and UPDATE. That means that without some additional special measure, both UPDATE and INSERT WITH CHECK ( ... ) options are applied regardless of whether the INSERT path was taken, or the UPDATE path. Maybe that's

Re: [HACKERS] Possible typo in create_policy.sgml

2015-01-06 Thread Peter Geoghegan
On Tue, Jan 6, 2015 at 1:03 PM, Robert Haas robertmh...@gmail.com wrote: I thought my rewrite clarified this distinction pretty well. Maybe I'm wrong? We're talking about the same paragraph. Sorry, I didn't express myself clearly. I think that you did get it right, but I would like to see

Re: [HACKERS] Updating copyright notices to 2015 for PGDG

2015-01-06 Thread Bruce Momjian
On Tue, Jan 6, 2015 at 06:12:30PM -0300, Alvaro Herrera wrote: Bruce Momjian wrote: On Tue, Jan 6, 2015 at 08:46:19PM +0100, Stefan Kaltenbrunner wrote: I will run the script today. I didn't do it earlier because I want to be current on reading community email before doing it.

Re: [HACKERS] Turning recovery.conf into GUCs

2015-01-06 Thread Peter Eisentraut
On 1/6/15 12:57 AM, Josh Berkus wrote: On 01/05/2015 05:43 PM, Peter Eisentraut wrote: The wins on the other hand are obscure: You can now use SHOW to inspect recovery settings. You can design your own configuration file include structures to set them. These are not bad, but is that all?

Re: [HACKERS] Re: Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs

2015-01-06 Thread Jim Nasby
On 1/6/15, 10:32 AM, Alvaro Herrera wrote: Tom Lane wrote: What would make sense to me is to teach the planner about inlining SQL functions that include ORDER BY clauses, so that the performance issue of a double sort could be avoided entirely transparently to the user. Wouldn't this be

Re: [HACKERS] Add min and max execute statement time in pg_stat_statement

2015-01-06 Thread Andrew Dunstan
On 12/21/2014 02:50 PM, Andrew Dunstan wrote: On 12/21/2014 02:12 PM, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: On 12/21/2014 01:23 PM, Alvaro Herrera wrote: The point, I think, is that without atomic instructions you have to hold a lock while incrementing the counters.

Re: [HACKERS] Re: Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs

2015-01-06 Thread David Johnston
On Tue, Jan 6, 2015 at 4:15 PM, Jim Nasby jim.na...@bluetreble.com wrote: On 1/6/15, 10:32 AM, Alvaro Herrera wrote: Tom Lane wrote: What would make sense to me is to teach the planner about inlining SQL functions that include ORDER BY clauses, so that the performance issue of a double

Re: [HACKERS] Turning recovery.conf into GUCs

2015-01-06 Thread Andres Freund
On 2015-01-06 16:33:36 -0800, Josh Berkus wrote: F. Inability to remaster without restarting the replica. That has pretty much nothing to do with the topic at hand. I. Fairly duplicative options between pg.conf and recovery.conf (i.e. standby_mode vs. hot_standby) Those aren't the same.

Re: [HACKERS] Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs

2015-01-06 Thread Jim Nasby
On 1/6/15, 1:00 AM, Ashutosh Bapat wrote: Even checking whether the output of the function is in the right order or not, has its cost. I am suggesting that we can eliminate this cost as well. For example, PostgreSQL does not check whether a function is really immutable or not. Actually, it

Re: [HACKERS] pg_rewind in contrib

2015-01-06 Thread Michael Paquier
On Wed, Jan 7, 2015 at 5:39 AM, Peter Eisentraut pete...@gmx.net wrote: Also, since you have been maintaining this tool for a while, what is the effort for maintaining it from version to version? From my own experience, the main source of maintenance across major versions is the modification of

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-01-06 Thread Kouhei Kaigai
scan_relid != InvalidOid Ideally, they should be OidIsValid(scan_relid) Scan.scanrelid is an index of range-tables list, not an object-id. So, InvalidOid or OidIsValid() are not a good choice. The bare relation oid has to be saved on relid of RangeTblEntry which can be pulled using

Re: [HACKERS] XLOG_PARAMETER_CHANGE handling of wal_log_hints

2015-01-06 Thread Michael Paquier
On Wed, Jan 7, 2015 at 4:24 AM, Petr Jelinek p...@2ndquadrant.com wrote: Hi, when I was fixing how commit_ts handles the XLOG_PARAMETER_CHANGE I noticed that for wal_log_hints we assign the value in ControFile to current value instead of value that comes from WAL. ISTM it has just

Re: [HACKERS] Possible typo in create_policy.sgml

2015-01-06 Thread Peter Geoghegan
I also don't see this behavior documented (this is from process_policies()): /* * If we end up with only USING quals, then use those as * WITH CHECK quals also. */ if (with_check_quals == NIL) with_check_quals = copyObject(quals); Now, I do see a reference to it under Per-Command policies -

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-01-06 Thread Petr Jelinek
On 07/01/15 00:05, Jim Nasby wrote: On 1/6/15, 8:17 AM, Kouhei Kaigai wrote: The attached patch is newer revision of custom-/foreign-join interface. Shouldn't instances of scan_relid 0 be scan_relid != InvalidOid Ideally, they should be OidIsValid(scan_relid) -- Petr Jelinek

Re: [HACKERS] pg_rewind in contrib

2015-01-06 Thread Andrew Dunstan
On 01/06/2015 03:39 PM, Peter Eisentraut wrote: I applaud the ingenuity on all levels in this patch. But it seems to me that there is way too much backend knowledge encoded and/or duplicated in a front-end program. If this ends up shipping, it's going to be a massively popular tool. I see it

Re: [HACKERS] Updating copyright notices to 2015 for PGDG

2015-01-06 Thread Tom Lane
Jim Nasby jim.na...@bluetreble.com writes: On 1/6/15, 3:30 PM, Stefan Kaltenbrunner wrote: I dont know why it is really needed but maybe for the files that have identical copyrights one could simple reference to the COPYRIGHT file we already have in the tree? +1 Unless either of you is a

Re: [HACKERS] pg_rewind in contrib

2015-01-06 Thread Andres Freund
On 2015-01-06 15:39:29 -0500, Peter Eisentraut wrote: I applaud the ingenuity on all levels in this patch. But it seems to me that there is way too much backend knowledge encoded and/or duplicated in a front-end program. Hm. There's really not that much in the current version anymore? Sure,

Re: [HACKERS] Turning recovery.conf into GUCs

2015-01-06 Thread Josh Berkus
Peter, all: Let me go over the issues I find with recovery.conf, based on 3 aspects of my experience (1) doing DBA support (2) as a tool author (HandyRep) and (3) as a trainer, teaching new users about it. If we agree on a list of problems with the current setup (as well as a list of benefits)

Re: [HACKERS] Updating copyright notices to 2015 for PGDG

2015-01-06 Thread Jim Nasby
On 1/6/15, 3:30 PM, Stefan Kaltenbrunner wrote: I dont know why it is really needed but maybe for the files that have identical copyrights one could simple reference to the COPYRIGHT file we already have in the tree? +1 Also, now that we're on git it wouldn't be that hard to add commit hooks

Re: [HACKERS] Updating copyright notices to 2015 for PGDG

2015-01-06 Thread Michael Paquier
On Wed, Jan 7, 2015 at 8:48 AM, Jim Nasby jim.na...@bluetreble.com wrote: On 1/6/15, 3:30 PM, Stefan Kaltenbrunner wrote: I dont know why it is really needed but maybe for the files that have identical copyrights one could simple reference to the COPYRIGHT file we already have in the tree?

Re: [HACKERS] parallel mode and parallel contexts

2015-01-06 Thread Robert Haas
On Tue, Jan 6, 2015 at 3:04 PM, Simon Riggs si...@2ndquadrant.com wrote: If you can explain it in more detail in comments and README, I may agree. At present, I don't get it and it makes me nervous. The comment says Only the top frame of the transaction state stack is copied to a parallel

Re: [HACKERS] pg_basebackup fails with long tablespace paths

2015-01-06 Thread Peter Eisentraut
On 12/27/14 8:02 PM, Robert Haas wrote: On Wed, Dec 24, 2014 at 8:12 AM, Peter Eisentraut pete...@gmx.net wrote: On 12/22/14 10:00 PM, Amit Kapila wrote: There is already a patch [1] in this CF which will handle both cases, so I am not sure if it is very good idea to go with a new tar format

Re: [HACKERS] Possible typo in create_policy.sgml

2015-01-06 Thread Robert Haas
On Tue, Jan 6, 2015 at 2:48 PM, Peter Geoghegan p...@heroku.com wrote: On Tue, Jan 6, 2015 at 11:25 AM, Stephen Frost sfr...@snowman.net wrote: Looks reasonable to me. Amit, does this read better for you? If so, I can handle making the change to the docs. The docs also prominently say:

[HACKERS] VODKA?

2015-01-06 Thread Josh Berkus
Oleg, Teodor: I take it VODKA is sliding to version 9.6? -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] parallel mode and parallel contexts

2015-01-06 Thread Simon Riggs
On 6 January 2015 at 21:01, Robert Haas robertmh...@gmail.com wrote: On Tue, Jan 6, 2015 at 3:04 PM, Simon Riggs si...@2ndquadrant.com wrote: If you can explain it in more detail in comments and README, I may agree. At present, I don't get it and it makes me nervous. The comment says Only

[HACKERS] XLOG_PARAMETER_CHANGE handling of wal_log_hints

2015-01-06 Thread Petr Jelinek
Hi, when I was fixing how commit_ts handles the XLOG_PARAMETER_CHANGE I noticed that for wal_log_hints we assign the value in ControFile to current value instead of value that comes from WAL. ISTM it has just information value so it should not have any practical impact, but it looks like a

Re: [HACKERS] Updating copyright notices to 2015 for PGDG

2015-01-06 Thread Alvaro Herrera
Bruce Momjian wrote: On Tue, Jan 6, 2015 at 08:46:19PM +0100, Stefan Kaltenbrunner wrote: I will run the script today. I didn't do it earlier because I want to be current on reading community email before doing it. hmm is it intentional that the commit also changed other files?

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-01-06 Thread Jim Nasby
On 1/6/15, 8:17 AM, Kouhei Kaigai wrote: The attached patch is newer revision of custom-/foreign-join interface. Shouldn't instances of scan_relid 0 be scan_relid != InvalidOid ? -- Jim Nasby, Data Architect, Blue Treble Consulting Data in Trouble? Get it in Treble! http://BlueTreble.com

Re: [HACKERS] Re: Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs

2015-01-06 Thread Jim Nasby
On 1/5/15, 3:14 PM, Tom Lane wrote: Jim Nasby jim.na...@bluetreble.com writes: Related... I'd like to see a way to inline a function that does something like: CREATE FUNCTION foo(text) RETURNS int LANGUAGE sql AS $$ SELECT a FROM b WHERE lower(b.c) = lower($1) $$ The reason that's not

Re: [HACKERS] Turning recovery.conf into GUCs

2015-01-06 Thread Andres Freund
On 2015-01-05 20:43:12 -0500, Peter Eisentraut wrote: For example, putting recovery target parameters into postgresql.conf might not make sense to some people. Once you have reached the recovery end point, the information is obsolete. Keeping it set could be considered confusing. I don't

Re: [HACKERS] Turning recovery.conf into GUCs

2015-01-06 Thread Josh Berkus
On 01/06/2015 05:17 PM, Andres Freund wrote: A real solution to this requires more. You need to 1) disable writing any wal 2) force catchup of all possible standbys, including apply. Most importantly of the new master. This requires knowing which standbys exist. 3) promote new master. 4) only

Re: [HACKERS] Turning recovery.conf into GUCs

2015-01-06 Thread Josh Berkus
On 01/06/2015 04:42 PM, Andres Freund wrote: On 2015-01-06 16:33:36 -0800, Josh Berkus wrote: F. Inability to remaster without restarting the replica. That has pretty much nothing to do with the topic at hand. It has *everything* to do with the topic at hand. The *only* reason we can't

Re: [HACKERS] Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs

2015-01-06 Thread Amit Langote
On 07-01-2015 AM 08:33, Jim Nasby wrote: On 1/6/15, 1:00 AM, Ashutosh Bapat wrote: Even checking whether the output of the function is in the right order or not, has its cost. I am suggesting that we can eliminate this cost as well. For example, PostgreSQL does not check whether a function is

Re: [HACKERS] pg_basebackup fails with long tablespace paths

2015-01-06 Thread Amit Kapila
On Wed, Jan 7, 2015 at 3:03 AM, Peter Eisentraut pete...@gmx.net wrote: On 12/27/14 8:02 PM, Robert Haas wrote: On Wed, Dec 24, 2014 at 8:12 AM, Peter Eisentraut pete...@gmx.net wrote: On 12/22/14 10:00 PM, Amit Kapila wrote: There is already a patch [1] in this CF which will handle both

Re: [HACKERS] Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs

2015-01-06 Thread Michael Paquier
On Tue, Jan 6, 2015 at 12:12 AM, Atri Sharma atri.j...@gmail.com wrote: I will add the patch to current commitfest. It has been indeed added to the commit fest 2014-12. That's a bit late, moving it to upcoming one 2015-02. Thanks, -- Michael -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Turning recovery.conf into GUCs

2015-01-06 Thread Andres Freund
On 2015-01-06 17:08:20 -0800, Josh Berkus wrote: On 01/06/2015 04:42 PM, Andres Freund wrote: On 2015-01-06 16:33:36 -0800, Josh Berkus wrote: F. Inability to remaster without restarting the replica. That has pretty much nothing to do with the topic at hand. It has *everything* to do

Re: [HACKERS] Possible typo in create_policy.sgml

2015-01-06 Thread Amit Langote
On 07-01-2015 AM 04:25, Stephen Frost wrote: Robert, Amit, * Robert Haas (robertmh...@gmail.com) wrote: I don't think that's a typo, although it's not particularly well-worded IMHO. I might rewrite the whole paragraph like this: A policy limits the ability to SELECT, INSERT, UPDATE, or

Re: [HACKERS] Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs

2015-01-06 Thread Ashutosh Bapat
Not in all cases postgres=# create function non_im_immutable_function() returns float as $$ begin return *random()*; end; $$ language plpgsql *immutable*; CREATE FUNCTION postgres=# select proname, provolatile from pg_proc where proname = 'random' or proname = 'non_im_immutable_function';

Re: [HACKERS] [REVIEW] Re: Fix xpath() to return namespace definitions

2015-01-06 Thread Peter Eisentraut
committed version 7 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2015-01-06 Thread Dilip kumar
On 20 December 2014 16:30, Amit Kapila Wrote, Summarization of latest changes: 1. Change file name from symlink_label to tablespace_map and changed the same every where in comments and variable names. 2. This feature will be supportted for both windows and linux; tablespace_map file will be

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2015-01-06 Thread Amit Kapila
On Wed, Jan 7, 2015 at 10:45 AM, Dilip kumar dilip.ku...@huawei.com wrote: On 20 December 2014 16:30, Amit Kapila Wrote, Summarization of latest changes: 1. Change file name from symlink_label to tablespace_map and changed the same every where in comments and variable names. 2. This

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2015-01-06 Thread Ashutosh Bapat
On Mon, Jan 5, 2015 at 11:55 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, Jan 2, 2015 at 3:45 PM, Tom Lane t...@sss.pgh.pa.us wrote: In short, you can't force 2PC technology on people who aren't using it already; while for those who are using it already, this isn't nearly good

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2015-01-06 Thread Dilip kumar
On 07 January 2015 11:21, Amit Kapila Wrote, Tom has spotted this problem and suggested 3 different options to handle this issue, apart from above 2, third one is Go over to a byte-count-then-value format. Then Andrew and Heikki supported/asked to follow option 2 (as is followed in patch) and no

Re: [HACKERS] [REVIEW] Re: Fix xpath() to return namespace definitions

2015-01-06 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: committed version 7 Isn't that a back-patchable bug fix? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Updating copyright notices to 2015 for PGDG

2015-01-06 Thread Alvaro Herrera
Stefan Kaltenbrunner wrote: On 01/06/2015 10:12 PM, Alvaro Herrera wrote: This makes me wonder however how wise it is to update the copyright notices in every single file in the repo. Why do we need this? Why not abolish the practice and live forever with most files having copyright

Re: [HACKERS] parallel mode and parallel contexts

2015-01-06 Thread Jim Nasby
On 1/6/15, 10:33 AM, Robert Haas wrote: Entrypints? Already noted by Andres; fixed in the attached version. Perhaps we only parallelize while drinking beer... ;) CreateParallelContext(): Does it actually make sense to have nworkers=0? ISTM that's a bogus case. Also, since the number of

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2015-01-06 Thread Michael Paquier
On Wed, Jan 7, 2015 at 12:51 AM, Rahila Syed rahilasyed...@gmail.com wrote: Following are some comments, Thanks for the feedback. uint16 hole_offset:15, /* number of bytes in hole */ Typo in description of hole_offset Fixed. That's before hole. for (block_id = 0; block_id =

Re: [HACKERS] psql -c does not honor ON_ERROR_STOP

2015-01-06 Thread Tom Lane
Joe Conway joe.con...@credativ.com writes: This seems like either a psql bug or maybe just a documentation bug. I know the psql docs say that -c behavior can be surprising, but I find the below surprising even after reading the docs a couple of times. Given that ON_ERROR_STOP defaults to off,