Re: [HACKERS] New CF app deployment

2015-01-25 Thread Magnus Hagander
On Sun, Jan 25, 2015 at 1:28 AM, Tomas Vondra wrote: > Hi, > > seems the CF app uses an invalid e-mail address when sending messages to > pgsql-hackers - I've added a comment to one of the patches and got this: > > pgsql-hackers-testing@localhost > Unrouteable address > > Maybe that's expec

Re: [HACKERS] New CF app deployment

2015-01-25 Thread Peter Geoghegan
Is there any possibility of making it possible to "annotate" particular messages (in particular, patch-related messages) with brief comments? I would like to be able to highlight particular messages as particular versions of the patch, and have it be apparent what properties that version has at a g

[HACKERS] Re: Shortcoming in CLOBBER_FREED_MEMORY coverage: disk buffer pointers

2015-01-25 Thread Noah Misch
On Sat, Jan 24, 2015 at 01:48:43PM -0800, Peter Geoghegan wrote: > On Sat, Jan 24, 2015 at 1:31 PM, Tom Lane wrote: > > Another idea is to teach Valgrind that whenever a backend reduces its > > pin count on a shared buffer to zero, that buffer should become undefined > > memory. > > That should b

Re: [HACKERS] proposal: row_to_array function

2015-01-25 Thread Pavel Stehule
Hi I tested a concept iteration over array in format [key1, value1, key2, value2, .. ] - what is nice, it works for [[key1,value1],[key2, value2], ...] too It is only a few lines more to current code, and this change doesn't break a compatibility. Do you think, so this patch is acceptable? Idea

Re: [HACKERS] Re: Abbreviated keys for Datum tuplesort

2015-01-25 Thread Andrew Gierth
> "Robert" == Robert Haas writes: >> Here's the cleaned-up version of the patch to allow abbreviated keys >> when sorting a single Datum. This also removes comments that suggest >> that the caller of tuplesort_begin_datum should ever have to care >> about the abbreviated key optimization.

Re: [HACKERS] New CF app deployment

2015-01-25 Thread Andrew Gierth
> "Peter" == Peter Geoghegan writes: Peter> The mailing list integration is good, but seems like it could Peter> often be overkill. I just want to "tag" an existing message for Peter> readability here, like with the old commitfest app. I like to Peter> make things easy to find from the CF

[HACKERS] longjmp clobber warnings are utterly broken in modern gcc

2015-01-25 Thread Tom Lane
I've been looking for other instances of the problem Mark Wilding pointed out, about missing "volatile" markers on variables that are modified in PG_TRY blocks and then used in the PG_CATCH stanzas. There definitely are some. Current gcc versions do not warn about that. If you turn on -Wclobbered

Re: [HACKERS] longjmp clobber warnings are utterly broken in modern gcc

2015-01-25 Thread Greg Stark
Some Google(tm)ing does turn up plenty of other people complaining about similar behaviour. This report seems to have the most enlightening response: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54561 Perhaps Clang has a more useful warning? ​

Re: [HACKERS] Client deadlocks when connecting via ssl

2015-01-25 Thread Maciek Sakrejda
Hello, I wanted to follow up on a bug report [1] from October. In a reply, Heikki conceded that there does seem to be an issue with how Postgres interacts with OpenSSL, but the nature of the API makes it difficult to fix. I'm with Heroku Postgres, and though the issue is not Heroku-specific, it d

Re: [HACKERS] longjmp clobber warnings are utterly broken in modern gcc

2015-01-25 Thread Tom Lane
Greg Stark writes: > Some Google(tm)ing does turn up plenty of other people complaining about > similar behaviour. This report seems to have the most enlightening response: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54561 Yeah, I saw that before too. I got an interesting response from Jakub

Re: [HACKERS] longjmp clobber warnings are utterly broken in modern gcc

2015-01-25 Thread Martijn van Oosterhout
On Sun, Jan 25, 2015 at 02:02:47PM -0500, Tom Lane wrote: > and compared the assembly language generated with and without adding > "volatile" to Tmpfd's declaration. Without "volatile" (ie, in the > code as shipped), gcc optimizes away the assignment "Tmpfd = -1" > within PG_TRY, and it also optim

Re: [HACKERS] longjmp clobber warnings are utterly broken in modern gcc

2015-01-25 Thread Tom Lane
Martijn van Oosterhout writes: > On Sun, Jan 25, 2015 at 02:02:47PM -0500, Tom Lane wrote: >> This is scary as hell. I intend to go around and manually audit >> every single PG_TRY in the current source code, but that is obviously >> not a long-term solution. Anybody have an idea about how we mi

Re: Partitioning: issues/ideas (Was: Re: [HACKERS] On partitioning)

2015-01-25 Thread Amit Langote
On 21-01-2015 PM 07:26, Amit Langote wrote: > Ok, I will limit myself to focusing on following things at the moment: > > * Provide syntax in CREATE TABLE to declare partition key While working on this, I stumbled upon the question of how we deal with any index definitions following from constrain

Re: [HACKERS] Error check always bypassed in tablefunc.c

2015-01-25 Thread Michael Paquier
On Sat, Jan 17, 2015 at 11:16 PM, Michael Paquier wrote: > Patch is attached. Comments welcome. So, I have been poking at this code a bit more and as the values of the parameters are passed as-is to the SQL queries that connectby generates internally (this is as well mentioned in the documentation

Re: [HACKERS] Client deadlocks when connecting via ssl

2015-01-25 Thread Heikki Linnakangas
On 01/25/2015 10:33 PM, Maciek Sakrejda wrote: Hello, I wanted to follow up on a bug report [1] from October. In a reply, Heikki conceded that there does seem to be an issue with how Postgres interacts with OpenSSL, but the nature of the API makes it difficult to fix. I'm with Heroku Postgres,

Re: [HACKERS] Client deadlocks when connecting via ssl

2015-01-25 Thread Maciek Sakrejda
On Sun, Jan 25, 2015 at 11:13 PM, Heikki Linnakangas < hlinnakan...@vmware.com> wrote: > I couldn't come up with any good solutions. I would suggest speaking to > the OpenSSL folk. They must be aware of the issue, so what do they > recommend, do they have any plans to fix it, and if there's anythi