Re: [HACKERS] New CF app deployment

2015-02-14 Thread Magnus Hagander
On Sat, Feb 7, 2015 at 1:59 PM, Magnus Hagander wrote: > On Sat, Feb 7, 2015 at 1:53 PM, Tom Lane wrote: > >> Magnus Hagander writes: >> > On Sat, Feb 7, 2015 at 1:02 AM, Jeff Janes >> wrote: >> >> I'd like the ability to add a comment which does not get turned into an >> >> email. >> >> > I r

Re: [HACKERS] New CF app deployment

2015-02-14 Thread Magnus Hagander
On Mon, Feb 9, 2015 at 4:56 PM, Robert Haas wrote: > On Mon, Feb 9, 2015 at 5:38 AM, Magnus Hagander > wrote: > > On Mon, Feb 9, 2015 at 11:09 AM, Marco Nenciarini > > wrote: > >> > >> Il 08/02/15 17:04, Magnus Hagander ha scritto: > >> > > >> > Filenames are now shown for attachments, includin

Re: [HACKERS] Patch to support SEMI and ANTI join removal

2015-02-14 Thread David Rowley
There does not seem to be a delete button, so marking as "rejected" due to this now being a duplicate entry for this patch. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Patch to support SEMI and ANTI join removal

2015-02-14 Thread David Rowley
On 13 February 2015 at 20:52, Michael Paquier wrote: > > > On Sun, Nov 23, 2014 at 8:23 PM, David Rowley > wrote: > >> >> As the patch stands there's still a couple of FIXMEs in there, so there's >> still a bit of work to do yet. >> Comments are welcome >> > > Hm, if there is still work to do, w

Re: [HACKERS] Manipulating complex types as non-contiguous structures in-memory

2015-02-14 Thread Tom Lane
Martijn van Oosterhout writes: > On Thu, Feb 12, 2015 at 08:52:56AM -0500, Robert Haas wrote: >>> BTW, I'm not all that thrilled with the "deserialized object" terminology. >>> I found myself repeatedly tripping up on which form was serialized and >>> which de-. If anyone's got a better naming id

Re: [HACKERS] why does find_my_exec resolve symlinks?

2015-02-14 Thread Tom Lane
Peter Eisentraut writes: > Here is a scenario: > ./configure --prefix=/usr/local/pgsql/9.4.1 > make > make install > ln -s 9.4.1 /usr/local/pgsql/9.4 > PATH=/usr/local/pgsql/9.4/bin:$PATH > And then when 9.4.2 comes out, the symlink is updated. > I think this sort of setup in variations is not u

Re: [HACKERS] chkpass with RANDOMIZE_ALLOCATED_MEMORY

2015-02-14 Thread Tom Lane
Asif Naeem writes: > It is been observed on RANDOMIZE_ALLOCATED_MEMORY enabled PG95 build that > chkpass is failing because of uninitialized memory and seems showing false > alarm. It's not a false alarm, unfortunately, because chkpass_in actually does give different results from one call to the

Re: [HACKERS] gcc5: initdb produces gigabytes of _fsm files

2015-02-14 Thread Andres Freund
On 2015-02-12 18:16:37 -0500, Tom Lane wrote: > I wrote: > > Christoph Berg writes: > >> gcc5 is lurking in Debian experimental, and it's breaking initdb. > > > Yeah, I just heard the same about Red Hat as well: > > https://bugzilla.redhat.com/show_bug.cgi?id=1190978 > > Not clear if it's an outr

Re: [HACKERS] Manipulating complex types as non-contiguous structures in-memory

2015-02-14 Thread Robert Haas
On Sat, Feb 14, 2015 at 10:45 AM, Tom Lane wrote: > Martijn van Oosterhout writes: >> On Thu, Feb 12, 2015 at 08:52:56AM -0500, Robert Haas wrote: BTW, I'm not all that thrilled with the "deserialized object" terminology. I found myself repeatedly tripping up on which form was serialize

Re: [HACKERS] "multiple backends attempting to wait for pincount 1"

2015-02-14 Thread Kevin Grittner
Andres Freund wrote: > I don't think it's actually 675333 at fault here. I think it's a > long standing bug in LockBufferForCleanup() that can just much > easier be hit with the new interrupt code. The patches I'll be posting soon make it even easier to hit, which is why I was trying to sort thi

Re: [HACKERS] New CF app deployment

2015-02-14 Thread Robert Haas
On Sat, Feb 14, 2015 at 7:29 AM, Magnus Hagander wrote: > Ok, I've pushed an attempt at doing this. > > For each mailthread, you can now create annotations. Each annotation is > connected to a mail in the thread, and has a free text comment field. The > message will then automatically be "highligh

Re: [HACKERS] Manipulating complex types as non-contiguous structures in-memory

2015-02-14 Thread Tom Lane
Robert Haas writes: > On Sat, Feb 14, 2015 at 10:45 AM, Tom Lane wrote: >> Martijn van Oosterhout writes: >>> The words that sprung to mind for me were: packed/unpacked. >> Trouble is that we're already using "packed" with a specific connotation >> in that same area of the code, namely for shor

Re: [HACKERS] "multiple backends attempting to wait for pincount 1"

2015-02-14 Thread Andres Freund
On 2015-02-14 17:25:00 +, Kevin Grittner wrote: > Andres Freund wrote: > > Imagine what happens in LockBufferForCleanup() when > > ProcWaitForSignal() returns spuriously - something it's > > documented to possibly do (and which got more likely with the new > > patches). In the normal case Unpi

Re: [HACKERS] reducing our reliance on MD5

2015-02-14 Thread Henry B (Hank) Hotz, CISSP
SASL was done by many of the same people who did GSSAPI. It's main practical advantages are that it supports password-based mechanisms (in addition to GSSAPI/krb5), and that it’s more explicitly pluggable than GSSAPI is. The password mechanism is simple enough that it's frequently implemented

Re: [HACKERS] "multiple backends attempting to wait for pincount 1"

2015-02-14 Thread Tom Lane
Andres Freund writes: > I don't think it's actually 675333 at fault here. I think it's a > long standing bug in LockBufferForCleanup() that can just much easier be > hit with the new interrupt code. > Imagine what happens in LockBufferForCleanup() when ProcWaitForSignal() > returns spuriously - s

Re: [HACKERS] "multiple backends attempting to wait for pincount 1"

2015-02-14 Thread Kevin Grittner
Andres Freund wrote: > On 2015-02-14 17:25:00 +, Kevin Grittner wrote: >>> I think we should simply move the >>> buf->flags &= ~BM_PIN_COUNT_WAITER (Inside LockBuffer) >> >> I think you meant inside UnpinBuffer? > > No, LockBufferHdr. What I meant was that the pincount can only be > manipula

Re: [HACKERS] New CF app deployment

2015-02-14 Thread Jim Nasby
On 2/14/15 11:42 AM, Robert Haas wrote: On Sat, Feb 14, 2015 at 7:29 AM, Magnus Hagander wrote: Ok, I've pushed an attempt at doing this. For each mailthread, you can now create annotations. Each annotation is connected to a mail in the thread, and has a free text comment field. The message wi

Re: [HACKERS] RangeType internal use

2015-02-14 Thread Jim Nasby
On 2/13/15 3:34 PM, David Fetter wrote: On Fri, Feb 13, 2015 at 03:13:11PM -0600, Jim Nasby wrote: On 2/10/15 2:04 PM, David Fetter wrote: Yeah, but people expect to be able to partition on ranges that are not all of equal width. I think any proposal that we shouldn't support that is the kiss

Re: [HACKERS] restrict global access to be readonly

2015-02-14 Thread Robert Haas
On Fri, Feb 13, 2015 at 3:32 AM, happy times wrote: > I didn’t find any convenient way to restrict access to PostgreSQL databases > to be read-only for all users. I need it in following scenarios: > > A) Planned switch-over from master to slave. We want to minimize impact > within the planned swit

[HACKERS] why does enum_endpoint call GetTransactionSnapshot()?

2015-02-14 Thread Robert Haas
The comments say say that we must use "an" MVCC snapshot here, but they don't explain why it should be one retrieved via GetTransactionSnapshot() rather than GetActiveSnapshot() or GetLatestSnapshot() or GetCatalogSnapshot(). The comments also refer the reader to catalog/pg_enum.c for more details

Re: [HACKERS] INSERT ... ON CONFLICT {UPDATE | IGNORE} 2.0

2015-02-14 Thread Heikki Linnakangas
On 02/10/2015 02:21 AM, Peter Geoghegan wrote: On Fri, Feb 6, 2015 at 1:51 PM, Bruce Momjian wrote: Other than the locking part, the biggest part of this patch is adjusting things so that an INSERT can change into an UPDATE. Thanks for taking a look at it. That's somewhat cleaned up in the at

Re: [HACKERS] why does enum_endpoint call GetTransactionSnapshot()?

2015-02-14 Thread Tom Lane
Robert Haas writes: > I think this is probably a holdover from before the death of > SnapshotNow, and that we should just pass NULL to > systable_beginscan_ordered() here, the same as we do for other catalog > accesses. Barring objections, I'll go make that change. Seems reasonable to me, but wh

Re: [HACKERS] why does enum_endpoint call GetTransactionSnapshot()?

2015-02-14 Thread Robert Haas
On Sat, Feb 14, 2015 at 5:12 PM, Tom Lane wrote: > Robert Haas writes: >> I think this is probably a holdover from before the death of >> SnapshotNow, and that we should just pass NULL to >> systable_beginscan_ordered() here, the same as we do for other catalog >> accesses. Barring objections, I

Re: [HACKERS] restrict global access to be readonly

2015-02-14 Thread Jim Nasby
On 2/14/15 3:14 PM, Robert Haas wrote: On Fri, Feb 13, 2015 at 3:32 AM, happy times wrote: I didn’t find any convenient way to restrict access to PostgreSQL databases to be read-only for all users. I need it in following scenarios: A) Planned switch-over from master to slave. We want to minimi

[HACKERS] Reduce pinning in btree indexes

2015-02-14 Thread Kevin Grittner
We have a customer who was unable to migrate from a well-known commercial database product to pg because they have a very large software base that holds cursors open for very long periods of time, preventing GlobalXmin values from advancing, leading to bloat. They have a standard test that exercis

Re: [HACKERS] restrict global access to be readonly

2015-02-14 Thread Tom Lane
Jim Nasby writes: > On 2/14/15 3:14 PM, Robert Haas wrote: >> Although I like the idea, it's not clear to me how to implement it. > Throw an error in AssignTransactionId/GetNewTransactionId? A whole lot depends on what you choose to mean by "read only". If it means the same thing as "all transa

[HACKERS] Allow "snapshot too old" error, to prevent bloat

2015-02-14 Thread Kevin Grittner
This patch is related to the "Reduce pinning in btree indexes" patch submitted here: http://www.postgresql.org/message-id/721615179.3351449.1423959585771.javamail.ya...@mail.yahoo.com That describes how they evolved and how they relate; I won't duplicate that here. Unlike the other patch, this o

Re: [HACKERS] Allow "snapshot too old" error, to prevent bloat

2015-02-14 Thread Tom Lane
Kevin Grittner writes: > What this patch does is add a GUC call old_snapshot_threshold. It > defaults to -1, which leaves behavior matching unpatched code. > Above that it allows tuples to be vacuumed away after the number of > transaction IDs specified by the GUC have been consumed. TBH, I'm no

Re: [HACKERS] improving speed of make check-world

2015-02-14 Thread Peter Eisentraut
On 8/31/14 5:36 AM, Fabien COELHO wrote: > Running "make -j2 check-world" does not work because "initdb" is not > found by "pg_regress". but "make -j1 check-world" does work fine. It > seems that some dependencies might be missing and there is a race > condition between temporary install and runnin

Re: [HACKERS] improving speed of make check-world

2015-02-14 Thread Tom Lane
Peter Eisentraut writes: > On 8/31/14 5:36 AM, Fabien COELHO wrote: >> Running "make -j2 check-world" does not work because "initdb" is not >> found by "pg_regress". but "make -j1 check-world" does work fine. It >> seems that some dependencies might be missing and there is a race >> condition betw

Re: [HACKERS] Allow "snapshot too old" error, to prevent bloat

2015-02-14 Thread Kevin Grittner
Tom Lane wrote: > Kevin Grittner writes: >> What this patch does is add a GUC call old_snapshot_threshold. It >> defaults to -1, which leaves behavior matching unpatched code. >> Above that it allows tuples to be vacuumed away after the number of >> transaction IDs specified by the GUC have been

[HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-02-14 Thread David Steele
I've posted a couple of messages over the last few weeks about the work I've been doing on the pg_audit extension. The lack of response could be due to either universal acclaim or complete apathy, but in any case I think this is a very important topic so I want to give it another try. I've extens

[HACKERS] mogrify and indent features for jsonb

2015-02-14 Thread Andrew Dunstan
Attached is a patch to provide a number of very useful facilities to jsonb that people have asked for. These are based on work by Dmitry Dolgov in his jsonbx extension, but I take responsibility for any bugs. The facilities are: new operations: concatenation:jsonb || jsonb -> jsonb dele

[HACKERS] Add pg_settings.pending_restart column

2015-02-14 Thread Peter Eisentraut
When managing configuration changes through automatic systems like Chef or Puppet, there is a problem: How do you manage changes requiring a restart? Generally, you'd set it up so that when a configuration file is changed, the server is reloaded. But for settings that require a restart, well, I d

[HACKERS] forward vs backward slashes in msvc build code

2015-02-14 Thread Peter Eisentraut
I understand that on Windows, you can use forward slashes in path names interchangeably with backward slashes (except possibly in the shell). I have developed the attached patch to change the msvc build code to use forward slashes consistently. Together with the other attached patch, which is an