Re: [HACKERS] 64-bit XIDs again

2015-08-01 Thread Simon Riggs
On 31 July 2015 at 22:46, Heikki Linnakangas wrote: > On 07/31/2015 12:29 AM, Josh Berkus wrote: > >> On 07/30/2015 07:24 AM, Heikki Linnakangas wrote: >> >>> >>> You'd never be forced to do anti-wraparound >>> vacuums, you could just let the clog grow arbitrarily large >>> >> >> When I introduce

Re: [HACKERS] Encoding of early PG messages

2015-08-01 Thread Shay Rojansky
Oh sorry, I think I misunderstood your suggestion - setting lc_messages in the startup packet wouldn't work any more than setting client_encoding, would it. So any solution here would be on the database/backend side, and so irrelevant for a general-purpose driver... On Fri, Jul 31, 2015 at 4:28 PM

Re: [HACKERS] [sqlsmith] Failed assertion in joinrels.c

2015-08-01 Thread Andreas Seltenreich
Tom Lane writes: > What concerns me more is that what you're finding is only cases that trip > an assertion sanity check. It seems likely that you're also managing to > trigger other bugs with less drastic consequences, such as "could not > devise a query plan" failures or just plain wrong answer

Re: [HACKERS] Foreign join pushdown vs EvalPlanQual

2015-08-01 Thread Robert Haas
On Fri, Jul 3, 2015 at 6:25 AM, Etsuro Fujita wrote: > Can't FDWs get the join information through the root, which I think we would > pass to the API as the argument? This is exactly what Tom suggested originally, and it has some appeal, but neither KaiGai nor I could see how to make it work . D

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2015-08-01 Thread Amit Kapila
On Tue, Feb 17, 2015 at 2:56 PM, Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote: > > 2. New catalog - This method takes out the need to have separate method > for C1, C5 and even C2, also the synchronization will be taken care of by > row locks, there will be no limit on the number of fore

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-08-01 Thread Michael Paquier
On Sat, Aug 1, 2015 at 5:00 AM, Alvaro Herrera wrote: > Fabrízio de Royes Mello wrote: > >> In this patch I didn't change all lockmode comparison places previous >> pointed by you, but I can change it maybe adding other method called >> LockModeIsValid(lockmode) to do the comparison "lockmode >= N

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-08-01 Thread Andres Freund
On August 1, 2015 2:17:24 PM GMT+02:00, Michael Paquier wrote: >On Sat, Aug 1, 2015 at 5:00 AM, Alvaro Herrera > wrote: >> Fabrízio de Royes Mello wrote: >> >>> In this patch I didn't change all lockmode comparison places >previous >>> pointed by you, but I can change it maybe adding other method

Re: [HACKERS] [DESIGN] ParallelAppend

2015-08-01 Thread Kouhei Kaigai
> On Tue, Jul 28, 2015 at 6:08 PM, Kouhei Kaigai wrote: > > > > > On Tue, Jul 28, 2015 at 7:59 AM, Kouhei Kaigai > > > wrote: > > > > > > > > > -Original Message- > > > > > From: pgsql-hackers-ow...@postgresql.org > > > > > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Kouhei

Re: [HACKERS] Foreign join pushdown vs EvalPlanQual

2015-08-01 Thread Kouhei Kaigai
> On Fri, Jul 3, 2015 at 6:25 AM, Etsuro Fujita > wrote: > > Can't FDWs get the join information through the root, which I think we would > > pass to the API as the argument? > > This is exactly what Tom suggested originally, and it has some appeal, > but neither KaiGai nor I could see how to mak

Re: [HACKERS] Re: Using quicksort and a merge step to significantly improve on tuplesort's single run "external sort"

2015-08-01 Thread Jeremy Harris
On 31/07/15 18:31, Robert Haas wrote: > On Fri, Jul 31, 2015 at 7:21 AM, Jeremy Harris wrote: >> Heapification is O(n) already, whether siftup (existing) or down. > > That's not my impression, or what Wikipedia says. Source? Measurements done last year: http://www.postgresql.org/message-id/52f

Re: [HACKERS] Re: Using quicksort and a merge step to significantly improve on tuplesort's single run "external sort"

2015-08-01 Thread Andres Freund
On 2015-07-31 13:31:54 -0400, Robert Haas wrote: > On Fri, Jul 31, 2015 at 7:21 AM, Jeremy Harris wrote: > > Heapification is O(n) already, whether siftup (existing) or down. > > That's not my impression, or what Wikipedia says. Source? Building a binary heap via successive insertions is O(n lo

Re: [HACKERS] [PROPOSAL] VACUUM Progress Checker.

2015-08-01 Thread Rahila Syed
>The total number of heap pages is known, and the total number of index >pages is also known, so it's possible to derive a percentage out of >this part. The total number of index pages scanned during entire vacuum will depend on number of index scans that happens. In order to extrapolate percent c

Re: [HACKERS] Foreign join pushdown vs EvalPlanQual

2015-08-01 Thread Tom Lane
Robert Haas writes: > The problem that was bothering us (or at least what was bothering me) > is that the PlannerInfo provides only a list of SpecialJoinInfo > structures, which don't directly give you the original join order. In > fact, min_righthand and min_lefthand are intended to constraint t

[HACKERS] No more libedit?! - openssl plans to switch to APL2

2015-08-01 Thread Andres Freund
Hi, According to https://www.openssl.org/blog/blog/2015/08/01/cla/ openssl is planning to relicense to the apache license 2.0. While APL2 is not compatible with GLP2 it *is* compatible with GPL3. Greetings, Andres Freund -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

[HACKERS] Cleaning up missing ERRCODE assignments

2015-08-01 Thread Tom Lane
I believe we have a project policy that all user-facing error reports should go through ereport not elog (so that they're translatable) and should not have ERRCODE_INTERNAL_ERROR as SQLSTATE. It's sometimes debatable where the line is between user-facing and not, but surely any error that is trigg

Re: [HACKERS] [sqlsmith] Failed assertion in joinrels.c

2015-08-01 Thread Tom Lane
Andreas Seltenreich writes: > Tom Lane writes: >> What concerns me more is that what you're finding is only cases that trip >> an assertion sanity check. It seems likely that you're also managing to >> trigger other bugs with less drastic consequences, such as "could not >> devise a query plan" f

Re: [HACKERS] brin index vacuum versus transaction snapshots

2015-08-01 Thread Kevin Grittner
Alvaro Herrera wrote: > Untested patch attached. That fixes the installcheck failure on my machine. -- Kevin Grittner EDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] Solaris testers wanted for strxfrm() behavior

2015-08-01 Thread Noah Misch
On Fri, Jul 31, 2015 at 08:29:51PM -0700, Josh Berkus wrote: > Where are we with this? Do we feel confident that this bug is only on > old versions of Solaris we don't care about? Or does it remain to be > resolved? Affected systems either have an available vendor update addressing the problem o

Re: [HACKERS] [sqlsmith] Failed assertion in joinrels.c

2015-08-01 Thread Andreas Seltenreich
Tom Lane writes: > Well, I certainly think all of these represent bugs: > > [...] thanks for priorizing them. I'll try to digest them somewhat before posting. > This one's pretty darn odd, because 2619 is pg_statistic and not an index > at all: > >> 4 | ERROR: cache lookup failed for inde

Re: [HACKERS] pg_rewind failure by file deletion in source server

2015-08-01 Thread Heikki Linnakangas
On 07/17/2015 06:28 AM, Michael Paquier wrote: On Wed, Jul 1, 2015 at 9:31 PM, Fujii Masao wrote: On Wed, Jul 1, 2015 at 2:21 AM, Heikki Linnakangas wrote: On 06/29/2015 09:44 AM, Michael Paquier wrote: On Mon, Jun 29, 2015 at 4:55 AM, Heikki Linnakangas wrote: But we'll still need to han

Re: [HACKERS] Cleaning up missing ERRCODE assignments

2015-08-01 Thread Peter Geoghegan
On Sat, Aug 1, 2015 at 8:39 AM, Tom Lane wrote: > I propose to back-patch this into 9.5, but not further; it's not an > important enough issue to justify changing SQLSTATE behavior in stable > branches. +1. As I've said in the past, I think that making it possible to determine mechanically that a

Re: [HACKERS] TAP tests are badly named

2015-08-01 Thread Noah Misch
On Thu, Jul 30, 2015 at 07:54:27PM -0400, Andrew Dunstan wrote: > On 07/30/2015 12:40 PM, Andrew Dunstan wrote: > >We should describe test sets by what they test, not by how they test. TAP I agree with that philosophy. I also respect the practicality of grouping by test harness as a shorthand. T

Re: [HACKERS] upgrade failure from 9.5 to head

2015-08-01 Thread Noah Misch
On Wed, Jul 29, 2015 at 04:42:55PM -0400, Andrew Dunstan wrote: > The next hump is this, in restoring contrib_regression_test_ddl_parse: > >pg_restore: creating FUNCTION "public"."text_w_default_in("cstring")" >pg_restore: [archiver (db)] Error while PROCESSING TOC: >pg_restore: [archi

Re: [HACKERS] TAP tests are badly named

2015-08-01 Thread Andrew Dunstan
On 08/01/2015 04:44 PM, Noah Misch wrote: --enable-tap-tests is a reasonable configuration setting, because it's about whether or not we have a TAP testing framework available, but I think we should stop calling the bin tests "TAP tests" and we should change the test name in vcregress.pl to a

Re: [HACKERS] TAP tests are badly named

2015-08-01 Thread Noah Misch
On Sat, Aug 01, 2015 at 07:13:04PM -0400, Andrew Dunstan wrote: > On 08/01/2015 04:44 PM, Noah Misch wrote: > >>>--enable-tap-tests is a reasonable configuration setting, because it's > >>>about whether or not we have a TAP testing framework available, but I > >>>think we should stop calling the bi

Re: [HACKERS] upgrade failure from 9.5 to head

2015-08-01 Thread Andrew Dunstan
On 08/01/2015 07:13 PM, Noah Misch wrote: On Wed, Jul 29, 2015 at 04:42:55PM -0400, Andrew Dunstan wrote: The next hump is this, in restoring contrib_regression_test_ddl_parse: pg_restore: creating FUNCTION "public"."text_w_default_in("cstring")" pg_restore: [archiver (db)] Error while

Re: [HACKERS] Parallel Seq Scan

2015-08-01 Thread Kouhei Kaigai
Amit, Let me ask three more detailed questions. Why Funnel has a valid qual of the subplan? The 2nd argument of make_funnel() is qualifier of the subplan (PartialSeqScan) then it is initialized at ExecInitFunnel, but never executed on the run-time. Why does Funnel node has useless qualifier expre