Re: [HACKERS] Parallel Aggregate

2016-03-15 Thread Robert Haas
On Mon, Mar 14, 2016 at 7:56 PM, David Rowley wrote: >> More generally, why are we inventing PartialAggref >> instead of reusing Aggref? The code comments seem to contain no >> indication as to why we shouldn't need all the same details for >> PartialAggref that we

Re: [HACKERS] Background Processes and reporting

2016-03-15 Thread Vladimir Borodin
> 15 марта 2016 г., в 19:57, Oleg Bartunov написал(а): > > > > On Tue, Mar 15, 2016 at 7:43 PM, Alexander Korotkov > > wrote: > On Tue, Mar 15, 2016 at 12:57 AM, Robert Haas

Re: [HACKERS] Missing conversion error handling in postgres_fdw

2016-03-15 Thread Robert Haas
On Tue, Mar 15, 2016 at 4:06 AM, Etsuro Fujita wrote: > I noticed that this in make_tuple_from_result_row does conversion error > handling only for the ordinary-column case (ie, errpos.cur_attno is set > for that case, but not for the ctid case). > > /*

Re: [HACKERS] Parallel Aggregate

2016-03-15 Thread Robert Haas
On Tue, Mar 15, 2016 at 5:50 PM, David Rowley wrote: >> I still think that's solving the problem the wrong way. Why can't >> exprType(), when applied to the Aggref, do something like this? >> >> { >> Aggref *aref = (Aggref *) expr; >> if (aref->aggpartial)

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2016-03-15 Thread Robert Haas
On Tue, Mar 15, 2016 at 10:41 AM, Thom Brown wrote: >> It turns out that I hate the fact that the Wait Event Name column is >> effectively in a random order. If a user sees a message, and goes to >> look up the value in the wait_event description table, they either >> have to

Re: [HACKERS] Soliciting Feedback on Improving Server-Side Programming Documentation

2016-03-15 Thread Álvaro Hernández Tortosa
I started a similar thread with probably similar concerns: http://www.postgresql.org/message-id/56d1a6aa.6080...@8kdata.com I believe this effort should be done. I added to my TODO list to compile a list of used functions in a selection of picked extensions to use that as a starting

Re: [HACKERS] pgbench stats per script & other stuff

2016-03-15 Thread Alvaro Herrera
Fabien COELHO wrote: > >If somebody specifies thousands of -f switches, they will waste a few > >bytes with each, but I'm hardly concerned about a few dozen kilobytes > >there ... > > Ok, so you prefer a memory leak. I hate it on principle. I don't "prefer" memory leaks -- I prefer interfaces

[HACKERS] Fix typos in comments

2016-03-15 Thread Oskari Saarenmaa
Attached a patch to fix a bunch of typos in comments. / Oskari >From 1effab7d75c3ac08257c637d8662b4c8b3fdc750 Mon Sep 17 00:00:00 2001 From: Oskari Saarenmaa Date: Tue, 15 Mar 2016 23:45:26 +0200 Subject: [PATCH] misc typofixes in comments --- contrib/pgcrypto/sha1.h

Re: [HACKERS] Fix typos in comments

2016-03-15 Thread Robert Haas
On Tue, Mar 15, 2016 at 5:48 PM, Oskari Saarenmaa wrote: > Attached a patch to fix a bunch of typos in comments. Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list

[HACKERS] NOT LIKE index support

2016-03-15 Thread Arjen Nienhuis
I noticed index support for NOT LIKE is missing. Is there a special reason for that, or would a patch be accepted? A use case would be: ... WHERE url NOT LIKE 'http%' Or ... WHERE path NOT LIKE '/%'

Re: [HACKERS] [PATCH v6] GSSAPI encryption support

2016-03-15 Thread Robbie Harwood
Stephen Frost writes: > Robbie, > > * Robbie Harwood (rharw...@redhat.com) wrote: >> Michael Paquier writes: >> > - maj_stat = gss_accept_sec_context( >> > - _stat, >> > + maj_stat =

Re: [HACKERS] Parallel Aggregate

2016-03-15 Thread David Rowley
On 16 March 2016 at 09:23, Robert Haas wrote: > On Mon, Mar 14, 2016 at 7:56 PM, David Rowley > wrote: >> A comment does explain this, but perhaps it's not good enough, so I've >> rewritten it to become. >> >> /* >> * PartialAggref >> * >>

Re: [HACKERS] Choosing parallel_degree

2016-03-15 Thread Robert Haas
On Mon, Mar 14, 2016 at 9:25 PM, David Rowley wrote: > Over in [1] James mentioned about wanting more to be able to have more > influence over the partial path's parallel_degree decision. At risk > of a discussion on that hijacking the parallel aggregate thread, I >

Re: [HACKERS] Small patch: fix warnings during compilation on FreeBSD

2016-03-15 Thread Aleksander Alekseev
> Please verify that the committed version solves your problem on > FreeBSD. I confirm this patch solves a problem. > I've checked this on my OS X box, which turns out to have the > interesting property that xlocale.h declares wcstombs_l(), but only > if you previously included stdlib.h ... wtf?

Re: FW: [HACKERS] [NOVICE] WHERE clause not used when index is used

2016-03-15 Thread Peter Eisentraut
On 3/15/16 2:28 PM, Jernigan, Kevin wrote: > I recently joined the product management team for AWS RDS Postgres > (after years at Oracle in their database team), and we are very > interested in confirming (or not) that the fix for the problem below > will be included in 9.5.2, and in the

Re: [HACKERS] Re: [COMMITTERS] pgsql: Only try to push down foreign joins if the user mapping OIDs mat

2016-03-15 Thread Robert Haas
On Tue, Mar 15, 2016 at 6:44 AM, Ashutosh Bapat wrote: > Here's patch which fixes the issue using Robert's idea. Please at least check your patches with 'git diff --check' before submitting them. And where it's not too much trouble, pgindent them. Or at least

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2016-03-15 Thread Alvaro Herrera
Robert Haas wrote: > On Tue, Mar 15, 2016 at 10:41 AM, Thom Brown wrote: > >> It turns out that I hate the fact that the Wait Event Name column is > >> effectively in a random order. If a user sees a message, and goes to > >> look up the value in the wait_event description table,

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2016-03-15 Thread Robert Haas
On Tue, Mar 15, 2016 at 9:17 AM, Thomas Reiss wrote: > Here's a small docpatch to fix two typos in the new documentation. Thanks, committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing

Re: [HACKERS] Soliciting Feedback on Improving Server-Side Programming Documentation

2016-03-15 Thread Corey Huinker
On Tue, Mar 15, 2016 at 4:38 PM, Álvaro Hernández Tortosa wrote: > > I started a similar thread with probably similar concerns: > http://www.postgresql.org/message-id/56d1a6aa.6080...@8kdata.com > > I believe this effort should be done. I added to my TODO list to >

[HACKERS] Show dropped users' backends in pg_stat_activity

2016-03-15 Thread Oskari Saarenmaa
I was looking into some issues we recently had when dropping db users and was surprised to see that dropped users' sessions and transactions continue to work after the role is dropped. Since dropping a role requires dropping all grants it has (using DROP OWNED BY ...) the dropped role can't

Re: [HACKERS] Combining Aggregates

2016-03-15 Thread David Rowley
On 16 March 2016 at 06:39, Tomas Vondra wrote: > After looking at the parallel aggregate patch, I also looked at this one, as > it's naturally related. Sadly I haven't found any issue that I could nag > about ;-) The patch seems well baked, as it was in the oven for

Re: [HACKERS] Parallel Aggregate

2016-03-15 Thread Robert Haas
On Tue, Mar 15, 2016 at 8:04 PM, David Rowley wrote: > On 16 March 2016 at 12:58, Robert Haas wrote: >> On Tue, Mar 15, 2016 at 6:55 PM, David Rowley >> wrote: >>> On 16 March 2016 at 11:00, Robert Haas

Re: [HACKERS] Parallel Aggregate

2016-03-15 Thread David Rowley
On 16 March 2016 at 13:42, Robert Haas wrote: > On Tue, Mar 15, 2016 at 8:04 PM, David Rowley > wrote: >> On 16 March 2016 at 12:58, Robert Haas wrote: >>> ...and why would one be true and the other false? >> >> One

Re: [HACKERS] [PROPOSAL] VACUUM Progress Checker.

2016-03-15 Thread Amit Langote
On 2016/03/16 2:33, Robert Haas wrote: > On Tue, Mar 15, 2016 at 1:16 AM, Amit Langote > wrote: >> On 2016/03/15 3:41, Robert Haas wrote: >>> Well, I think you need to study the index AMs and figure this out. >> >> OK. I tried to put calls to the callback in

Re: [HACKERS][PROPOSAL] Covering + unique indexes.

2016-03-15 Thread Peter Geoghegan
On Mon, Mar 14, 2016 at 8:43 PM, Peter Geoghegan wrote: > Does this work with amcheck? Maybe it works with bt_index_check(), but > not bt_index_parent_check()? I think that you need to make sure that > _bt_compare() knows about this, too. That's because it isn't good > enough to

Re: [HACKERS] NOT LIKE index support

2016-03-15 Thread Andreas Karlsson
On 03/15/2016 11:01 PM, Arjen Nienhuis wrote: I noticed index support for NOT LIKE is missing. Is there a special reason for that, or would a patch be accepted? A use case would be: ... WHERE url NOT LIKE 'http%' Or ... WHERE path NOT LIKE '/%' My guess is the lack of many compelling use

Re: [HACKERS] [PATCH] Supporting +-Infinity values by to_timestamp(float8)

2016-03-15 Thread David Steele
On 3/4/16 2:56 PM, Vitaly Burovoy wrote: > On 3/4/16, Anastasia Lubennikova wrote: > >> I think that you should update documentation. At least description of >> epoch on this page: >> http://www.postgresql.org/docs/devel/static/functions-datetime.html > > Thank you

Re: [HACKERS] Default Roles

2016-03-15 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Feb 29, 2016 at 10:02 PM, Stephen Frost wrote: > > Attached is a stripped-down version of the default roles patch which > > includes only the 'pg_signal_backend' default role. This provides the > > framework and structure

Re: [HACKERS] [PATCH v6] GSSAPI encryption support

2016-03-15 Thread Robbie Harwood
Michael Paquier writes: > On Tue, Mar 15, 2016 at 3:12 PM, David Steele wrote: >> On 3/8/16 5:44 PM, Robbie Harwood wrote: >>> Here's yet another version of GSSAPI encryption support. >> >> This looks far more stable than last versions, cool to

Re: [HACKERS] [NOVICE] WHERE clause not used when index is used

2016-03-15 Thread Peter Geoghegan
On Thu, Mar 3, 2016 at 2:07 AM, Simon Riggs wrote: > Later, I will add the tests we discovered here to index scans, so that > further optimization work is more easily possible. Please do. I would like to start testing the B-Tree code more exhaustively by adding a test

Re: [HACKERS] [PATCH v6] GSSAPI encryption support

2016-03-15 Thread Stephen Frost
Robbie, * Robbie Harwood (rharw...@redhat.com) wrote: > Michael Paquier writes: > > - maj_stat = gss_accept_sec_context( > > - _stat, > > + maj_stat = gss_accept_sec_context(_stat, > > > > This is just noise. > >

Re: [HACKERS] insufficient qualification of some objects in dump files

2016-03-15 Thread Peter Eisentraut
On 2/26/16 1:30 AM, Tom Lane wrote: > As the patch is presented, I agree with Peter that it does not really > need a format number bump. The question that has to be answered is > whether this solution is good enough? You could not trust it for > automated processing of tags --- it's easy to

Re: [HACKERS] IF (NOT) EXISTS in psql-completion

2016-03-15 Thread Peter Eisentraut
On 2/5/16 3:09 AM, Kyotaro HORIGUCHI wrote: > I considered how to make tab-completion robust for syntactical > noises, in other words, optional words in syntax. Typically "IF > (NOT) EXISTS", UNIQUE and TEMPORARY are words that don't affect > further completion. To repeat the question I raised in

Re: [HACKERS] Minor bug affecting ON CONFLICT lock wait log messages

2016-03-15 Thread Peter Geoghegan
On Tue, Mar 15, 2016 at 6:18 AM, Stephen Frost wrote: > Agreed. I'm going to play with it a bit more but barring objections, > I'll commit and back-patch Peter's patch. Thanks for taking care of this, Stephen. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Parallel Aggregate

2016-03-15 Thread Robert Haas
On Tue, Mar 15, 2016 at 6:55 PM, David Rowley wrote: > On 16 March 2016 at 11:00, Robert Haas wrote: >> I don't see why we would need to leave aggpartial out of the equals() >> check. I must be missing something. > > See

Re: [HACKERS] Parallel Aggregate

2016-03-15 Thread David Rowley
On 16 March 2016 at 12:58, Robert Haas wrote: > On Tue, Mar 15, 2016 at 6:55 PM, David Rowley > wrote: >> On 16 March 2016 at 11:00, Robert Haas wrote: >>> I don't see why we would need to leave aggpartial out of the

Re: [HACKERS] plpgsql - DECLARE - cannot to use %TYPE or %ROWTYPE for composite types

2016-03-15 Thread Tom Lane
Pavel Stehule writes: >> Robert Haas writes: >>> That's not a dumb idea. I think %TYPE is an Oracle-ism, and it >>> doesn't seem to have been their best-ever design decision. > Using %TYPE has sense in PostgreSQL too. It's certainly useful

Re: [HACKERS] Parallel Aggregate

2016-03-15 Thread Robert Haas
On Tue, Mar 15, 2016 at 9:23 PM, David Rowley wrote: >>> Should I update the patch to use the method you describe? >> >> Well, my feeling is that is going to make this a lot smaller and >> simpler, so I think so. But if you disagree strongly, let's discuss >>

Re: [HACKERS] Choosing parallel_degree

2016-03-15 Thread Robert Haas
On Tue, Mar 15, 2016 at 8:45 PM, David Rowley wrote: > On 16 March 2016 at 13:26, Julien Rouhaud wrote: >> On 15/03/2016 21:12, Robert Haas wrote: >>> I thought about this a bit more. There are a couple of easy things we >>> could do

Re: [HACKERS] Choosing parallel_degree

2016-03-15 Thread David Rowley
On 16 March 2016 at 13:26, Julien Rouhaud wrote: > On 15/03/2016 21:12, Robert Haas wrote: >> I thought about this a bit more. There are a couple of easy things we >> could do here. >> >> The 1000-page threshold could be made into a GUC. >> >> We could add a per-table

Re: [HACKERS] Parallel Aggregate

2016-03-15 Thread David Rowley
On 16 March 2016 at 14:08, Robert Haas wrote: > On Tue, Mar 15, 2016 at 8:55 PM, David Rowley > wrote: >> On 16 March 2016 at 13:42, Robert Haas wrote: >>> On Tue, Mar 15, 2016 at 8:04 PM, David Rowley >>>

Re: [HACKERS] pam auth - add rhost item

2016-03-15 Thread Peter Eisentraut
On 3/10/16 8:11 AM, Grzegorz Sampolski wrote: > In attchment new patch with updated documentation and with small change > to coding style as you suggested. This patch seems fine. I'm not sure about the name "pamusedns" for the option, since we use the OS resolver, which might not actually use

Re: [HACKERS] Idle In Transaction Session Timeout, revived

2016-03-15 Thread Vik Fearing
On 03/08/2016 10:42 PM, Robert Haas wrote: > On Sun, Jan 31, 2016 at 8:33 AM, Vik Fearing wrote: >> Attached is a rebased and revised version of my >> idle_in_transaction_session_timeout patch from last year. >> >> This version does not suffer the problems the old one did

Re: [HACKERS] Parallel Aggregate

2016-03-15 Thread Robert Haas
On Tue, Mar 15, 2016 at 8:55 PM, David Rowley wrote: > On 16 March 2016 at 13:42, Robert Haas wrote: >> On Tue, Mar 15, 2016 at 8:04 PM, David Rowley >> wrote: >>> On 16 March 2016 at 12:58, Robert Haas

Re: [HACKERS] WAL logging problem in 9.4.3?

2016-03-15 Thread Kyotaro HORIGUCHI
Thank you for the comment. I understand that this is not an issue in a hurry so don't bother to reply. At Tue, 15 Mar 2016 18:21:34 +0100, Michael Paquier wrote in

Re: [HACKERS] Parallel Aggregate

2016-03-15 Thread David Rowley
On 16 March 2016 at 11:00, Robert Haas wrote: > I don't see why we would need to leave aggpartial out of the equals() > check. I must be missing something. See fix_combine_agg_expr_mutator() This piece of code: /* * Aggrefs for partial aggregates are wrapped up in a

Re: [HACKERS] Support for N synchronous standby servers - take 2

2016-03-15 Thread Thomas Munro
Synchronous replication offers the ability to confirm that all changes -made by a transaction have been transferred to one synchronous standby -server. This extends the standard level of durability +made by a transaction have been transferred to one or more synchronous

Re: [HACKERS] [WIP] speeding up GIN build with parallel workers

2016-03-15 Thread Constantin S. Pan
On Mon, 14 Mar 2016 08:42:26 -0400 David Steele wrote: > On 2/18/16 10:10 AM, Constantin S. Pan wrote: > > On Wed, 17 Feb 2016 23:01:47 +0300 > > Oleg Bartunov wrote: > > > >> My feedback is (Mac OS X 10.11.3) > >> > >> set gin_parallel_workers=2; > >>

Re: [HACKERS] Choosing parallel_degree

2016-03-15 Thread Julien Rouhaud
On 15/03/2016 21:12, Robert Haas wrote: > On Mon, Mar 14, 2016 at 9:25 PM, David Rowley > wrote: >> Over in [1] James mentioned about wanting more to be able to have more >> influence over the partial path's parallel_degree decision. At risk >> of a discussion on

Re: [HACKERS] amcheck (B-Tree integrity checking tool)

2016-03-15 Thread Peter Geoghegan
On Tue, Mar 15, 2016 at 12:31 AM, Amit Langote wrote: > Ah, I see the nuance. Thanks for the explanation. Maybe, > bt_index_check() and bt_index_parent_child_check() / > bt_index_check_parent_child(). IMHO, the latter more clearly highlights > the fact that

Re: [HACKERS] amcheck (B-Tree integrity checking tool)

2016-03-15 Thread Amit Langote
Hi Peter, On 2016/03/15 16:11, Peter Geoghegan wrote: > On Mon, Mar 14, 2016 at 11:48 PM, Amit Langote > wrote: >>> Dunno about that. It's defining characteristic is that it checks child >>> pages against their parent IMV. Things are not often defined in terms >>>

Re: [HACKERS] [PATCH] we have added support for box type in SP-GiST index

2016-03-15 Thread Oleg Bartunov
On Mon, Mar 14, 2016 at 9:01 PM, David Steele wrote: > On 2/15/16 10:29 AM, Teodor Sigaev wrote: > > It's very pity but author is not able to continue work on this patch, >> and I would like to raise this flag. >> >> I'd like to add some comments about patches: >> >>

Re: [HACKERS] Proposal: BSD Authentication support

2016-03-15 Thread Thomas Munro
On Sat, Mar 12, 2016 at 5:14 AM, David Steele wrote: > On 1/14/16 11:22 PM, Robert Haas wrote: >> On Tue, Jan 12, 2016 at 2:27 AM, Marisa Emerson wrote: >>> I've attached the latest version of this patch. I've fixed up an issue with >>> the configuration

Re: [HACKERS] propose: detail binding error log

2016-03-15 Thread Craig Ringer
On 15 March 2016 at 15:06, Ioseph Kim wrote: > case 2: in jdbc program. > ERROR: 42804: column "a" is of type boolean but expression is of type > integer at character 25 > HINT: You will need to rewrite or cast the expression. > LOCATION: transformAssignedExpr,

[HACKERS] Missing conversion error handling in postgres_fdw

2016-03-15 Thread Etsuro Fujita
Hi, I noticed that this in make_tuple_from_result_row does conversion error handling only for the ordinary-column case (ie, errpos.cur_attno is set for that case, but not for the ctid case). /* convert value to internal representation */ if (i > 0) { /*

Re: [HACKERS] amcheck (B-Tree integrity checking tool)

2016-03-15 Thread Amit Langote
On 2016/03/12 6:31, Peter Geoghegan wrote: > On Thu, Mar 10, 2016 at 9:18 AM, Tomas Vondra > wrote: >> I've looked at this patch today, mostly to educate myself, so this >> probably should not count as a full review. Anyway, the patch seems in >> excellent shape -

Re: [HACKERS] propose: detail binding error log

2016-03-15 Thread Ioseph Kim
thanks for reply. Craig wrote: >> At the time PostgreSQL parses the statement it doesn't know the >> parameter values yet, because PgJDBC hasn't sent them to it. It >> cannot log them even if they mattered, which they don't. I know already that, so I wrote how can see error value at server

Re: [HACKERS] Re: [COMMITTERS] pgsql: Only try to push down foreign joins if the user mapping OIDs mat

2016-03-15 Thread Ashutosh Bapat
Here's patch which fixes the issue using Robert's idea. On Mon, Mar 14, 2016 at 10:53 PM, Robert Haas wrote: > On Mon, Mar 14, 2016 at 1:05 PM, Tom Lane wrote: > > Robert Haas writes: > >> On Sun, Mar 13, 2016 at 10:51 PM, Tom

Re: [HACKERS] Background Processes and reporting

2016-03-15 Thread Amit Kapila
On Tue, Mar 15, 2016 at 1:32 AM, Andres Freund wrote: > > On 2016-03-12 16:29:11 +0530, Amit Kapila wrote: > > On Sat, Mar 12, 2016 at 3:10 AM, Andres Freund wrote: > > > > > > > > > > Similarly for the wait event stuff - checkpointer, wal writer, > > > >

Re: [HACKERS] Re: [PATCH] Integer overflow in timestamp[tz]_part() and date/time boundaries check

2016-03-15 Thread Anastasia Lubennikova
15.03.2016 03:21, Vitaly Burovoy: On 3/14/16, Anastasia Lubennikova wrote: 14.03.2016 16:23, David Steele: On 2/25/16 4:44 PM, Vitaly Burovoy wrote: Added to the commitfest 2016-03. [CF] https://commitfest.postgresql.org/9/540/ This looks like a fairly

Re: [HACKERS] Timeline following for logical slots

2016-03-15 Thread Craig Ringer
On 15 March 2016 at 17:12, Andres Freund wrote: > Hi > Thanks very much for the review. This patch was split out from failover slots, which its self underwent quite a few revisions, so I'm really happy to have fresh eyes on it. Especially more experienced ones. > On

Re: [HACKERS] Timeline following for logical slots

2016-03-15 Thread Alvaro Herrera
Andres Freund wrote: > Could you perhaps wait till tomorrow? I'd like to do a pass over it. Sure thing. I'll wait for your review. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers

Re: [HACKERS] Minor bug affecting ON CONFLICT lock wait log messages

2016-03-15 Thread Julien Rouhaud
On 15/03/2016 03:30, Peter Geoghegan wrote: > On Mon, Mar 7, 2016 at 1:46 PM, Peter Geoghegan wrote: >> Attached patch fixes a bug reported privately by Stephen this morning. > > Bump. > > I would like to see this in the next point release. It shouldn't be > hard to review. >

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2016-03-15 Thread Thomas Reiss
Hello, Here's a small docpatch to fix two typos in the new documentation. Regards, Thomas Le 11/03/2016 07:19, Amit Kapila a écrit : On Fri, Mar 11, 2016 at 12:28 AM, Robert Haas > wrote: > > > Committed with some further editing. In

Re: [HACKERS] Minor bug affecting ON CONFLICT lock wait log messages

2016-03-15 Thread Stephen Frost
* Julien Rouhaud (julien.rouh...@dalibo.com) wrote: > On 15/03/2016 03:30, Peter Geoghegan wrote: > > On Mon, Mar 7, 2016 at 1:46 PM, Peter Geoghegan wrote: > >> Attached patch fixes a bug reported privately by Stephen this morning. > > > > Bump. > > > > I would like to see

Re: [HACKERS] Minor bug affecting ON CONFLICT lock wait log messages

2016-03-15 Thread Julien Rouhaud
On 15/03/2016 14:18, Stephen Frost wrote: > * Julien Rouhaud (julien.rouh...@dalibo.com) wrote: >> On 15/03/2016 03:30, Peter Geoghegan wrote: >>> On Mon, Mar 7, 2016 at 1:46 PM, Peter Geoghegan wrote: Attached patch fixes a bug reported privately by Stephen this morning.

Re: [HACKERS] silent data loss with ext4 / all current versions

2016-03-15 Thread Michael Paquier
On Thu, Mar 10, 2016 at 4:25 AM, Andres Freund wrote: > I've finally pushed these, after making a number of mostly cosmetic > fixes. The only of real consequence is that I've removed the durable_* > call from the renames to .deleted in xlog[archive].c - these don't need > to be durable, and are

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2016-03-15 Thread Thom Brown
On 15 March 2016 at 14:00, Thom Brown wrote: > On 10 March 2016 at 18:58, Robert Haas wrote: >> On Thu, Mar 10, 2016 at 12:18 AM, Amit Kapila >> wrote: >>> On Wed, Mar 9, 2016 at 7:17 PM, Robert Haas wrote:

Re: [HACKERS] Fuzzy substring searching with the pg_trgm extension

2016-03-15 Thread Artur Zakirov
On 15.03.2016 17:28, David Steele wrote: On 3/14/16 12:27 PM, Artur Zakirov wrote: On 14.03.2016 18:48, David Steele wrote: Hi Jeff, On 2/25/16 5:00 PM, Jeff Janes wrote: But, It doesn't sound like I am going to win that debate. Given that, I don't think we need a different name for the

Re: [HACKERS] WIP: Failover Slots

2016-03-15 Thread Craig Ringer
Here's a new failover slots rev, addressing the issues Oleksii Kliukin raised and adding a bunch of TAP tests. In particular, for the checkpoint issue I landed up moving CheckPointReplicationSlots to occur at the start of a checkpoint, before writing WAL is prohibited. As the comments note it's

Re: [HACKERS] Fuzzy substring searching with the pg_trgm extension

2016-03-15 Thread David Steele
On 3/14/16 12:27 PM, Artur Zakirov wrote: > On 14.03.2016 18:48, David Steele wrote: >> Hi Jeff, >> >> On 2/25/16 5:00 PM, Jeff Janes wrote: >> >>> But, It doesn't sound like I am going to win that debate. Given that, >>> I don't think we need a different name for the function. I'm fine with >>>

Re: [HACKERS] Small patch: fix warnings during compilation on FreeBSD

2016-03-15 Thread Aleksander Alekseev
> Yeah. In practice, there are exactly two cases we care about: either > both of these functions will be declared in like POSIX > says, or both of them will be in . There's no need to > work harder than we have to do to figure that out. > > I'm totally unimpressed with the proposal of

Re: [HACKERS] Parallel Aggregate

2016-03-15 Thread David Rowley
On 15 March 2016 at 13:48, David Rowley wrote: > An updated patch will follow soon. I've attached an updated patch which addresses some of Robert's and Tomas' concerns. I've not done anything about the exprCollation() yet, as I'm still unsure of what it should do. I

Re: [HACKERS] pgbench - allow backslash-continuations in custom scripts

2016-03-15 Thread Fabien COELHO
I intend to have a look at it, I had a look at a previous instance, but I'm ok if someone wants to proceed. There's not exactly a long line of reviewers at the moment so if you could do a followup review that would be great. Ok. It is in the queue, not for right know, though. -- Fabien.

Re: [HACKERS] Speed up Clog Access by increasing CLOG buffers

2016-03-15 Thread David Steele
On 3/15/16 1:17 AM, Amit Kapila wrote: > On Tue, Mar 15, 2016 at 12:00 AM, David Steele >> This patch no longer applies cleanly: >> >> $ git apply ../other/group_update_clog_v6.patch >> error: patch failed: src/backend/storage/lmgr/proc.c:404 >> error:

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2016-03-15 Thread Thom Brown
On 10 March 2016 at 18:58, Robert Haas wrote: > On Thu, Mar 10, 2016 at 12:18 AM, Amit Kapila wrote: >> On Wed, Mar 9, 2016 at 7:17 PM, Robert Haas wrote: >>> >>> On Wed, Mar 9, 2016 at 8:31 AM, Amit Kapila

Re: [HACKERS] [PATCH v6] GSSAPI encryption support

2016-03-15 Thread David Steele
On 3/8/16 5:44 PM, Robbie Harwood wrote: > Here's yet another version of GSSAPI encryption support. OK, everything seems to be working fine with a 9.6 client and server so next I tested older clients and I got this error: $ /usr/lib/postgresql/9.1/bin/psql -h localhost \ -U

Re: [HACKERS] Speed up Clog Access by increasing CLOG buffers

2016-03-15 Thread Amit Kapila
On Tue, Mar 15, 2016 at 7:54 PM, David Steele wrote: > > On 3/15/16 1:17 AM, Amit Kapila wrote: > > > On Tue, Mar 15, 2016 at 12:00 AM, David Steele > > >> This patch no longer applies cleanly: > >> > >> $ git apply ../other/group_update_clog_v6.patch >

Re: [HACKERS] Timeline following for logical slots

2016-03-15 Thread Alvaro Herrera
Craig already replied to most points. I think we can sum up as "we've done the best we can with what we have, maybe somebody can figure how to do better in the future but for now this works." Andres Freund wrote: > On 2016-03-14 20:10:58 -0300, Alvaro Herrera wrote: > > +#ifndef FRONTEND > > +

Re: [HACKERS] [PATCH] Integer overflow in timestamp[tz]_part() and date/time boundaries check

2016-03-15 Thread Mark Dilger
> On Mar 15, 2016, at 8:35 AM, Mark Dilger wrote: > > >> On Mar 14, 2016, at 5:12 PM, Vitaly Burovoy wrote: >> >> On 3/14/16, Mark Dilger wrote: >>> The first thing I notice about this patch is that >>>

Re: [HACKERS] amcheck (B-Tree integrity checking tool)

2016-03-15 Thread Peter Geoghegan
On Mon, Mar 14, 2016 at 11:48 PM, Amit Langote wrote: >> Dunno about that. It's defining characteristic is that it checks child >> pages against their parent IMV. Things are not often defined in terms >> of their locking requirements. > > At the risk of sounding a

Re: [HACKERS] amcheck (B-Tree integrity checking tool)

2016-03-15 Thread Amit Langote
On 2016/03/15 16:42, Peter Geoghegan wrote: > On Tue, Mar 15, 2016 at 12:31 AM, Amit Langote > wrote: >> By the way, one request (as a non-native speaker of English language, who >> ends up looking up quite a few words regularly) - >> >> Could we use "conform" or

Re: [HACKERS] Timeline following for logical slots

2016-03-15 Thread Andres Freund
Hi, On 2016-03-14 20:10:58 -0300, Alvaro Herrera wrote: > diff --git a/src/backend/access/transam/xlogreader.c > b/src/backend/access/transam/xlogreader.c > index fcb0872..7b60b8f 100644 > --- a/src/backend/access/transam/xlogreader.c > +++ b/src/backend/access/transam/xlogreader.c > @@ -10,9

Re: [HACKERS] Background Processes and reporting

2016-03-15 Thread Alexander Korotkov
On Tue, Mar 15, 2016 at 12:57 AM, Robert Haas wrote: > On Mon, Mar 14, 2016 at 4:42 PM, Andres Freund wrote: > > On 2016-03-14 16:16:43 -0400, Robert Haas wrote: > >> > I have already shown [0, 1] the overhead of measuring timings in > linux on > >> >

Re: [HACKERS] [PATCH v6] GSSAPI encryption support

2016-03-15 Thread Michael Paquier
On Tue, Mar 15, 2016 at 3:12 PM, David Steele wrote: > On 3/8/16 5:44 PM, Robbie Harwood wrote: >> Here's yet another version of GSSAPI encryption support. This looks far more stable than last versions, cool to see the progress. pgbench -C does not complain on my side so

[HACKERS] Soliciting Feedback on Improving Server-Side Programming Documentation

2016-03-15 Thread Corey Huinker
Over the past few months, I've been familiarizing myself with postgres server side programming in C. My attempts to educate myself were slow and halting. The existing server side programming documentation has some examples, but those examples didn't show me how do what I wanted to do, and my

Re: [HACKERS] Background Processes and reporting

2016-03-15 Thread Oleg Bartunov
On Tue, Mar 15, 2016 at 7:43 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Tue, Mar 15, 2016 at 12:57 AM, Robert Haas > wrote: > >> On Mon, Mar 14, 2016 at 4:42 PM, Andres Freund >> wrote: >> > On 2016-03-14 16:16:43 -0400, Robert

Re: [HACKERS] Small patch: fix warnings during compilation on FreeBSD

2016-03-15 Thread Alvaro Herrera
Aleksander Alekseev wrote: > Please note that these changes: > > ``` > -#define LARGE_OFF_T (((off_t) 1 << 62) - 1 + ((off_t) 1 << 62)) > +#define LARGE_OFF_T off_t) 1 << 31) << 31) - 1 + (((off_t) 1 << > 31) << 31)) > ``` > > ... were generated but `autoreconf -iv`. I was not sure what to

Re: [HACKERS] Small patch: fix warnings during compilation on FreeBSD

2016-03-15 Thread Tom Lane
Aleksander Alekseev writes: > OK, I'm not an expert in Autotools but this patch (see attachment) seems > to solve a problem. I fooled around with this some. I felt originally that it should use AC_CHECK_DECL, but that turns out not to work because AC_CHECK_DECL has

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

2016-03-15 Thread Anastasia Lubennikova
14.03.2016 16:02, David Steele: Hi Anastasia, On 2/18/16 12:29 PM, Anastasia Lubennikova wrote: 18.02.2016 20:18, Anastasia Lubennikova: 04.02.2016 20:16, Peter Geoghegan: On Fri, Jan 29, 2016 at 8:50 AM, Anastasia Lubennikova wrote: I fixed it in the new

Re: [HACKERS] IF (NOT) EXISTS in psql-completion

2016-03-15 Thread Robert Haas
On Fri, Feb 26, 2016 at 2:37 AM, Kyotaro HORIGUCHI wrote: > Hello, this is the new version of this patch. The CommitFest entry for this patch is messed up. It shows no author, even though I'm pretty sure that a patch has to have one by definition.

Re: [HACKERS] ALTER TABLE behind-the-scenes effects' CONTEXT

2016-03-15 Thread David Steele
On 1/30/16 10:52 AM, Marko Tiikkaja wrote: > On 2016-01-21 04:17, Simon Riggs wrote: >> Marko, I was/am waiting for an updated patch. Could you comment please? > > Sorry, I've not found time to work on this recently. > > Thanks for everyone's comments so far. I'll move this to the next CF > and

[HACKERS] Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby

2016-03-15 Thread Michael Paquier
On Mon, Mar 14, 2016 at 6:46 PM, David Steele wrote: > On 2/24/16 12:40 AM, Michael Paquier wrote: > >> This has the merit to be clear, thanks for the input. Whatever the >> approach taken at the end we have two candidates: >> - Extend XLogInsert() with an extra argument for

Re: [HACKERS] Soliciting Feedback on Improving Server-Side Programming Documentation

2016-03-15 Thread Shulgin, Oleksandr
On Tue, Mar 15, 2016 at 6:02 PM, Corey Huinker wrote: > Over the past few months, I've been familiarizing myself with postgres > server side programming in C. > > My attempts to educate myself were slow and halting. The existing server > side programming documentation

Re: [HACKERS] Soliciting Feedback on Improving Server-Side Programming Documentation

2016-03-15 Thread Corey Huinker
> > > I think this is all great. You may find some automated assistance from > doxygen.postgresql.org . > > Sincerely, > > JD doxygen is great as far as it goes, but it does a great job of separating function definition from the comment explaining the function, so I have to drill into the raw

Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol

2016-03-15 Thread David Steele
Hi Michael, On 3/14/16 7:07 PM, Michael Paquier wrote: > On Mon, Mar 14, 2016 at 5:06 PM, Michael Paquier > wrote: > >> On Mon, Mar 14, 2016 at 4:32 PM, David Steele wrote: >> >>> Could you provide an updated set of patches for review?

Re: [HACKERS] Add numeric_trim(numeric)

2016-03-15 Thread Robert Haas
On Wed, Jan 27, 2016 at 7:09 PM, Alvaro Herrera wrote: >> Here's a patch for the second function suggested in 5643125e.1030...@joh.to. > > I think this patch got useful feedback but we never saw a followup > version posted. I closed it as returned-with-feedback. Feel

Re: [HACKERS] silent data loss with ext4 / all current versions

2016-03-15 Thread David Steele
On 3/15/16 10:39 AM, Michael Paquier wrote: > On Thu, Mar 10, 2016 at 4:25 AM, Andres Freund wrote: > >> Note that we currently have some frontend programs with the equivalent >> problem. Most importantly receivelog.c (pg_basebackup/pg_recveivexlog) >> are missing pretty much the same directory

Re: [HACKERS] WAL logging problem in 9.4.3?

2016-03-15 Thread Michael Paquier
On Fri, Mar 11, 2016 at 9:32 AM, Kyotaro HORIGUCHI wrote: > At Fri, 19 Feb 2016 22:27:00 +0900, Michael Paquier > wrote in > >> > Worth noting that this patch does

Re: [HACKERS] Soliciting Feedback on Improving Server-Side Programming Documentation

2016-03-15 Thread Corey Huinker
On Tue, Mar 15, 2016 at 1:19 PM, Shulgin, Oleksandr < oleksandr.shul...@zalando.de> wrote: > There's also a good deal of README files in the source tree, so I would > add: > > 4. find src -name 'README*' > That too. But README's don't show up (easily) in a google search, so they elude discovery.

  1   2   >