Re: [HACKERS] WIP: Barriers

2016-08-14 Thread konstantin knizhnik
Hi Thomas, Barriers are really very simple and convenient mechanism for process synchronization. But it is actually a special case of semaphores: having semaphore primitive it is trivial to implement a barrier. We have semaphores in Postgres, but ... them can not be used by extensions: there

Re: [HACKERS] WIP: Covering + unique indexes.

2016-08-14 Thread Andrey Borodin
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, failed Spec compliant: tested, passed Documentation:tested, passed Hi hackers! I've read the patch and here is my code review.

[HACKERS] Patch: initdb: "'" for QUOTE_PATH (non-windows)

2016-08-14 Thread Ryan Murphy
Hello Postgres Team! This is to fix an issue that came up for me when running initdb. At the end of a successful initdb it says: Success. You can now start the database server using: pg_ctl -D /some/path/to/data -l logfile start but this command did not work for me because my data

Re: [HACKERS] [NOVICE] numeric data type upper limit.

2016-08-14 Thread Tom Lane
Aravind Kumar writes: > when I do > select 1.0e+1001::numeric; > I get > invalid input syntax for type numeric: "1.0e+1001" > Postgresql documentation tells me that numeric data type has an upper > limit of 131072 digits before decimal point. You can successfully do

Re: [HACKERS] Bogus ANALYZE results for an otherwise-unique column with many nulls

2016-08-14 Thread Andreas Joseph Krogh
På søndag 07. august 2016 kl. 18:35:56, skrev Tom Lane >: Dean Rasheed writes: > On 5 August 2016 at 21:48, Tom Lane wrote: >> OK, thanks.  What shall we do about Andreas' request to back-patch this?

[HACKERS] Improve handling of ^C in psql / top-level transaction abort

2016-08-14 Thread Jim Nasby
I recently had a client contact me thinking that a CREATE MATERIALIZED VIEW had somehow managed to keep running in the background after being ^C'd in psql. Turns out this confusion was because their monitoring eventually complained about the still open (but now aborted) transaction. The user

Re: [HACKERS] COPY FREEZE and PD_ALL_VISIBLE

2016-08-14 Thread Jeff Janes
On Tue, Nov 3, 2015 at 6:37 AM, Simon Riggs wrote: > On 3 November 2015 at 15:23, Amit Kapila wrote: >> >> On Fri, Oct 23, 2015 at 6:29 AM, Simon Riggs >> wrote: >>> >>> On 21 October 2015 at 13:31, Jeff Janes

[HACKERS] Why --backup-and-modify-in-place in perltidy config?

2016-08-14 Thread Tom Lane
I did a trial run following the current pgindent README procedure, and noticed that the perltidy step left me with a pile of '.bak' files littering the entire tree. This seems like a pretty bad idea because a naive "git add ." would have committed them. It's evidently because

[HACKERS] Small patch: initdb: "'" for QUOTE_PATH (non-windows)

2016-08-14 Thread Ryan Murphy
Hello Postgres Hackers! I sent this already a few hours ago but it got blocked because I had not yet joined the mailing list. Trying again, sorry for any redundancy or confusion! This is to fix an issue that came up for me when running initdb. At the end of a successful initdb it says:

Re: [HACKERS] [Patch] Temporary tables that do not bloat pg_catalog (a.k.a fast temp tables)

2016-08-14 Thread Tom Lane
Andres Freund writes: > On 2016-08-07 14:46:06 -0400, Tom Lane wrote: >> Robert Haas writes: >>> I think the whole idea of a fast temporary table is that there are no >>> catalog entries. If there are no catalog entries, then dependencies >>> are not

Re: [HACKERS] condition variables

2016-08-14 Thread Thomas Munro
On Sun, Aug 14, 2016 at 9:04 AM, Thomas Munro wrote: > On Fri, Aug 12, 2016 at 9:47 AM, Robert Haas wrote: >> [condition-variable-v1.patch] > > Don't you need to set proc->cvSleeping = false in ConditionVariableSignal? I poked at this a

Re: [HACKERS] [Patch] Temporary tables that do not bloat pg_catalog (a.k.a fast temp tables)

2016-08-14 Thread Andres Freund
On 2016-08-07 14:46:06 -0400, Tom Lane wrote: > Robert Haas writes: > > I think the whole idea of a fast temporary table is that there are no > > catalog entries. If there are no catalog entries, then dependencies > > are not visible. If there ARE catalog entries, to what

Re: [HACKERS] [Patch] Temporary tables that do not bloat pg_catalog (a.k.a fast temp tables)

2016-08-14 Thread Andres Freund
On 2016-08-14 21:04:57 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2016-08-07 14:46:06 -0400, Tom Lane wrote: > >> Robert Haas writes: > >>> I think the whole idea of a fast temporary table is that there are no > >>> catalog entries. If there