Re: [HACKERS] Checksums by default?

2017-01-26 Thread Joshua D. Drake
On 01/25/2017 05:25 PM, Peter Geoghegan wrote: On Wed, Jan 25, 2017 at 1:22 PM, Peter Geoghegan wrote: I understand that my experience with storage devices is unusually narrow compared to everyone else here. That's why I remain neutral on the high level question of whether or

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-01-26 Thread Peter Eisentraut
On 1/24/17 3:26 AM, Mithun Cy wrote: > In my code by default, we only dump at shutdown time. If we want to > dump at regular interval then we need to set the GUC > pg_autoprewarm.buff_dump_interval to > 0. Just a thought with an additional use case: If I want to set up a standby for offloading

Re: [HACKERS] CONNECTION LIMIT and Parallel Query don't play well together

2017-01-26 Thread Robert Haas
On Thu, Jan 26, 2017 at 7:59 AM, David Rowley wrote: > On 12 January 2017 at 15:24, David Rowley > wrote: >> I've attached a patch which intended to assist discussions on this topic. >> >> The patch adds some notes to the docs to

Re: [HACKERS] Assignment of valid collation for SET operations on queries with UNKNOWN types.

2017-01-26 Thread Robert Haas
On Wed, Jan 25, 2017 at 9:37 AM, Tom Lane wrote: > Pushed, thanks for the reviews! I think this is a nice improvement. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list

Re: [HACKERS] [COMMITTERS] pgsql: Reindent table partitioning code.

2017-01-26 Thread Peter Eisentraut
On 1/24/17 10:51 AM, Robert Haas wrote: > On Tue, Jan 24, 2017 at 10:28 AM, Tom Lane wrote: >> Robert Haas writes: >>> Reindent table partitioning code. >> >> Oh, thank you, I was starting to get annoyed with that too. > > Glad you like. The pgindent

Re: [HACKERS] Patch: Write Amplification Reduction Method (WARM)

2017-01-26 Thread Alvaro Herrera
Alvaro Herrera wrote: > I wonder if heap_hot_search_buffer() and heap_hot_search() should return > a tri-valued enum instead of boolean; that idea looks reasonable in > theory but callers have to do more work afterwards, so maybe not. > > I think heap_hot_search() sometimes leaving the buffer

Re: [HACKERS] Performance improvement for joins where outer side is unique

2017-01-26 Thread David Rowley
On 26 January 2017 at 04:56, Antonin Houska wrote: > I suspect that "inner" and "outer" relation / tuple are sometimes confused in > comments: > > > * analyzejoins.c:70 > > "searches for subsequent matching outer tuples." > > > * analyzejoins.c:972 > > /* > *

Re: [HACKERS] Radix tree for character conversion

2017-01-26 Thread Kyotaro HORIGUCHI
At Thu, 26 Jan 2017 16:29:10 +0900, Michael Paquier wrote in > On Wed, Jan 25, 2017 at 7:18 PM, Ishii Ayumi wrote: > > I patched 4 patchset and run "make", but I got

[HACKERS] Allow interrupts on waiting standby

2017-01-26 Thread Simon Riggs
Currently a waiting standby doesn't allow interrupts. Patch implements that. Barring objection, patching today with backpatches. -- Simon Riggshttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services interrupt_waiting_standby.v1.patch

Re: [HACKERS] pg_ls_dir & friends still have a hard-coded superuser check

2017-01-26 Thread Robert Haas
On Wed, Jan 25, 2017 at 10:31 PM, Stephen Frost wrote: > Frankly, I get quite tired of the argument essentially being made here > that because pg_ls_dir() wouldn't grant someone superuser rights, that > we should remove superuser checks from everything. As long as you are >

Re: [HACKERS] Microvacuum support for Hash Index

2017-01-26 Thread Jesper Pedersen
On 01/23/2017 02:53 PM, Jesper Pedersen wrote: I have done some more testing with this, and have moved to the patch back to 'Needs Review' pending Amit's comments. Moved to "Ready for Committer". Best regards, Jesper -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] BUG: pg_stat_statements query normalization issues with combined queries

2017-01-26 Thread Tom Lane
Craig Ringer writes: > One suggestion: it's currently non-obvious that ProcessUtility_hook > gets called with the full text of all parts of a multi-statement. OK, we can improve that ... > The same query string may be passed to multiple invocations of >

Re: [HACKERS] Floating point comparison inconsistencies of the geometric types

2017-01-26 Thread Kyotaro HORIGUCHI
Hello, At Thu, 26 Jan 2017 11:53:28 +0100, Emre Hasegeli wrote in > > Even though I'm not sure but I don't see a "natural" (or > > agreeable by many poeple) ordering of geometric types in > > general. Anyway

Re: [HACKERS] Replication slot xmin is not reset if HS feedback is turned off while standby is shut down

2017-01-26 Thread Simon Riggs
On 13 January 2017 at 10:17, Ants Aasma wrote: > On 5 Jan 2017 2:54 a.m., "Craig Ringer" wrote: >> Ants, do you think you'll have a chance to convert your shell script >> test into a TAP test in src/test/recovery? >> >> Simon has said he would like to

Re: [HACKERS] CONNECTION LIMIT and Parallel Query don't play well together

2017-01-26 Thread David Rowley
On 12 January 2017 at 15:24, David Rowley wrote: > I've attached a patch which intended to assist discussions on this topic. > > The patch adds some notes to the docs to mention that background > workers and prepared xacts are not counted in CONNECTION LIMIT, it >

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-26 Thread Haribabu Kommi
On Thu, Jan 26, 2017 at 4:32 AM, Tom Lane wrote: > Ashutosh Bapat writes: > > On Wed, Jan 25, 2017 at 9:58 AM, Haribabu Kommi > > wrote: > >> All the ereport messages of level are LOG, because of this reason, >

Re: [HACKERS] Performance improvement for joins where outer side is unique

2017-01-26 Thread David Rowley
On 27 January 2017 at 00:37, David Rowley wrote: > The attached has my Merge Join changes, to show what I think can be > done to make use of unique outer. Let me know what you think, but I > get that idea that we're both leaning towards ripping the outer unique >

Re: [HACKERS] Performance improvement for joins where outer side is unique

2017-01-26 Thread David Rowley
Thank for looking at this again. On 25 January 2017 at 06:27, Tom Lane wrote: > David Rowley writes: >> However, having said that, I'm not sure why we'd need outer_unique >> available so we'd know that we could skip mark/restore. I think >>

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-26 Thread Tom Lane
Haribabu Kommi writes: > This patch currently doesn't have the code for reporting the two log > messages that can occur in tokenize_file function. To support the same, > I am thinking of changing line_nums list to line_info list that can > contain both line number and

Re: [HACKERS] Radix tree for character conversion

2017-01-26 Thread Kyotaro HORIGUCHI
Thank you for looking this. At Thu, 26 Jan 2017 16:28:16 +0900, Michael Paquier wrote in > On Tue, Jan 10, 2017 at 8:22 PM, Kyotaro HORIGUCHI > wrote: > >

Re: [HACKERS] multivariate statistics (v19)

2017-01-26 Thread Kyotaro HORIGUCHI
Hello, I'll return on this since this should welcome more eyeballs. At Thu, 26 Jan 2017 09:03:10 +, "Ideriha, Takeshi" wrote in <4E72940DA2BF16479384A86D54D0988A565822A9@G01JPEXMBKW04> > Hi > > When you have time, could you rebase the pathes? > Some

Re: [HACKERS] logical decoding of two-phase transactions

2017-01-26 Thread Stas Kelvich
> On 26 Jan 2017, at 12:51, Craig Ringer wrote: > > * Tracking xid/gid map in memory also doesn’t help much — if server reboots > between prepare > and commit we’ll lose that mapping. > > Er what? That's why I suggested using the prepared xacts shmem state. It's >

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Alvaro Herrera
Robert Haas wrote: > 0002 renames programs whose names contains "xlog". There have been complaints that pg_receivexlog's name is not consistent with pg_recvlogical, and I seem to recall there were some votes for renaming pg_receivexlog to match. We could make it "pg_recvwal" now. -- Álvaro

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Tom Lane
Robert Haas writes: > On Thu, Jan 26, 2017 at 12:27 PM, Alvaro Herrera > wrote: >> There have been complaints that pg_receivexlog's name is not consistent >> with pg_recvlogical, and I seem to recall there were some votes for >> renaming

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Stephen Frost
* Andres Freund (and...@anarazel.de) wrote: > On 2017-01-24 16:47:29 -0500, Robert Haas wrote: > > I'm happy to go change every last bit of it. > > I quite regret not aggressively opining against the renaming of pg_xlog > to pg_wal. I think the few users deleting their data don't weigh against >

Re: [HACKERS] Patch: Write Amplification Reduction Method (WARM)

2017-01-26 Thread Robert Haas
On Wed, Jan 25, 2017 at 4:08 PM, Alvaro Herrera wrote: > I think the way WARM works has been pretty well hammered by now, other > than the CREATE INDEX CONCURRENTLY issues, so I'm looking at the code > from a maintainability point of view only. Which senior hackers have

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Robert Haas
On Thu, Jan 26, 2017 at 12:27 PM, Alvaro Herrera wrote: > Robert Haas wrote: > >> 0002 renames programs whose names contains "xlog". > > There have been complaints that pg_receivexlog's name is not consistent > with pg_recvlogical, and I seem to recall there were some

Re: [HACKERS] Superowners

2017-01-26 Thread Simon Riggs
On 26 January 2017 at 17:37, Peter Eisentraut wrote: > On 1/24/17 8:19 AM, Tom Lane wrote: >> What about just saying that the database owner has those privileges? >> After all, the ultimate privilege of an owner is to drop the object >> (and then remake it as she

Re: [HACKERS] Superowners

2017-01-26 Thread Michael Banck
On Thu, Jan 26, 2017 at 12:37:44PM -0500, Peter Eisentraut wrote: > On 1/24/17 8:19 AM, Tom Lane wrote: > > What about just saying that the database owner has those privileges? > > After all, the ultimate privilege of an owner is to drop the object > > (and then remake it as she pleases), and the

Re: [HACKERS] Superowners

2017-01-26 Thread Peter Eisentraut
On 1/24/17 8:19 AM, Tom Lane wrote: > What about just saying that the database owner has those privileges? > After all, the ultimate privilege of an owner is to drop the object > (and then remake it as she pleases), and the DB owner has that option > w.r.t. the whole database. So I'm not sure we

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Robert Haas
On Thu, Jan 26, 2017 at 12:41 PM, Tom Lane wrote: > Robert Haas writes: >> On Thu, Jan 26, 2017 at 12:27 PM, Alvaro Herrera >> wrote: >>> There have been complaints that pg_receivexlog's name is not consistent >>> with

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Tom Lane
Stephen Frost writes: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> What I think might be worth considering is inserting underscores, >> eg "pg_receive_wal", anywhere that we are running the abbreviation >> directly against another word. We won't get another chance. > Wouldn't

Re: [HACKERS] Add support to COMMENT ON CURRENT DATABASE

2017-01-26 Thread Fabrízio de Royes Mello
On Mon, Jan 9, 2017 at 6:14 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > > On 1/9/17 1:34 PM, Robert Haas wrote: > > On Fri, Jan 6, 2017 at 7:29 PM, Peter Eisentraut > > wrote: > >> On 1/3/17 11:52 PM, Ashutosh Bapat wrote: > >>> We will need

Re: [HACKERS] [PATCH] Generic type subscription

2017-01-26 Thread Robert Haas
On Mon, Jan 23, 2017 at 2:07 PM, Tom Lane wrote: > Can we arrange to do that differently? I'd prefer something in which the > argument and result types are visibly connected to the actual datatypes > at hand, for instance > array_subscript(anyarray, internal)

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Andres Freund
On 2017-01-24 16:47:29 -0500, Robert Haas wrote: > I'm happy to go change every last bit of it. I quite regret not aggressively opining against the renaming of pg_xlog to pg_wal. I think the few users deleting their data don't weigh against renaming a bunch of tools and function for some sense of

Re: [HACKERS] [COMMITTERS] pgsql: Reindent table partitioning code.

2017-01-26 Thread Robert Haas
On Thu, Jan 26, 2017 at 10:16 AM, Peter Eisentraut wrote: > On 1/24/17 10:51 AM, Robert Haas wrote: >> On Tue, Jan 24, 2017 at 10:28 AM, Tom Lane wrote: >>> Robert Haas writes: Reindent table partitioning code. >>>

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Robert Haas writes: > > On Thu, Jan 26, 2017 at 12:27 PM, Alvaro Herrera > > wrote: > >> There have been complaints that pg_receivexlog's name is not consistent > >> with pg_recvlogical, and I seem to

Re: [HACKERS] Superowners

2017-01-26 Thread David G. Johnston
On Thursday, January 26, 2017, Michael Banck wrote: > On Thu, Jan 26, 2017 at 12:37:44PM -0500, Peter Eisentraut wrote: > > On 1/24/17 8:19 AM, Tom Lane wrote: > > > What about just saying that the database owner has those privileges? > > > After all, the ultimate

Re: [HACKERS] Allow interrupts on waiting standby

2017-01-26 Thread Robert Haas
On Thu, Jan 26, 2017 at 7:18 AM, Simon Riggs wrote: > Currently a waiting standby doesn't allow interrupts. > > Patch implements that. > > Barring objection, patching today with backpatches. "today" is a little quick, but the patch looks fine. I doubt anyone's going to

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Tom Lane
Robert Haas writes: > Yeah, I thought about that, too, but it doesn't really seem worth it. > If we had pg_receive_wal and pg_receive_logical, they'd be nicely > consistent with each other, but inconsistent with practically every > other utility we have: pg_basebackup,

Re: [HACKERS] increasing the default WAL segment size

2017-01-26 Thread Robert Haas
On Tue, Jan 24, 2017 at 10:26 PM, Michael Paquier wrote: > On Wed, Jan 25, 2017 at 6:58 AM, Robert Haas wrote: >> On Fri, Jan 20, 2017 at 7:00 PM, Michael Paquier >> wrote: No, because the output of SHOW is always

Re: [HACKERS] Allow interrupts on waiting standby

2017-01-26 Thread Andres Freund
On 2017-01-26 12:24:44 -0500, Robert Haas wrote: > On Thu, Jan 26, 2017 at 7:18 AM, Simon Riggs wrote: > > Currently a waiting standby doesn't allow interrupts. > > > > Patch implements that. > > > > Barring objection, patching today with backpatches. > > "today" is a

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Robert Haas
On Thu, Jan 26, 2017 at 2:13 PM, Andres Freund wrote: > On 2017-01-26 14:05:43 -0500, Robert Haas wrote: >> I completely understand that position. I have always been doubtful of >> the value of renaming pg_xlog to pg_wal, and I'm not any more >> dedicated to the idea now than

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Robert Haas
On Thu, Jan 26, 2017 at 2:24 PM, Andres Freund wrote: >> Whether the voters recognized that fact at the time I would have to concur >> that if we are going to change from xlog to wal we should be all-in. If >> you want to vote to reject putting the whole camel in the tent I

Re: [HACKERS] Performance improvement for joins where outer side is unique

2017-01-26 Thread Tom Lane
David Rowley writes: > I've attached a version without outer unique. I looked through this a bit, and the first thing I noticed was it doesn't touch costsize.c at all. That seems pretty wrong; it's little help to have a performance improvement if the planner won't

Re: \if, \elseif, \else, \endif (was Re: [HACKERS] PSQL commands: \quit_if, \quit_unless)

2017-01-26 Thread Daniel Verite
Corey Huinker wrote: > Revised patch A comment about control flow and variables: in branches that are not taken, variables are expanded nonetheless, in a way that can be surprising. Case in point: \set var 'ab''cd' -- select :var; \if false select :var ; \else select 1; \endif

Re: [HACKERS] increasing the default WAL segment size

2017-01-26 Thread Robert Haas
On Thu, Jan 26, 2017 at 1:34 PM, Andres Freund wrote: > On 2017-01-26 13:16:13 -0500, Robert Haas wrote: >> > OK, I have done this refactoring effort as attached because I think >> > that's really worth it. And here are the diff numbers: >> > 3 files changed, 113

Re: [HACKERS] Allow interrupts on waiting standby

2017-01-26 Thread Simon Riggs
On 26 January 2017 at 19:20, Andres Freund wrote: > On 2017-01-26 12:24:44 -0500, Robert Haas wrote: >> On Thu, Jan 26, 2017 at 7:18 AM, Simon Riggs wrote: >> > Currently a waiting standby doesn't allow interrupts. >> > >> > Patch implements that. >> >

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread David G. Johnston
On Thu, Jan 26, 2017 at 12:37 PM, Andres Freund wrote: > On 2017-01-26 14:28:01 -0500, Robert Haas wrote: > > On Thu, Jan 26, 2017 at 2:24 PM, Andres Freund > wrote: > > >> Whether the voters recognized that fact at the time I would have to > concur > >

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Joshua D. Drake
-Hackers, From the field. I do not care what you chose, I care that: 1. It is consistent 2. It is readable/understandable 3. It is documented 4. It is done wholesale (because of usability) That's it. So whatever meets that criteria, let's go for it. That may mean that certain commands look a

Re: [HACKERS] [PATCH] Generic type subscription

2017-01-26 Thread Robert Haas
On Thu, Jan 26, 2017 at 1:38 PM, Tom Lane wrote: > So I'd really prefer that the functionality > involve a parser callout, and that would certainly need "internal" > argument(s). Thanks, I see now. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Andres Freund
On 2017-01-26 14:05:43 -0500, Robert Haas wrote: > I completely understand that position. I have always been doubtful of > the value of renaming pg_xlog to pg_wal, and I'm not any more > dedicated to the idea now than I was when I committed that patch. But > there was overwhelming support for

Re: [HACKERS] increasing the default WAL segment size

2017-01-26 Thread Andres Freund
Hi, On 2017-01-25 12:26:21 +0900, Michael Paquier wrote: > diff --git a/src/backend/access/common/tupdesc.c > b/src/backend/access/common/tupdesc.c > index 083c0303dc..2eb3a420ac 100644 > --- a/src/backend/access/common/tupdesc.c > +++ b/src/backend/access/common/tupdesc.c > @@ -629,6 +629,14 @@

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Tom Lane
Robert Haas writes: > On Thu, Jan 26, 2017 at 2:24 PM, Andres Freund wrote: >>> Whether the voters recognized that fact at the time I would have to concur >>> that if we are going to change from xlog to wal we should be all-in. If >>> you want to vote

Re: [HACKERS] increasing the default WAL segment size

2017-01-26 Thread Andres Freund
On 2017-01-26 13:16:13 -0500, Robert Haas wrote: > > OK, I have done this refactoring effort as attached because I think > > that's really worth it. And here are the diff numbers: > > 3 files changed, 113 insertions(+), 162 deletions(-) > > That's a bit less than what I thought first because of

Re: [HACKERS] [PATCH] Generic type subscription

2017-01-26 Thread Tom Lane
Robert Haas writes: > On Mon, Jan 23, 2017 at 2:07 PM, Tom Lane wrote: >> Can we arrange to do that differently? I'd prefer something in which the >> argument and result types are visibly connected to the actual datatypes >> at hand, for instance >>

Re: [HACKERS] Cache Hash Index meta page.

2017-01-26 Thread Mithun Cy
On Tue, Jan 24, 2017 at 3:10 PM, Amit Kapila wrote: > 1. > @@ -505,26 +505,22 @@ hashbulkdelete(IndexVacuumInfo *info, > In the above flow, do we really need an updated metapage, can't we use > the cached one? We are already taking care of bucket split down in > that

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Andres Freund
On 2017-01-26 12:23:24 -0700, David G. Johnston wrote: > On Thu, Jan 26, 2017 at 12:13 PM, Andres Freund wrote: > > > On 2017-01-26 14:05:43 -0500, Robert Haas wrote: > > > I completely understand that position. I have always been doubtful of > > > the value of renaming

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Andres Freund
On 2017-01-26 14:28:01 -0500, Robert Haas wrote: > On Thu, Jan 26, 2017 at 2:24 PM, Andres Freund wrote: > >> Whether the voters recognized that fact at the time I would have to concur > >> that if we are going to change from xlog to wal we should be all-in. If > >> you want

Re: [HACKERS] Allow interrupts on waiting standby

2017-01-26 Thread Stephen Frost
* Andres Freund (and...@anarazel.de) wrote: > On 2017-01-26 19:36:11 +, Simon Riggs wrote: > > Tomorrow is too late. > > Huh? We're not wrapping today/tomorrow, are we? If I missed something > and we are, then sure, it makes sense to push ahead. I haven't seen anyone suggest that we're

Re: [HACKERS] increasing the default WAL segment size

2017-01-26 Thread Andres Freund
Hi, On 2017-01-23 11:35:11 +0530, Beena Emerson wrote: > Please find attached an updated WIP patch. I have incorporated almost all > comments. This is to be applied over Robert's patches. I will post > performance results later on. > > 1. shift (>>) and AND (&) operations: The assign hook of

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread David G. Johnston
On Thu, Jan 26, 2017 at 12:13 PM, Andres Freund wrote: > On 2017-01-26 14:05:43 -0500, Robert Haas wrote: > > I completely understand that position. I have always been doubtful of > > the value of renaming pg_xlog to pg_wal, and I'm not any more > > dedicated to the idea now

Re: [HACKERS] Allow interrupts on waiting standby

2017-01-26 Thread Andres Freund
On 2017-01-26 19:36:11 +, Simon Riggs wrote: > On 26 January 2017 at 19:20, Andres Freund wrote: > > On 2017-01-26 12:24:44 -0500, Robert Haas wrote: > >> On Thu, Jan 26, 2017 at 7:18 AM, Simon Riggs wrote: > >> > Currently a waiting standby doesn't

Re: [HACKERS] Patch: Write Amplification Reduction Method (WARM)

2017-01-26 Thread Alvaro Herrera
Robert Haas wrote: > On Wed, Jan 25, 2017 at 4:08 PM, Alvaro Herrera > wrote: > > I think the way WARM works has been pretty well hammered by now, other > > than the CREATE INDEX CONCURRENTLY issues, so I'm looking at the code > > from a maintainability point of view

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Michael Paquier
On Fri, Jan 27, 2017 at 2:21 AM, Robert Haas wrote: > On Tue, Jan 24, 2017 at 4:47 PM, Robert Haas wrote: >>> But I don't see any proposals to actually change all uses of "xlog" to >>> "wal". What about program names, command line options, etc.? If

Re: [HACKERS] [COMMITTERS] pgsql: Check interrupts during hot standby waits

2017-01-26 Thread Michael Paquier
On Fri, Jan 27, 2017 at 4:06 AM, Andres Freund wrote: > Hi, > > On 2017-01-26 19:00:34 +, Simon Riggs wrote: >> Check interrupts during hot standby waits >> >> Branch >> -- >> master >> >> Details >> --- >>

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-26 Thread Michael Paquier
On Thu, Jan 26, 2017 at 11:36 PM, Tom Lane wrote: > Haribabu Kommi writes: >> This patch currently doesn't have the code for reporting the two log >> messages that can occur in tokenize_file function. To support the same, >> I am thinking of changing

Re: [HACKERS] Microvacuum support for Hash Index

2017-01-26 Thread Amit Kapila
On Thu, Jan 26, 2017 at 6:38 PM, Jesper Pedersen wrote: > On 01/23/2017 02:53 PM, Jesper Pedersen wrote: >> >> I have done some more testing with this, and have moved to the patch >> back to 'Needs Review' pending Amit's comments. >> > > Moved to "Ready for Committer".

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-01-26 Thread Amit Kapila
On Thu, Jan 26, 2017 at 8:45 PM, Peter Eisentraut wrote: > On 1/24/17 3:26 AM, Mithun Cy wrote: >> In my code by default, we only dump at shutdown time. If we want to >> dump at regular interval then we need to set the GUC >> pg_autoprewarm.buff_dump_interval to

Re: [HACKERS] BUG: pg_stat_statements query normalization issues with combined queries

2017-01-26 Thread Tom Lane
Craig Ringer writes: > So perhaps: > "The same query string may be passed to multiple invocations of > ProcessUtility if a utility statement invokes subcommands (e.g. ALTER > TABLE), in which case context will be set to > PROCESS_UTILITY_SUBCOMMAND, or if the user

Re: [HACKERS] [GENERAL] C++ port of Postgres

2017-01-26 Thread Andres Freund
Hi Peter, On 2016-09-30 15:24:09 -0400, Peter Eisentraut wrote: > Yeah, I have committed a few of the patches now and I'll close the CF > entry now. Thanks for your research. Are you planning to push more of these at some point? - Andres -- Sent via pgsql-hackers mailing list

[HACKERS] Typo in comment in postgres_fdw.c

2017-01-26 Thread Etsuro Fujita
Hi, I ran into a typo in a comment in contrib/postgres_fdw/postgres_fdw.c. Attached is a small patch for fixing that. Best regards, Etsuro Fujita diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c index fbe6929..7cb9dc5 100644 ---

Re: [HACKERS] pgbench more operators & functions

2017-01-26 Thread Fabien COELHO
Hello Stephen, For my 2c, at least, while I'm definitely interested in this, it's not nearly high enough on my plate with everything else going on to get any attention in the next few weeks, at least. Fine with me. I do think that, perhaps, this patch may deserve a bit of a break, to allow

Re: [HACKERS] Speedup twophase transactions

2017-01-26 Thread Nikhil Sontakke
>> Umm, AFAICS, CheckPointTwoPhase() does not get called in the "standby >> promote" code path. > > CreateRestartPoint() calls it via CheckPointGuts() while in recovery. May be that I am missing something. But, I put the recovery process and the checkpointer process of the standby under gdb with

Re: [HACKERS] Speedup twophase transactions

2017-01-26 Thread Stas Kelvich
> On 26 Jan 2017, at 10:34, Michael Paquier wrote: > > On Thu, Jan 26, 2017 at 4:09 PM, Nikhil Sontakke > wrote: >>> I look at this patch from you and that's present for me: >>>

Re: [HACKERS] multivariate statistics (v19)

2017-01-26 Thread Ideriha, Takeshi
Hi When you have time, could you rebase the pathes? Some patches cannot be applied to the current HEAD. 0001 patch can be applied but the following 0002 patch cannot be. I've just started reading your patch (mainly docs and README, not yet source code.) Though these are minor things, I've

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2017-01-26 Thread vinayak
Hi Sawada-san, On 2017/01/26 16:51, Masahiko Sawada wrote: Thank you for reviewing! I think this is a bug of pg_fdw_resolver contrib module. I had forgotten to change the SQL executed by pg_fdw_resolver process. Attached latest version 002 patch. As previous version patch conflicts to

Re: [HACKERS] Floating point comparison inconsistencies of the geometric types

2017-01-26 Thread Kyotaro HORIGUCHI
Hello, Emre. At Wed, 25 Jan 2017 12:24:18 +0100, Emre Hasegeli wrote in > I am responding both of your emails together. > > > Perhaps I don't understand it. Many opclass are defined for > > btree. But since

Re: [HACKERS] multivariate statistics (v19)

2017-01-26 Thread Dilip Kumar
On Thu, Jan 5, 2017 at 3:27 AM, Tomas Vondra wrote: > Thanks. Those plans match my experiments with the TPC-H data set, although > I've been playing with the smallest scale (1GB). > > It's not very difficult to make the estimation error arbitrary large, e.g. > by

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2017-01-26 Thread Masahiko Sawada
On Thu, Jan 26, 2017 at 6:04 PM, vinayak wrote: > Hi Sawada-san, > > On 2017/01/26 16:51, Masahiko Sawada wrote: > > Thank you for reviewing! > > I think this is a bug of pg_fdw_resolver contrib module. I had > forgotten to change the SQL executed by

Re: [HACKERS] logical decoding of two-phase transactions

2017-01-26 Thread Craig Ringer
On 26 Jan. 2017 18:43, "Stas Kelvich" wrote: >> >> Yes, that’s also possible but seems to be less flexible restricting us to some >> specific GID format. >> >> Anyway, I can measure WAL space overhead introduced by the GID’s inside commit records >> to know exactly what

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-26 Thread Robert Haas
On Thu, Jan 26, 2017 at 1:21 PM, Andres Freund wrote: > On 2017-01-24 16:47:29 -0500, Robert Haas wrote: >> I'm happy to go change every last bit of it. > > I quite regret not aggressively opining against the renaming of pg_xlog > to pg_wal. I think the few users deleting

Re: [HACKERS] [COMMITTERS] pgsql: Check interrupts during hot standby waits

2017-01-26 Thread Andres Freund
Hi, On 2017-01-26 19:00:34 +, Simon Riggs wrote: > Check interrupts during hot standby waits > > Branch > -- > master > > Details > --- > http://git.postgresql.org/pg/commitdiff/e8ee3d6b859a18d7f7375ceb9e04d256eb18aaec > > Modified Files > -- >

Re: [HACKERS] simplify sequence test

2017-01-26 Thread Peter Eisentraut
On 1/25/17 5:29 AM, Petr Jelinek wrote: > On 25/01/17 03:48, Peter Eisentraut wrote: >> We maintain a separate test output file sequence_1.out because the >> log_cnt value can vary if there is a checkpoint happening at the right >> time. So we have to maintain two files because of a one character

Re: [HACKERS] Allow interrupts on waiting standby

2017-01-26 Thread Alvaro Herrera
Simon Riggs wrote: > On 26 January 2017 at 19:20, Andres Freund wrote: > > I'm personally fine with going with a CHECK_FOR_INTERRUPTS > > for now, but I think it'd better to replace it with a latch. > > I have waited, so not sure what you mean. Tomorrow is too late. > >

Re: [HACKERS] Performance improvement for joins where outer side is unique

2017-01-26 Thread David Rowley
On 27 January 2017 at 08:34, Tom Lane wrote: > David Rowley writes: >> I've attached a version without outer unique. > > I looked through this a bit, and the first thing I noticed was it doesn't > touch costsize.c at all. That seems pretty

Re: [HACKERS] safer node casting

2017-01-26 Thread Andres Freund
On 2017-01-25 19:21:40 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2016-12-31 12:08:22 -0500, Peter Eisentraut wrote: > >> RestrictInfo *rinfo = castNode(RestrictInfo, lfirst(lc)); > > > Are you planning to add this / update this patch? Because I really would > >

Re: [HACKERS] Failure in commit_ts tap tests

2017-01-26 Thread Tom Lane
Alvaro Herrera writes: > It is really quite annoying that the buildfarm doesn't do what stock > tests do. What about pushing a bit stronger for having these > optimizations as part of the standard build run, instead of being only > in the buildfarm client script? Huh?

Re: [HACKERS] Failure in commit_ts tap tests

2017-01-26 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera writes: > > It is really quite annoying that the buildfarm doesn't do what stock > > tests do. What about pushing a bit stronger for having these > > optimizations as part of the standard build run, instead of being only > > in the

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-01-26 Thread Beena Emerson
On Fri, Jan 27, 2017 at 8:14 AM, Amit Kapila wrote: > On Thu, Jan 26, 2017 at 8:45 PM, Peter Eisentraut > wrote: > > On 1/24/17 3:26 AM, Mithun Cy wrote: > >> In my code by default, we only dump at shutdown time. If we want to > >> dump

Re: [HACKERS] Logical Replication WIP

2017-01-26 Thread Petr Jelinek
On 25/01/17 18:16, Peter Eisentraut wrote: > On 1/22/17 8:11 PM, Petr Jelinek wrote: >> 0001 - Changes the libpqrcv_connect to use async libpq api so that it >> won't get stuck forever in case of connect is stuck. This is preexisting >> bug that also affects walreceiver but it's less visible there

[HACKERS] nodes.h - comments comment

2017-01-26 Thread Erik Rijkers
Orthography fix in nodes.h comment block.--- src/include/nodes/nodes.h.orig 2017-01-27 06:54:38.704059681 +0100 +++ src/include/nodes/nodes.h 2017-01-27 06:57:17.535250383 +0100 @@ -560,7 +560,7 @@ /* * castNode(type, ptr) casts ptr to type and, if cassert is enabled, verifies - * that the

Re: [HACKERS] Parallel bitmap heap scan

2017-01-26 Thread Dilip Kumar
On Tue, Jan 24, 2017 at 10:18 AM, Dilip Kumar wrote: > I have changed as per the comments. 0002 and 0003 are changed, 0001 is > still the same. 2 days back my colleague Rafia, reported one issue (offlist) that parallel bitmap node is not scaling as good as other nodes e.g

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-01-26 Thread Mithun Cy
On Thu, Jan 26, 2017 at 8:45 PM, Peter Eisentraut wrote: > Just a thought with an additional use case: If I want to set up a > standby for offloading queries, could I take the dump file from the > primary or another existing standby, copy it to the new standby,

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2017-01-26 Thread Kuntal Ghosh
On Wed, Jan 25, 2017 at 6:00 PM, Haribabu Kommi wrote: > Corrected as suggested. > > Updated patch attached. There is no change in the contrib patch. Got whitspace error warning while applying contrib_macaddr8_1.patch:184. diff --git

Re: [HACKERS] BUG: pg_stat_statements query normalization issues with combined queries

2017-01-26 Thread Kyotaro HORIGUCHI
At Thu, 26 Jan 2017 22:34:57 -0500, Tom Lane wrote in <23778.1485488...@sss.pgh.pa.us> > Craig Ringer writes: > > So perhaps: > > > "The same query string may be passed to multiple invocations of > > ProcessUtility if a utility statement

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2017-01-26 Thread Vitaly Burovoy
On 1/25/17, Haribabu Kommi wrote: > On Wed, Jan 25, 2017 at 6:43 PM, Vitaly Burovoy > wrote: > >> On 1/23/17, Haribabu Kommi wrote: >> > The patch is split into two parts. >> > 1. Macaddr8 datatype support >> > 2.

Re: [HACKERS] Floating point comparison inconsistencies of the geometric types

2017-01-26 Thread Emre Hasegeli
> Even though I'm not sure but I don't see a "natural" (or > agreeable by many poeple) ordering of geometric types in > general. Anyway it's quite application (not application program > but the relationship with the real world) specific. We can just define it for point as "ORDER BY point.x,

Re: [HACKERS] safer node casting

2017-01-26 Thread Andres Freund
On 2017-01-26 17:27:45 -0500, Tom Lane wrote: > Andres Freund writes: > > #if defined(USE_ASSERT_CHECKING) && defined(PG_USE_INLINE) > > is probably a better gatekeeper in the back-branches, than gcc? > > Ah, yeah, that would work --- I'd already swapped out that business ;-)

Re: [HACKERS] safer node casting

2017-01-26 Thread Andres Freund
Hi, On 2016-12-31 12:08:22 -0500, Peter Eisentraut wrote: > This is inspired by the dynamic_cast operator in C++, but follows the > syntax of the well-known makeNode() macro. The analogy to dynamic_cast goes only so far, because we don't actually support inheritance. I.e. in c++ we could

  1   2   >