Re: [HACKERS] dropping partitioned tables without CASCADE

2017-02-21 Thread Ashutosh Bapat
On Tue, Feb 21, 2017 at 12:05 PM, Amit Langote wrote: > Hi Ashutosh, > > Thanks for taking a look at the patch. > > On 2017/02/20 21:49, Ashutosh Bapat wrote: >> Thanks for working on all the follow on work for partitioning feature. >> >> May be you should add all

Re: [HACKERS] Should we cacheline align PGXACT?

2017-02-21 Thread Alexander Korotkov
On Tue, Feb 21, 2017 at 2:37 PM, Andres Freund wrote: > On 2017-02-21 16:57:36 +0530, Ashutosh Sharma wrote: > > Yes, there is still some regression however it has come down by a > > small margin. I am not doing initdb for each run instead I am doing, > >

Re: [HACKERS] [POC] A better way to expand hash indexes.

2017-02-21 Thread Mithun Cy
Thanks, Amit On Mon, Feb 20, 2017 at 9:51 PM, Amit Kapila wrote: > How will high and lowmask calculations work in this new strategy? > Till now they always work on doubling strategy and I don't see you > have changed anything related to that code. Check below places.

Re: [HACKERS] Patch: Write Amplification Reduction Method (WARM)

2017-02-21 Thread Pavan Deolasee
Hi Tom, On Wed, Feb 1, 2017 at 3:51 AM, Tom Lane wrote: > > (I'm a little more concerned by Alvaro's apparent position that WARM > is a done deal; I didn't think so. Are there any specific aspects of the design that you're not comfortable with? I'm sure there could be some

Re: [HACKERS] pageinspect: Hash index support

2017-02-21 Thread Ashutosh Sharma
Thanks for reporting it. This is because of incorrect data typecasting. Attached is the patch that fixes this issue. On Tue, Feb 21, 2017 at 2:58 PM, Mithun Cy wrote: > On Fri, Feb 10, 2017 at 1:06 AM, Robert Haas > wrote: > > > Alright,

Re: [HACKERS] Should we cacheline align PGXACT?

2017-02-21 Thread Alexander Korotkov
Hi, Ashutosh! On Mon, Feb 20, 2017 at 1:20 PM, Ashutosh Sharma wrote: > Following are the pgbench results for read-write workload, I got with > pgxact-align-3 patch. The results are for 300 scale factor with 8GB of > shared buffer i.e. when data fits into the shared

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-21 Thread Masahiko Sawada
On Tue, Feb 21, 2017 at 3:42 AM, Fujii Masao wrote: > On Thu, Feb 16, 2017 at 11:40 AM, Masahiko Sawada > wrote: >> On Thu, Feb 16, 2017 at 7:52 AM, Petr Jelinek >> wrote: >>> On 15/02/17 06:43, Masahiko Sawada wrote:

Re: [HACKERS] pageinspect: Hash index support

2017-02-21 Thread Mithun Cy
On Fri, Feb 10, 2017 at 1:06 AM, Robert Haas wrote: > Alright, committed with a little further hacking. I did pull the latest code, and tried Test: create table t1(t int); create index i1 on t1 using hash(t); insert into t1 select generate_series(1, 1000);

Re: [HACKERS] powerpc(32) point/polygon regression failures on Debian Jessie

2017-02-21 Thread Christoph Berg
Re: To Tom Lane 2017-02-20 <20170220161556.5ukosuj5o572b...@msg.credativ.de> > I was compiling the program on jessie and on sid, and running the > jessie binary on sid made it output the same as the sid binary, so the > difference isn't in the binary, but in some system library. Fwiw, the problem

[HACKERS] [patch] reorder tablespaces in basebackup tar stream for backup_label

2017-02-21 Thread Michael Banck
Hi, currently, the backup_label and (I think) the tablespace_map files are (by design) conveniently located at the beginning of the main tablespace tarball when making a basebackup. However, (by accident or also by design?) the main tablespace is the last tarball[1] to be streamed via the

Re: [HACKERS] Should we cacheline align PGXACT?

2017-02-21 Thread Ashutosh Sharma
On Tue, Feb 21, 2017 at 4:21 PM, Alexander Korotkov wrote: > > Hi, Ashutosh! > On Mon, Feb 20, 2017 at 1:20 PM, Ashutosh Sharma > wrote: >> >> Following are the pgbench results for read-write workload, I got with >> pgxact-align-3 patch. The

Re: [HACKERS] LWLock optimization for multicore Power machines

2017-02-21 Thread Alexander Korotkov
On Tue, Feb 21, 2017 at 1:47 PM, Bernd Helmle wrote: > Am Samstag, den 11.02.2017, 15:42 +0300 schrieb Alexander Korotkov: > > I think it would make sense to run more kinds of tests. Could you > > try set > > of tests provided by Tomas Vondra? > > If even we wouldn't see

Re: [HACKERS] [doc fix] Really trivial fix for BRIN documentation

2017-02-21 Thread Simon Riggs
On 21 February 2017 at 06:34, Tsunakawa, Takayuki wrote: > Hello, > > This is just a correction from "index" to "table". I was a bit confused when > I first read this part. Pushed, but using "heap" rather than "table", for clarity. Thanks for the patch. --

Re: [HACKERS] Push down more UPDATEs/DELETEs in postgres_fdw

2017-02-21 Thread Rushabh Lathia
On Mon, Feb 20, 2017 at 1:41 PM, Etsuro Fujita wrote: > On 2017/02/13 18:24, Rushabh Lathia wrote: > >> I started reviewing the patch again. Patch applied cleanly on latest >> source >> as well as regression pass through with the patch. I also performed >> few manual

Re: [HACKERS] Should we cacheline align PGXACT?

2017-02-21 Thread Andres Freund
Hi, On 2017-02-21 16:57:36 +0530, Ashutosh Sharma wrote: > Yes, there is still some regression however it has come down by a > small margin. I am not doing initdb for each run instead I am doing, > dropdb-->createdb-->pgbench -i. Is dropping old database and creating > a new one for every run not

Re: [HACKERS] drop support for Python 2.3

2017-02-21 Thread Tom Lane
Peter Eisentraut writes: > On 2/19/17 23:33, Devrim Gündüz wrote: >> Thanks! Looks like buildfarm is green again. > Thank. I have committed the patch to drop Python 2.3 support. I spent some time last night building a (rather makeshift) python 2.4.1

Re: [HACKERS] Measuring replay lag

2017-02-21 Thread Simon Riggs
On 17 February 2017 at 07:45, Thomas Munro wrote: > On Fri, Feb 17, 2017 at 12:45 AM, Simon Riggs wrote: >> Feeling happier about this for now at least. > > Thanks! And happier again, leading me to move to the next stage of review, focusing

Re: [HACKERS] pg_monitor role

2017-02-21 Thread Thomas Reiss
Le 20/02/2017 à 12:48, Dave Page a écrit : > Further to the patch I just submitted > (https://www.postgresql.org/message-id/CA%2BOCxow-X%3DD2fWdKy%2BHP%2BvQ1LtrgbsYQ%3DCshzZBqyFT5jOYrFw%40mail.gmail.com) > I'd like to propose the addition of a default role, pg_monitor. > > The intent is to make

Re: [HACKERS] Should we cacheline align PGXACT?

2017-02-21 Thread Ashutosh Sharma
On Tue, Feb 21, 2017 at 5:52 PM, Alexander Korotkov wrote: > On Tue, Feb 21, 2017 at 2:37 PM, Andres Freund wrote: >> >> On 2017-02-21 16:57:36 +0530, Ashutosh Sharma wrote: >> > Yes, there is still some regression however it has come down by a >> >

Re: [HACKERS] LWLock optimization for multicore Power machines

2017-02-21 Thread Bernd Helmle
Am Dienstag, den 14.02.2017, 15:53 +0300 schrieb Alexander Korotkov: > +1 > And you could try to use pg_wait_sampling > to sampling of wait > events. I've tried this with your example from your blog post[1] and got this: (pgbench scale 1000)

Re: [HACKERS] Provide list of subscriptions and publications in psql's completion

2017-02-21 Thread Petr Jelinek
On 21/02/17 07:50, Michael Paquier wrote: > On Tue, Feb 21, 2017 at 12:48 AM, Stephen Frost wrote: >> * Fujii Masao (masao.fu...@gmail.com) wrote: >>> On Fri, Feb 17, 2017 at 11:17 PM, Peter Eisentraut >>> 1) Expose all the columns except subconninfo in pg_subscription to >>>

Re: [HACKERS] drop support for Python 2.3

2017-02-21 Thread Peter Eisentraut
On 2/19/17 23:33, Devrim Gündüz wrote: > Thanks! Looks like buildfarm is green again. Thank. I have committed the patch to drop Python 2.3 support. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via

Re: [HACKERS] GUC for cleanup indexes threshold.

2017-02-21 Thread Amit Kapila
On Tue, Feb 21, 2017 at 1:09 AM, Simon Riggs wrote: > On 20 February 2017 at 10:27, Amit Kapila wrote: >> On Mon, Feb 20, 2017 at 3:01 PM, Simon Riggs wrote: >>> On 20 February 2017 at 09:15, Amit Kapila

Re: [HACKERS] Partitioned tables and relfilenode

2017-02-21 Thread Ashutosh Bapat
Some comments about 0003 patch. @@ -996,10 +996,20 @@ inheritance_planner(PlannerInfo *root) Index rti; + RangeTblEntry *parent_rte; There's already another variable declared in that function within a loop foreach(lc, root->append_rel_list) { ... RangeTblEntry

Re: [HACKERS] foreign partition DDL regression tests

2017-02-21 Thread Ashutosh Bapat
Please add this to the upcoming commitfest. On Wed, Feb 22, 2017 at 7:10 AM, Amit Langote wrote: > Ashutosh Bapat pointed out [0] that regression tests are missing for the > foreign partition DDL commands. Attached patch takes care of that. > > Thanks, > Amit > >

[HACKERS] Statement timeout behavior in extended queries

2017-02-21 Thread Tatsuo Ishii
Last year I have proposed an enhancement regarding behavior of the statement timeout in extended queries. https://www.postgresql.org/message-id/20160528.220442.1489791680347556026.t-ishii%40sraoss.co.jp IMO the current behavior is counter intuitive and I would like to change it toward PostgreSQL

Re: [HACKERS] SERIALIZABLE with parallel query

2017-02-21 Thread Robert Haas
On Tue, Feb 21, 2017 at 12:55 AM, Thomas Munro wrote: > On Thu, Feb 16, 2017 at 6:19 PM, Thomas Munro > wrote: >> Specifically, DeleteChildTargetLocks() assumes it can walk >> MySerializableXact->predicateLocks and throw away locks

Re: [HACKERS] snapbuild woes

2017-02-21 Thread Petr Jelinek
On 13/12/16 00:38, Petr Jelinek wrote: > On 12/12/16 23:33, Andres Freund wrote: >> On 2016-12-12 23:27:30 +0100, Petr Jelinek wrote: >>> On 12/12/16 22:42, Andres Freund wrote: Hi, On 2016-12-10 23:10:19 +0100, Petr Jelinek wrote: > Hi, > First one is outright bug, which

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-02-21 Thread Robert Haas
On Wed, Feb 22, 2017 at 4:06 AM, Peter Eisentraut wrote: > On 2/10/17 15:12, Robert Haas wrote: >> Right. I can't see why you'd want to be able to separately control >> those two things. If you're not dumping, you don't want to load; if >> you're not loading,

Re: [HACKERS] Bold itemized list entries

2017-02-21 Thread Robert Haas
On Tue, Feb 21, 2017 at 10:26 PM, Magnus Hagander wrote: > Did this one get fixed with the changes that went on a couple of days ago? The lists-being-boldfaced thing seems to be fixed, at least it looks like it to me, but the devel documentation still doesn't look right

[HACKERS] foreign partition DDL regression tests

2017-02-21 Thread Amit Langote
Ashutosh Bapat pointed out [0] that regression tests are missing for the foreign partition DDL commands. Attached patch takes care of that. Thanks, Amit [0] https://www.postgresql.org/message-id/CAFjFpRcrdzBRj0cZ%2BJAQmfSa2Tv8wSEcWAeYtDpV-YZnNna2sA%40mail.gmail.com >From

Re: [HACKERS] dropping partitioned tables without CASCADE

2017-02-21 Thread Amit Langote
On 2017/02/22 10:49, Amit Langote wrote: > On 2017/02/21 20:17, Ashutosh Bapat wrote: >> Are you sure you have attached the right patch? > > Oops, really fixed this time. Sorry again, 3rd time's a charm. I copy-paste the hunk below from the patch file before I attach it to make sure: -

Re: [HACKERS] Documentation improvements for partitioning

2017-02-21 Thread Robert Haas
On Tue, Feb 21, 2017 at 10:27 PM, Yugo Nagata wrote: > There is a very small typo that a comma is missing. > Attached is the patch to fix it. Thank you. I have committed your patch. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [HACKERS] patch proposal

2017-02-21 Thread Venkata B Nagothi
On Tue, Jan 31, 2017 at 10:41 AM, Michael Paquier wrote: > On Tue, Jan 31, 2017 at 4:49 AM, David Steele wrote: > > On 1/27/17 3:19 AM, Venkata B Nagothi wrote: > >> I have split the patch into two different > >> pieces. One is to determine if

Re: [HACKERS] Documentation improvements for partitioning

2017-02-21 Thread Robert Haas
On Tue, Feb 21, 2017 at 2:03 AM, Bruce Momjian wrote: > I have to admit my reaction was similar to Simon's, meaning that the > lack of docs is a problem, and that the limitations are kind of a > surprise, and I wonder what other surprises there are. Did you read my message

Re: [HACKERS] "may be unused" warnings for gcc

2017-02-21 Thread Andres Freund
On 2017-02-21 17:20:44 -0500, Peter Eisentraut wrote: > On 2/20/17 09:41, Andres Freund wrote: > > When building with a new-ish gcc (6.3.0 right now, but I've seen this > > for a while) with optimization I get a number of warnings: > > These all look like related to inlining/-O3. > > I have

Re: [HACKERS] patch proposal

2017-02-21 Thread Venkata B Nagothi
On Tue, Jan 31, 2017 at 6:49 AM, David Steele wrote: > On 1/27/17 3:19 AM, Venkata B Nagothi wrote: > > > I will be adding the tests in > > src/test/recovery/t/003_recovery_targets.pl > > . My tests would look more or less > > similar to

Re: [HACKERS] foreign partition DDL regression tests

2017-02-21 Thread Amit Langote
On 2017/02/22 13:26, Ashutosh Bapat wrote: > Please add this to the upcoming commitfest. Done. Thanks, Amit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Enabling parallelism for queries coming from SQL or other PL functions

2017-02-21 Thread Rafia Sabih
Hello everybody, In the current version, queries in SQL or PL functions can not leverage parallelism. To relax this restriction I prepared a patch, the approach used in the patch is explained next, Approach: 1. Allow parallelism for queries in PL functions by passing CURSOR_OPT_PARALLEL_OK

Re: [HACKERS] mat views stats

2017-02-21 Thread Jim Nasby
On 2/21/17 4:22 PM, Peter Eisentraut wrote: Attached is a patch to trigger autovacuum based on a matview refresh along with a system view pg_stat_all_matviews to show information more meaningful for materialized views. It might be easier to include materialized views into pg_stat_*_tables.

Re: [HACKERS] dropping partitioned tables without CASCADE

2017-02-21 Thread Ashutosh Bapat
Looks good to me. In the attached patch I have added a comment explaining the reason to make partition tables "Auto" dependent upon the corresponding partitioned tables. In the tests we are firing commands to drop partitioned table, but are not checking whether those tables or the partitions are

Re: [HACKERS] Passing query string to workers

2017-02-21 Thread Rafia Sabih
On Wed, Feb 22, 2017 at 12:25 PM, Robert Haas wrote: > Looks fine to me. Committed. I did move es_queryText to what I think > is a more appropriate location in the structure definition. > > Thanks. > Many thanks to Robert for committing and to Kuntal and Amit for

[HACKERS] tablesample with partitioned tables

2017-02-21 Thread Amit Langote
Attached patch fixes an oversight that tablesample cannot be used with partitioned tables: create table p (a int) partition by list (a); select * from p tablesample bernoulli (50); ERROR: TABLESAMPLE clause can only be applied to tables and materialized views Thanks, Amit >From

Re: [HACKERS] Change in "policy" on dump ordering?

2017-02-21 Thread Jim Nasby
On 2/21/17 4:25 PM, Peter Eisentraut wrote: On 2/21/17 14:58, Jim Nasby wrote: AFAICT in older versions only object types that absolutely had to wait for DO_POST_DATA_BOUNDARY would do so. More recently though, objects are being added after that (presumably because it's easier than renumbering

Re: [HACKERS] Replication vs. float timestamps is a disaster

2017-02-21 Thread Jim Nasby
On 2/20/17 5:04 AM, Andres Freund wrote: On 2017-02-20 11:58:12 +0100, Petr Jelinek wrote: That being said, I did wonder myself if we should just deprecate float timestamps as well. I think we need a proper deprecation period for that, given that the conversion away will be painful for

Re: [HACKERS] pageinspect: Hash index support

2017-02-21 Thread Robert Haas
On Tue, Feb 21, 2017 at 3:14 PM, Ashutosh Sharma wrote: > Thanks for reporting it. This is because of incorrect data typecasting. > Attached is the patch that fixes this issue. Oops, that's probably my fault. Thanks for the patch; committed. -- Robert Haas EnterpriseDB:

Re: [HACKERS] Radix tree for character conversion

2017-02-21 Thread Michael Paquier
On Fri, Feb 3, 2017 at 1:18 PM, Kyotaro HORIGUCHI wrote: > Thanks to that Heikki have pushed the first two patches and a > part of the third, only one patch is remaining now. > > # Sorry for not separating KOI8 stuffs. > > At Tue, 31 Jan 2017 19:06:09 +0900 (Tokyo

[HACKERS] GRANT EXECUTE ON FUNCTION foo() TO bar();

2017-02-21 Thread Joel Jacobson
Hi Hackers, Currently, it's only possible to grant/revoke execute on functions to roles. I think it would be useful in many situations, both for documentation purposes, but also for increased security, to in a precise way control what other function(s) are allowed to execute a specific function.

Re: [HACKERS] Replication vs. float timestamps is a disaster

2017-02-21 Thread Jim Nasby
On 2/21/17 4:52 PM, James Cloos wrote: "TL" == Tom Lane writes: TL> The question to be asked is whether there is still anybody out there TL> using float timestamps. Gentoo's ebuild includes: $(use_enable !pg_legacytimestamp integer-datetimes) \ FWIW, last time I

Re: [HACKERS] dropping partitioned tables without CASCADE

2017-02-21 Thread Amit Langote
On 2017/02/22 13:46, Ashutosh Bapat wrote: > Looks good to me. In the attached patch I have added a comment > explaining the reason to make partition tables "Auto" dependent upon > the corresponding partitioned tables. Good call. + /* +* Unlike inheritance children, partition

Re: [HACKERS] Push down more UPDATEs/DELETEs in postgres_fdw

2017-02-21 Thread Etsuro Fujita
On 2017/02/21 19:31, Rushabh Lathia wrote: On Mon, Feb 20, 2017 at 1:41 PM, Etsuro Fujita > wrote: On 2017/02/13 18:24, Rushabh Lathia wrote: Here are few comments: 1) @@ -211,6 +211,12 @@ typedef

Re: [HACKERS] Parallel Index-only scan

2017-02-21 Thread Rafia Sabih
On Sun, Feb 19, 2017 at 4:02 PM, Robert Haas wrote: > Committed, although I neglected to incorporate this change. Not sure > if I should go back and do that; it doesn't read too badly as-is. > Thanks Robert for committing, and thanks Rahila, Amit, and Tushar for reviewing

Re: [HACKERS] Passing query string to workers

2017-02-21 Thread Robert Haas
On Tue, Feb 21, 2017 at 9:18 AM, Rafia Sabih wrote: > Done. Looks fine to me. Committed. I did move es_queryText to what I think is a more appropriate location in the structure definition. Thanks. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The

Re: [HACKERS] Replication vs. float timestamps is a disaster

2017-02-21 Thread Andres Freund
On 2017-02-22 00:10:35 -0600, Jim Nasby wrote: > On 2/20/17 5:04 AM, Andres Freund wrote: > > On 2017-02-20 11:58:12 +0100, Petr Jelinek wrote: > > > That being said, I did wonder myself if we should just deprecate float > > > timestamps as well. > > > > I think we need a proper deprecation

Re: [HACKERS] Adding new output parameter of pg_stat_statements to identify operation of the query.

2017-02-21 Thread Jim Nasby
On 2/19/17 10:02 PM, Tom Lane wrote: Jim Nasby writes: Something that needs to be considered with doing this in pg_stat_statement is that a query that's reported there can contain multiple SQL statements. I don't remember offhand if all statements get parsed as a

[HACKERS] Performance degradation in TPC-H Q18

2017-02-21 Thread Kuntal Ghosh
Hello everyone, While conducting the experiments for parallelism, Rafia came across a hang in Q18 when plan uses partial and finalize hash aggregate. This could be seen on both scale factors - 20 and 300, on setting work_mem high enough so that the query uses hash aggregate. It seems that commit

Re: [HACKERS] Allow pg_dumpall to work without pg_authid

2017-02-21 Thread Robins Tharakan
Stephen, On 20 February 2017 at 08:50, Stephen Frost wrote: > The other changes to use pg_roles instead of pg_authid when rolpassword > isn't being used look like they should just be changed to use pg_roles > instead of using one or the other. That should be an independent

Re: [HACKERS] drop support for Python 2.3

2017-02-21 Thread Peter Eisentraut
On 2/21/17 10:18, Tom Lane wrote: > Based on some not-fun I had along the way to that, I think it would be > a good idea to do the Python version check a bit earlier than you have > here. The shlib search in PGAC_CHECK_PYTHON_EMBED_SETUP is pretty fragile > and version-dependent, which means that

Re: [HACKERS] pg_dump does not refresh matviews from extensions

2017-02-21 Thread Stephen Frost
Jim, * Jim Nasby (jim.na...@bluetreble.com) wrote: > I think $SUBJECT is a bug. While it would be unusual for an > extension to have a matview, it's still allowed, and as it stands > right now that view won't be refreshed at the end of a restore, > unlike other matviews. > > I started looking

Re: [HACKERS] [doc fix] Really trivial fix for BRIN documentation

2017-02-21 Thread Tsunakawa, Takayuki
From: Simon Riggs [mailto:si...@2ndquadrant.com] > Pushed, but using "heap" rather than "table", for clarity. Thanks for the > patch. Thank you for responding so quickly. I'm comfortable with "heap." On the other hand, src/backend/access/brin/README uses "table" as follows. Second, I thought

Re: [HACKERS] dropping partitioned tables without CASCADE

2017-02-21 Thread Amit Langote
On 2017/02/21 20:17, Ashutosh Bapat wrote: > On Tue, Feb 21, 2017 at 12:05 PM, Amit Langote wrote: >> On 2017/02/20 21:49, Ashutosh Bapat wrote: >>> Here are some comments >>> >>> For the sake of readability you may want reverse the if and else order. >>> -recordDependencyOn(, ,

Re: [HACKERS] Speedup twophase transactions

2017-02-21 Thread Michael Paquier
On Wed, Feb 22, 2017 at 7:03 AM, Alvaro Herrera wrote: > I have pushed the TAP test file, which is already passing, at least for > me. Let's see what the buildfarm says. Thanks. I still have on my sheet to look at the latest 2PC patch. -- Michael -- Sent via

Re: [HACKERS] Speedup twophase transactions

2017-02-21 Thread Alvaro Herrera
I have pushed the TAP test file, which is already passing, at least for me. Let's see what the buildfarm says. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] "may be unused" warnings for gcc

2017-02-21 Thread Peter Eisentraut
On 2/20/17 09:41, Andres Freund wrote: > When building with a new-ish gcc (6.3.0 right now, but I've seen this > for a while) with optimization I get a number of warnings: These all look like related to inlining/-O3. I have attempted to fix these in the past, but I have found that -O3 doesn't

Re: [HACKERS] mat views stats

2017-02-21 Thread Peter Eisentraut
On 2/20/17 10:06, Jim Mlodgenski wrote: > I've come across a number of times where the statistics on materialized > views become stale producing bad plans. It turns out that autovacuum > only touches a materialized view when it is first created and ignores it > on a refresh. When you have a

Re: [HACKERS] Change in "policy" on dump ordering?

2017-02-21 Thread Peter Eisentraut
On 2/21/17 14:58, Jim Nasby wrote: > AFAICT in older versions only object types that absolutely had to wait > for DO_POST_DATA_BOUNDARY would do so. More recently though, objects are > being added after that (presumably because it's easier than renumbering > everything in dbObjectTypePriority).

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-02-21 Thread Peter Eisentraut
On 2/10/17 15:12, Robert Haas wrote: > Right. I can't see why you'd want to be able to separately control > those two things. If you're not dumping, you don't want to load; if > you're not loading, you don't want to dump. What about the case where you want to prewarm a standby from the info

Re: [HACKERS] Replication vs. float timestamps is a disaster

2017-02-21 Thread James Cloos
> "TL" == Tom Lane writes: TL> The question to be asked is whether there is still anybody out there TL> using float timestamps. Gentoo's ebuild includes: $(use_enable !pg_legacytimestamp integer-datetimes) \ meaning that by default --enable-integer-datetimes is

[HACKERS] Json support for array pseudotypes

2017-02-21 Thread Andrew Dunstan
The attached tiny patch lets the to_json(b) routines convert objects with array pseudotypes to json{b}. The main impetus for this came from my trying to convert the annyarray columns in pg_stats to json and finding that they ended up as text instead of json arrays. This way to_json on these

Re: [HACKERS] safer node casting

2017-02-21 Thread Jeff Janes
On Tue, Feb 21, 2017 at 9:00 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 1/26/17 16:15, Andres Freund wrote: > > On 2017-01-25 19:21:40 -0500, Tom Lane wrote: > >> Andres Freund writes: > >>> On 2016-12-31 12:08:22 -0500, Peter Eisentraut wrote: >

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-21 Thread Masahiko Sawada
On Wed, Feb 22, 2017 at 1:52 AM, Fujii Masao wrote: > On Tue, Feb 21, 2017 at 7:52 PM, Masahiko Sawada > wrote: >> On Tue, Feb 21, 2017 at 3:42 AM, Fujii Masao wrote: >>> On Thu, Feb 16, 2017 at 11:40 AM, Masahiko Sawada

Re: [HACKERS] pg_monitor role

2017-02-21 Thread Masahiko Sawada
On Mon, Feb 20, 2017 at 8:48 PM, Dave Page wrote: > Further to the patch I just submitted > (https://www.postgresql.org/message-id/CA%2BOCxow-X%3DD2fWdKy%2BHP%2BvQ1LtrgbsYQ%3DCshzZBqyFT5jOYrFw%40mail.gmail.com) > I'd like to propose the addition of a default role, pg_monitor. >

Re: [HACKERS] Walsender crash

2017-02-21 Thread Fujii Masao
On Mon, Feb 13, 2017 at 8:55 PM, Stas Kelvich wrote: > Hello. > > While playing with logical publications/subscriptions I’ve noted that > walsender crashes > when i’m trying to CREATE SUBSCRIPTION to a current server. > > So having one running postgres instance on a

Re: [HACKERS] SUBSCRIPTION command hangs up, segfault occurs in the server process and to cancel the execution.

2017-02-21 Thread Fujii Masao
On Wed, Feb 22, 2017 at 1:54 AM, Masahiko Sawada wrote: > On Tue, Feb 21, 2017 at 7:11 AM, nuko yokohama > wrote: >> Hi. >> While verifying the logical replication of PostgreSQL 10-devel, I found the >> following problem. Thanks for the problem

Re: [HACKERS] Resolved typo in a comment

2017-02-21 Thread Fujii Masao
On Mon, Feb 20, 2017 at 7:34 AM, neha khatri wrote: > Hi, > > Attached is a patch that fixes a comment typo in varlena.c Thanks! Pushed. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] IF (NOT) EXISTS in psql-completion

2017-02-21 Thread Pavel Stehule
2017-02-14 11:51 GMT+01:00 Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp>: > Thank you for the comment. > > At Mon, 6 Feb 2017 17:10:43 +0100, Pavel Stehule > wrote in mail.gmail.com> > > >

Re: [HACKERS] Measuring replay lag

2017-02-21 Thread Thomas Munro
On Tue, Feb 21, 2017 at 6:21 PM, Simon Riggs wrote: > And happier again, leading me to move to the next stage of review, > focusing on the behaviour emerging from the design. > > So my current understanding is that this doesn't rely upon LSN > arithmetic to measure lag,

Re: [HACKERS] Bold itemized list entries

2017-02-21 Thread Magnus Hagander
On Feb 13, 2017 8:45 AM, "Ashutosh Bapat" wrote: Hi Bulletted list in Devel branch are all showing up bold as seen in the screenshot of [1] attached. But the same page for 9.6 branch shows normal bulletted lists. If I try to bulid docs from the latest resources

[HACKERS] pg_dump does not refresh matviews from extensions

2017-02-21 Thread Jim Nasby
I think $SUBJECT is a bug. While it would be unusual for an extension to have a matview, it's still allowed, and as it stands right now that view won't be refreshed at the end of a restore, unlike other matviews. I started looking into a patch for this, but I'm not sure of the best way to

[HACKERS] Change in "policy" on dump ordering?

2017-02-21 Thread Jim Nasby
AFAICT in older versions only object types that absolutely had to wait for DO_POST_DATA_BOUNDARY would do so. More recently though, objects are being added after that (presumably because it's easier than renumbering everything in dbObjectTypePriority). Is this change a good or bad idea?

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-21 Thread Fujii Masao
On Tue, Feb 21, 2017 at 7:52 PM, Masahiko Sawada wrote: > On Tue, Feb 21, 2017 at 3:42 AM, Fujii Masao wrote: >> On Thu, Feb 16, 2017 at 11:40 AM, Masahiko Sawada >> wrote: >>> On Thu, Feb 16, 2017 at 7:52 AM, Petr Jelinek

[HACKERS] pg_upgrade loses security lables and COMMENTs on blobs

2017-02-21 Thread Stephen Frost
Greetings, When pg_upgrade calls pg_dump, it passes in "--schema-only", which is generally correct, except that this causes everything having to do with large objects to be excluded. That's still usually correct, because pg_upgrade will simply copy the pg_largeobject and pg_largeobject_metadata

Re: [HACKERS] SUBSCRIPTION command hangs up, segfault occurs in the server process and to cancel the execution.

2017-02-21 Thread Masahiko Sawada
On Tue, Feb 21, 2017 at 7:11 AM, nuko yokohama wrote: > Hi. > While verifying the logical replication of PostgreSQL 10-devel, I found the > following problem. > > * When you run the SUBSCRIPTION command against a table in the same > PostgreSQL server, hang up. > *

Re: [HACKERS] Documentation improvements for partitioning

2017-02-21 Thread Yugo Nagata
Hi, There is a very small typo that a comma is missing. Attached is the patch to fix it. On Wed, 15 Feb 2017 07:57:53 -0500 Robert Haas wrote: > On Wed, Feb 15, 2017 at 4:26 AM, Ashutosh Bapat > wrote: > > Noticed some typos in the

Re: [HACKERS] safer node casting

2017-02-21 Thread Peter Eisentraut
On 1/26/17 16:15, Andres Freund wrote: > On 2017-01-25 19:21:40 -0500, Tom Lane wrote: >> Andres Freund writes: >>> On 2016-12-31 12:08:22 -0500, Peter Eisentraut wrote: RestrictInfo *rinfo = castNode(RestrictInfo, lfirst(lc)); >> >>> Are you planning to add this / update

Re: [HACKERS] safer node casting

2017-02-21 Thread Tom Lane
Jeff Janes writes: > With commit 38d103763d14baddf3cbfe4b00b501059fc9447f, I'm now getting a > compiler warning: > indxpath.c: In function 'generate_bitmap_or_paths': > indxpath.c:1312: warning: unused variable 'rinfo' Me too, without asserts. Fixed.

Re: [HACKERS] Json support for array pseudotypes

2017-02-21 Thread Tom Lane
Andrew Dunstan writes: > The attached tiny patch lets the to_json(b) routines convert objects > with array pseudotypes to json{b}. The main impetus for this came from > my trying to convert the annyarray columns in pg_stats to json and > finding that they ended up

Re: [HACKERS] Json support for array pseudotypes

2017-02-21 Thread Andrew Dunstan
On 02/21/2017 06:01 PM, Tom Lane wrote: > Andrew Dunstan writes: >> The attached tiny patch lets the to_json(b) routines convert objects >> with array pseudotypes to json{b}. The main impetus for this came from >> my trying to convert the annyarray columns in