Re: [HACKERS] UPDATE of partition key

2017-05-18 Thread Amit Khandekar
On 17 May 2017 at 17:29, Rushabh Lathia wrote: > > > On Wed, May 17, 2017 at 12:06 PM, Dilip Kumar wrote: >> >> On Fri, May 12, 2017 at 4:17 PM, Amit Khandekar >> wrote: >> > Option 3 >> > >> > >> > BR, AR delete

Re: [HACKERS] [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur

2017-05-18 Thread Tsunakawa, Takayuki
From: Michael Paquier [mailto:michael.paqu...@gmail.com] > Does JDBC use something like that to make a difference between a failure > and a move-on-to-next-one? No, it just tries the next host. See the first while loop in org/postgresql/jdbc/core/v3/ConnectionFactoryImpl.java. > From

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-05-18 Thread Masahiko Sawada
On Thu, May 18, 2017 at 3:19 PM, Michael Paquier wrote: > On Thu, May 18, 2017 at 2:59 PM, Masahiko Sawada > wrote: >> It seems to me that it's not good idea to forcibly set ANALYZE in >> spite of ANALYZE option is not specified. One reason is

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-05-18 Thread Masahiko Sawada
On Thu, May 18, 2017 at 11:01 AM, Michael Paquier wrote: > On Thu, May 18, 2017 at 12:06 AM, Bossart, Nathan wrote: >> I agree with you here, too. I stopped short of allowing customers to >> explicitly provide per-table options, so the example

Re: [HACKERS] Hash Functions

2017-05-18 Thread Jeff Davis
On Wed, May 17, 2017 at 11:35 AM, Tom Lane wrote: > I think the question is whether we are going to make a distinction between > logical partitions (where the data division rule makes some sense to the > user) and physical partitions (where it needn't). I think it might be >

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-05-18 Thread Michael Paquier
On Thu, May 18, 2017 at 2:59 PM, Masahiko Sawada wrote: > It seems to me that it's not good idea to forcibly set ANALYZE in > spite of ANALYZE option is not specified. One reason is that it would > make us difficult to grep it from such as server log. I think It's > better

Re: [HACKERS] Removal of plaintext password type references

2017-05-18 Thread Heikki Linnakangas
On 05/15/2017 07:03 AM, Noah Misch wrote: On Thu, May 11, 2017 at 10:08:30AM +0900, Michael Paquier wrote: On Wed, May 10, 2017 at 10:22 PM, Michael Paquier wrote: On Wed, May 10, 2017 at 10:01 PM, Tom Lane wrote: Heikki Linnakangas

[HACKERS] Proposal: Improve bitmap costing for lossy pages

2017-05-18 Thread Dilip Kumar
I would like to propose a patch to improve the cost of bitmap heap scan that is sensitive to work_mem. Currently, in bitmap scan, we don't consider work_mem. Now, in cases when there are a lot of lossy pages bitmap scan gets selected that eventually leads to degraded performance. While

Re: [HACKERS] 10beta1/m68k: static assertion failed: "MAXALIGN too small to fit int32"

2017-05-18 Thread Christoph Berg
Re: Heikki Linnakangas 2017-05-18 > I'll commit that, barring objections. If you can verify that it fixes the > problem before that, that'd be great, otherwise I guess we'll find out some > time after the commit. Please go ahead, I don't think I have

[HACKERS] zajimavy clanek - par vychytavek v pg

2017-05-18 Thread Pavel Stehule
Ahoj viz http://blog.cleverelephant.ca/2017/05/great-postgresql.html Pavel

[HACKERS] Regression in join selectivity estimations when using foreign keys

2017-05-18 Thread David Rowley
I've been analyzing a reported regression case between a 9.5 plan and a 9.6 plan. I tracked this down to the foreign key join selectivity code, specifically the use_smallest_selectivity code which is applied to outer joins where the referenced table is on the outer side of the join. A vastly

Re: [HACKERS] [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur

2017-05-18 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Tsunakawa, > Takayuki > Done. I'll examine whether we can use SQLSTATE. I tried conceivable errors during connection. Those SQLSTATEs are as follows: [transient error (after which you may want

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

2017-05-18 Thread Ashutosh Bapat
On Thu, Apr 6, 2017 at 6:37 AM, Robert Haas wrote: > >> There's a relevant comment in 0006, build_joinrel_partition_info() >> (probably that name needs to change, but I will do that once we have >> settled on design) >> + /* >> +* Construct partition keys for the

Re: [HACKERS] Cached plans and statement generalization

2017-05-18 Thread Konstantin Knizhnik
On 15.05.2017 18:31, Robert Haas wrote: On Wed, May 10, 2017 at 12:11 PM, Konstantin Knizhnik wrote: Robert, can you please explain why using TRY/CATCH is not safe here: This is definitely not a safe way of using TRY/CATCH. This has been discussed many, many

[HACKERS] Typo in json.c

2017-05-18 Thread Daniel Gustafsson
Spotted while reading code, patch attached. cheers ./daniel typo-json.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in json.c

2017-05-18 Thread Heikki Linnakangas
On 05/18/2017 10:17 AM, Daniel Gustafsson wrote: Spotted while reading code, patch attached. Applied, thanks. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] 10beta1/m68k: static assertion failed: "MAXALIGN too small to fit int32"

2017-05-18 Thread Heikki Linnakangas
On 05/17/2017 10:39 PM, Christoph Berg wrote: Not sure if a lot of people still care about m68k, but it's still one of the unofficial Debian ports (it used to be the first non-x86 port done decades ago): gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels

Re: [HACKERS] UPDATE of partition key

2017-05-18 Thread Amit Kapila
On Wed, May 17, 2017 at 4:05 PM, Dilip Kumar wrote: > On Wed, May 17, 2017 at 3:15 PM, Amit Kapila wrote: >>> Earlier I thought that option1 is better but later I think that this >>> can complicate the situation as we are firing first BR update

Re: [HACKERS] transition table behavior with inheritance appears broken (was: Declarative partitioning - another take)

2017-05-18 Thread Amit Langote
On 2017/05/18 7:13, Thomas Munro wrote: > On Wed, May 17, 2017 at 7:42 PM, Thomas Munro > wrote: >> On Wed, May 17, 2017 at 6:04 PM, Amit Langote >> wrote: >>> targetRelInfo should instead be set to mtstate->rootResultRelInfo that was

Re: [HACKERS] [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur

2017-05-18 Thread Michael Paquier
On Thu, May 18, 2017 at 5:05 PM, Tsunakawa, Takayuki wrote: > So, how about trying connection to the next host when the class code is > neither 28, 3D, nor 42? > > Honestly, I'm not happy with this approach, for a maintenance reason that > others are worried

Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.

2017-05-18 Thread Tom Lane
Piotr Stefaniak writes: > That, I assume, would be me. Coincidentally, I'm about to push my fixes > upstream (FreeBSD). Before that happens, my changes can be obtained from > https://github.com/pstef/freebsd_indent and tested, if anyone wishes. I spent a little bit

Re: [HACKERS] Cached plans and statement generalization

2017-05-18 Thread Andres Freund
On 2017-05-18 11:57:57 +0300, Konstantin Knizhnik wrote: > From my own experience I found out that PG_TRY/PG_CATCH mechanism is not > providing proper cleanup (unlike C++ exceptions). Right, simply because there's no portable way to transparently do so. Would be possible on elf glibc platforms,

Re: [HACKERS] [POC] hash partitioning

2017-05-18 Thread Dilip Kumar
On Wed, May 17, 2017 at 2:07 PM, amul sul wrote: >> I would suggest "non-zero positive", since that's what we are using in >> the documentation. >> > > Understood, Fixed in the attached version. Why non-zero positive? We do support zero for the remainder right? -- Regards,

Re: [HACKERS] 10beta1/m68k: static assertion failed: "MAXALIGN too small to fit int32"

2017-05-18 Thread Andres Freund
On 2017-05-18 10:48:48 +0300, Heikki Linnakangas wrote: > If that's all that prevents it from working, by all means let's fix it. I > think this should do it, although I don't have a system to test it on: Yes, that's what I thought about doing too. > It adds a few instructions to check that on

Re: [HACKERS] WIP Patch: Precalculate stable functions, infrastructure v1

2017-05-18 Thread Andres Freund
Hi, On 2017-05-18 19:00:09 +0300, Marina Polyakova wrote: > > Here's v2 of the patches. Changes from v1: > > And here there's v3 of planning and execution: common executor steps for all > types of cached expression. I've not followed this thread, but just scanned this quickly because it

Re: [HACKERS] WIP Patch: Precalculate stable functions, infrastructure v1

2017-05-18 Thread Marina Polyakova
Here's v2 of the patches. Changes from v1: And here there's v3 of planning and execution: common executor steps for all types of cached expression. -- Marina Polyakova Postgres Professional: http://www.postgrespro.com The Russian Postgres CompanyFrom 5e89221251670526eb2b5750868ac73eee48f10b

Re: [HACKERS] [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur

2017-05-18 Thread Robert Haas
On Thu, May 18, 2017 at 7:06 AM, Michael Paquier wrote: > FWIW, I am of the opinion to not have an implementation based on any > SQLSTATE codes, as well as not doing something similar to JDBC. > Keeping things simple is one reason, a second is that the approach > taken

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-05-18 Thread Robert Haas
On Thu, May 18, 2017 at 2:45 AM, Masahiko Sawada wrote: > On Thu, May 18, 2017 at 3:19 PM, Michael Paquier > wrote: >> On Thu, May 18, 2017 at 2:59 PM, Masahiko Sawada >> wrote: >>> It seems to me that it's not good idea

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-05-18 Thread Masahiko Sawada
On Fri, May 19, 2017 at 12:03 AM, Tom Lane wrote: > Robert Haas writes: >> Ugh, really? Are we sure that the current behavior is anything other >> than a bug? The idea that VACUUM foo (a) implies ANALYZE doesn't >> really sit very well with me in the

Re: [HACKERS] Proposal: Improve bitmap costing for lossy pages

2017-05-18 Thread Robert Haas
On Thu, May 18, 2017 at 2:52 AM, Dilip Kumar wrote: > Most of the queries show decent improvement, however, Q14 shows > regression at work_mem = 4MB. On analysing this case, I found that > number of pages_fetched calculated by "Mackert and Lohman formula" is > very high

Re: [HACKERS] Hash Functions

2017-05-18 Thread Robert Haas
On Thu, May 18, 2017 at 1:53 AM, Jeff Davis wrote: > For instance, it makes little sense to have individual check > constraints, indexes, permissions, etc. on a hash-partitioned table. > It doesn't mean that we should necessarily forbid them, but it should > make us question

Re: [HACKERS] 10beta1 sequence regression failure on sparc64

2017-05-18 Thread Tom Lane
Christoph Berg writes: > *** 34,44 > --- 34,47 > CREATE SEQUENCE sequence_test7 AS bigint; > CREATE SEQUENCE sequence_test8 AS integer MAXVALUE 10; > CREATE SEQUENCE sequence_test9 AS integer INCREMENT BY -1; > + ERROR: MINVALUE (-9223372036854775808) is out

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-05-18 Thread Tom Lane
Robert Haas writes: > Ugh, really? Are we sure that the current behavior is anything other > than a bug? The idea that VACUUM foo (a) implies ANALYZE doesn't > really sit very well with me in the first place. I'd be more inclined > to reject that with an ERROR

Re: [HACKERS] statement_timeout is not working as expected with postgres_fdw

2017-05-18 Thread Robert Haas
On Wed, May 17, 2017 at 6:57 AM, Amit Kapila wrote: > +1. Why not similar behavior for any other statements executed in > this module by do_sql_command? The other cases are not quite the same situation. It would be good to accept interrupts in all cases, but there's no

Re: [HACKERS] Get stuck when dropping a subscription during synchronizing table

2017-05-18 Thread Robert Haas
On Wed, May 17, 2017 at 6:58 AM, Masahiko Sawada wrote: > I think the above changes can solve this issue but It seems to me that > holding AccessExclusiveLock on pg_subscription by DROP SUBSCRIPTION > until commit could lead another deadlock problem in the future. So I'd >

Re: [HACKERS] Get stuck when dropping a subscription during synchronizing table

2017-05-18 Thread Noah Misch
On Mon, May 15, 2017 at 03:28:14AM +, Noah Misch wrote: > On Mon, May 08, 2017 at 06:27:30PM +0900, Masahiko Sawada wrote: > > I encountered a situation where DROP SUBSCRIPTION got stuck when > > initial table sync is in progress. In my environment, I created > > several tables with some data

Re: [HACKERS] 10beta1 sequence regression failure on sparc64

2017-05-18 Thread Andres Freund
On 2017-05-18 10:11:48 -0400, Tom Lane wrote: > Christoph Berg writes: > > *** 34,44 > > --- 34,47 > > CREATE SEQUENCE sequence_test7 AS bigint; > > CREATE SEQUENCE sequence_test8 AS integer MAXVALUE 10; > > CREATE SEQUENCE sequence_test9 AS integer INCREMENT

Re: [HACKERS] 10beta1 sequence regression failure on sparc64

2017-05-18 Thread Peter Eisentraut
On 5/18/17 10:11, Tom Lane wrote: > Well, that's just wacko. Somehow sequence.c's init_params() must > be falling down on the job in selecting the right seqform->seqmin, > but I'm darned if I see anything that's either wrong or potentially > machine-dependent in that code. It almost looks like

Re: [HACKERS] 10beta1 sequence regression failure on sparc64

2017-05-18 Thread Christoph Berg
Re: Peter Eisentraut 2017-05-18 <7a4d3b0f-78da-2a5b-7f3b-8b3509c1e...@2ndquadrant.com> > If we had a typo or something in that code, the build farm should have > caught it by now. > > I would try compiling with lower -O and see what happens. Trying -O0 now. Re: Andres Freund 2017-05-18

Re: [HACKERS] different column orders in regression test database

2017-05-18 Thread Thomas Munro
On Fri, May 19, 2017 at 7:21 AM, Peter Eisentraut wrote: > But this is a bit more suspicious: > > Original: > > Table "public.mlparted11" > Column | Type | Collation | Nullable | Default > +-+---+--+- > b

Re: [HACKERS] NOT NULL constraints on range partition key columns

2017-05-18 Thread Robert Haas
On Tue, May 16, 2017 at 8:19 PM, Amit Langote wrote: > Thanks for the review. I updated the comments. I found several more places that also needed to be updated using 'git grep'. Committed with various additions. -- Robert Haas EnterpriseDB:

Re: [HACKERS] 10beta1/m68k: static assertion failed: "MAXALIGN too small to fit int32"

2017-05-18 Thread Heikki Linnakangas
On 05/18/2017 12:31 PM, Christoph Berg wrote: Re: Heikki Linnakangas 2017-05-18 I'll commit that, barring objections. If you can verify that it fixes the problem before that, that'd be great, otherwise I guess we'll find out some time after the

[HACKERS] different column orders in regression test database

2017-05-18 Thread Peter Eisentraut
When you dump out the regression test database and load it back in, a few tables end up with different column orders: Original: Table "public.f_star" Column | Type | Collation | Nullable | Default +--+---+--+- class |

Re: [HACKERS] different column orders in regression test database

2017-05-18 Thread Tom Lane
Peter Eisentraut writes: > When you dump out the regression test database and load it back in, a > few tables end up with different column orders: > ... > This table is part of a lengthy inheritance chain, so this might be > intentional or too hard to fix. This

Re: [HACKERS] different column orders in regression test database

2017-05-18 Thread Thomas Munro
On Fri, May 19, 2017 at 10:53 AM, Peter Eisentraut wrote: > On 5/18/17 16:21, Thomas Munro wrote: >> That's because if you attach a partition with a different column >> ordering, > > Is it intentional and sensible to allow that in the first place? Or was > it

Re: [HACKERS] different column orders in regression test database

2017-05-18 Thread Alvaro Herrera
Peter Eisentraut wrote: > On 5/18/17 16:21, Thomas Munro wrote: > > That's because if you attach a partition with a different column > > ordering, > > Is it intentional and sensible to allow that in the first place? Or was > it just inherited from inheritance? I think it was deliberately

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-05-18 Thread Michael Paquier
On Fri, May 19, 2017 at 12:03 AM, Tom Lane wrote: > Robert Haas writes: >> Ugh, really? Are we sure that the current behavior is anything other >> than a bug? Point was raised already upthread by me ince, which is what lead me to the reasoning of my

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-05-18 Thread Michael Paquier
On Fri, May 19, 2017 at 9:06 AM, Michael Paquier wrote: > I am fine with an ERROR if a column list is specified without ANALYZE > listed in the options. But that should happen as well for the case > where only one relation is listed. Perhaps this could be changed for

[HACKERS] fix for table syncing with different column order

2017-05-18 Thread Peter Eisentraut
The issues with the different column orders in the regression test database also revealed that logical replication table syncing was broken for that case. Here is a fix and a test. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA,

Re: [HACKERS] Documentation about pg_stat_bgwriter

2017-05-18 Thread Peter Eisentraut
On 5/10/17 04:38, Kyotaro HORIGUCHI wrote: > Hi. While I read the documentation I found the following > description about some columns in pg_stat_bgwriter. > > https://www.postgresql.org/docs/devel/static/monitoring-stats.html#pg-stat-bgwriter-view > > This table shows cluster-global values, not

Re: [HACKERS] Getting error at the time of dropping subscription and few more issues

2017-05-18 Thread Peter Eisentraut
On 5/12/17 13:25, Masahiko Sawada wrote: >> postgres=# alter subscription sub set publication pub refresh; >> NOTICE: removed subscription for table public.t1 >> NOTICE: removed subscription for table public.t2 >> ALTER SUBSCRIPTION >> >> I think - in publication too ,we should provide NOTICE

Re: [HACKERS] NOT NULL constraints on range partition key columns

2017-05-18 Thread Amit Langote
On 2017/05/19 3:06, Robert Haas wrote: > On Tue, May 16, 2017 at 8:19 PM, Amit Langote > wrote: >> Thanks for the review. I updated the comments. > > I found several more places that also needed to be updated using 'git > grep'. Committed with various additions.

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-05-18 Thread Michael Paquier
On Fri, May 19, 2017 at 10:00 AM, Tom Lane wrote: > Michael Paquier writes: >> On Fri, May 19, 2017 at 9:06 AM, Michael Paquier >> wrote: >>> I am fine with an ERROR if a column list is specified without ANALYZE >>>

Re: [HACKERS] Re: proposal - using names as primary names of plpgsql function parameters instead $ based names

2017-05-18 Thread Peter Eisentraut
On 5/15/17 14:34, Pavel Stehule wrote: > Now, I when I working on plpgsql_check, I have to check function > parameters. I can use fn_vargargnos and out_param_varno for list of > arguments and related varno(s). when I detect some issue, I am using > refname. It is not too nice now,

Re: [HACKERS] [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur

2017-05-18 Thread Michael Paquier
On Thu, May 18, 2017 at 11:30 PM, Robert Haas wrote: > On Thu, May 18, 2017 at 7:06 AM, Michael Paquier > wrote: >> FWIW, I am of the opinion to not have an implementation based on any >> SQLSTATE codes, as well as not doing something similar to

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-05-18 Thread Tom Lane
Michael Paquier writes: > On Fri, May 19, 2017 at 9:06 AM, Michael Paquier > wrote: >> I am fine with an ERROR if a column list is specified without ANALYZE >> listed in the options. But that should happen as well for the case >> where only

Re: [HACKERS] [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur

2017-05-18 Thread Peter Eisentraut
On 5/17/17 13:19, Tom Lane wrote: > I agree with Robert's point that major redesign of the feature on the > basis of one complaint isn't necessarily the way to go. Since the > existing behavior is already out in beta1, let's wait and see if anyone > else complains. We don't need to fix it Right

Re: [HACKERS] Getting error at the time of dropping subscription and few more issues

2017-05-18 Thread Masahiko Sawada
On Fri, May 19, 2017 at 9:54 AM, Peter Eisentraut wrote: > On 5/12/17 13:25, Masahiko Sawada wrote: >>> postgres=# alter subscription sub set publication pub refresh; >>> NOTICE: removed subscription for table public.t1 >>> NOTICE: removed subscription for

Re: [HACKERS] [BUGS] Concurrent ALTER SEQUENCE RESTART Regression

2017-05-18 Thread Andres Freund
On 2017-05-15 10:34:02 -0400, Peter Eisentraut wrote: > On 5/10/17 09:12, Michael Paquier wrote: > > Looking at 0001 and 0002... So you are correctly blocking nextval() > > when ALTER SEQUENCE holds a lock on the sequence object. And > > concurrent calls of nextval() don't conflict. As far as I

Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)

2017-05-18 Thread Tom Lane
Piotr Stefaniak writes: > On 2017-05-17 23:46, Tom Lane wrote: >> ... Much of what >> I'm seeing with this version is randomly different decisions about >> how far to indent comments > pgindent doesn't set the -c indent option ("The column in which comments > on code

Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.

2017-05-18 Thread Piotr Stefaniak
On 2017-05-18 18:13, Tom Lane wrote: > Piotr Stefaniak writes: >> That, I assume, would be me. Coincidentally, I'm about to push my fixes >> upstream (FreeBSD). Before that happens, my changes can be obtained from >> https://github.com/pstef/freebsd_indent and tested,

Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)

2017-05-18 Thread Piotr Stefaniak
On 2017-05-17 23:46, Tom Lane wrote: > I hacked around that by putting back a detab/entab step at the end > using the existing subroutines in pgindent. That about halved the > size of the diff, but it's still too big to post. Much of what > I'm seeing with this version is randomly different

Re: [HACKERS] different column orders in regression test database

2017-05-18 Thread Peter Eisentraut
On 5/18/17 16:21, Thomas Munro wrote: > That's because if you attach a partition with a different column > ordering, Is it intentional and sensible to allow that in the first place? Or was it just inherited from inheritance? > pg_dump dumps it with a normal CREATE TABLE ... PARTITION OF > ...

Re: [HACKERS] Fix refresh_option syntax of ALTER SUBSCRIPTION in document

2017-05-18 Thread Peter Eisentraut
On 5/17/17 01:26, Masahiko Sawada wrote: > While reading documentation I found refresh_option syntax of ALTER > SUBSCRIPTION in documentation is not correct. > > ALTER SUBSCRIPTION ... REFRESH PUBLICATION WITH (refresh_option value [, ...] > ) > should be changed to > ALTER SUBSCRIPTION ...

Re: [HACKERS] [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur

2017-05-18 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Peter Eisentraut > The problem is that if we decide to change the behavior mid-beta, then we'll > only have the rest of beta to find out whether people will like the other > behavior. > > I would

Re: [HACKERS] different column orders in regression test database

2017-05-18 Thread Peter Eisentraut
On 5/18/17 19:07, Thomas Munro wrote: > To make normal dump/restore preserve the order, we could either make > it *always* write create-then-attach, or do it only if required. I'd > vote for doing it only if required because of different column order, > because I don't want to see 1,000

Re: [HACKERS] [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur

2017-05-18 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Michael Paquier > > One thing I'm worried is that people here might become more conservative > against change once the final version is released. > > Any redesign after release would finish by

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-05-18 Thread Bossart, Nathan
On 5/18/17, 8:03 PM, "Tom Lane" wrote: >”Bossart, Nathan" writes: >> On 5/18/17, 6:12 PM, "Michael Paquier" wrote: >>> Fine for me as well. I would suggest to split the patch into two parts >>> to ease review then: >>> - Rework

Re: [HACKERS] Documentation about pg_stat_bgwriter

2017-05-18 Thread Kyotaro HORIGUCHI
Hello, thank you for the reply. At Thu, 18 May 2017 20:48:44 -0400, Peter Eisentraut wrote in <343d4cdb-e25d-867d-2830-6502eca4d...@2ndquadrant.com> > On 5/10/17 04:38, Kyotaro HORIGUCHI wrote: > > Hi. While I read the documentation I found the following > >

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-05-18 Thread Michael Paquier
On Fri, May 19, 2017 at 12:17 PM, Bossart, Nathan wrote: > Just in case it was missed among the discussion, I’d like to point out that > v5 of the patch includes the “ERROR if ANALYZE not specified” change. As long as I don't forget... +VACUUM vactst (i); Looking at the

Re: [HACKERS] [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur

2017-05-18 Thread Michael Paquier
On Fri, May 19, 2017 at 11:01 AM, Tsunakawa, Takayuki wrote: > From: pgsql-hackers-ow...@postgresql.org >> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Peter Eisentraut >> The problem is that if we decide to change the behavior mid-beta, then we'll >>

Re: [HACKERS] Replication status in logical replication

2017-05-18 Thread Masahiko Sawada
On Wed, Apr 12, 2017 at 5:31 AM, Simon Riggs wrote: > On 22 March 2017 at 02:50, Masahiko Sawada wrote: > >> When using logical replication, I ran into a situation where the >> pg_stat_replication.state is not updated until any wal record is sent >>

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-05-18 Thread Bossart, Nathan
On 5/18/17, 6:12 PM, "Michael Paquier" wrote: > Fine for me as well. I would suggest to split the patch into two parts > to ease review then: > - Rework this error handling for one relation. > - The main patch. I’d be happy to do so, but I think part one would be

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-05-18 Thread Tom Lane
"Bossart, Nathan" writes: > On 5/18/17, 6:12 PM, "Michael Paquier" wrote: >> Fine for me as well. I would suggest to split the patch into two parts >> to ease review then: >> - Rework this error handling for one relation. >> - The main patch. >

Re: [HACKERS] Re: proposal - using names as primary names of plpgsql function parameters instead $ based names

2017-05-18 Thread Pavel Stehule
2017-05-19 3:14 GMT+02:00 Peter Eisentraut : > On 5/15/17 14:34, Pavel Stehule wrote: > > Now, I when I working on plpgsql_check, I have to check function > > parameters. I can use fn_vargargnos and out_param_varno for list of > > arguments and

Re: [HACKERS] Race conditions with WAL sender PID lookups

2017-05-18 Thread Michael Paquier
On Thu, May 18, 2017 at 1:43 PM, Thomas Munro wrote: > On Thu, May 11, 2017 at 1:48 PM, Michael Paquier > wrote: >> I had my eyes on the WAL sender code this morning, and I have noticed >> that walsender.c is not completely consistent

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

2017-05-18 Thread Masahiko Sawada
On Wed, May 17, 2017 at 1:30 AM, Robert Haas wrote: > On Sat, May 13, 2017 at 7:27 AM, Amit Kapila wrote: >> On Fri, May 12, 2017 at 9:14 AM, Tom Lane wrote: >>> Robert Haas writes: On Wed, May 10,

Re: [HACKERS] [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur

2017-05-18 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Michael Paquier > On Thu, May 18, 2017 at 11:30 PM, Robert Haas wrote: > > Because why? > > Because it is critical to let the user know as well *why* an error happened. >

Re: [HACKERS] Get stuck when dropping a subscription during synchronizing table

2017-05-18 Thread Peter Eisentraut
On 5/18/17 11:11, Noah Misch wrote: > IMMEDIATE ATTENTION REQUIRED. This PostgreSQL 10 open item is past due for > your status update. Please reacquaint yourself with the policy on open item > ownership[1] and then reply immediately. If I do not hear from you by > 2017-05-19 16:00 UTC, I will

Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)

2017-05-18 Thread Tom Lane
I wrote: > Curiously, there are other enum declarations that don't get the phony > extra indentation. I traced through it a bit and eventually found that > the difference between OK and not OK is that the declarations that don't > get messed up look like "typedef enum enumlabel ...", ie the

Re: [HACKERS] Get stuck when dropping a subscription during synchronizing table

2017-05-18 Thread Kyotaro HORIGUCHI
Hello, At Thu, 18 May 2017 10:16:35 -0400, Robert Haas wrote in > On Wed, May 17, 2017 at 6:58 AM, Masahiko Sawada > wrote: > > I think the above changes can solve this issue but

Re: [HACKERS] transition table behavior with inheritance appears broken (was: Declarative partitioning - another take)

2017-05-18 Thread Kevin Grittner
On Thu, May 18, 2017 at 5:16 AM, Amit Langote wrote: > Do we need to update documentation? Perhaps, some clarification on the > inheritance/partitioning behavior somewhere. Yeah, I think so. > -Assert((enrmd->reliddesc == InvalidOid) != (enrmd->tupdesc ==

Re: [HACKERS] Disallowing multiple queries per PQexec()

2017-05-18 Thread Surafel Temesgen
hey Vaishnavi > > I think GUC's name can be something like "multiple_query_execution" and > setting it ON/OFF will be better. I think others will also come up with > some suggestions here as the current name doesn't go well with other > existing GUCs. > Thank you very much for the suggestion

Re: [HACKERS] different column orders in regression test database

2017-05-18 Thread Amit Langote
On 2017/05/19 11:02, Peter Eisentraut wrote: > On 5/18/17 19:07, Thomas Munro wrote: >> To make normal dump/restore preserve the order, we could either make >> it *always* write create-then-attach, or do it only if required. I'd >> vote for doing it only if required because of different column

Re: [HACKERS] [ANNOUNCE] PostgreSQL 10 Beta 1 Released!

2017-05-18 Thread Huong Dangminh
Hi, > * 10 Beta Release Notes: > https://www.postgresql.org/docs/devel/static/release-10.html Just a minute thing, but changing of hot_standby default value is not fully noted in release-10.sgml. Please find the attached patch. --- Thanks and best regards, Dang Minh Huong NEC Solution

[HACKERS] [Bug fix]If recovery.conf has target_session_attrs=read-write, the standby fails to start.

2017-05-18 Thread Higuchi, Daisuke
Hello, I found a problem with libpq connection failover. If primary_conninfo in recovery.conf has 'target_session_attrs=read-write', the standby fails to start. How to reproduce the bug: 1. Prepare two standby (standby_1, standby_2) for one master. On standby_1, primary_conninfo in

Re: [HACKERS] [Bug fix]If recovery.conf has target_session_attrs=read-write, the standby fails to start.

2017-05-18 Thread Michael Paquier
On Fri, May 19, 2017 at 1:16 PM, Higuchi, Daisuke wrote: > The reason of this problem is that sending 'show transaction_read_only' is > failed. > 'show' must be in uppercase letters because the streaming replication > protocol only accepts capital letters. > In

[HACKERS] Multiple table synchronizations are processed serially

2017-05-18 Thread Masahiko Sawada
Hi, While testing table synchronization in logical replication, I found that multiple table synchronizations for a subscription are processed serially due to lock wait. I setup pgbench tables on publisher (scalefactor = 1000) and on subscriber, and truncated these tables on subscriber, and then

Re: [HACKERS] transition table behavior with inheritance appears broken (was: Declarative partitioning - another take)

2017-05-18 Thread Thomas Munro
On Fri, May 19, 2017 at 1:38 AM, Kevin Grittner wrote: > On Thu, May 18, 2017 at 5:16 AM, Amit Langote > wrote: > >> Do we need to update documentation? Perhaps, some clarification on the >> inheritance/partitioning behavior somewhere. > > Yeah,

Re: [HACKERS] [POC] hash partitioning

2017-05-18 Thread Amit Langote
On 2017/05/19 1:09, Dilip Kumar wrote: > On Wed, May 17, 2017 at 2:07 PM, amul sul wrote: >>> I would suggest "non-zero positive", since that's what we are using in >>> the documentation. >>> >> >> Understood, Fixed in the attached version. > > Why non-zero positive? We do

Re: [HACKERS] transition table behavior with inheritance appears broken (was: Declarative partitioning - another take)

2017-05-18 Thread Amit Langote
On 2017/05/19 14:01, Thomas Munro wrote: > On Fri, May 19, 2017 at 1:38 AM, Kevin Grittner wrote: >> On Thu, May 18, 2017 at 5:16 AM, Amit Langote >> wrote: >> >>> Do we need to update documentation? Perhaps, some clarification on the >>>

[HACKERS] Re: [BUGS] BUG #14657: Server process segmentation fault in v10, May 10th dev snapshot

2017-05-18 Thread Sveinn Sveinsson
The patch fixed the problem, thanks a lot. Regards, Sveinn. On fim 18.maí 2017 01:53, Amit Langote wrote: > On 2017/05/18 10:49, Amit Langote wrote: >> On 2017/05/18 2:14, Dilip Kumar wrote: >>> On Wed, May 17, 2017 at 7:41 PM, wrote: (gdb) bt #0