Re: [HACKERS] PG10 Crash-safe and replicable Hash Indexes and UNIQUE

2017-05-21 Thread Chapman Flack
On 05/19/17 11:41, Tom Lane wrote: > No, nobody's done anything about allowing hash indexes to support > uniqueness AFAIK. I don't have a clear picture of how much work > it would be, but it would likely be more than trivial effort; I see what you mean. Because of the way hash values are

Re: [HACKERS] asynchronous execution

2017-05-21 Thread Kyotaro HORIGUCHI
Hello. At Tue, 04 Apr 2017 19:25:39 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170404.192539.29699823.horiguchi.kyot...@lab.ntt.co.jp> > The attached patch is rebased on the current master, but no > substantial changes other than disallowing

Re: [HACKERS] psql - add special variable to reflect the last query status

2017-05-21 Thread Pavel Stehule
Hi 2017-04-04 23:01 GMT+02:00 Pavel Stehule : > > > 2017-04-04 22:05 GMT+02:00 Fabien COELHO : > >> >> After some discussions about what could be useful since psql scripts now >> accepts tests, this patch sets a few variables which can be used by

Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)

2017-05-21 Thread Piotr Stefaniak
On 2017-05-22 01:50, Tom Lane wrote: > Being lazy, I just wiped my copy and re-cloned, but it still seems the > same as before ... last commit on the pass3 branch is from Mar 4. > What branch should I be paying attention to? Sorry for the trouble, this is because I interactively git-rebased it in

Re: [HACKERS] transition table behavior with inheritance appears broken (was: Declarative partitioning - another take)

2017-05-21 Thread Amit Langote
On 2017/05/20 9:01, Thomas Munro wrote: > On Sat, May 20, 2017 at 10:43 AM, Thomas Munro > wrote: >> On Fri, May 19, 2017 at 6:35 PM, Amit Langote >> wrote: >>> On 2017/05/19 15:16, Thomas Munro wrote: Would

Re: [HACKERS] [POC] hash partitioning

2017-05-21 Thread Ashutosh Bapat
On Fri, May 19, 2017 at 10:35 PM, Robert Haas wrote: > > + * For range and list partitioned tables, datums is an array of datum-tuples > + * with key->partnatts datums each. > + * For hash partitioned tables, it is an array of datum-tuples with 2 datums, > + * modulus and

Re: [HACKERS] Regression in join selectivity estimations when using foreign keys

2017-05-21 Thread David Rowley
On 21 May 2017 at 07:56, Tom Lane wrote: > I'm entirely unconvinced by this patch --- it seems to simply be throwing > away a lot of logic. Notably it lobotomizes the FK code altogether for > semi/antijoin cases, but you've not shown any example that even involves > such

Re: [HACKERS] asynchronous execution

2017-05-21 Thread Kyotaro HORIGUCHI
At Mon, 22 May 2017 13:12:14 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170522.131214.20936668.horiguchi.kyot...@lab.ntt.co.jp> > > The attached patch is rebased on the current master, but no > > substantial changes other than disallowing

Re: [HACKERS] Race conditions with WAL sender PID lookups

2017-05-21 Thread Erik Rijkers
On 2017-05-21 06:37, Erik Rijkers wrote: On 2017-05-20 14:40, Michael Paquier wrote: On Fri, May 19, 2017 at 3:01 PM, Masahiko Sawada wrote: Also, as Horiguchi-san pointed out earlier, walreceiver seems need the similar fix. Actually, now that I look at it,

Re: [HACKERS] proposal psql \gdesc

2017-05-21 Thread Fabien COELHO
Hello Pavel, v6 patch applies cleanly; make check ok; code, comments, doc & tests ok; various interactive tests I did ok. Thanks for this useful little feature! Let's see what committers think about it. -- Fabien. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] proposal psql \gdesc

2017-05-21 Thread Pavel Stehule
2017-05-21 8:39 GMT+02:00 Fabien COELHO : > > Hello Pavel, > > v6 patch applies cleanly; make check ok; code, comments, doc & tests ok; > various interactive tests I did ok. > > Thanks for this useful little feature! > > Let's see what committers think about it. Thank you

Re: [HACKERS] [Q] When should I use reg* types instead of oid in the system catalog?

2017-05-21 Thread MauMau
From: Tom Lane It's probably mostly historical accident :-(. There have been suggestions before to convert more system catalog columns to regfoo types, but there's serious stumbling blocks in the way: Thank you so much for concise detailed explanation of the history and current situation. I

Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)

2017-05-21 Thread Tom Lane
Piotr Stefaniak writes: > On 2017-05-21 03:00, Tom Lane wrote: >> I wrote: >>> Also, I found two places where an overlength comment line is simply busted >>> altogether --- notice that a character is missing at the split point: >> I found the cause of that: you need

Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)

2017-05-21 Thread Bruce Momjian
On Sun, May 21, 2017 at 10:12:20AM -0400, Tom Lane wrote: > Piotr Stefaniak writes: > > On 2017-05-21 03:00, Tom Lane wrote: > >> I wrote: > >>> Also, I found two places where an overlength comment line is simply busted > >>> altogether --- notice that a character is

Re: [HACKERS] Variable substitution in psql backtick expansion

2017-05-21 Thread Fabien COELHO
Thanks for the pointer. I grepped for them without success. Here is a v4. I am sending a review of this patch. This patch has trivial implementation - and there are not any objection to used new variable names. 1. there was not any problem with patching, compiling 2. all regress tests

Re: [HACKERS] Causal reads take II

2017-05-21 Thread Dmitry Dolgov
Hi I'm wondering about status of this patch and how can I try it out? > On 3 January 2017 at 02:43, Thomas Munro wrote: > The replay lag tracking patch this depends on is in the current commitfest I assume you're talking about this patch [1] (at least it's the

Re: [HACKERS] WIP: [[Parallel] Shared] Hash

2017-05-21 Thread Thomas Munro
On Thu, Apr 27, 2017 at 11:03 AM, Thomas Munro wrote: > On Thu, Apr 27, 2017 at 5:13 AM, Oleg Golovanov wrote: >> Can you actualize your patch set? The error got from >> 0010-hj-parallel-v12.patch. > > I really should get around to setting up a

[HACKERS] Patch: add --if-exists to pg_recvlogical

2017-05-21 Thread Rosser Schwarz
Hackers, While doing some scripting around pg_recvlogical at $work, I found a need for $subject. Attached, find a patch to that effect. I tried simply to mirror the logic used elsewhere. I don't think there's anything controversial here, but welcome any comments or suggestions. This applies and

Re: [HACKERS] [ANNOUNCE] PostgreSQL 10 Beta 1 Released!

2017-05-21 Thread Huong Dangminh
> From: Bruce Momjian [mailto:br...@momjian.us] > Sent: Saturday, May 20, 2017 1:11 AM > On Fri, May 19, 2017 at 04:10:09AM +, Huong Dangminh wrote: > > Hi, > > > > > * 10 Beta Release Notes: > > > https://www.postgresql.org/docs/devel/static/release-10.html > > > > Just a minute thing, but

Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)

2017-05-21 Thread Tom Lane
Piotr Stefaniak writes: >> * const unsigned(*TABLE_index)[2]; >> * OffsetNumber(*findChildPtr) (GinBtree, Page, BlockNumber, OffsetNumber); >> * an overlength comment line is simply busted altogether > Fixed and pushed to my github repository. I'm pretty confused by

[HACKERS] translatable string fixes

2017-05-21 Thread Alvaro Herrera
I noticed this entry while updating the translation for 9.6: #: catalog/index.c:3456 commands/vacuumlazy.c:1345 commands/vacuumlazy.c:1421 #: commands/vacuumlazy.c:1610 commands/vacuumlazy.c:1820 #, c-format msgid "%s." msgstr "%s." All of these correspond to errdetail printing pg_rusage_show()

Re: [HACKERS] Causal reads take II

2017-05-21 Thread Thomas Munro
On Mon, May 22, 2017 at 4:10 AM, Dmitry Dolgov <9erthali...@gmail.com> wrote: > I'm wondering about status of this patch and how can I try it out? Hi Dmitry, thanks for your interest. >> On 3 January 2017 at 02:43, Thomas Munro >> wrote: >> The replay lag tracking

Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)

2017-05-21 Thread Piotr Stefaniak
> * const unsigned(*TABLE_index)[2]; > * OffsetNumber(*findChildPtr) (GinBtree, Page, BlockNumber, OffsetNumber); > * an overlength comment line is simply busted altogether Fixed and pushed to my github repository. Note that indent won't wrap long lines like links or paths anymore. But obviously

Re: [HACKERS] Allowing dash character in LTREE

2017-05-21 Thread Manuel Kniep
Manuel Kniep Danziger Str. 116 10405 Berlin > Am 20.05.2017 um 10:27 schrieb Cyril Auburtin : > > It could be useful to allow the `-` char in allowed LTREE label characters > (currently a-zA-Z0-9_ >

[HACKERS] Location of PG_CATALOG_VERSION

2017-05-21 Thread Vicky Vergara
Hello all The postgreSQL version is needed internally in order to make the code work because for example the type of funcctx->max_calls changed on 9.6 uint64_t result_count = 0; ... #if PGSQL_VERSION > 95 funcctx->max_calls = result_count; #else funcctx->max_calls =

Re: [HACKERS] Location of PG_CATALOG_VERSION

2017-05-21 Thread Tom Lane
Vicky Vergara writes: > From this message: > https://www.postgresql.org/message-id/1585.1472410329%40sss.pgh.pa.us > I deduced that in the code I can use > PG_CATALOG_VERSION No, sorry, thinko on my part. It's CATALOG_VERSION_NO, from , that people usually use for

[HACKERS] Fix a typo in hash.c

2017-05-21 Thread Masahiko Sawada
Hi, Attached patch for $subject. s/curent/current/ Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center fix_typo_in_hash_c.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Multiple table synchronizations are processed serially

2017-05-21 Thread Masahiko Sawada
On Sat, May 20, 2017 at 4:47 AM, Peter Eisentraut wrote: > On 5/19/17 01:01, Masahiko Sawada wrote: >> Seems all four table sync workers are launched at the almost same >> time, but three workers of them get stuck in idle transaction state >> when creating

[HACKERS] Default Partition for Range

2017-05-21 Thread Beena Emerson
Hello, Many were in favour of the default partition for tables partitioned by range [1]. Please find attached the WIP patch for the same which can be applied over the default_partition_v12.patch. Syntax: Same as agreed for list: CREATE PARTITION PARTITION OF DEFAULT; Default Constraint:

Re: [HACKERS] Adding support for Default partition in partitioning

2017-05-21 Thread Beena Emerson
Hello, Patch for default range partition has been added. PFA the rebased v12 patch for the same. I have not removed the has_default variable yet. Default range partition: https://www.postgresql.org/message-id/CAOG9ApEYj34fWMcvBMBQ-YtqR9fTdXhdN82QEKG0SVZ6zeL1xg%40mail.gmail.com -- Beena Emerson

Re: [HACKERS] Re: [doc fix] PG10: wroing description on connect_timeout when multiple hosts are specified

2017-05-21 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Robert Haas > Committed. I also added a slight tweak to the wording of the documentation. Thank you, the doc looks clearer. Regards Takayuki Tsunakawa -- Sent via pgsql-hackers mailing list