[HACKERS] Typo in drop_publication.sgml

2017-06-18 Thread Julien Rouhaud
Patch attached. -- Julien Rouhaud http://dalibo.com - http://dalibo.org diff --git a/doc/src/sgml/ref/drop_publication.sgml b/doc/src/sgml/ref/drop_publication.sgml index 517d142251..8e45a43982 100644 --- a/doc/src/sgml/ref/drop_publication.sgml +++ b/doc/src/sgml/ref/drop_publication.sgml @@

[HACKERS] Typo in insert.sgml

2017-06-18 Thread Julien Rouhaud
Patch attached. -- Julien Rouhaud http://dalibo.com - http://dalibo.org diff --git a/doc/src/sgml/ref/insert.sgml b/doc/src/sgml/ref/insert.sgml index 94dad00870..0e327e5b2e 100644 --- a/doc/src/sgml/ref/insert.sgml +++ b/doc/src/sgml/ref/insert.sgml @@ -228,7 +228,7 @@ INSERT INTO table_name [

Re: [HACKERS] Typo in drop_publication.sgml

2017-06-18 Thread Julien Rouhaud
On Sun, Jun 18, 2017 at 07:42:54PM +0200, Magnus Hagander wrote: > On Sun, Jun 18, 2017 at 8:46 AM, Julien Rouhaud > wrote: > > > Patch attached. > > > > Applied, thanks. > Thanks. -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers

Re: [HACKERS] transition table behavior with inheritance appears broken

2017-06-18 Thread Andrew Gierth
> "Andrew" == Andrew Gierth writes: Andrew> Unfortunately I've been delayed over the past couple of days, Andrew> but I have Thomas' latest patchset in hand and will be working Andrew> on it over the rest of the week. Status update by 23:59 BST on Andrew> Sun

Re: [HACKERS] Parallel Aggregation support for aggregate functions that use transitions not implemented for array_agg

2017-06-18 Thread Tomas Vondra
Hi, On 6/7/17 5:52 AM, Regina Obe wrote: On 6/6/17 13:52, Regina Obe wrote: It seems CREATE AGGREGATE was expanded in 9.6 to support parallelization of aggregate functions using transitions, with the addition of serialfunc and deserialfunc to the aggregate definitions.

Re: [HACKERS] how are the rpms configured that are available in PostgreSQL RPM Building Project - Yum Repository

2017-06-18 Thread Cook, Malcolm
Great – perfect – and …. I have one installed – we will investigate… From: David G. Johnston [mailto:david.g.johns...@gmail.com] Sent: Friday, June 16, 2017 8:59 PM To: Cook, Malcolm Cc: pgsql-hackers@PostgreSQL.org; McGee, Jenny Subject: Re: [HACKERS] how

Re: [HACKERS] Decimal64 and Decimal128

2017-06-18 Thread Thomas Munro
On Mon, Jun 19, 2017 at 2:24 AM, Tom Lane wrote: > Robert Haas writes: >> On Sat, Jun 17, 2017 at 11:58 PM, Thomas Munro >> wrote: >>> On Sun, Jun 18, 2017 at 2:31 PM, Robert Haas wrote: What

Re: [HACKERS] WIP: Data at rest encryption

2017-06-18 Thread Tomas Vondra
Hi all, I've noticed this thread got resurrected a few days ago, but I haven't managed to read all the messages until today. I do have a bunch of comments, but let me share them as a single consistent message instead of sending a thousand responses to individual messages. 1) Threat model

Re: [HACKERS] Transition tables vs ON CONFLICT

2017-06-18 Thread Andrew Gierth
> "Thomas" == Thomas Munro writes: Thomas> That accidentally removed a comment that I wanted to keep. Thomas> Here is a better version. I plan to commit this soon; if anyone has any comment to make, now would be a good time. -- Andrew (irc:RhodiumToad)

Re: [HACKERS] improve release-note for pg_current_logfile()

2017-06-18 Thread Tatsuo Ishii
>>> Add function pg_current_logfile() to read syslog's current stderr and >>> csvlog output file names (Gilles Darold) >> >> This confused me because "syslog" is one of method for logging as well >> as stderr and csvlog. I guess it is intended syslogger, but I think that >> "logging collector"

Re: [HACKERS] INSERT ... ON CONFLICT () SELECT

2017-06-18 Thread Peter Geoghegan
On Sun, Jun 18, 2017 at 4:33 AM, Matt Pulver wrote: > This would be nearly identical to the existing error message that is > produced when running: > > INSERT INTO example (name) VALUES ('foo'), ('foo') > ON CONFLICT (name) DO UPDATE SET value=1 > RETURNING * > > >

Re: [HACKERS] Preliminary results for proposed new pgindent implementation

2017-06-18 Thread Tom Lane
Peter Eisentraut writes: > On 6/16/17 10:51, Tom Lane wrote: >> So I'm back to the position that we ought to stick the indent >> code under src/tools/ in our main repo. Is anyone really >> seriously against that? > I think it would be better to have it

Re: [HACKERS] GSoC 2017: Foreign Key Arrays

2017-06-18 Thread Alexander Korotkov
On Sun, Jun 18, 2017 at 12:41 AM, Mark Rofail wrote: > *Questions:* > >- I'd like to check that anyelem and anyarray have the same element >type. but anyelem is obtained from PG_FUNCTION_ARGS as a Datum. How >can I make such a check? > > As I know, it's

Re: [HACKERS] Typo in drop_publication.sgml

2017-06-18 Thread Magnus Hagander
On Sun, Jun 18, 2017 at 8:46 AM, Julien Rouhaud wrote: > Patch attached. > Applied, thanks. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: [HACKERS] Making server name part of the startup message

2017-06-18 Thread narlapurams
Thank you, Alvaro, Andres, Magnus, Peter, and Tom for your thoughts! I consolidated all the responses, and provided the high level overview of the Azure PostgreSQL database architecture, and provided additional details at the bottom of the message. > Tom Lane: We don't actually have any concept

Re: [HACKERS] PG10 transition tables, wCTEs and multiple operations on the same table

2017-06-18 Thread Andrew Gierth
> "Thomas" == Thomas Munro writes: Thomas> Thanks both for the review. New version of patch #2 attached. I'm looking to commit this soon; if anyone has any further comment now would be a good time to speak up. -- Andrew (irc:RhodiumToad) -- Sent via

Re: [HACKERS] psql - add special variable to reflect the last query status

2017-06-18 Thread Pavel Stehule
2017-06-17 7:58 GMT+02:00 Fabien COELHO : > > I have not any other comments. The implementation is trivial. I rerun all >> tests and tests passed. >> >> I'll mark this patch as ready for commiters. >> > > Oops, I just noticed a stupid confusion on my part which got through, I

[HACKERS] PATCH: Making constant StringInfo

2017-06-18 Thread Craig Ringer
Hi all TL;DR: formalize using StringInfo over an existing buffer as a cursor for pq_getmsg. In src/backend/replication/logical/worker.c we intern a pre-existing string in a StringInfo so it can be used with the pq_getmsg functions etc. StringInfoData s;

Re: [HACKERS] Directory pg_replslot is not properly cleaned

2017-06-18 Thread Andres Freund
Hi, On 2017-06-07 15:46:45 -0300, Fabrízio de Royes Mello wrote: > > >> Just adding Dimitriy to conversation... previous email I provided was > > >wrong. > > >> > > > > > >Does anyone have some thought about this critical issue? > > > > > > > I plan to look into it over the next few days. > > >

Re: [HACKERS] proposal psql \gdesc

2017-06-18 Thread Pavel Stehule
2017-06-16 8:45 GMT+02:00 Fabien COELHO : > > Hello Pavel, > > new update - rebase, changed message >> > > I did yet another rebase of your patch after Tom alphabetically ordered > backslash commands. Here is the result. It looks well Thank you Pavel > > > -- > Fabien.

[HACKERS] REPLICA IDENTITY FULL

2017-06-18 Thread Tatsuo Ishii
While playing around with logical replication, I am confused by the behavior of REPLICA IDENTITY FULL. First I created a table having 2 INT columns with no keys. If I execute ALTER TABLE REPLICA IDENTITY FULL, replication for UPDATE/DELETE works. In the session below, port 11002 is the publisher

Re: [HACKERS] Something is rotten in publication drop

2017-06-18 Thread Noah Misch
On Thu, Jun 15, 2017 at 02:04:04AM +, Noah Misch wrote: > On Fri, Jun 09, 2017 at 11:45:58AM -0400, Tom Lane wrote: > > Peter Eisentraut writes: > > > On 6/8/17 23:53, Tom Lane wrote: > > >> ! ERROR: publication "addr_pub" does not exist > > > > > The \d+

Re: [HACKERS] Getting server crash on Windows when using ICU collation

2017-06-18 Thread Ashutosh Sharma
Hi, On Sun, Jun 18, 2017 at 6:39 PM, Amit Kapila wrote: > On Sat, Jun 17, 2017 at 8:27 PM, Ashutosh Sharma > wrote: >> Hi, >> >> On Sat, Jun 17, 2017 at 6:38 PM, Peter Eisentraut >> wrote: >>> On 6/16/17 23:46,

Re: [HACKERS] UPDATE of partition key

2017-06-18 Thread Amit Khandekar
When I tested partition-key-update on a partitioned table having no child partitions, it crashed. This is because there is an Assert(mtstate->mt_num_partitions > 0) for creating the partition-to-root map, which fails if there are no partitions under the partitioned table. Actually we should skp

Re: [HACKERS] outfuncs.c utility statement support

2017-06-18 Thread Tom Lane
Peter Eisentraut writes: > An empty token produces "<>", so just debackslashing wouldn't work. pg_strtok recognizes "<>" and returns length = 0, so debackslash() would produce the right answer AFAICS (admittedly, I haven't tested). But I don't really want to do

Re: [HACKERS] Decimal64 and Decimal128

2017-06-18 Thread Tom Lane
Robert Haas writes: > On Sat, Jun 17, 2017 at 11:58 PM, Thomas Munro > wrote: >> On Sun, Jun 18, 2017 at 2:31 PM, Robert Haas wrote: >>> What would be the point of that? >> We'd accept and display the new SQL:2016

Re: [HACKERS] Getting server crash on Windows when using ICU collation

2017-06-18 Thread Amit Kapila
On Sat, Jun 17, 2017 at 8:27 PM, Ashutosh Sharma wrote: > Hi, > > On Sat, Jun 17, 2017 at 6:38 PM, Peter Eisentraut > wrote: >> On 6/16/17 23:46, Amit Kapila wrote: >>> I have just posted one way >>> to determine if icu library has support

Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index

2017-06-18 Thread Shubham Barai
Hi, Please find the updated patch here. Regards, Shubham On 16 June 2017 at 15:54, Shubham Barai wrote: > Hi, hackers! > > I have created my first patch for predicate locking in gist index. It > includes a test for verification of serialization failures and a test to

Re: [HACKERS] Decimal64 and Decimal128

2017-06-18 Thread Robert Haas
On Sat, Jun 17, 2017 at 11:58 PM, Thomas Munro wrote: > On Sun, Jun 18, 2017 at 2:31 PM, Robert Haas wrote: >> On Sat, Jun 17, 2017 at 3:50 PM, Thomas Munro >> wrote: >>> On Sun, Jun 18, 2017 at 5:38 AM, Robert

Re: [HACKERS] initdb initalization failure for collation "ja_JP"

2017-06-18 Thread Tom Lane
Marco Atzeri writes: > Building on Cygwin latest 10 beta1 or head sourece, > make check fails as: > ... > performing post-bootstrap initialization ... 2017-05-31 23:23:22.214 > CEST [16860] FATAL: collation "ja_JP" for encoding "EUC_JP" already exists Hmph. Could we

Re: [HACKERS] INSERT ... ON CONFLICT () SELECT

2017-06-18 Thread Matt Pulver
On Sat, Jun 17, 2017 at 9:55 PM, Peter Geoghegan wrote: > On Sat, Jun 17, 2017 at 7:49 AM, Matt Pulver > wrote: > > With the proposed "INSERT ... ON CONFLICT () SELECT" feature, the > > get_or_create_id() function is simplified to: > > Are you locking