Re: [HACKERS] Default Partition for Range

Hello Dilip, On Wed, Jun 21, 2017 at 6:27 PM, Dilip Kumar wrote: > On Tue, Jun 20, 2017 at 6:57 PM, Dilip Kumar wrote: >> This is basically crashing in RelationBuildPartitionDesc, so I think >> we don't have any test case for testing DEFAULT range

Re: [HACKERS] Multi column range partition table

On Fri, Jun 30, 2017 at 1:36 PM, Amit Langote wrote: > > Alright, I spent some time implementing a patch to allow specifying > -infinity and +infinity in arbitrary ways. Of course, it prevents > nonsensical inputs with appropriate error messages. I don't think

Re: [HACKERS] [PATCH] Generic type subscripting

On Wednesday, 10 May 2017 23:43:10 MSK, Dmitry Dolgov wrote: > So, a few words about current state of the patch: > > * after a lot of serious improvements general design of this feature is > agreeable > > * we introduced a lot of small changes to polish it > > * I rebased the patch on the

[HACKERS] Fix doc of DROP SUBSCRIPTION

Hi, The documentation says that a subscription that has a replication slot cannot be dropped in a transaction block, but it is not allowed even outside of a transaction block. Attached is a patch to fix it. Regards, -- Yugo Nagata diff --git

[HACKERS] Fix a typo in aclchk.c

Hi, Attached patch for $subject. s/entires/entries/ Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center fix_typo_in_aclchk_c.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

On Mon, May 22, 2017 at 12:02 PM, Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote: > > Here's set of patches rebased on latest head. > In an attempt to test this set of patches, I found that not all of the patches could be applied on latest head-- commit

Re: [HACKERS] Multi column range partition table

On 2017/06/23 17:00, Dean Rasheed wrote: > On 23 June 2017 at 08:01, Ashutosh Bapat > wrote: >> The way we have designed our syntax, we don't have a way to tell that >> p3 comes after p2 and they have no gap between those. But I don't >> think that's your

Re: [HACKERS] pg_stop_backup(wait_for_archive := true) on standby server

On Thu, Jun 29, 2017 at 10:30 PM, Magnus Hagander wrote: > On Thu, Jun 22, 2017 at 6:22 PM, Masahiko Sawada > wrote: >> >> On Thu, Jun 22, 2017 at 10:36 PM, Magnus Hagander >> wrote: >> > >> > >> > On Thu, Jun 22, 2017 at 10:12

Re: [HACKERS] Parallel Append implementation

On Tue, Apr 4, 2017 at 12:37 PM, Amit Khandekar wrote: > Attached is an updated patch v13 that has some comments changed as per > your review, and also rebased on latest master. > This is not applicable on the latest head i.e. commit --

Re: [HACKERS] Apparent walsender bug triggered by logical replication

On 30/06/17 04:46, Tom Lane wrote: > Petr Jelinek writes: >> On 30/06/17 02:07, Tom Lane wrote: >>> I'm also kind of wondering why the "behind the apply" path out of >>> LogicalRepSyncTableStart exists at all; as far as I can tell we'd be much >>> better off if we

Re: [HACKERS] Bug in ExecModifyTable function and trigger issues for foreign tables

On 2017/06/16 21:29, Etsuro Fujita wrote: On 2017/06/16 19:26, Ashutosh Bapat wrote: That issue has not been addressed. The reason stated was that it would make code complicated. But I have not had chance to look at how complicated would be and assess myself whether that's worth the trouble.

[HACKERS] Parallel COPY FROM execution

Greetings pgsql-hackers, I am a GSOC student this year, my initial proposal has been discussed in the following thread https://www.postgresql.org/message-id/flat/7179F2FD-49CE-4093-AE14-1B26C5DFB0DA%40gmail.com Patch with COPY FROM errors handling seems to be quite finished, so I have started

[HACKERS] Postgres process invoking exit resulting in sh-QUIT core

Hi, We are using Postgres version 9.3.14 over linux based OS and we are observing sh-QUIT core files randomly when we are restarting the system(occurrence seen once in 30 times). Backtrace is showing as below: Loaded symbols for /lib64/ld.so.1 Core was generated by `sh -c exit 1'. Program

Re: [HACKERS] Code quality issues in ICU patch

On 6/24/17 11:51, Tom Lane wrote: > Ah, I was about to suggest the same thing, but I was coming at it from > the standpoint of not requiring buffers several times larger than > necessary, which could in itself cause avoidable palloc failures. > > I was going to suggest a small variant actually:

Re: [HACKERS] Adding support for Default partition in partitioning

Hi, On Mon, Jun 19, 2017 at 12:34 PM, Amit Langote < langote_amit...@lab.ntt.co.jp> wrote: > On 2017/06/16 14:16, Ashutosh Bapat wrote: > > On Fri, Jun 16, 2017 at 12:48 AM, Robert Haas > wrote: > >> On Thu, Jun 15, 2017 at 12:54 PM, Ashutosh Bapat > >>

Re: [HACKERS] Fix doc of DROP SUBSCRIPTION

On Fri, Jun 30, 2017 at 7:01 PM, Yugo Nagata wrote: > Hi, > > The documentation says that a subscription that has a replication slot > cannot be dropped in a transaction block, but it is not allowed even > outside of a transaction block. Hmm, I think we can drop a

Re: [HACKERS] Postgres process invoking exit resulting in sh-QUIT core

On 30 June 2017 at 17:41, K S, Sandhya (Nokia - IN/Bangalore) wrote: > When we checked the process listing during the time of core generation, we > found Postgres startup process is invoking “sh -c exit 1”: > 4518 9249 0.1 0.0 155964 2036 ?Ss 15:05 0:00

Re: [HACKERS] Parallel COPY FROM execution

2017-06-30 15:45 GMT+02:00 Pavel Stehule : > > > 2017-06-30 15:42 GMT+02:00 Alex K : > >> On Fri, Jun 30, 2017 at 3:35 PM, Pavel Stehule >> wrote: >> > >> > >> > 2017-06-30 14:23 GMT+02:00 Alex K

Re: [HACKERS] "SELECT *" vs hidden columns and logical column order

On Wed, Jun 28, 2017 at 11:52 PM, Thomas Munro wrote: > I am aware of at three potential projects that would change the > meaning of "SELECT *": > > 1. Incremental MATERIALIZED VIEW maintenance probably needs to be > able to use a hidden counter column which you

Re: [HACKERS] Small comment fix in partition.c

On Wed, Jun 28, 2017 at 5:11 AM, Masahiko Sawada wrote: > Attached patch for $subject. > A period is missing at the end of sentence. Seems reasonable. Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via

Re: [HACKERS] Fix doc of DROP SUBSCRIPTION

On Fri, 30 Jun 2017 20:17:39 +0900 Masahiko Sawada wrote: > On Fri, Jun 30, 2017 at 7:01 PM, Yugo Nagata wrote: > > Hi, > > > > The documentation says that a subscription that has a replication slot > > cannot be dropped in a transaction block, but

Re: [HACKERS] Parallel COPY FROM execution

On Fri, Jun 30, 2017 at 3:35 PM, Pavel Stehule wrote: > > > 2017-06-30 14:23 GMT+02:00 Alex K : >> >> Thus, it results in a ~60% performance boost per each x2 multiplication of >> parallel processes, which is consistent with the initial

Re: [HACKERS] Parallel COPY FROM execution

2017-06-30 15:42 GMT+02:00 Alex K : > On Fri, Jun 30, 2017 at 3:35 PM, Pavel Stehule > wrote: > > > > > > 2017-06-30 14:23 GMT+02:00 Alex K : > >> > >> Thus, it results in a ~60% performance boost per each x2

Re: [HACKERS] CREATE COLLATION definitional questions for ICU

On 6/25/17 11:45, Tom Lane wrote: > * Also (and this would be a pre-existing bug), why doesn't the FROM > path copy the old collation's encoding? For example, if you attempted > to clone the "C" encoding, you wouldn't get a true clone but something > that's specific to the current DB's encoding.

Re: [HACKERS] Broken hint bits (freeze)

On Fri, Jun 30, 2017 at 6:26 AM, Bruce Momjian wrote: > On Wed, Jun 28, 2017 at 10:11:35PM -0400, Bruce Momjian wrote: >> On Fri, Jun 23, 2017 at 06:17:47PM +0300, Sergey Burladyan wrote: >> > PS: >> > I successfully upgraded last night from 9.2 to 9.4 and find other issue :-)

Re: [HACKERS] Request more documentation for incompatibility of parallelism and plpgsql exec_run_select

> On Jun 29, 2017, at 8:55 PM, Mark Dilger wrote: > > > Changing myfunc to create a temporary table, to execute the sql to populate > that temporary table, and to then loop through the temporary table's rows > fixes the problem. For the real-world example where I hit

Re: [HACKERS] CREATE COLLATION definitional questions for ICU

On 6/25/17 11:45, Tom Lane wrote: > * Now that it's possible for user-created collations to have encoding -1, > I do not think that the "shadowing" tests in CollationCreate and > IsThereCollationInNamespace are sufficient. They don't prevent a new > collation with encoding -1 from shadowing an

Re: [HACKERS] CREATE COLLATION definitional questions for ICU

On 6/25/17 11:45, Tom Lane wrote: > * For an ICU collation, should we not insist that collcollate and > collctype be equal? If not, what does it mean for them to be different? I have fixed that for now by enforcing them to be the same. In the longer term, I'm thinking about converting these two

Re: [HACKERS] Fix doc of DROP SUBSCRIPTION

On 30/06/17 15:17, Yugo Nagata wrote: > On Fri, 30 Jun 2017 20:17:39 +0900 > Masahiko Sawada wrote: > >> On Fri, Jun 30, 2017 at 7:01 PM, Yugo Nagata wrote: >>> Hi, >>> >>> The documentation says that a subscription that has a replication slot >>>

Re: [HACKERS] CREATE COLLATION definitional questions for ICU

On 6/27/17 11:17, Tom Lane wrote: > Moreover, if you insist on defining it this way, it's going to limit > our freedom of action in future. It's possible that, either in some > future version of ICU or for some other provider, there could be more > than one version of a collation simultaneously

Re: [HACKERS] Incorrect mentions to pg_xlog in walmethods.c/h

On 6/27/17 01:26, Michael Paquier wrote: > I have noticed $subject. A patch is attached. Those comments are not > completely wrong either as pg_basebackup can generate pg_xlog as well, > still I would recommend to just mention "pg_wal". committed -- Peter Eisentraut

Re: [HACKERS] Get stuck when dropping a subscription during synchronizing table

On 6/29/17 23:39, Noah Misch wrote: > IMMEDIATE ATTENTION REQUIRED. This PostgreSQL 10 open item is long past due > for your status update. Please reacquaint yourself with the policy on open > item ownership[1] and then reply immediately. If I do not hear from you by > 2017-07-01 04:00 UTC, I

Re: [HACKERS] CREATE COLLATION definitional questions for ICU

Peter Eisentraut writes: > On 6/25/17 11:45, Tom Lane wrote: >> * Now that it's possible for user-created collations to have encoding -1, >> I do not think that the "shadowing" tests in CollationCreate and >> IsThereCollationInNamespace are sufficient. They

[HACKERS] Re: pg_ctl wait exit code (was Re: [COMMITTERS] pgsql: Additional tests for subtransactions in recovery)

On 5/1/17 12:19, Peter Eisentraut wrote: > On 4/27/17 08:41, Michael Paquier wrote: >> +$node_slave->promote; >> +$node_slave->poll_query_until('postgres', >> + "SELECT NOT pg_is_in_recovery()") >> + or die "Timed out while waiting for promotion of standby"; >> >> This reminds me that we should

Re: [HACKERS] Typo in comment in xlog.c: ReadRecord

On 6/27/17 20:54, Amit Langote wrote: > Attached fixes $SUBJECT. > > s/fetch_ckpt/fetching_ckpt/g committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] pg_stop_backup(wait_for_archive := true) on standby server

Peter, all, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > On 6/30/17 04:08, Masahiko Sawada wrote: > >> I'm not sure. I think this can be considered a bug in the implementation > >> for > >> 10, and as such is "open for fixing". However, it's not a very critical bug > >> so I

Re: [HACKERS] Fix a typo in aclchk.c

On 6/30/17 03:58, Masahiko Sawada wrote: > Attached patch for $subject. > > s/entires/entries/ fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] pg_stop_backup(wait_for_archive := true) on standby server

On 6/30/17 04:08, Masahiko Sawada wrote: >> I'm not sure. I think this can be considered a bug in the implementation for >> 10, and as such is "open for fixing". However, it's not a very critical bug >> so I doubt it should be a release blocker, but if someone wants to work on a >> fix I think we

Re: [HACKERS] Out of date comment in predicate.c

On 6/27/17 01:21, Thomas Munro wrote: > Commit ea9df812d8502fff74e7bc37d61bdc7d66d77a7f got rid of > FirstPredicateLockMgrLock, but it's still referred to in a comment in > predicate.c where the locking protocol is documented. I think it's > probably best to use the name of the macro that's

Re: [HACKERS] UPDATE of partition key

On Fri, Jun 30, 2017 at 12:01 AM, Amit Khandekar wrote: > On 29 June 2017 at 07:42, Amit Langote wrote: >> Hi Amit, >> >> On 2017/06/28 20:43, Amit Khandekar wrote: >>> In attached patch v12 >> >> The patch no longer applies and fails to

Re: [HACKERS] [PATCH] doc: Fix typo

On Fri, Jun 30, 2017 at 2:50 PM, Peter Eisentraut wrote: > On 6/28/17 07:54, Zero King wrote: >> --- >> doc/src/sgml/installation.sgml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/doc/src/sgml/installation.sgml

Re: [HACKERS] "SELECT *" vs hidden columns and logical column order

On 6/28/17 23:52, Thomas Munro wrote: > 2. SQL:2011 temporal tables track system time and/or valid time with > columns that users create and then declare to be temporal control > columns. I don't think they show up unless you name them directly (I > didn't check the standard but I noticed that

Re: [HACKERS] Typo in comment in postgres_fdw.c

On 6/28/17 09:53, Albe Laurenz wrote: > Attached is a fix for a small typo I found. committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Misleading comment in slru.h

On 6/27/17 01:43, Thomas Munro wrote: > As mentioned in another thread[1], slru.h says: > > * Note: slru.c currently assumes that segment file names will be four hex > * digits. This sets a lower bound on the segment size (64K transactions > * for 32-bit TransactionIds). > > That comment

Re: [HACKERS] [PATCH] doc: Fix typo

On 6/28/17 07:54, Zero King wrote: > --- > doc/src/sgml/installation.sgml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml > index becf868..809cacb 100644 > --- a/doc/src/sgml/installation.sgml > +++

Re: [HACKERS] UPDATE of partition key

On Thu, Jun 29, 2017 at 3:52 PM, Amit Khandekar wrote: > So to conclude, I think, we can do this : > > Scenario 1 : > Only one partitioned table : the root; rest all are leaf partitions. > In this case, it is definitely efficient to just check the root > partition key,

Re: [HACKERS] Race conditions with WAL sender PID lookups

Michael Paquier wrote: > On Thu, Jun 29, 2017 at 7:52 AM, Alvaro Herrera > wrote: > > I think I'm done with the walsender half of this patch; I still need to > > review the walreceiver part. I will report back tomorrow 19:00 CLT. > > Thanks! > > > Currently, I'm

Re: [HACKERS] Incorrect mentions to pg_xlog in walmethods.c/h

On Sat, Jul 1, 2017 at 3:41 AM, Peter Eisentraut wrote: > On 6/27/17 01:26, Michael Paquier wrote: >> I have noticed $subject. A patch is attached. Those comments are not >> completely wrong either as pg_basebackup can generate pg_xlog as well, >> still I would

Re: [HACKERS] Apparent walsender bug triggered by logical replication

I wrote: > I've been poking into the src/test/subscription TAP tests, thinking > that they seem a lot slower than they ought to be. The first thing > I came across was this bit in WaitForReplicationWorkerAttach(): > /* > * We need timeout because we generally don't get notified

Re: [HACKERS] Small comment fix in partition.c

On Fri, Jun 30, 2017 at 11:02 PM, Robert Haas wrote: > On Wed, Jun 28, 2017 at 5:11 AM, Masahiko Sawada > wrote: >> Attached patch for $subject. >> A period is missing at the end of sentence. > > Seems reasonable. Committed. > Thank you! --

Re: [HACKERS] Parallel COPY FROM execution

2017-06-30 14:23 GMT+02:00 Alex K : > Greetings pgsql-hackers, > > I am a GSOC student this year, my initial proposal has been discussed > in the following thread > https://www.postgresql.org/message-id/flat/7179F2FD-49CE- > 4093-AE14-1B26C5DFB0DA%40gmail.com > >