[HACKERS] moving some partitioning code to executor

2017-09-14 Thread Amit Langote
Hi. It seems to me that some of the code in partition.c is better placed somewhere under the executor directory. There was even a suggestion recently [1] to introduce a execPartition.c to house some code around tuple-routing. IMO, catalog/partition.c should present an interface for handling

Re: [HACKERS] Surjective functional indexes

2017-09-14 Thread Konstantin Knizhnik
On 13.09.2017 14:00, Simon Riggs wrote: On 13 September 2017 at 11:30, Konstantin Knizhnik wrote: The only reason of all this discussion about terms is that I need to choose name for correspondent index option. Simon think that we do not need this option at all.

Re: [HACKERS] [PATCH] Call RelationDropStorage() for broader range of object drops.

2017-09-14 Thread Alvaro Herrera
Hadi Moshayedi wrote: > To provide more context, in cstore_fdw creating the storage is easy, we > only need to hook into CREATE FOREIGN TABLE using event triggers. Removing > the storage is not that easy, for DROP FOREIGN TABLE we can use event > triggers. This all sounds a little more

Re: [HACKERS] Surjective functional indexes

2017-09-14 Thread Simon Riggs
On 14 September 2017 at 10:42, Konstantin Knizhnik wrote: > > > On 13.09.2017 14:00, Simon Riggs wrote: >> >> On 13 September 2017 at 11:30, Konstantin Knizhnik >> wrote: >> >>> The only reason of all this discussion about terms is that I

Re: [HACKERS] Setting pd_lower in GIN metapage

2017-09-14 Thread Michael Paquier
On Thu, Sep 14, 2017 at 6:36 PM, Amit Kapila wrote: > Why do we need to change metapage at every place for btree ... I have been hunting for some time places where meta buffers were marked as dirtied and logged. So in the effort, I think that my hands and mind got

Re: [HACKERS] Allow GiST opcalsses without compress\decompres functions

2017-09-14 Thread Dmitriy Sarafannikov
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed This is simple and intuitive patch. Code looks pretty clear

[HACKERS] Re: [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur

2017-09-14 Thread Tsunakawa, Takayuki
Hello, Robert, Noah From: Robert Haas [mailto:robertmh...@gmail.com] > On Fri, Jul 28, 2017 at 1:30 AM, Noah Misch wrote: > > We've reached that period. If anyone is going to push for a change > > here, now is the time. Absent such arguments, the behavior won't change. > >

Re: [HACKERS] Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b

2017-09-14 Thread Dean Rasheed
On 13 September 2017 at 10:05, Amit Langote wrote: > Coincidentally, I just wrote the patch for canonicalizing stored values, > instead of erroring out. Please see attached if that's what you were > thinking too. > Looks reasonable to me, if we decide to go this

Re: [HACKERS] Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b

2017-09-14 Thread Dean Rasheed
On 13 September 2017 at 14:51, Robert Haas wrote: > Coincidentally, I wrote a patch for this too, but mine goes back to > rejecting MINVALUE or MAXVALUE followed by anything else. > LGTM, if we decide to go this way. One minor review comment -- you missed an example code

[HACKERS] Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b

2017-09-14 Thread Dean Rasheed
On 14 September 2017 at 03:49, Noah Misch wrote: > On Wed, Sep 13, 2017 at 12:06:40PM -0400, Robert Haas wrote: >> OK, thanks. I still don't really like allowing this, but I can see >> that compatibility with other systems has some value here, and if >> nobody else is

Re: [HACKERS] SCRAM in the PG 10 release notes

2017-09-14 Thread Alvaro Hernandez
On 14/09/17 08:57, Heikki Linnakangas wrote: On 09/12/2017 04:09 AM, Noah Misch wrote: On Wed, May 10, 2017 at 10:50:51PM -0400, Bruce Momjian wrote: On Mon, May 1, 2017 at 08:12:51AM -0400, Robert Haas wrote: On Tue, Apr 25, 2017 at 10:16 PM, Bruce Momjian wrote: Well,

Re: [HACKERS] [PATCH] Add citext_pattern_ops to citext contrib module

2017-09-14 Thread Alexey Chernyshov
On Tue, 12 Sep 2017 12:59:20 -0400 Tom Lane wrote: > Quick comment on this patch: recently, we've decided that having > patches replace the whole base script for an extension is too much of > a maintenance problem, especially when there are several patches in > the pipeline

Re: [HACKERS] [PATCH] Improve geometric types

2017-09-14 Thread Kyotaro HORIGUCHI
At Tue, 12 Sep 2017 19:30:44 +0200, Emre Hasegeli wrote in

Re: [HACKERS] Optimise default partition scanning while adding new partition

2017-09-14 Thread Jeevan Ladhe
Thanks Amit for reviewing. Patch looks fine to me. By the way, why don't we just say "Can we skip > scanning part_rel?" in the comment before the newly added call to > PartConstraintImpliedByRelConstraint()? We don't need to repeat the > explanation of what it does at the every place we call

Re: [HACKERS] [POC] hash partitioning

2017-09-14 Thread amul sul
On Wed, Sep 13, 2017 at 7:43 PM, Jesper Pedersen wrote: > Hi Amul, > > On 09/08/2017 08:40 AM, amul sul wrote: > >> Rebased 0002 against this commit & renamed to 0001, PFA. >> >> > This patch needs a rebase. > > Thanks for your note. ​ ​ Attached is the patch rebased

Re: [HACKERS] Setting pd_lower in GIN metapage

2017-09-14 Thread Amit Kapila
On Thu, Sep 14, 2017 at 12:30 PM, Michael Paquier wrote: > On Wed, Sep 13, 2017 at 4:43 PM, Amit Langote > wrote: >> Sure, no problem. > > > +* > +* This won't be of any help unless we use option like REGBUF_STANDARD > +*

Re: [HACKERS] uninterruptible state in 10beta4

2017-09-14 Thread Andres Freund
On 2017-09-13 14:46:08 -0700, Jeff Janes wrote: > On Wed, Sep 13, 2017 at 2:41 PM, Andres Freund wrote: > > Indeed that seems plausible. I guess something like the attached should > > fix the issue? > > > > Yep, that fixes it. Cool. Pushed. Thanks for the report! Thanks,

Re: [HACKERS] POC: Cache data in GetSnapshotData()

2017-09-14 Thread Mithun Cy
On Wed, Sep 13, 2017 at 7:24 PM, Jesper Pedersen wrote: > I have done a run with this patch on a 2S/28C/56T/256Gb w/ 2 x RAID10 SSD > machine. > > Both for -M prepared, and -M prepared -S I'm not seeing any improvements (1 > to 375 clients); e.g. +-1%. My test was

Re: [HACKERS] uninterruptible state in 10beta4

2017-09-14 Thread Andres Freund
On 2017-09-13 17:53:44 -0400, Tom Lane wrote: > Andres Freund writes: > > Indeed that seems plausible. I guess something like the attached should > > fix the issue? > > Ah, I see you came to the same conclusion I did. But see comment > about adding a comment. I've pushed

Re: [HACKERS] Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b

2017-09-14 Thread Amit Langote
On 2017/09/14 16:53, Dean Rasheed wrote: > On 13 September 2017 at 10:05, Amit Langote > wrote: >> Coincidentally, I just wrote the patch for canonicalizing stored values, >> instead of erroring out. Please see attached if that's what you were >> thinking too. >> >

Re: [HACKERS] Race between SELECT and ALTER TABLE NO INHERIT

2017-09-14 Thread Kyotaro HORIGUCHI
At Wed, 13 Sep 2017 20:20:48 -0400, Robert Haas wrote in > On Mon, Jun 26, 2017 at 4:46 AM, Kyotaro HORIGUCHI > wrote: > > The cause is that NO INHERIT doesn't take an

Re: [HACKERS] Warnings "unrecognized node type" for some DDLs with log_statement = 'ddl'

2017-09-14 Thread Ashutosh Sharma
On Thu, Sep 14, 2017 at 9:24 AM, Michael Paquier wrote: > Hi all, > > While reviewing another patch, I have bumped into a couple of failures > when running installcheck if log_statement = 'ddl'. This pops > regression failures for 4 tests: object_address, alter_generic,

[HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-14 Thread Anthony Bykov
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:tested, failed Hello, As far as I understand, this patch adds functionality

Re: [HACKERS] SCRAM in the PG 10 release notes

2017-09-14 Thread Michael Paquier
On Thu, Sep 14, 2017 at 3:57 PM, Heikki Linnakangas wrote: > I updated the list of drivers on the wiki > (https://wiki.postgresql.org/wiki/List_of_drivers), adding a column for > whether the driver supports SCRAM authentication. Currently, the only > non-libpq driver that has

Re: [HACKERS] moving some partitioning code to executor

2017-09-14 Thread Amit Langote
Repeating links for better accessibility: On 2017/09/14 16:13, Amit Langote wrote: > [1] https://www.postgresql.org/message-id/CA%2BTgmoafr%3DhUrM%3Dcbx-k%3DBDHOF2OfXaw95HQSNAK4mHBwmSjtw%40mail.gmail.com > [2]

Re: [HACKERS] Patches that don't apply or don't compile: 2017-09-12

2017-09-14 Thread Aleksander Alekseev
Hi Martin, > > === Build Failed: 7 === > > Title: Fix the optimization to skip WAL-logging on table created in same > > transaction > > Author: Martijn van Oosterhout > > URL: https://commitfest.postgresql.org/14/528/ > > I'm not the author of this patch, and the page

Re: [HACKERS] expanding inheritance in partition bound order

2017-09-14 Thread Amit Khandekar
On 14 September 2017 at 06:43, Amit Langote > langote_amit...@lab.ntt.co.jp> wrote: > Attached updated patch. @@ -1222,151 +1209,130 @@ PartitionDispatch * RelationGetPartitionDispatchInfo(Relation rel, int *num_parted, List

Re: [HACKERS] Log LDAP "diagnostic messages"?

2017-09-14 Thread Ashutosh Bapat
On Wed, Sep 13, 2017 at 6:58 AM, Thomas Munro wrote: > On Tue, Sep 12, 2017 at 11:23 PM, Ashutosh Bapat > wrote: >> On Wed, Aug 16, 2017 at 11:13 AM, Ashutosh Bapat >> wrote: >>> On Wed, Aug 16,

Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the same transaction

2017-09-14 Thread Alvaro Herrera
Peter Eisentraut wrote: > On 9/13/17 09:56, Alvaro Herrera wrote: > > Tom Lane wrote: > >> Peter Eisentraut writes: > > > >>> - Disallow DROP SUBSCRIPTION in a transaction under certain > >>> circumstances, for example if a transaction has previously manipulated

Re: [HACKERS] Fix performance degradation of contended LWLock on NUMA

2017-09-14 Thread Jesper Pedersen
On 09/11/2017 11:01 AM, Jesper Pedersen wrote: Thanks for working on this ! Moved to "Ready for Committer". Best regards,  Jesper -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] psql: new help related to variables are not too readable

2017-09-14 Thread Alvaro Herrera
Tom Lane wrote: > "David G. Johnston" writes: > >​If I was going to try and read it like a book I'd want the extra > > white-space to make doing so easier (white-space gives the eye a breather > > when done with a particular concept) - and the length wouldn't really >

Re: [HACKERS] [PATCH] pageinspect function to decode infomasks

2017-09-14 Thread Craig Ringer
On 14 September 2017 at 19:57, Ashutosh Sharma wrote: > > Are you planning to work on the review comments from Robert, Moon > Insung and supply the new patch. I just had a quick glance into this > mail thread (after a long time) and could understand Robert's concern >

Re: [HACKERS] Log LDAP "diagnostic messages"?

2017-09-14 Thread Alvaro Herrera
BTW I added --with-ldap and --with-pam to the configure line for the reports in coverage.postgresql.org and the % covered in auth.c went from 24% to 18.9% (from very bad to terribly sad). -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote

Re: [HACKERS] psql: new help related to variables are not too readable

2017-09-14 Thread Pavel Stehule
2017-09-14 15:17 GMT+02:00 Alvaro Herrera : > Tom Lane wrote: > > "David G. Johnston" writes: > > >​If I was going to try and read it like a book I'd want the extra > > > white-space to make doing so easier (white-space gives the eye a >

Re: [HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-14 Thread Pavel Stehule
Hi 2017-09-14 12:33 GMT+02:00 Anthony Bykov : > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: not tested > Documentation:

Re: [HACKERS] no test coverage for ALTER FOREIGN DATA WRAPPER name HANDLER ...

2017-09-14 Thread Ashutosh Bapat
On Wed, Sep 13, 2017 at 1:46 PM, Amit Langote wrote: >> >> Ok. May be then create_function_1.sql is the right place. Just add it >> to the section of passing tests and annotate that it's testing >> creating an FDW handler. Sorry for jumping back and forth. > >

Re: [HACKERS] PATCH : Generational memory allocator (was PATCH: two slab-like memory allocators)

2017-09-14 Thread Simon Riggs
On 14 August 2017 at 01:35, Tomas Vondra wrote: > Hi, > > Attached is a rebased version of the Generational context, originally > submitted with SlabContext (which was already committed into Pg 10). > > The main change is that I've abandoned the pattern of defining a

Re: [HACKERS] [PATCH] pageinspect function to decode infomasks

2017-09-14 Thread Ashutosh Sharma
Hi Craig, On Thu, Aug 17, 2017 at 5:50 AM, Craig Ringer wrote: > On 16 August 2017 at 23:14, Robert Haas wrote: >> >> On Tue, Aug 15, 2017 at 4:36 PM, Tomas Vondra >> wrote: >> > You might say that people investigating

Re: [HACKERS] Parallel Hash take II

2017-09-14 Thread Thomas Munro
On Thu, Sep 14, 2017 at 11:57 AM, Thomas Munro wrote: > On Thu, Sep 14, 2017 at 12:51 AM, Prabhat Sahu > wrote: >> Setting with lower "shared_buffers" and "work_mem" as below, query getting >> crash but able to see explain plan. > >

Re: [HACKERS] Log LDAP "diagnostic messages"?

2017-09-14 Thread Alvaro Herrera
I think the ldap_unbind() changes should be in a separate preliminary patch to be committed separately and backpatched. The other bits looks fine, with nitpicks 1. please move the new support function to the bottom of the section dedicated to LDAP, and include a prototype 2. please wrap lines

Re: [HACKERS] Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b

2017-09-14 Thread Stephen Frost
Robert, all, * Robert Haas (robertmh...@gmail.com) wrote: > On Wed, Sep 13, 2017 at 10:49 PM, Noah Misch wrote: > >> > Both Oracle and MySQL allow finite values after MAXVALUE (usually > >> > listed as "0" in code examples, e.g. see [1]). Oracle explicitly > >> > documents the

Re: [HACKERS] [POC] hash partitioning

2017-09-14 Thread Jesper Pedersen
Hi, On 09/14/2017 12:05 PM, Robert Haas wrote: On Thu, Sep 14, 2017 at 11:39 AM, Jesper Pedersen wrote: When I do CREATE TABLE mytab ( a integer NOT NULL, b integer NOT NULL, c integer, d integer ) PARTITION BY HASH (b); and create 64 partitions;

Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256

2017-09-14 Thread Peter Eisentraut
On 9/12/17 19:03, Michael Paquier wrote: > Once channel binding is involved though.. This needs to be extended > and this needs careful thoughts: > * "scram-sha-256" means that the version without channel binding is > accepted. "!scram-sha-256" means that scram without channel binding is >

Re: [HACKERS] [POC] hash partitioning

2017-09-14 Thread Jesper Pedersen
On 09/14/2017 12:56 PM, Robert Haas wrote: On Thu, Sep 14, 2017 at 12:54 PM, David Fetter wrote: Should we be pointing the gun away from people's feet by making hash partitions that cover the space automagically when the partitioning scheme[1] is specified? In other words,

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-09-14 Thread Peter Eisentraut
On 9/12/17 16:39, Michael Banck wrote: > We could split up the logic here and create the optional physical > replication slot in the main connection and the temporary one in the WAL > streamer connection, but this would keep any fragility around for > (likely more frequently used) temporary

Re: [HACKERS] Surjective functional indexes

2017-09-14 Thread Simon Riggs
On 14 September 2017 at 16:37, Konstantin Knizhnik wrote: > > > On 14.09.2017 13:19, Simon Riggs wrote: >> This works by looking at overall stats, and only looks at the overall >> HOT %, so its too heavyweight and coarse. >> >> I suggested storing stat info on the

Re: [HACKERS] [POC] hash partitioning

2017-09-14 Thread Robert Haas
On Thu, Sep 14, 2017 at 11:39 AM, Jesper Pedersen wrote: > When I do > > CREATE TABLE mytab ( > a integer NOT NULL, > b integer NOT NULL, > c integer, > d integer > ) PARTITION BY HASH (b); > > and create 64 partitions; > > CREATE TABLE mytab_p00 PARTITION OF

Re: [HACKERS] Parallel Append implementation

2017-09-14 Thread Amit Khandekar
On 11 September 2017 at 18:55, Amit Kapila wrote: >>> Do you think non-parallel-aware Append >>> will be better in any case when there is a parallel-aware append? I >>> mean to say let's try to create non-parallel-aware append only when >>> parallel-aware append is not

Re: [HACKERS] additional contrib test suites

2017-09-14 Thread David Steele
On 9/8/17 1:32 PM, Peter Eisentraut wrote: > > Yes, some of the error messages had changed. Fixed patches attached. Patches apply and all tests pass. A few comments: * [PATCH v2 1/7] adminpack: Add test suite There are no regular tests for pg_logdir_ls(). It looks like TAP tests would be

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

2017-09-14 Thread Robert Haas
On Wed, Sep 13, 2017 at 10:57 PM, Amit Langote wrote: > I very much like pcinfo-for-subquery.patch, although I'm not sure if we > need to create PartitionedChildRelInfo for the sub-query parent RTE as the > patch teaches add_paths_to_append_rel() to do. ISTM,

Re: [HACKERS] SCRAM in the PG 10 release notes

2017-09-14 Thread Dave Cramer
On 14 September 2017 at 02:21, Alvaro Hernandez wrote: > > > On 14/09/17 08:57, Heikki Linnakangas wrote: > >> On 09/12/2017 04:09 AM, Noah Misch wrote: >> >>> On Wed, May 10, 2017 at 10:50:51PM -0400, Bruce Momjian wrote: >>> On Mon, May 1, 2017 at 08:12:51AM -0400,

Re: [HACKERS] A bug in mapping attributes in ATExecAttachPartition()

2017-09-14 Thread Robert Haas
On Thu, Sep 14, 2017 at 12:59 AM, Amit Langote wrote: > Since Jeevan Ladhe mentioned this patch [1] earlier this week, sending the > rebased patches here for consideration. Actually there are only 2 patches > now, because 0002 above is rendered unnecessary by

Re: [HACKERS] Surjective functional indexes

2017-09-14 Thread Konstantin Knizhnik
On 14.09.2017 13:19, Simon Riggs wrote: On 14 September 2017 at 10:42, Konstantin Knizhnik wrote: On 13.09.2017 14:00, Simon Riggs wrote: On 13 September 2017 at 11:30, Konstantin Knizhnik wrote: The only reason of all this

Re: [HACKERS] Parallel Append implementation

2017-09-14 Thread Robert Haas
On Mon, Sep 11, 2017 at 9:25 AM, Amit Kapila wrote: > I think the patch stores only non-partial paths in decreasing order, > what if partial paths having more costs follows those paths? The general picture here is that we don't want the leader to get stuck inside some

Re: [HACKERS] [POC] hash partitioning

2017-09-14 Thread Robert Haas
On Thu, Sep 14, 2017 at 12:54 PM, David Fetter wrote: > Should we be pointing the gun away from people's feet by making hash > partitions that cover the space automagically when the partitioning > scheme[1] is specified? In other words, do we have a good reason to have > only

Re: [HACKERS] Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b

2017-09-14 Thread David G. Johnston
On Thu, Sep 14, 2017 at 8:41 AM, Stephen Frost wrote: > Robert, all, > > * Robert Haas (robertmh...@gmail.com) wrote: > > > > > > > I vote for rejecting it. DDL compatibility is less valuable than other > > > compatibility. The hypothetical affected application can change

Re: [HACKERS] Optimise default partition scanning while adding new partition

2017-09-14 Thread Robert Haas
On Thu, Sep 14, 2017 at 4:03 AM, Jeevan Ladhe wrote: > Thanks Amit for reviewing. >> Patch looks fine to me. By the way, why don't we just say "Can we skip >> scanning part_rel?" in the comment before the newly added call to >>

Re: [HACKERS] [POC] hash partitioning

2017-09-14 Thread David Fetter
On Mon, Sep 11, 2017 at 07:43:29AM -0400, Robert Haas wrote: > On Mon, Sep 11, 2017 at 4:17 AM, Ashutosh Bapat > wrote: > >> Rebased 0002 against this commit & renamed to 0001, PFA. > > > > Given that we have default partition support now, I am wondering > >

Re: [HACKERS] Is it time to kill support for very old servers?

2017-09-14 Thread Robert Haas
On Wed, Sep 13, 2017 at 11:39 PM, Tom Lane wrote: >>> One small problem with cutting libpq's V2 support is that the server's >>> report_fork_failure_to_client() function still sends a V2-style message. > >> We should really fix that so it reports the error as a v3 message, >>

Re: [HACKERS] Log LDAP "diagnostic messages"?

2017-09-14 Thread Robert Haas
On Thu, Sep 14, 2017 at 10:21 AM, Alvaro Herrera wrote: > BTW I added --with-ldap and --with-pam to the configure line for the > reports in coverage.postgresql.org and the % covered in auth.c went from > 24% to 18.9% (from very bad to terribly sad). Improved code

Re: [HACKERS] SCRAM in the PG 10 release notes

2017-09-14 Thread Alvaro Hernandez
On 14/09/17 18:06, Dave Cramer wrote: On 14 September 2017 at 02:21, Alvaro Hernandez > wrote: On 14/09/17 08:57, Heikki Linnakangas wrote: On 09/12/2017 04:09 AM, Noah Misch wrote: On Wed, May 10, 2017 at 10:50:51PM

[HACKERS] Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b

2017-09-14 Thread Robert Haas
On Wed, Sep 13, 2017 at 10:49 PM, Noah Misch wrote: >> > Both Oracle and MySQL allow finite values after MAXVALUE (usually >> > listed as "0" in code examples, e.g. see [1]). Oracle explicitly >> > documents the fact that values after MAXVALUE are irrelevant in [1]. >> > I'm

Re: [HACKERS] [POC] hash partitioning

2017-09-14 Thread Jesper Pedersen
Hi Amul, On 09/14/2017 04:58 AM, amul sul wrote: On Wed, Sep 13, 2017 at 7:43 PM, Jesper Pedersen

Re: [HACKERS] expanding inheritance in partition bound order

2017-09-14 Thread Robert Haas
On Thu, Sep 14, 2017 at 7:56 AM, Amit Khandekar wrote: > On 14 September 2017 at 06:43, Amit Langote >> langote_amit...@lab.ntt.co.jp> wrote: >> Attached updated patch. > > @@ -1222,151 +1209,130 @@ PartitionDispatch * > RelationGetPartitionDispatchInfo(Relation rel, >

Re: [HACKERS] [COMMITTERS] pgsql: passwordcheck: Add test suite

2017-09-14 Thread Michael Paquier
On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut wrote: > passwordcheck: Add test suite > > Also improve one error message. > > Reviewed-by: David Steele Sorry for showing up late for this topic. +REGRESS_OPTS = --temp-config $(srcdir)/passwordcheck.conf

Re: [HACKERS] POC: Sharing record typmods between backends

2017-09-14 Thread Andres Freund
Hi, On 2017-09-04 18:14:39 +1200, Thomas Munro wrote: > Thanks for the review and commits so far. Here's a rebased, debugged > and pgindented version of the remaining patches. I've pushed this with minor modifications: - added typedefs to typedefs.list - re-pgindented, there were some missing

Re: [HACKERS] POC: Sharing record typmods between backends

2017-09-14 Thread Tom Lane
Thomas Munro writes: > On Fri, Sep 15, 2017 at 3:03 PM, Andres Freund wrote: >> - added typedefs to typedefs.list > Should I do this manually with future patches? FWIW, I'm not on board with that. I think the version of typedefs.list in the

Re: [HACKERS] [COMMITTERS] pgsql: passwordcheck: Add test suite

2017-09-14 Thread Michael Paquier
On Fri, Sep 15, 2017 at 12:02 PM, Michael Paquier wrote: > On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut wrote: >> passwordcheck: Add test suite >> >> Also improve one error message. >> >> Reviewed-by: David Steele > > Sorry

Re: [HACKERS] path toward faster partition pruning

2017-09-14 Thread Dilip Kumar
On Wed, Sep 6, 2017 at 4:08 PM, Amit Langote wrote: > On 2017/09/04 10:10, Amit Langote wrote: >> On 2017/09/02 2:52, Robert Haas wrote: > > [PATCH 2/5] WIP: planner-side changes for partition-pruning > > This patch adds a stub get_partitions_for_keys in

Re: [HACKERS] Trouble with amcheck

2017-09-14 Thread Douglas Doole
Thanks all. Making and installing the contribs got me rolling again. (I tried "make world" but ran into trouble with the XML docs. But that's pain and suffering for another day.) I'd agree that "make installcheck-world" should imply that all prereqs are met - that's certainsly the normal

Re: [HACKERS] taking stdbool.h into use

2017-09-14 Thread Tom Lane
Peter Eisentraut writes: > 0005-Make-casting-between-bool-and-GinTernaryValue-more-r.patch > 0008-Use-stdbool.h-if-available.patch > These need some more work based on Tom's feedback. > Attached is a new patch set. Based on the discussion so far, 0001 >

Re: [HACKERS] Trouble with amcheck

2017-09-14 Thread Andres Freund
On 2017-09-15 02:22:49 +, Douglas Doole wrote: > Thanks all. Making and installing the contribs got me rolling again. (I > tried "make world" but ran into trouble with the XML docs. But that's pain > and suffering for another day.) > > I'd agree that "make installcheck-world" should imply

Re: [HACKERS] Clarification in pg10's pgupgrade.html step 10 (upgrading standby servers)

2017-09-14 Thread Stephen Frost
Michael, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Fri, Sep 15, 2017 at 10:21 AM, Stephen Frost wrote: > > No, one of the baseline requirements of pg_upgrade is to *not* screw > > with the existing cluster. Removing its WAL or "cleaning it up" > > definitely

Re: [HACKERS] Small patch for pg_basebackup argument parsing

2017-09-14 Thread Ryan Murphy
Great, thanks Pierre! I don't have a chance to try the patch tonight, but I will on the weekend if no one else beats me to it. On Wed, Sep 13, 2017 at 12:53 PM Pierre Ducroquet wrote: > On Wednesday, September 13, 2017 2:06:50 AM CEST Daniel Gustafsson wrote: > > > On 05

Re: [HACKERS] Trouble with amcheck

2017-09-14 Thread Tom Lane
Stephen Frost writes: > * Andres Freund (and...@anarazel.de) wrote: >> I'm very unconvinced by this, given that one use of installcheck is to >> run against an existing server. For which one might not even have access >> to the relevant directories to install extensions into.

Re: [HACKERS] path toward faster partition pruning

2017-09-14 Thread Amit Langote
Hi Dilip, Thanks for looking at the patch. On 2017/09/15 13:43, Dilip Kumar wrote: > On Wed, Sep 6, 2017 at 4:08 PM, Amit Langote >> [PATCH 2/5] WIP: planner-side changes for partition-pruning >> >> This patch adds a stub get_partitions_for_keys in partition.c with a >> suitable interface for

Re: [HACKERS] [COMMITTERS] pgsql: Add support for coordinating record typmods among parallel worke

2017-09-14 Thread Tom Lane
Andres Freund writes: > Sorry for missing that during review - unfortunately I don't have a computer > with me now - so I won't get around to this till tomorrow... It turns out that this breaks my local build, too, so I went ahead and pushed a fix. At least two buildfarm

Re: [HACKERS] Trouble with amcheck

2017-09-14 Thread Andres Freund
On 2017-09-14 22:36:38 -0400, Stephen Frost wrote: > Andres, > > * Andres Freund (and...@anarazel.de) wrote: > > On 2017-09-15 02:22:49 +, Douglas Doole wrote: > > > Thanks all. Making and installing the contribs got me rolling again. (I > > > tried "make world" but ran into trouble with the

Re: [HACKERS] Trouble with amcheck

2017-09-14 Thread Stephen Frost
Andres, * Andres Freund (and...@anarazel.de) wrote: > On 2017-09-15 02:22:49 +, Douglas Doole wrote: > > Thanks all. Making and installing the contribs got me rolling again. (I > > tried "make world" but ran into trouble with the XML docs. But that's pain > > and suffering for another day.) >

Re: [HACKERS] POC: Sharing record typmods between backends

2017-09-14 Thread Thomas Munro
On Fri, Sep 15, 2017 at 3:03 PM, Andres Freund wrote: > On 2017-09-04 18:14:39 +1200, Thomas Munro wrote: >> Thanks for the review and commits so far. Here's a rebased, debugged >> and pgindented version of the remaining patches. > > I've pushed this with minor modifications:

Re: [HACKERS] Add Roman numeral conversion to to_number

2017-09-14 Thread Oliver Ford
I'll fix the brace, but there are two other patches in the first email for tests and docs. For some reason the commitfest app didn't pick them up. On Friday, 15 September 2017, Doug Doole wrote: > The following review has been posted through the commitfest application: >

Re: [HACKERS] path toward faster partition pruning

2017-09-14 Thread Amit Langote
On 2017/09/15 10:55, David Rowley wrote: > On 21 August 2017 at 18:37, Amit Langote > wrote: >> I've been working on implementing a way to perform plan-time >> partition-pruning that is hopefully faster than the current method of >> using constraint exclusion to

Re: [HACKERS] parallelize queries containing initplans

2017-09-14 Thread Amit Kapila
On Thu, Aug 31, 2017 at 11:23 AM, Amit Kapila wrote: > On Mon, Aug 21, 2017 at 2:40 PM, Amit Kapila wrote: >> On Mon, Aug 21, 2017 at 1:44 PM, Haribabu Kommi >> wrote: >>> >>> >>> Thanks for adding more details. It is

Re: [HACKERS] additional contrib test suites

2017-09-14 Thread Peter Eisentraut
On 9/14/17 11:01, David Steele wrote: > On 9/8/17 1:32 PM, Peter Eisentraut wrote: >> >> Yes, some of the error messages had changed. Fixed patches attached. > > Patches apply and all tests pass. A few comments: > > * [PATCH v2 1/7] adminpack: Add test suite > > There are no regular tests for

Re: [HACKERS] Small code improvement for btree

2017-09-14 Thread Doug Doole
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested Looks good to me. The new status of this patch is: Ready for

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

2017-09-14 Thread Amit Langote
On 2017/09/15 4:43, Robert Haas wrote: > On Thu, Sep 14, 2017 at 8:06 AM, Ashutosh Bapat > wrote: >> I have few changes to multi-level expansion patch as per discussion in >> earlier mails > > OK, I have committed >

Re: [HACKERS] Clarification in pg10's pgupgrade.html step 10 (upgrading standby servers)

2017-09-14 Thread Michael Paquier
On Fri, Sep 15, 2017 at 8:23 AM, Andreas Joseph Krogh wrote: > I tested upgrading from 9.6 to 10 now, using pg_upgrade, and pg_upgrade > creates the new data-dir with pg_wal "in it" (just like regular initdb), so > pg_upgrade seems not to care about where the old version's

Re: [HACKERS] Process startup infrastructure is a mess

2017-09-14 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Andres Freund > I think we should seriously consider doing a larger refactoring of this > soon. I've some ideas about what to do, but I'd welcome some thoughts on > whether others consider this a

Re: [HACKERS] Add Roman numeral conversion to to_number

2017-09-14 Thread Doug Doole
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:not tested Code looks fine, but one niggly complaint at line 146 of the patch

Re: [HACKERS] PATCH : Generational memory allocator (was PATCH: two slab-like memory allocators)

2017-09-14 Thread Tomas Vondra
On 09/14/2017 04:21 PM, Simon Riggs wrote: > On 14 August 2017 at 01:35, Tomas Vondra wrote: >> Hi, >> >> Attached is a rebased version of the Generational context, originally >> submitted with SlabContext (which was already committed into Pg 10). >> >> The main

Re: [HACKERS] Clarification in pg10's pgupgrade.html step 10 (upgrading standby servers)

2017-09-14 Thread Stephen Frost
Michael, all, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Fri, Sep 15, 2017 at 8:23 AM, Andreas Joseph Krogh > wrote: > > I tested upgrading from 9.6 to 10 now, using pg_upgrade, and pg_upgrade > > creates the new data-dir with pg_wal "in it" (just like regular

Re: [HACKERS] SCRAM in the PG 10 release notes

2017-09-14 Thread Michael Paquier
On Fri, Sep 15, 2017 at 12:10 AM, Alvaro Hernandez wrote: >> On the JDBC driver, strictly speaking, code has not been released yet. >> It is scheduled for v 42.2.0, and maybe the wiki should also mention from >> what version of the driver it is supported (I guess for all

Re: [HACKERS] Trouble with amcheck

2017-09-14 Thread Stephen Frost
Peter, Douglas, * Peter Geoghegan (p...@bowt.ie) wrote: > On Thu, Sep 14, 2017 at 5:03 PM, Douglas Doole wrote: > > I just cloned PostgreSQL to a new machine today (Ubuntu 17.04). "make > > install" and "make check-world" run fine but "make installcheck-world" is > > having

Re: [HACKERS] Process startup infrastructure is a mess

2017-09-14 Thread Stephen Frost
Andres, Simon, * Andres Freund (and...@anarazel.de) wrote: > On 2017-09-15 01:06:54 +0100, Simon Riggs wrote: > > If we add something to an area then its a good time to refactor it > > since we were going to get bugs anyway. > > We've added something to the area on a regular basis. As in last in

Re: [HACKERS] Clarification in pg10's pgupgrade.html step 10 (upgrading standby servers)

2017-09-14 Thread Michael Paquier
On Fri, Sep 15, 2017 at 10:21 AM, Stephen Frost wrote: > No, one of the baseline requirements of pg_upgrade is to *not* screw > with the existing cluster. Removing its WAL or "cleaning it up" > definitely seems like it's violating that principle. Not necessarily. Using

Re: [HACKERS] Trouble with amcheck

2017-09-14 Thread Michael Paquier
On Fri, Sep 15, 2017 at 10:31 AM, Stephen Frost wrote: > Yes, I was working with someone earlier today who ran into exactly the > same issue. If you don't 'make world' or make the individual contrib > modules, then 'make installcheck-world' isn't going to work. Or should

Re: [HACKERS] path toward faster partition pruning

2017-09-14 Thread David Rowley
On 21 August 2017 at 18:37, Amit Langote wrote: > I've been working on implementing a way to perform plan-time > partition-pruning that is hopefully faster than the current method of > using constraint exclusion to prune each of the potentially many > partitions

Re: [HACKERS] Allow GiST opcalsses without compress\decompres functions

2017-09-14 Thread Alexander Korotkov
On Thu, Sep 14, 2017 at 2:20 PM, Dmitriy Sarafannikov < dsarafanni...@yandex.ru> wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed >

Re: [HACKERS] [POC] hash partitioning

2017-09-14 Thread Robert Haas
On Thu, Sep 14, 2017 at 2:05 PM, Jesper Pedersen wrote: > However, it is a little bit difficult to follow the dependencies between > different partition patches, so I may not always provide sane feedback, as > seen in [1]. > > [1] >

[HACKERS] Pre-existing bug in trigger.c

2017-09-14 Thread Tom Lane
While fooling with the transition-tables bug, I noticed a problem in trigger.c that has been there a very long time. AfterTriggerEndQuery correctly notes * ... Be careful here: firing a * trigger could result in query_stack being repalloc'd, so we can't save * its address across

  1   2   >