Re: [HACKERS] Failing start-up archive recovery at Standby mode in PG9.2.4

2013-04-25 Thread Amit Langote
. regards, Amit Langote -- View this message in context: http://postgresql.1045698.n5.nabble.com/Failing-start-up-archive-recovery-at-Standby-mode-in-PG9-2-4-tp5753110p5753221.html Sent from the PostgreSQL - hackers mailing list archive at Nabble.com. -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Failing start-up archive recovery at Standby mode in PG9.2.4

2013-04-25 Thread Amit Langote
How would code after applying this patch behave if a recycled segment gets renamed using the newest timeline (say 3) while we are still recovering from a lower timeline (say 2)? In that case, since XLogFileReadAnyTLI returns that recycled segment as the next segment to recover from, we get the

Re: [HACKERS] Failing start-up archive recovery at Standby mode in PG9.2.4

2013-04-25 Thread Amit Langote
How would code after applying this patch behave if a recycled segment gets renamed using the newest timeline (say 3) while we are still recovering from a lower timeline (say 2)? In that case, since XLogFileReadAnyTLI returns that recycled segment as the next segment to recover from, we get the

Re: [HACKERS] Failing start-up archive recovery at Standby mode in PG9.2.4

2013-04-26 Thread Amit Langote
What would happen if a recycled segment gets assigned a newer timeline than the one we are currently recovering from? In the reported erroneous behavior, that is what happens causing XLogFileReadAnyTLI() to return such bogus segment causing the error. Since, expectedTLIs contains a newer timeline

[HACKERS] Confusing comment in xlog.c or am I missing something?

2013-05-01 Thread Amit Langote
I was just going through the xlog.c and I came across following which confused me: Given, src/include/access/xlogdefs.h #define XLogSegsPerFile (((uint32) 0x) / XLogSegSize) #define XLogFileSize(XLogSegsPerFile * XLogSegSize) Also, typedef struct XLogRecPtr { uint32

Re: [HACKERS] Confusing comment in xlog.c or am I missing something?

2013-05-02 Thread Amit Langote
the xlog file (not segment) boundary, right? Am I still missing something as in 9.2? Amit Langote -- View this message in context: http://postgresql.1045698.n5.nabble.com/Confusing-comment-in-xlog-c-or-am-I-missing-something-tp5754010p5754014.html Sent from the PostgreSQL - hackers mailing list

Re: [HACKERS] Confusing comment in xlog.c or am I missing something?

2013-05-02 Thread Amit Langote
Yeah, that would be more correct. The phrase we seem to use elsewhere in xlog.c is crossing a logid boundary. Should we change it in 9.2 to clear the confusion? (Attached is a rather small patch to fix that! :) ) -- Amit Langote minor-xlog-comment.patch (914 bytes) http://postgresql

Re: [HACKERS] Confusing comment in xlog.c or am I missing something?

2013-05-02 Thread Amit Langote
Attached patch fixes this. -- Amit Langote minor-xlog-comment-fix.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Assertion failure at standby promotion

2013-05-05 Thread Amit Langote
: wal sender process amit [local] idle Is this related to the assertion failure that you have reported? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] XLogFlush invoked about twice as much after 9.2 group commit enhancement

2013-05-07 Thread Amit Langote
with TPS result (after applying the patch) not being significantly different (as in not twice as much on my system). Using: pgbench scale=10 shared_buffers=256MB max_connections=1000 checkpoint_segments=15 synchronous_commit=on Comments? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql

[HACKERS] XLogFlush invoked about twice as many times after 9.2 group commit enhancement

2013-05-07 Thread Amit Langote
not being significantly different (as in not twice as much on my system). I used: pgbench scale=10 shared_buffers=256MB max_connections=1000 checkpoint_segments=15 synchronous_commit=on Comments? -- Amit Langote -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] XLogFlush invoked about twice as many times after 9.2 group commit enhancement

2013-05-07 Thread Amit Langote
transactions faster and hence cause XLogFlush() to be invoked more often. So, any rise in number of XLogFlush() calls should roughly be accounted for by increased throughput. Am I right in interpreting it this way? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] XLogFlush invoked about twice as much after 9.2 group commit enhancement

2013-05-07 Thread Amit Langote
, it might have been wrong of me to conclude that the throughput rise and rise in #invocations of XLogFlush() are not proportional. I think they are, though not rigorously as far as I could measure. I am wondering if this line of interpreting it is correct? -- Amit Langote -- Sent via pgsql

[HACKERS] Logging of PAM Authentication Failure

2013-05-08 Thread Amit Langote
first connection request in that case. But, pam method leads to it being logged. Is this a problem? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Logging of PAM Authentication Failure

2013-05-12 Thread Amit Langote
logging or is there a problem with authentication exchange itself in case of PAM? Also, when you say PAM layer, is that pam_passwd_conv_proc() that needs to be able to return an alternative status code? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Logging of PAM Authentication Failure

2013-05-13 Thread Amit Langote
added to conn, would the backend's authentication state still be waiting for the password? Can we do away without having to create a second connection? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Logging of PAM Authentication Failure

2013-05-13 Thread Amit Langote
of. -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Logging of PAM Authentication Failure

2013-05-14 Thread Amit Langote
of the reasons why this has not already been implemented? Comments? On Tue, May 14, 2013 at 11:22 AM, Amit Langote amitlangot...@gmail.com wrote: Well, if we are allowed to use a bit ugry way, the attached patch seems to cope with this issue. As far as I can see there's no problem since pg_fe_sendauth

[HACKERS] Update description in sysv_shmem.c

2013-05-14 Thread Amit Langote
shared memory using SysV facilities * * These routines represent a fairly thin layer on top of SysV shared * memory functionality. * ? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] Logging of PAM Authentication Failure

2013-05-15 Thread Amit Langote
to create more new functions than necessary and make appropriate changes. -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Logging of PAM Authentication Failure

2013-05-15 Thread Amit Langote
propose to change simple_prompt() that would be able to detect an authentication timeout on server and exit with an appropriate message? I think that should be done. I will try to revise the patch to incorporate these considerations and post a revised patch. -- Amit Langote -- Sent via pgsql

Re: [HACKERS] Logging of PAM Authentication Failure

2013-05-15 Thread Amit Langote
I created a patch which enables it to use the existing connection in such a case (unlike what we currently do). It modifies connectDBComplete() and PQconnectPoll() to also include states pertaining to password being accepted from the user. That is, the state machine in PQconnectPoll() is

Re: [HACKERS] Logging of PAM Authentication Failure

2013-05-15 Thread Amit Langote
Sorry that I am writing separate emails on the same topic. I seem to have a solution that allows us to accomplish what we are trying to without much change to the existing libpq interface (especially what to expect about return values and connection state that we are in when we return from

Re: [HACKERS] Logging of PAM Authentication Failure

2013-05-16 Thread Amit Langote
Attached herewith is a patch based on description in my previous mail. This patch would need revision since the error situation in case of authentication timeout on the server needs to be handled; probably in simple_prompt()? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] Logging of PAM Authentication Failure

2013-05-16 Thread Amit Langote
On Thu, May 16, 2013 at 3:53 PM, Amit Langote amitlangot...@gmail.com wrote: Attached herewith is a patch based on description in my previous mail. This patch would need revision since the error situation in case of authentication timeout on the server needs to be handled; probably

Re: [HACKERS] Logging of PAM Authentication Failure

2013-05-16 Thread Amit Langote
On Thu, May 16, 2013 at 8:01 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-05-16 17:35:10 +0900, Amit Langote wrote: On Thu, May 16, 2013 at 3:53 PM, Amit Langote amitlangot...@gmail.com wrote: Attached herewith is a patch based on description in my previous mail. This patch

Re: [HACKERS] Logging of PAM Authentication Failure

2013-05-16 Thread Amit Langote
On Fri, May 17, 2013 at 1:05 AM, Tom Lane t...@sss.pgh.pa.us wrote: Amit Langote amitlangot...@gmail.com writes: On Thu, May 16, 2013 at 8:01 PM, Andres Freund and...@2ndquadrant.com wrote: I unfortunately have to say I don't really see the point of this. The cost of the additional

Re: [HACKERS] Logging of PAM Authentication Failure

2013-05-16 Thread Amit Langote
On Fri, May 17, 2013 at 1:46 AM, Tom Lane t...@sss.pgh.pa.us wrote: Andres Freund and...@2ndquadrant.com writes: On 2013-05-17 01:29:25 +0900, Amit Langote wrote: Can this stay in the future releases for new users of libpq to consider using it (saving them a reconnection, however small

Fwd: [HACKERS] Logging of PAM Authentication Failure

2013-05-18 Thread Amit Langote
, Robert Haas robertmh...@gmail.com, PostgreSQL-development pgsql-hackers@postgresql.org On Fri, May 17, 2013 at 1:05 AM, Tom Lane t...@sss.pgh.pa.us wrote: Amit Langote amitlangot...@gmail.com writes: On Thu, May 16, 2013 at 8:01 PM, Andres Freund and...@2ndquadrant.com wrote: I unfortunately

Re: [HACKERS] Why there is a union in HeapTupleHeaderData struct

2013-05-20 Thread Amit Langote
part oh HeapTuple, there is a union that is named t_choice, union { HeapTupleFields t_heap; DatumTupleFields t_datum; }t_choice; I can't find out why we need t_datum, actually there is no comment about DatumTupleFields. Regards Soroosh -- Amit

Re: [HACKERS] Why there is a union in HeapTupleHeaderData struct

2013-05-20 Thread Amit Langote
: Thanks, If a tuple constructed in memory we don't need t_heap. I have another question, How make an in-memory tuple? On Mon, May 20, 2013 at 12:46 PM, Amit Langote amitlangot...@gmail.com wrote: Hello, I think the comment just above the HeapTupleFields struct definition has the related

Re: [HACKERS] Why there is a union in HeapTupleHeaderData struct

2013-05-20 Thread Amit Langote
Wonder though if this question is better asked in pgsql-novice? On Mon, May 20, 2013 at 9:23 PM, Amit Langote amitlangot...@gmail.com wrote: Hello, I think a more appropriate question to be asked here would be at what point (in the life of a typical tuple), does a tuple's header contain

[HACKERS] WAL segments (names) not in a sequence

2013-05-22 Thread Amit Langote
0001000E007D -rw--- 1 postgres postgres 16777216 May 21 14:53 0001000E007E -rw--- 1 postgres postgres 16777216 May 21 14:53 0001000E007F -rw--- 1 postgres postgres 16777216 May 21 14:53 0001000E0080 Is this a known issue? -- Amit Langote -- Sent via

Re: [HACKERS] WAL segments (names) not in a sequence

2013-05-23 Thread Amit Langote
pg_xlogfile_name(pg_xlog_current_location()). -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] WAL segments (names) not in a sequence

2013-05-23 Thread Amit Langote
if whatever configuration he is using is sub-optimal that these many WAL segments can be re-cycled upon a checkpoint? Or is this okay? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] Time limit for a process to hold Content lock in Buffer Cache

2013-05-23 Thread Amit Langote
to statement_timeout amount of time? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] WAL segments (names) not in a sequence

2013-05-24 Thread Amit Langote
it faster. Then I switch to wal_level=hot_standby, i.e the production configuration, and the WAL segment seuqence seems to overlap with the segments generated with the other setting. Though, now you understand it's not what it looks like, right? :-) -- Amit Langote -- Sent via pgsql-hackers

Re: [HACKERS] WAL segments (names) not in a sequence

2013-05-24 Thread Amit Langote
:32 (the latest writes seem to have happened to this segment) whereas pre-allocated ones seem to have around May 22 12:05 to 12:15 (which are yet to be written to). Does that help? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] WAL segments (names) not in a sequence

2013-05-24 Thread Amit Langote
, checkpoint_timeout, wal_keep_segments? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] PostgreSQL Process memory architecture

2013-05-27 Thread Amit Langote
memory? An index is built in backend process's local memory, but, when accessing, index pages are stored in shared memory. That is, for example, when an index scan is performed, index pages are brought into shared memory and accessed from there. -- Amit Langote -- Sent via pgsql-hackers

Re: [HACKERS] PostgreSQL Process memory architecture

2013-05-27 Thread Amit Langote
? CreateSharedMemoryAndSemaphores() (src/backend/storage/ipc/ipci.c) seems to be the place where we can see what all things reside in shared memory, since at the beginning of the function, you can see size being computed for shared memory to hold all the things that need to be in shared memory. -- Amit Langote

Re: [HACKERS] Logging of PAM Authentication Failure

2013-05-28 Thread Amit Langote
included in the request. -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Logging of PAM Authentication Failure

2013-05-28 Thread Amit Langote
On Tue, May 28, 2013 at 5:04 PM, Amit Langote amitlangot...@gmail.com wrote: On Tue, May 28, 2013 at 2:32 PM, Craig Ringer cr...@2ndquadrant.com wrote: On 05/11/2013 03:25 AM, Robert Haas wrote: Not really. We could potentially fix it by extending the wire protocol to allow the server

[HACKERS] Behavior of a pg_trgm index for 2 (or 3) character LIKE queries

2013-05-29 Thread Amit Langote
...@mail.gmail.com), but things didn't change. So, it appears, for search strings consisting of 2 (or 3) characters, trigrams can not be utilized. No? NOTE: Using the master branch. The indexed column is a text field and data consists of mix of Japanese, alphanumeric characters. -- Amit Langote -- Sent via

Re: [HACKERS] Behavior of a pg_trgm index for 2 (or 3) character LIKE queries

2013-05-30 Thread Amit Langote
On Thu, May 30, 2013 at 11:47 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, May 29, 2013 at 10:51 PM, Amit Langote amitlangot...@gmail.com wrote: So, it appears, for search strings consisting of 2 (or 3) characters, trigrams can not be utilized. No? I think that's right. trigram

Re: [HACKERS] Behavior of a pg_trgm index for 2 (or 3) character LIKE queries

2013-05-30 Thread Amit Langote
implemented into pg_trgm yet, right? And even though, such a facility would be added, we would still need to handle multibyte characters case differently (even for partial matching), is that right? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Behavior of a pg_trgm index for 2 (or 3) character LIKE queries

2013-05-30 Thread Amit Langote
) is yes) NOT to be used in such a partial matching case? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Behavior of a pg_trgm index for 2 (or 3) character LIKE queries

2013-05-31 Thread Amit Langote
On Sat, Jun 1, 2013 at 1:48 AM, Sawada Masahiko sawada.m...@gmail.com wrote: On Fri, May 31, 2013 at 11:16 AM, Amit Langote amitlangot...@gmail.com wrote: 2) And if that is so, is there problem in gin_extract_query_trgm(), that is while generating trigrams from a query search term that causes

[HACKERS] Regarding GIN Fast Update Technique

2013-06-05 Thread Amit Langote
Hello, At what point do the entries in the pending list are moved to the main GIN data structure? From documentation, I read that overflowing work_mem and vacuum are two such causes; what about when the concerned backend is to exit and autovacuum has not yet kicked in? -- Amit Langote

Re: [HACKERS] Regarding GIN Fast Update Technique

2013-06-07 Thread Amit Langote
On Fri, Jun 7, 2013 at 11:15 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Jun 5, 2013 at 10:06 PM, Amit Langote amitlangot...@gmail.com wrote: At what point do the entries in the pending list are moved to the main GIN data structure? From documentation, I read that overflowing work_mem

Re: [HACKERS] Regarding GIN Fast Update Technique

2013-06-07 Thread Amit Langote
On Fri, Jun 7, 2013 at 11:36 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-06-07 23:28:56 +0900, Amit Langote wrote: On Fri, Jun 7, 2013 at 11:15 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Jun 5, 2013 at 10:06 PM, Amit Langote amitlangot...@gmail.com wrote: At what

Re: [HACKERS] [PATCH] Remove useless USE_PGXS support in contrib

2013-06-14 Thread Amit Langote
/to/pg_config install When user does not work with pg source directly and does not have postgresql-contrib installed? Am I missing something here? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

[HACKERS] A minor correction in comment in heaptuple.c

2013-06-18 Thread Amit Langote
-natts) return true; Attached patch fixes this. -- Amit Langote correct-a-comment-in-heaptupledotc.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] A minor correction in comment in heaptuple.c

2013-06-18 Thread Amit Langote
On Tue, Jun 18, 2013 at 6:01 PM, Andres Freund and...@2ndquadrant.com wrote: Hi, On 2013-06-18 17:56:34 +0900, Amit Langote wrote: Should it be: return true if attnum is out of range according to the tupdesc instead of return NULL if attnum is out of range according to the tupdesc at src

Re: [HACKERS] Patch to add support of IF NOT EXISTS to others CREATE statements

2013-06-19 Thread Amit Langote
already exists, then I won't be able to add pg_bigm (which has its own use cases and we can probably have the two co-exist) and vice versa. It would be nice if we had the above feature so that pg_bigm or pg_trgm can use 'IF NOT EXISTS' while creating pg_trgm_ops operator class. Thoughts? -- Amit

Re: [HACKERS] Patch to add support of IF NOT EXISTS to others CREATE statements

2013-06-20 Thread Amit Langote
On Thu, Jun 20, 2013 at 9:48 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Thu, Jun 20, 2013 at 1:52 AM, Amit Langote amitlangot...@gmail.com wrote: Is it possible to: CREATE [ OR REPLACE | IF NOT EXISTS ] OPERATOR CLASS I am in a situation where I need to conditionally

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-24 Thread Amit Langote
wal_sender_timeout = 50 --- Just ask to clarify: Is 'slave2' a failback standby? What does 'synchronous_transfer = all' mean? Does that mean wait during both commit and checkpoint? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-24 Thread Amit Langote
it starts replaying any WAL? * And, would the new master, before forking the WAL, replay all the WAL that is necessary to come to state (of data directory) that the old master was just before it crashed? Am I missing something here? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql

[HACKERS] Computer VARSIZE_ANY(PTR) during debugging

2013-06-25 Thread Amit Langote
anything of this kind been encountered/reported before? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Computer VARSIZE_ANY(PTR) during debugging

2013-06-26 Thread Amit Langote
On Thu, Jun 27, 2013 at 12:02 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Amit Langote escribió: The segfault in question happens at line 1141: off = att_align_pointer(off, thisatt-attalign, -1, tp + off); char *tp; /* ptr to tuple data */ long

Re: [HACKERS] Computer VARSIZE_ANY(PTR) during debugging

2013-06-26 Thread Amit Langote
On Thu, Jun 27, 2013 at 12:02 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Amit Langote escribió: The segfault in question happens at line 1141: off = att_align_pointer(off, thisatt-attalign, -1, tp + off); char *tp; /* ptr to tuple data */ long

Re: [HACKERS] WAL and XLOG

2013-07-07 Thread Amit Langote
? You could start here: http://www.postgresql.org/docs/9.2/static/wal-intro.html -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] maintenance_work_mem and CREATE INDEX time

2013-07-22 Thread Amit Langote
anyway. Does that make sense? -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] maintenance_work_mem and CREATE INDEX time

2013-07-23 Thread Amit Langote
On Tue, Jul 23, 2013 at 1:11 PM, Amit Langote amitlangot...@gmail.com wrote: Hello, While understanding the effect of maintenance_work_mem on time taken by CREATE INDEX, I observed that for the values of maintenance_work_mem less than the value for which an internal sort is performed

Re: [HACKERS] maintenance_work_mem and CREATE INDEX time

2013-07-23 Thread Amit Langote
On Wed, Jul 24, 2013 at 6:02 AM, Jeff Janes jeff.ja...@gmail.com wrote: On Tue, Jul 23, 2013 at 1:23 AM, Amit Langote amitlangot...@gmail.com wrote: On Tue, Jul 23, 2013 at 1:11 PM, Amit Langote amitlangot...@gmail.com wrote: Hello, While understanding the effect of maintenance_work_mem

Re: [HACKERS] maintenance_work_mem and CREATE INDEX time

2013-07-23 Thread Amit Langote
On Wed, Jul 24, 2013 at 11:30 AM, Amit Langote amitlangot...@gmail.com wrote: On Wed, Jul 24, 2013 at 6:02 AM, Jeff Janes jeff.ja...@gmail.com wrote: If you are using trace_sort to report that, it reports the switch as happening as soon as it runs out of memory. At point, all we have been

Re: [HACKERS] maintenance_work_mem and CREATE INDEX time

2013-07-23 Thread Amit Langote
On Wed, Jul 24, 2013 at 3:20 AM, Jeff Janes jeff.ja...@gmail.com wrote: On Mon, Jul 22, 2013 at 9:11 PM, Amit Langote amitlangot...@gmail.com wrote: Hello, While understanding the effect of maintenance_work_mem on time taken by CREATE INDEX, I observed that for the values

Re: [HACKERS] maintenance_work_mem and CREATE INDEX time

2013-07-29 Thread Amit Langote
Hi Jeff, On Tue, Jul 30, 2013 at 3:25 AM, Jeff Janes jeff.ja...@gmail.com wrote: On Tue, Jul 23, 2013 at 10:56 PM, Amit Langote amitlangot...@gmail.com wrote: On Wed, Jul 24, 2013 at 3:20 AM, Jeff Janes jeff.ja...@gmail.com wrote: The heap structure used in external sorts is cache

Re: [HACKERS] Computer VARSIZE_ANY(PTR) during debugging

2013-07-30 Thread Amit Langote
) 800; -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] FailedAssertion on initdb with 9.4dev

2013-08-01 Thread Amit Langote
0x005d58c7 in main (argc=9, argv=0x12cd330) at main.c:192 -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] FailedAssertion on initdb with 9.4dev

2013-08-01 Thread Amit Langote
Build using: CFLAGS=-g -O0 ./configure --with-pam --enable-cassert --enable-debug --prefix=/home/amit/dev/pginstall/ -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] FailedAssertion on initdb with 9.4dev

2013-08-01 Thread Amit Langote
On Thu, Aug 1, 2013 at 3:52 PM, Amit Langote amitlangot...@gmail.com wrote: Build using: CFLAGS=-g -O0 ./configure --with-pam --enable-cassert --enable-debug --prefix=/home/amit/dev/pginstall/ -- Amit Langote Umm, I guess I forgot to make clean before building with the latest HEAD. Now, I

[HACKERS] Bottlenecks with large number of relation segment files

2013-08-05 Thread Amit Langote
pgbench -i -s 3500 would be. May the routines in fd.c become bottleneck with a large number of concurrent connections to above database, say something like pgbench -j 8 -c 128? Is there any other place I should be paying attention to? -- Amit Langote -- Sent via pgsql-hackers mailing list

Re: [HACKERS] [GENERAL] Bottlenecks with large number of relation segment files

2013-08-05 Thread Amit Langote
On Mon, Aug 5, 2013 at 5:01 PM, KONDO Mitsumasa kondo.mitsum...@lab.ntt.co.jp wrote: Hi Amit, (2013/08/05 15:23), Amit Langote wrote: May the routines in fd.c become bottleneck with a large number of concurrent connections to above database, say something like pgbench -j 8 -c 128

[HACKERS] Typo in 9.2.5 release note item?

2013-10-08 Thread Amit Langote
with the following commit: http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=bd5ab4b28745605493ab7061724ba0375ee9593a -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Call flow of btinsert(PG_FUNCTION_ARGS)

2013-11-19 Thread Amit Langote
On Tue, Nov 19, 2013 at 7:31 PM, Rohit Goyal rhtgyl...@gmail.com wrote: On Tue, Nov 19, 2013 at 11:26 AM, Peter Geoghegan p...@heroku.com wrote: On Tue, Nov 19, 2013 at 2:22 AM, Rohit Goyal rhtgyl...@gmail.com wrote: I was reading b tree index code and I wanted to the know the calling

[HACKERS] A GIN index internals question

2013-12-26 Thread Amit Langote
Hi, Can a posting item / ItemPointer belonging to posting list/tree of some entry stored in a GIN index be lossy? If yes, under what circumstances would such a lossy ItemPointer be included for the entry? I got an impression that there may be some lossy ItemPointers stored in a GIN index while

Re: [HACKERS] GIN improvements part 1: additional information

2014-01-06 Thread Amit Langote
On Sat, Dec 21, 2013 at 4:36 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Yet another version. The encoding/decoding code is now quite isolated in ginpostinglist.c, so it's easy to experiment with different encodings. This patch uses varbyte encoding again. I got a bit carried away,

Re: [HACKERS] [BUG] Archive recovery failure on 9.3+.

2014-01-09 Thread Amit Langote
in 9.2 branch was to address a similar/same problem? http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=4aed94f1660fb55bc825bf7f3135379dab28eb55 -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

[HACKERS] Typo fix in src/backend/catalog/README

2014-01-26 Thread Amit Langote
Hi, There is a possible typo in src/backend/catalog/README and the attached fixes it. -- Amit diff --git a/src/backend/catalog/README b/src/backend/catalog/README index fce01ea..7e0ddf3 100644 --- a/src/backend/catalog/README +++ b/src/backend/catalog/README @@ -92,7 +92,7 @@ them. Thus, the

Re: [HACKERS] Retain dynamic shared memory segments for postmaster lifetime

2014-01-27 Thread Amit Langote
On Mon, Jan 27, 2014 at 11:18 PM, Amit Langote amitlangot...@gmail.com wrote: On Mon, Jan 13, 2014 at 2:50 PM, Amit Kapila amit.kapil...@gmail.com wrote: I have extended test (contrib) module dsm_demo such that now user can specify during dsm_demo_create the lifespan of segment. The values

Re: [HACKERS] Retain dynamic shared memory segments for postmaster lifetime

2014-01-27 Thread Amit Langote
On Mon, Jan 13, 2014 at 2:50 PM, Amit Kapila amit.kapil...@gmail.com wrote: I have extended test (contrib) module dsm_demo such that now user can specify during dsm_demo_create the lifespan of segment. The values it can accept are 0 or 1. Default value is 0. 0 -- means segment will be

Re: [HACKERS] Retain dynamic shared memory segments for postmaster lifetime

2014-01-27 Thread Amit Langote
On Tue, Jan 28, 2014 at 1:41 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Mon, Jan 27, 2014 at 7:48 PM, Amit Langote amitlangot...@gmail.com wrote: On Mon, Jan 13, 2014 at 2:50 PM, Amit Kapila amit.kapil...@gmail.com wrote: I have extended test (contrib) module dsm_demo such that now user

Re: [HACKERS] Regarding google summer of code

2014-01-30 Thread Amit Langote
Hi Anirudh, On Fri, Jan 31, 2014 at 12:23 PM, Anirudh anirudh2...@gmail.com wrote: Hello everyone, My name is Anirudh Subramanian and I am a graduate student in Computer Science. I would like to participate in Google Summer of Code and would like to contribute to postgresql. I am not

[HACKERS] Typo in a comment?

2014-02-06 Thread Amit Langote
In src/backend/storage/freespace/freespace.c, * * MaxFSMRequestSize depends on the architecture and BLCKSZ, but assuming * default 8k BLCKSZ, and that MaxFSMRequestSize is 24 bytes, the categories * look like this * Is 24 bytes a typo considering that #define MaxFSMRequestSize

Re: [HACKERS] how set GUC_check_errhint_string in call_string_check_hook()

2014-02-13 Thread Amit Langote
Amul, On Thu, Feb 13, 2014 at 5:59 PM, amul sul sul_a...@yahoo.co.in wrote: I have basic questions, 1. Condition testing of GUC_check_errdetail_string or other GUC_* is needed, even if we resting it? A few lines before this conditional test, there is a call to the hook function (using the

[HACKERS] Need to update this comment in xlog.c?

2014-02-17 Thread Amit Langote
Hi, Should background writer in the following comment be checkpointer post-9.2? src/backend/access/transam/xlog.c /* * Statistics for current checkpoint are collected in this global struct. * Because only the background writer or a stand-alone backend can perform * checkpoints, this will be

Re: [HACKERS] The behavior of CheckRequiredParameterValues()

2014-03-04 Thread Amit Langote
On Wed, Mar 5, 2014 at 2:09 AM, Sawada Masahiko sawada.m...@gmail.com wrote: xlog.c:6177 if (ControlFile-wal_level WAL_LEVEL_HOT_STANDBY) ereport(ERROR, (errmsg(hot standby is not possible because wal_level was not So we have to start and stop standby server with

Re: [HACKERS] The behavior of CheckRequiredParameterValues()

2014-03-05 Thread Amit Langote
On Wed, Mar 5, 2014 at 12:07 PM, Amit Langote amitlangot...@gmail.com wrote: On Wed, Mar 5, 2014 at 2:09 AM, Sawada Masahiko sawada.m...@gmail.com wrote: xlog.c:6177 if (ControlFile-wal_level WAL_LEVEL_HOT_STANDBY) ereport(ERROR, (errmsg(hot standby is not possible

[HACKERS] Comment in src/backend/commands/vacuumlazy.c

2014-03-24 Thread Amit Langote
Hi, Note the following comment in src/backend/commands/vacuumlazy.c:lazy_scan_heap() 1088 /* If no indexes, make log report that lazy_vacuum_heap would've made */ 1089 if (vacuumed_pages) 1090 ereport(elevel, Just wondering if it would read better as: 1088 /* Make the log

Re: [HACKERS] History of WAL_LEVEL (archive vs hot_standby)

2014-03-28 Thread Amit Langote
On Fri, Mar 28, 2014 at 12:16 PM, David Johnston pol...@yahoo.com wrote: Slightly tangential but are the locking operations associated with the recent bugfix generated in both (all?) modes or only hot_standby? I thought it strange that transient locking operations were output with WAL though

Re: [HACKERS] Comment in src/backend/commands/vacuumlazy.c

2014-03-31 Thread Amit Langote
On Mon, Mar 31, 2014 at 11:44 PM, Robert Haas robertmh...@gmail.com wrote: On Mon, Mar 24, 2014 at 12:28 AM, Amit Langote amitlangot...@gmail.com wrote: Hi, Note the following comment in src/backend/commands/vacuumlazy.c:lazy_scan_heap() 1088 /* If no indexes, make log report

[HACKERS] Typo fix in contrib/sepgsql/relation.c

2014-03-31 Thread Amit Langote
Hi, Just noticed the following in contrib/sepgsql/relation.c: 1 /* - 2 * 3 * contrib/sepgsql/label.c 4 * Attached fixes this. -- Amit sepgsql-file-label-fix.patch Description: Binary data -- Sent via pgsql-hackers

[HACKERS] [doc] EXPLAIN CREATE MATERIALIZED VIEW AS?

2014-04-15 Thread Amit Langote
Hi, Attached adds CREATE MATERIALIZED VIEW AS to the list of statements that can be EXPLAINed. -- Amit explain-create-materialized-view-as.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

[HACKERS] Typo fix in src/backend/access/transam/recovery.conf.sample

2014-04-18 Thread Amit Langote
Hi, Attached fixes a minor typo in src/backend/access/transam/recovery.conf.sample. -- Amit recovery-conf-sample-typo-fix.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Typo fix in src/backend/access/transam/recovery.conf.sample

2014-04-18 Thread Amit Langote
On Fri, Apr 18, 2014 at 7:50 PM, Magnus Hagander mag...@hagander.net wrote: On Fri, Apr 18, 2014 at 12:24 PM, Amit Langote amitlangot...@gmail.com wrote: Hi, Attached fixes a minor typo in src/backend/access/transam/recovery.conf.sample. Applied, except I also rewrapped the line to make

[HACKERS] Typo in doc/src/sgml/monitoring.sgml? s/tranche/trance?

2014-04-23 Thread Amit Langote
Hi, Attached fixes a typo in doc/src/sgml/monitoring.sgml. -- Amit docs-monitoring-lwlock-tranche-not-trance-fix.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Typo in doc/src/sgml/monitoring.sgml? s/tranche/trance?

2014-04-23 Thread Amit Langote
On Wed, Apr 23, 2014 at 6:15 PM, Amit Langote amitlangot...@gmail.com wrote: Hi, Attached fixes a typo in doc/src/sgml/monitoring.sgml. Sorry, typo in subject (kinda ironic!); I meant s/trance/tranche? Patch attached again. -- Amit docs-monitoring-lwlock-tranche-not-trance-fix.patch

[HACKERS] Allowing empty target list in SELECT (1b4f7f93b4693858cb983af3cd557f6097dab67b)

2014-05-01 Thread Amit Langote
Hi, I ​s the following behavior perceived fix-worthy? -- note the ​'​ ​1's in the output ​s ​ ​po​ stgres=# CREATE TABLE test AS SELECT; SELECT 1 postgres=# insert into test select; INSERT 0 1​ ​My guess why ​this happens is because changes made in the commit in $SUBJECT only pertain to

Re: [HACKERS] Allowing empty target list in SELECT (1b4f7f93b4693858cb983af3cd557f6097dab67b)

2014-05-01 Thread Amit Langote
On Fri, May 2, 2014 at 12:57 PM, Amit Langote amitlangot...@gmail.com wrote: I s the following behavior perceived fix-worthy? -- note the ' 1's in the output s po stgres=# CREATE TABLE test AS SELECT; SELECT 1 postgres=# insert into test select; INSERT 0 1 Or maybe, it just

  1   2   3   4   5   6   7   8   9   10   >