Re: [HACKERS] Error trying to compile a simple C trigger

2012-03-20 Thread Asif Naeem
It seems that compiler is complain about Relation structure, can you please try adding the following in trigtest.c i.e. #include utils/rel.h Best Regards, Asif Naeem On Tue, Mar 20, 2012 at 3:53 PM, Marco Nenciarini marco.nenciar...@2ndquadrant.it wrote: I was trying to compile orafce

Re: [HACKERS] pg_ctl idempotent option

2013-01-28 Thread Asif Naeem
) is not going to accept -I option as mentioned in the patch i.e. contrib/start-scripts/linux su - $PGUSER -c $DAEMON -I -D '$PGDATA' $PGLOG 2 Rest of the patch changes looks good to me. Thanks. Best Regards, Asif Naeem On Thu, Jan 24, 2013 at 6:06 PM, Bruce Momjian br...@momjian.us wrote

[HACKERS] plpython crash (PG 92)

2012-04-26 Thread Asif Naeem
() #17 0x005ad360 in main () Apparently it is being crashed because of invalid related pointer value of pfree() *header-context-methods-free_p. It is reproducible with latest version of python i.e. Python-2.7.3 and Python-3.2.3. Thanks. Best Regards, Muhammad Asif Naeem plpython_crash.sql

Re: [HACKERS] plpython crash (PG 92)

2012-04-26 Thread Asif Naeem
FYI, I have observed this crash on Linux64. Thanks. Best Regards, Muhammad Asif Naeem On Thu, Apr 26, 2012 at 5:32 PM, Asif Naeem asif.na...@enterprisedb.comwrote: Hi, PFA test case. It used simple select statement to retrieve data via plpython. It crashes latest pg 9.2 with the following

[HACKERS] pgdump tar bug (PG 9.2)

2012-06-11 Thread Asif Naeem
Date: Tue May 29 23:22:14 2012 -0400 Rewrite --section option to decouple it from --schema-only/--data-only. PFA patch. Thanks. Best Regards, Muhammad Asif Naeem pg_backup_tar.c.patch.pg Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

[HACKERS] plpython issue with Win64 (PG 9.2)

2012-06-27 Thread Asif Naeem
that trigger this issue is when Function PLyUnicode_Bytes() calls PyUnicode_AsEncodedString( ,WIN1252 /*Server encoding*/, ) it fails with null. I built latest pg 9.2 source code with python 3.2.2.3 by using Visual Studio 2010. Thanks. Best Regards, Muhammad Asif Naeem

Re: [HACKERS] plpython issue with Win64 (PG 9.2)

2012-06-29 Thread Asif Naeem
Thank you. Please do let me know once fix check-in. I will test it and share feedback with you. Thanks. Best Regards, Asif Naeem On Fri, Jun 29, 2012 at 3:36 AM, Jan Urbański wulc...@wulczer.org wrote: On 27/06/12 13:57, Jan Urbański wrote: On 27/06/12 11:51, Asif Naeem wrote: Hi

Re: [HACKERS] plpython issue with Win64 (PG 9.2)

2012-07-04 Thread Asif Naeem
'); enctest | encode --+ tróspido | 7472c3b3737069646f (1 row) Please do let me know If you have any other query. Thanks. Best Regards, Muhammad Asif Naeem

Re: [HACKERS] [PATCH] Add use of asprintf()

2013-09-17 Thread Asif Naeem
something or more info is required. Thank you. Regards, Muhammad Asif Naeem On Tue, Sep 17, 2013 at 1:31 AM, Alvaro Herrera alvhe...@2ndquadrant.comwrote: Peter Eisentraut wrote: The attached patch should speak for itself. Yeah, it's a very nice cleanup. I have supplied a few variants

Re: [HACKERS] [PATCH] Add use of asprintf()

2013-09-17 Thread Asif Naeem
On Tue, Sep 17, 2013 at 3:13 PM, Asif Naeem anaeem...@gmail.com wrote: Hi, I did put some time review the patch, please see my findings below i.e. 1. It seems that you have used strdup() on multiple places in the patch, e.g. in the below code snippet is it going to lead crash if newp-ident

Re: [HACKERS] [PATCH] Add use of asprintf()

2013-10-02 Thread Asif Naeem
the patch successfully. Can you please guide ?. Thanks. Best Regards, Muhammad Asif Naeem On Wed, Oct 2, 2013 at 7:29 AM, Peter Eisentraut pete...@gmx.net wrote: On Tue, 2013-09-17 at 15:13 +0500, Asif Naeem wrote: I did put some time review the patch, please see my findings below i.e. Updated

Re: [HACKERS] [PATCH] Add use of asprintf()

2013-10-03 Thread Asif Naeem
You are right, wget worked. Latest patch looks good to me. make check run fine. Thank you Peter. On Wed, Oct 2, 2013 at 5:02 PM, Peter Eisentraut pete...@gmx.net wrote: On 10/2/13 5:12 AM, Asif Naeem wrote: Neither git nor patch command apply the patch successfully. Can you please guide

Re: [HACKERS] [PATCH] Add use of asprintf()

2013-10-14 Thread Asif Naeem
+1 I think you can safely use va_list without copy on Windows. va_copy is available in Visual Studio 2013 as part of support for C99, previous versions don't have it. Regards, Muhammad Asif Naeem On Tue, Oct 15, 2013 at 10:33 AM, Amit Kapila amit.kapil...@gmail.comwrote: On Tue, Oct 15, 2013

Re: [HACKERS] [PATCH] Add use of asprintf()

2013-10-15 Thread Asif Naeem
On Tue, Oct 15, 2013 at 10:55 AM, David Rowley dgrowle...@gmail.com wrote: Though this is not yet enough to get the windows build work with me... I'm still getting link failures for isolationtester.c D:\Postgres\c\pgsql.sln (default target) (1) - D:\Postgres\c\isolationtester.vcxproj

Re: [HACKERS] PostgreSQL Service on Windows does not start. ~ is not a valid Win32 application

2013-10-28 Thread Asif Naeem
files\9.3\data1 -l logfile start server starting Can you please share the exact steps ?. Thanks. Regards, Muhammad Asif Naeem On Mon, Oct 28, 2013 at 10:26 AM, Naoya Anzai anzai-na...@mxu.nes.nec.co.jp wrote: Hi All, I have found a case that PostgreSQL Service does not start. When

Re: [HACKERS] PostgreSQL Service on Windows does not start. ~ is not a valid Win32 application

2013-10-28 Thread Asif Naeem
postgresql-9.3 -D C:/Users/asif/Desktop/Program files/9.3/data -w It would be good if this is reported on pg installer forum or security forum. Thanks. Regards, Asif Naeem On Mon, Oct 28, 2013 at 12:06 PM, Naoya Anzai anzai-na...@mxu.nes.nec.co.jp wrote: Hi, Asif. Thank you for response. C

Re: [HACKERS] PostgreSQL Service on Windows does not start. ~ is not a valid Win32 application

2013-10-28 Thread Asif Naeem
Hi Sandeep, PFA Naoya's patch (pg_ctl.c.patch). Hi Naoya, Good finding. I have attached another version of patch (pg_ctl.c_windows_vulnerability.patch) attached that has fewer lines of code changes, can you please take a look ?. Thanks. Best Regards, Asif Naeem On Mon, Oct 28, 2013 at 4:46

Re: [HACKERS] PostgreSQL Service on Windows does not start. ~ is not a valid Win32 application

2013-10-29 Thread Asif Naeem
Yes. It should not be installer issue as installer is using pg_ctl to register and run the service on Windows. Thanks. Best Regards, Muhammad Asif Naeem On Tue, Oct 29, 2013 at 9:57 AM, Sandeep Thakkar sandeep.thak...@enterprisedb.com wrote: So, this is not an installer issue. Is this bug

Re: [HACKERS] PostgreSQL Service on Windows does not start. ~ is not a valid Win32 application

2013-10-30 Thread Asif Naeem
On Thu, Oct 31, 2013 at 10:17 AM, Amit Kapila amit.kapil...@gmail.comwrote: On Tue, Oct 29, 2013 at 12:46 PM, Naoya Anzai anzai-na...@mxu.nes.nec.co.jp wrote: Hi Sandeep I think, you should change the subject line to Unquoted service path containing space is vulnerable and can be

Re: [HACKERS] [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation

2014-01-15 Thread Asif Naeem
(), 771 errmsg(could not remove symbolic link \%s\: %m, 772 linkloc))); 773 } …. Other than this patch looks good to me. Regards, Muhammad Asif Naeem On Thu, Oct 31, 2013 at 8:03 PM

Re: [HACKERS] [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation

2014-01-15 Thread Asif Naeem
(linkloc) 0 errno != ENOENT) + #endif ereport(ERROR, (errcode_for_file_access(), errmsg(could not remove symbolic link \%s\: %m, What is your opinion about it, Is it not worth changing ? . Thanks. On Wed, Jan 15, 2014 at 7:42 PM, MauMau maumau...@gmail.com wrote: From: Asif Naeem

Re: [HACKERS] [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder

2014-01-31 Thread Asif Naeem
function available that effects only subsequent calls to LoadLibrary and LoadLibraryEx. I will look into this patch further and let you know about my more findings. Thanks. Regards, Muhammad Asif Naeem On Wed, Dec 4, 2013 at 5:07 PM, MauMau maumau...@gmail.com wrote: From: MauMau maumau

Re: [HACKERS] Extending MSVC scripts to support --with-extra-version

2014-06-26 Thread Asif Naeem
on Unix like OS/MinGW) or It is intended for Window specific requirement ?. Thanks. Regards, Muhammad Asif Naeem On Tue, May 27, 2014 at 5:58 AM, Michael Paquier michael.paqu...@gmail.com wrote: Hi all, Please find attached a patch extending support of --with-extra-version in the MSVC scripts

Re: [HACKERS] Extending MSVC scripts to support --with-extra-version

2014-06-30 Thread Asif Naeem
-- PostgreSQL 9.5devel-30JUN, compiled by Visual C++ build 1600, 64-bit (1 row) C:\PG\postgresql\inst_withpatch_v2_extra-versionbin\initdb.exe -V initdb (PostgreSQL) 9.5devel-30JUN Patch looks good to me. I think it is ready for committer. Thanks. Regards, Muhammad Asif Naeem On Fri

Re: [HACKERS] [BUGS] BUG #9652: inet types don't support min/max

2014-06-30 Thread Asif Naeem
: Is there any other utility required to apply the patch, Can you please guide ?. Thanks. Regards, Muhammad Asif Naeem On Thu, Jun 5, 2014 at 6:28 AM, Haribabu Kommi kommi.harib...@gmail.com wrote: On Thu, Jun 5, 2014 at 9:12 AM, Andres Freund and...@2ndquadrant.com wrote: Hi, On 2014-06

Re: [HACKERS] [BUGS] BUG #9652: inet types don't support min/max

2014-07-07 Thread Asif Naeem
On Mon, Jun 30, 2014 at 4:45 PM, Abhijit Menon-Sen a...@2ndquadrant.com wrote: At 2014-06-30 16:35:45 +0500, anaeem...@gmail.com wrote: pc1dotnetpk:postgresql asif$ patch -p0 ~/core/min_max_support_for_inet_datatypes/inet_agg_v4.patch can't find file to patch at input line 3

Re: [HACKERS] [BUGS] BUG #9652: inet types don't support min/max

2014-07-07 Thread Asif Naeem
source code, general practice seems to be to use “smaller and “larger” as related function name postfix e.g. timestamp_smaller()/timestamp_larger(), interval_smaller/interval_larger(), cashsmaller()/cashlarger() etc. Thanks. Regards, Muhammad Asif Naeem On Mon, Jul 7, 2014 at 1:56 PM, Asif Naeem

Re: [HACKERS] [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder

2014-07-07 Thread Asif Naeem
Hi MauMau, Other than my pervious comments, patch looks good to me. Thanks. Regards, Muhammad Asif Naeem On Wed, Feb 26, 2014 at 2:14 AM, Peter Eisentraut pete...@gmx.net wrote: You should be able to do this without specifically referencing the names libpq or ecpg. Look into the Makefile

Re: [HACKERS] [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder

2014-07-08 Thread Asif Naeem
Yes. Can you please take a look at Win_lib_bin.patch I shared earlier ?, I think it is or similar approach will be appropriate. Thanks. Regards, Muhammad Asif Naeem On Tue, Jul 8, 2014 at 5:53 PM, MauMau maumau...@gmail.com wrote: From: Asif Naeem anaeem...@gmail.com Other than my pervious

Re: [HACKERS] [BUGS] BUG #9652: inet types don't support min/max

2014-07-24 Thread Asif Naeem
of replaceable Other than this patch looks good to me. Thanks. Regards, Muhammad Asif Naeem On Wed, Jul 9, 2014 at 6:21 PM, Haribabu Kommi kommi.harib...@gmail.com wrote: On Mon, Jul 7, 2014 at 6:59 PM, Asif Naeem anaeem...@gmail.com wrote: Hi Haribabu, Thank you for sharing the patch. I

Re: [HACKERS] [BUGS] BUG #9652: inet types don't support min/max

2014-08-03 Thread Asif Naeem
Thank you Haribabu. Please see my comments inlined below i.e. On Sun, Jul 27, 2014 at 11:42 AM, Haribabu Kommi kommi.harib...@gmail.com wrote: On Thu, Jul 24, 2014 at 5:59 PM, Asif Naeem anaeem...@gmail.com wrote: Sorry for being late. Thank you for sharing updated patch, sgml changes seems

Re: [HACKERS] [BUGS] BUG #9652: inet types don't support min/max

2014-08-18 Thread Asif Naeem
this patch looks good to me, please share updated patch and feel free to assign it to committer. Thanks. Regards, Muhammad Asif Naeem On Tue, Aug 12, 2014 at 3:12 PM, Haribabu Kommi kommi.harib...@gmail.com wrote: On Mon, Aug 4, 2014 at 3:22 PM, Asif Naeem anaeem...@gmail.com wrote: Sorry

Re: [HACKERS] Add shutdown_at_recovery_target option to recovery.conf

2014-10-29 Thread Asif Naeem
segment from archive LOG: restored log file 00010005 from archive DEBUG: got WAL segment from archive LOG: restored log file 00010006 from archive DEBUG: got WAL segment from archive … Is that right ?. Thanks. Regards, Muhammad Asif Naeem On Thu, Oct 16

[HACKERS] chkpass with RANDOMIZE_ALLOCATED_MEMORY

2015-02-13 Thread Asif Naeem
value for DES based result. PFA patch, to generate consistent results, it uses constant salt value. It seems a minor inconvenience but it will make results better. Please do let me know if I missed something or more information is required. Thanks. Regards, Muhammad Asif Naeem

Re: [HACKERS] Install shared libs in lib/ and bin/ with MSVC (Was: install libpq.dll in bin directory on Windows / Cygwin)

2015-03-12 Thread Asif Naeem
Thank you Michael overall v3 patch looks good to me, There is one observation that it is not installing following lib files that are required for dev work i.e. inst\lib\libpq.lib inst\lib\libpgtypes.lib inst\lib\libecpg_compat.lib inst\lib\libecpg.lib Please do let me know if I missed

Re: [HACKERS] chkpass with RANDOMIZE_ALLOCATED_MEMORY

2015-03-03 Thread Asif Naeem
Thank you Tom, Thank you Amit. Regards, Muhammad Asif Naeem On Wed, Mar 4, 2015 at 9:30 AM, Tom Lane t...@sss.pgh.pa.us wrote: Amit Kapila amit.kapil...@gmail.com writes: On Sat, Feb 14, 2015 at 10:26 PM, Tom Lane t...@sss.pgh.pa.us wrote: It's not a false alarm, unfortunately, because

Re: [HACKERS] New CF app deployment

2015-02-27 Thread Asif Naeem
On Fri, Feb 27, 2015 at 11:32 AM, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: On 02/26/2015 01:59 PM, Michael Paquier wrote: On Thu, Feb 26, 2015 at 9:15 PM, Asif Naeem anaeem...@gmail.com wrote: This thread seems relevant, Please guide me to how can access older CF pages

Re: [HACKERS] New CF app deployment

2015-02-27 Thread Asif Naeem
Thank you Michael, It works. On Thu, Feb 26, 2015 at 5:59 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Feb 26, 2015 at 9:15 PM, Asif Naeem anaeem...@gmail.com wrote: This thread seems relevant, Please guide me to how can access older CF pages The MSVC portion of this fix

Re: [HACKERS] Install shared libs in lib/ and bin/ with MSVC (Was: install libpq.dll in bin directory on Windows / Cygwin)

2015-03-03 Thread Asif Naeem
redundant now, is there any use for them other than backward compatibility ? i.e. inst\lib\libpq.dll inst\lib\libpgtypes.dll inst\lib\libecpg_compat.dll inst\lib\libecpg.dll Thanks. Regards, Muhammad Asif Naeem On Tue, Jan 20, 2015 at 6:06 AM, Michael Paquier michael.paqu...@gmail.com wrote: Hi

Re: [HACKERS] New CF app deployment

2015-02-26 Thread Asif Naeem
://commitfest.postgresql.org/action/patch_view?id=1330 Above link result in the following error i.e. Not found The specified URL was not found. Please do let me know if I missed something. Thanks. Regards, Muhammad Asif Naeem On Tue, Feb 24, 2015 at 11:59 PM, Peter Eisentraut pete...@gmx.net

Re: [HACKERS] Fix broken Install.bat when target directory contains a space

2015-04-21 Thread Asif Naeem
, If you like please feel free to change status to ready for committer. Thanks. On Fri, Apr 17, 2015 at 10:36 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Apr 16, 2015 at 5:40 PM, Asif Naeem wrote: Along with fixing the space in installation path, it is also changing the behavior

Re: [HACKERS] Fix broken Install.bat when target directory contains a space

2015-04-21 Thread Asif Naeem
Thank you Michael, latest patch looks good to me. I have changed its status to ready for committer. Regards, Muhammad Asif Naeem On Tue, Apr 21, 2015 at 6:02 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, Apr 21, 2015 at 4:33 PM, Asif Naeem anaeem...@gmail.com wrote: The v2

Re: [HACKERS] Fix broken Install.bat when target directory contains a space

2015-04-16 Thread Asif Naeem
that (2) shows usage message as 'Usage:* install.pl http://install.pl* targetdir [installtype]' but (3) shows usage message as 'Usage: *install.bat* path'. Thanks. Regards, Muhammad Asif Naeem On Mon, Mar 2, 2015 at 9:27 AM, Michael Paquier michael.paqu...@gmail.com wrote: Hi all, When using

Re: [HACKERS] 9.5: Can't connect with PGSSLMODE=require on Windows

2015-09-28 Thread Asif Naeem
elp" for help. > postgres=# select version(); > version > - > PostgreSQL 9.5alpha2, compiled by Visual C++ build 1800, 64-bit > (1 row) Regards, Muhammad Asif Naeem On Thu, Sep 24

Re: [HACKERS] 9.5: Can't connect with PGSSLMODE=require on Windows

2015-09-29 Thread Asif Naeem
> Type "help" for help. > postgres=# select version(); > version > - > PostgreSQL 9.5alpha2, compiled by Visual C++ build 1800, 64-bit > (1 row) Regards, Muhammad Asif Naeem

Re: [HACKERS] Truncating/vacuuming relations on full tablespaces

2016-06-20 Thread Asif Naeem
Thank you for useful suggestions. PFA patch, I have tried to cover all the points mentioned. Regards, Muhammad Asif Naeem On Wed, Apr 6, 2016 at 9:06 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Apr 6, 2016 at 3:32 AM, Asif Naeem <anaeem...@gmail.com> wrote: > >

Re: [HACKERS] Truncating/vacuuming relations on full tablespaces

2016-04-06 Thread Asif Naeem
> [asif@centos66 inst_96]$ find . | grep base/13250/16384 > ./data/base/13250/16384 > postgres=# vacuum test1; > VACUUM > [asif@centos66 inst_96]$ find . | grep base/13250/16384 > ./data/base/13250/16384 > ./data/base/13250/16384_fsm > ./data/base/13250/16384_vm Please do

Re: [HACKERS] Truncating/vacuuming relations on full tablespaces

2016-04-07 Thread Asif Naeem
On Thu, Apr 7, 2016 at 2:15 AM, Jim Nasby wrote: > On 4/6/16 11:06 AM, Robert Haas wrote: > >> This is too late for 9.6 at this point and certainly requires >> discussion anyway, so please add it to the next CommitFest. >> > > If the goal here is to free up space via

Re: [HACKERS] Truncating/vacuuming relations on full tablespaces

2016-04-07 Thread Asif Naeem
Thank you Robert. Sure, I will add the updated patch on the next CommitFest with all the suggested changes. On Wed, Apr 6, 2016 at 9:06 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Apr 6, 2016 at 3:32 AM, Asif Naeem <anaeem...@gmail.com> wrote: > >> Oh, I see

Re: [HACKERS] Truncating/vacuuming relations on full tablespaces

2016-04-22 Thread Asif Naeem
On Wed, Apr 6, 2016 at 9:06 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Apr 6, 2016 at 3:32 AM, Asif Naeem <anaeem...@gmail.com> wrote: > >> Oh, I see. I think it's probably not a good idea to skip truncating > >> those maps, but perhaps the option

Re: [HACKERS] pgcrypto compilation error due to stack-allocated EVP_CIPHER_CTX

2016-12-08 Thread Asif Naeem
eful I will be able to share all my findings tomorrow. Thanks. On Wed, Dec 7, 2016 at 2:23 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Dec 6, 2016 at 11:42 PM, Asif Naeem <anaeem...@gmail.com> wrote: > > Thanks for updated patch. Although EVP_CIPHER_CTX_cle

Re: [HACKERS] pgcrypto compilation error due to stack-allocated EVP_CIPHER_CTX

2016-12-06 Thread Asif Naeem
f I guess use of deprecated function is fine, until OpenSSL library support it. On Tue, Dec 6, 2016 at 6:15 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Dec 6, 2016 at 9:31 PM, Asif Naeem <anaeem...@gmail.com> wrote: > > Thank you for v2 patch, I would like

Re: [HACKERS] pgcrypto compilation error due to stack-allocated EVP_CIPHER_CTX

2016-12-06 Thread Asif Naeem
Hi Michael, Thank you for v2 patch, I would like to comment on it. It seems that you have used function EVP_CIPHER_CTX_reset in the patch that was introduced in OpenSSL 1.1.0, older library version might not work now, is it intentional change ?. Regards, Muhammad Asif Naeem On Tue, Dec 6, 2016