Re: [HACKERS] per-user pg_service.conf

2010-01-15 Thread Christoph Berg
I was surprised/annoyed to find out that there is no way to have per-user pg_service.conf, something like ~/.pg_service.conf (well, except by export PGSYSCONFDIR). That would be easy to add. Comments? Here's a patch. Perhaps those who had said they would like that can validate the

[HACKERS] pl/perl and utf-8 in sql_ascii databases

2012-02-09 Thread Christoph Berg
Hi, we have a database that is storing strings in various encodings (and non-encodings, namely the arbitrary byte soup that you might see in email headers from the internet). For this reason, the database uses sql_ascii encoding. The columns are text, as most characters are ascii, so bytea didn't

Re: [HACKERS] pl/perl and utf-8 in sql_ascii databases

2012-02-13 Thread Christoph Berg
Re: Alex Hunsaker 2012-02-10 cafapbrr9y1fu6gpvu+8ta8vty6qvcm3dfarkt8jg_ehgetx...@mail.gmail.com Does the attached fix the issue for you? Yes. :) Christoph -- c...@df7cb.de | http://www.df7cb.de/ signature.asc Description: Digital signature

[HACKERS] [trivial patch] typo in doc/src/sgml/sepgsql.sgml

2012-02-15 Thread Christoph Berg
diff --git a/doc/src/sgml/sepgsql.sgml b/doc/src/sgml/sepgsql.sgml index e45c258..ee0a255 100644 *** a/doc/src/sgml/sepgsql.sgml --- b/doc/src/sgml/sepgsql.sgml *** UPDATE t1 SET x = 2, y = md5sum(y) WHERE *** 358,364 /synopsis In this case we must have

Re: [HACKERS] [trivial patch] typo in doc/src/sgml/sepgsql.sgml

2012-02-15 Thread Christoph Berg
Re: Robert Haas 2012-02-15 ca+tgmozjutszhpxwwzcm4kjjwh__1admo3kosbbq+fhscqp...@mail.gmail.com Fixed, but note that I had to recreate the patch by manual examination. Including it inline tends to garble things. Hmm, I thought I had :set paste and everything... (It is unclear to me why the

Re: [HACKERS] Runtime SHAREDIR for testing CREATE EXTENSION

2012-02-24 Thread Christoph Berg
Re: Sandro Santilli 2012-02-22 20120222101656.GB6125@gnash I'm not really looking for inline extensions. I do want to install the extension objects somewhere, just NOT in the PostgreSQL builtin SHAREDIR but in an arbitrary staging directory to use for QA the extension before distribution. We

Re: [HACKERS] Runtime SHAREDIR for testing CREATE EXTENSION

2012-02-25 Thread Christoph Berg
Re: Peter Eisentraut 2012-02-24 1330107599.32452.15.ca...@vanquo.pezone.net On fre, 2012-02-24 at 11:53 -0500, Tom Lane wrote: We have the same problem with testing extensions at build-time in the Debian packages. The server's SHAREDIR /usr/share/postgresql/... is only writable by

[HACKERS] psql patch: tab-complete :variables also at buffer start

2011-02-10 Thread Christoph Berg
Currently, tab-completing :variable names in psql does not work at the beginning of the line. Fix this by moving the code block before the empty buffer case. (I have several sql macros in my .psqlrc like :relsize that prints table sizes in a nicely formatted way, being able to type :tab would be

[HACKERS] configure.in and setproctitle/optreset problem

2012-12-17 Thread Christoph Berg
We are regularly teaching PostgreSQL courses at linuxhotel.de. Starting from the course in November, PG doesn't compile anymore on their default Debian Squeeze install laptops they hand out to the participants. After ./configure make, the error looks like this: postmaster/postmaster.o: In

Re: [HACKERS] configure.in and setproctitle/optreset problem

2012-12-18 Thread Christoph Berg
Re: Tom Lane 2012-12-18 26465.1355798...@sss.pgh.pa.us I think we should assume that the libedit developers are utterly clueless about not trampling on application namespace, and just cut that library out of *all* our link checks except for the symbols we specifically expect to get from

Re: [HACKERS] configure.in and setproctitle/optreset problem

2012-12-19 Thread Christoph Berg
is -l{readline,edit} included in these configure checks at all? Most (if not all) of the function checks in that block are not related to input editing anyway. Mit freundlichen Grüßen, Christoph Berg -- Tel.: +49 (0)21 61 / 46 43-187 credativ GmbH, HRB Mönchengladbach 12080 Hohenzollernstr. 133

Re: [HACKERS] PL/perl should fail on configure, not make

2013-01-09 Thread Christoph Berg
Re: Tom Lane 2013-01-09 9802.1357702...@sss.pgh.pa.us Item: there is not a test for perl.h, as such, in configure. There probably should be, just because we have comparable tests for tcl.h and Python.h. However, adding one won't fix your problem on Debian-based distros, because for some

Re: [HACKERS] Notify system doesn't recover from No space error

2012-07-25 Thread Christoph Berg
Re: Tom Lane 2012-07-02 18088.1341245...@sss.pgh.pa.us Christoph Berg christoph.b...@credativ.de writes: What is still puzzling me is that the customer is repeatedly reporting these issues, even after rebooting the system. Hm. A server restart really ought to clear any problem

Re: [HACKERS] invalid search_path complaints

2012-04-10 Thread Christoph Berg
Re: Tom Lane 2012-04-04 28647.1333558...@sss.pgh.pa.us Now, Scott's comment seems to me to offer a principled way out of this: if we define the intended semantics of search_path as being similar to the traditional understanding of Unix PATH, then it's not an error or even unexpected to have

[HACKERS] [trivial patch] grammar fixes in doc/src/sgml/high-availability.sgml

2012-04-13 Thread Christoph Berg
diff --git a/doc/src/sgml/high-availability.sgml b/doc/src/sgml/high-availability.sgml new file mode 100644 index ed34dac..c5f3ff9 *** a/doc/src/sgml/high-availability.sgml --- b/doc/src/sgml/high-availability.sgml *** primary_conninfo = 'host=192.168.1.50 po *** 1022,1028

Re: [HACKERS] Notify system doesn't recover from No space error

2012-06-29 Thread Christoph Berg
[Resending as the original post didn't get through to the list] Warming up an old thread here - we ran into the same problem. Database is 9.1.4/x86_64 from Debian/testing. The client application is bucardo hammering the database with NOTIFYs (including some master-master replication conflicts,

Re: [HACKERS] Notify system doesn't recover from No space error

2012-07-02 Thread Christoph Berg
Re: Tom Lane 2012-06-29 8308.1340933...@sss.pgh.pa.us in async.c that would try to create the missing page. This error will persist until the server is restarted (thus resetting the state of pg_notify), even if the underlying disk-full condition is cleared. Thanks for digging into this and

Re: [HACKERS] Call for Google Summer of Code mentors, admins

2013-02-19 Thread Christoph Berg
Re: Andres Freund 2013-02-18 20130218213711.ga1...@awork2.anarazel.de On 2013-02-14 10:02:13 -0800, Josh Berkus wrote: - Please suggest project ideas for GSOC pg_upgrade support for debian's pg_upgradecluster We'd need Peter to be the student for that one :)

Re: [HACKERS] Re: [BUGS] BUG #8043: 9.2.4 doesn't open WAL files from archive, only looks in pg_xlog

2013-04-09 Thread Christoph Berg
Re: Jeff Janes 2013-04-06 CAMkU=1zvioqvmgbwsshv3dnxmneejmqtq_5hjqlgx8i4ega...@mail.gmail.com I don't think the docs are very clear on that. They say This file will of course be archived as a part of your backup dump file, but will be does not imply must be. Elsewhere it emphasizes that the

[HACKERS] [PATCH] pg_regress and non-default unix socket path

2013-04-09 Thread Christoph Berg
Hi, Debian has been patching pg_regress for years because our default unix socket directory is /var/run/postgresql, but that is not writable by the build user at build time. This used to be a pretty ugly make- patch-make check-unpatch-make install patch dance, but now it is a pretty patch that

Re: [HACKERS] [PATCH] pg_regress and non-default unix socket path

2013-04-12 Thread Christoph Berg
Re: To PostgreSQL Hackers 2013-04-09 20130409120807.gd26...@msgid.df7cb.de If the patch looks too intrusive at this stage of the release, it would be enough if the last chunk got included, which should really be painless: diff --git a/src/test/regress/pg_regress.c

Re: [HACKERS] [PATCH] pg_regress and non-default unix socket path

2013-04-14 Thread Christoph Berg
Re: Tom Lane 2013-04-12 20318.1365786...@sss.pgh.pa.us Robert Haas robertmh...@gmail.com writes: The hunk that changes the messages might need some thought so that it doesn't cause a translation regression. But in general I see no reason not to do this before we release beta1. It seems

[HACKERS] [patch] PSQLDIR not passed to pg_regress in contrib/pg_upgrade/test.sh

2013-05-07 Thread Christoph Berg
make check-world in 9.3beta1 fails if you don't actually have 9.3 installed. In contrib/pg_upgrade/test.sh, it will try pg_regress --psqldir=/usr/lib/postgresql/9.3/bin which doesn't exist. +

[HACKERS] [patch] Adding EXTRA_REGRESS_OPTS to all pg_regress invocations

2013-05-07 Thread Christoph Berg
make check supports EXTRA_REGRESS_OPTS to pass extra options to pg_regress, but all the other places where pg_regress is used do not allow this. The attached patch adds EXTRA_REGRESS_OPTS to Makefile.global.in (for contrib modules) and two more special Makefiles (isolation and pg_upgrade). The

[HACKERS] plperl segfault in plperl_trusted_init() on kfreebsd

2013-05-15 Thread Christoph Berg
The newly activated make check-world on Debian (I haven't found the time yet to follow up on the other threads I opened for that, sorry) actually found something: plperl and plperlu segfault on the kfreebsd-amd64 and kfreebsd-i386 architectures. These are FreeBSD 9 kernels with a GNU/Debian

Re: [HACKERS] plperl segfault in plperl_trusted_init() on kfreebsd

2013-05-15 Thread Christoph Berg
Re: Tom Lane 2013-05-15 244.1368675...@sss.pgh.pa.us You sure that wholesale override of CFLAGS is a good idea? This report doesn't show what flags the rest of your system was built with, but seems like there could be a compatibility issue. Or maybe you prevented plperl from being built with

Re: [HACKERS] plperl segfault in plperl_trusted_init() on kfreebsd

2013-05-16 Thread Christoph Berg
Re: Stephen Frost 2013-05-16 20130516123344.gt4...@tamriel.snowman.net * Christoph Berg (c...@df7cb.de) wrote: That was because the plain ./configure version (for a minimal way to reproduce) didn't built with debug symbols. The original gcc line from the Debian build log is: It did

Re: [HACKERS] plperl segfault in plperl_trusted_init() on kfreebsd

2013-05-21 Thread Christoph Berg
Re: Andrew Dunstan 2013-05-17 51964770.6070...@dunslane.net I have reproduced this. It happens with both the distro perl and a home-built perl 5.14. AFAICT this is a Perl bug. Any reference at all to ERRSV at the point this occurs causes a core dump, even just assigning it to a local SV *

Re: [HACKERS] PostgreSQL 9.3 beta breaks some extensions make install

2013-05-23 Thread Christoph Berg
Re: Cédric Villemain 2013-05-17 201305171642.59241.ced...@2ndquadrant.com If it seems to be on the right way, I'll keep fixing EXTENSION building with VPATH. I haven't tried the patch, but let me just say that Debian (and apt.postgresql.org) would very much like the VPATH situation getting

Re: [HACKERS] PostgreSQL 9.3 beta breaks some extensions make install

2013-05-25 Thread Christoph Berg
Re: Cédric Villemain 2013-05-25 201305251641.28401.ced...@2ndquadrant.com I just took time to inspect our contribs, USE_PGXS is not supported by all of them atm because of SHLIB_PREREQS (it used submake) I have a patch pending here to fix that. Once all our contribs can build with USE_PGXS I

[HACKERS] [trivial patch] Ellipsis whitespace in SQL docs

2010-11-29 Thread Christoph Berg
Hi, here's a trivial patch: Changed several occurrences of ,... to , ... in SQL syntax to be consistent with the rest. diff --git a/doc/src/sgml/ref/alter_default_privileges.sgml b/doc/src/sgml/ref/alter_default_privileges.sgml index e1aa293..c27466f 100644 ***

Re: [HACKERS] psql 9.1 alpha5: connection pointer is NULL

2011-04-22 Thread Christoph Berg
Re: Tom Lane 2011-04-03 1397.1301782...@sss.pgh.pa.us Yeah, that's clearly a bug --- fix committed, thanks for the patch! It could explain Devrim's report if the parameters passed by psql had some problem that was detectable by conninfo_array_parse(). That seems a bit unlikely, but I did

[HACKERS] extra_float_digits and casting from real to numeric

2014-01-07 Thread Christoph Berg
A customer recently upgraded their jdbc driver from 8.4 to 9.2. This enabled the binary wire protocol (effectively between 9.1 and 9.2). They reported that single precision values inserted into a numeric(10,2) column were suddenly rounded wrongly, i.e. 1.18 was inserted as 1.20, while that

Re: [HACKERS] extra_float_digits and casting from real to numeric

2014-01-08 Thread Christoph Berg
Re: Tom Lane 2014-01-07 14979.1389112...@sss.pgh.pa.us But if extra_float_digits 0 is set, I'd expect not only the float4 output to be affected by it, but also casts to other datatypes, This proposal scares me. extra_float_digits is strictly a matter of I/O representation, it does not

Re: [HACKERS] [doc patch] extra_float_digits and casting from real to numeric

2014-02-04 Thread Christoph Berg
Re: To Tom Lane 2014-01-08 20140108094017.ga20...@msgid.df7cb.de What about this patch to mention this gotcha more explicitely in the documentation? diff --git a/doc/src/sgml/datatype.sgml b/doc/src/sgml/datatype.sgml new file mode 100644 index 0386330..968f4a7 ***

Re: [HACKERS] [doc patch] extra_float_digits and casting from real to numeric

2014-02-06 Thread Christoph Berg
. Including some explicit heads-up sentence in there solves that problem, either your version, or mine. Mit freundlichen Grüßen, Christoph Berg -- Tel.: +49 (0)21 61 / 46 43-187 credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209 Hohenzollernstr. 133, 41061 Mönchengladbach

Re: [HACKERS] [BUG] Archive recovery failure on 9.3+.

2014-02-12 Thread Christoph Berg
Re: Heikki Linnakangas 2014-01-13 52d3caff.3010...@vmware.com Actually, why is the partially-filled 00010002 file archived in the first place? Looking at the code, it's been like that forever, but it seems like a bad idea. If the original server is still up and running, and

Re: [HACKERS] [BUG] Archive recovery failure on 9.3+.

2014-02-13 Thread Christoph Berg
00010002 00010002.0020.backup The 9.3 log/ls looks the same. Mit freundlichen Grüßen, Christoph Berg -- Senior Berater, Tel.: +49 (0)21 61 / 46 43-187 credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209 Hohenzollernstr. 133, 41061 Mönchengladbach

Re: [HACKERS] [BUG] Archive recovery failure on 9.3+.

2014-02-13 Thread Christoph Berg
, Christoph Berg -- Senior Berater, Tel.: +49 (0)21 61 / 46 43-187 credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209 Hohenzollernstr. 133, 41061 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer pgp fingerprint: 5C48 FE61 57F4 9179 5970 87C6 4C5A 6BAB 12D2 A7AE

Re: [HACKERS] [BUG] Archive recovery failure on 9.3+.

2014-02-13 Thread Christoph Berg
postgresql.conf (and docs)... Otoh, it's still not nice that this could still be an archive command that fails, i.e. requires admin intervention before archiving can proceed. Mit freundlichen Grüßen, Christoph Berg -- Senior Berater, Tel.: +49 (0)21 61 / 46 43-187 credativ GmbH, HRB Mönchengladbach 12080

Re: [HACKERS] Useless Replica Identity: NOTHING noise from psql \d

2014-03-27 Thread Christoph Berg
Re: Bruce Momjian 2014-03-26 20140326161056.ga...@momjian.us The attached patch matches your suggestion. It is basically back to what the code originally had, except it skips system tables, and shows ??? for invalid values. Fwiw, make check-world is currently broken:

Re: [HACKERS] Useless Replica Identity: NOTHING noise from psql \d

2014-03-27 Thread Christoph Berg
Re: Bruce Momjian 2014-03-27 20140327131048.ga11...@momjian.us On Thu, Mar 27, 2014 at 10:02:20AM +0100, Christoph Berg wrote: Re: Bruce Momjian 2014-03-26 20140326161056.ga...@momjian.us The attached patch matches your suggestion. It is basically back to what the code originally had

Re: [HACKERS] Useless Replica Identity: NOTHING noise from psql \d

2014-03-27 Thread Christoph Berg
updating the scripts when something new gets included in PostgreSQL itself. The pg_upgrade test is included. Mit freundlichen Grüßen, Christoph Berg -- Senior Berater, Tel.: +49 (0)21 61 / 46 43-187 credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209 Hohenzollernstr. 133, 41061

Re: [HACKERS] [patch] Adding EXTRA_REGRESS_OPTS to all pg_regress invocations

2014-03-27 Thread Christoph Berg
Re: Bruce Momjian 2013-12-04 20131204151533.gb17...@momjian.us On Mon, May 6, 2013 at 11:51:47PM -0700, Christoph Berg wrote: make check supports EXTRA_REGRESS_OPTS to pass extra options to pg_regress, but all the other places where pg_regress is used do not allow this. The attached patch

Re: [HACKERS] Doing better at HINTing an appropriate column within errorMissingColumn()

2014-03-28 Thread Christoph Berg
Re: Albe Laurenz 2014-03-28 a737b7a37273e048b164557adef4a58b17ce8...@ntex2010i.host.magwien.gv.at ERROR: 42703: column ol.orderids does not exist LINE 1: ...* from orders o join orderlines ol on o.orderid = ol.orderid... ^

Re: [HACKERS] Securing make check (CVE-2014-0067)

2014-03-29 Thread Christoph Berg
Re: Noah Misch 2014-03-24 20140323230420.ga4139...@tornado.leadboat.com On Thu, Mar 06, 2014 at 11:52:22PM -0500, Noah Misch wrote: On Thu, Mar 06, 2014 at 12:44:34PM -0500, Tom Lane wrote: I'm inclined to suggest that we should put the socket under $CWD by default, but provide some way

Re: [HACKERS] Securing make check (CVE-2014-0067)

2014-03-30 Thread Christoph Berg
Re: Noah Misch 2014-03-30 20140330014531.ge170...@tornado.leadboat.com On Sat, Mar 29, 2014 at 10:04:55AM +0100, Christoph Berg wrote: Fwiw, to relocate the pg_regress socket dir, there is already the possibility to run make check EXTRA_REGRESS_OPTS=--host=/tmp. (With the pending fix I sent

Re: [HACKERS] Securing make check (CVE-2014-0067)

2014-03-31 Thread Christoph Berg
Re: Tom Lane 2014-03-31 22183.1396293...@sss.pgh.pa.us Enable pg_regress --host=/path/to/socket: https://alioth.debian.org/scm/loggerhead/pkg-postgresql/postgresql-9.4/trunk/view/head:/debian/patches/60-pg_regress_socketdir.patch Wasn't this patch submitted for inclusion in PostgreSQL at

[HACKERS] includedir_internal headers are not self-contained

2014-04-26 Thread Christoph Berg
Debian is shipping client headers in /usr/include/postgresql in the libpq-dev package. The server headers go into /usr/include/postgresql/major/server in postgresql-server-dev-major, so we can have the headers for several majors installed in parallel. Historically, a few server headers were also

Re: [HACKERS] includedir_internal headers are not self-contained

2014-04-27 Thread Christoph Berg
Re: Tom Lane 2014-04-26 21449.1398524...@sss.pgh.pa.us internal/postgres_fe.h includes common/fe_memutils.h which includes utils/palloc.h Hm. It seems rather fundamentally broken to me that frontend code is including palloc.h --- that file was never intended to be frontend-safe,

Re: [HACKERS] includedir_internal headers are not self-contained

2014-04-28 Thread Christoph Berg
Re: Heikki Linnakangas 2014-04-28 535e09b7.3090...@vmware.com Comments? If there's anyone who has a really good use-case for using relpath() from outside the backend, better speak up. I'm using it in the pg_rewind tool. It needs to know how to map relfilenodes to physical files. It has

Re: [HACKERS] includedir_internal headers are not self-contained

2014-05-02 Thread Christoph Berg
Re: Tom Lane 2014-05-02 9995.1398994...@sss.pgh.pa.us The patch is certainly too invasive to consider back-patching into 9.3, though. Understood. I feel unsure about this. I agree the patch is quite invasive. Leaving 9.3 in a broken state seems problematic. In particular I'm not sure

[HACKERS] postgresql.auto.conf read from wrong directory

2014-05-06 Thread Christoph Berg
Hi, if you split configuration and data by setting data_directory, postgresql.auto.conf is writen to the data directory (/var/lib/postgresql/9.4/main in Debian), but tried to be read from the etc directory (/etc/postgresql/9.4/main). One place to fix it would be in ProcessConfigFile in

Re: [HACKERS] tab completion for setting search_path

2014-05-06 Thread Christoph Berg
Re: Jeff Janes 2014-05-05 CAMkU=1yo97bcGR-z6wg-OJpHKfEcaaaS=x1n7xygxcuakv5...@mail.gmail.com I've personally never had a need to set the search_path to a system schema, and I guess I was implicitly modelling this on what is returned by \dn, not by \dnS. I wouldn't object much to including

Re: [HACKERS] postgresql.auto.conf read from wrong directory

2014-05-07 Thread Christoph Berg
Re: Amit Kapila 2014-05-07 caa4ek1ktjkpvmnkos2gfnnh2zsko4ggdspswshjbq1cpu9e...@mail.gmail.com This problem occurs because we don't have the value of data_directory set in postgresql.conf by the time we want to parse .auto.conf file during server start. The value of data_directory is only

Re: [HACKERS] postgresql.auto.conf read from wrong directory

2014-05-08 Thread Christoph Berg
Re: Andres Freund 2014-05-08 20140508145901.gb1...@awork2.anarazel.de Maybe this is nitpicking, but what happens when postgresql.auto.conf also includes the setting of data_directory? This is possible because we can set data_directory via ALTER SYSTEM now. Should we just ignore such

[HACKERS] Supporting tcl 8.6

2014-05-10 Thread Christoph Berg
Hi, the current tcl version is 8.6, and configure should recognize it. The attached patch has been in the Debian/Ubuntu packages for a while, so it's tested. Christoph -- c...@df7cb.de | http://www.df7cb.de/ diff --git a/config/tcl.m4 b/config/tcl.m4 new file mode 100644 index e886057..a9fe7ba

[HACKERS] Updating config.guess/config.sub for ppc64le

2014-05-10 Thread Christoph Berg
Hi, to support ppc64le, config.guess needs to be updated. The attached patch is what was reported to work for Ubuntu. Christoph -- c...@df7cb.de | http://www.df7cb.de/ diff --git a/config/config.guess b/config/config.guess new file mode 100755 index 2055429..b79252d *** a/config/config.guess

Re: [HACKERS] Supporting tcl 8.6

2014-05-10 Thread Christoph Berg
Re: Tom Lane 2014-05-10 27409.1399729...@sss.pgh.pa.us Christoph Berg c...@df7cb.de writes: the current tcl version is 8.6, and configure should recognize it. The attached patch has been in the Debian/Ubuntu packages for a while, so it's tested. While that patch looks harmless enough

Re: [HACKERS] Updating config.guess/config.sub for ppc64le

2014-05-10 Thread Christoph Berg
Re: Tom Lane 2014-05-10 27476.1399729...@sss.pgh.pa.us Christoph Berg c...@df7cb.de writes: to support ppc64le, config.guess needs to be updated. The attached patch is what was reported to work for Ubuntu. Our normal procedure is o update config.guess and config.sub at the start

[HACKERS] New timezones used in regression tests

2014-05-12 Thread Christoph Berg
84df54b22e8035addc7108abd9ff6995e8c49264 introduced timestamp constructors. In the regression tests, various time zones are tested, including America/Metlakatla. Now, if you configure using --with-system-tzdata, you'll get an error if that zone isn't there. Unfortunately, this is what I'm getting

Re: [HACKERS] New timezones used in regression tests

2014-05-12 Thread Christoph Berg
Re: To PostgreSQL Hackers 2014-05-12 20140512214025.ga31...@msgid.df7cb.de 84df54b22e8035addc7108abd9ff6995e8c49264 introduced timestamp constructors. In the regression tests, various time zones are tested, including America/Metlakatla. Now, if you configure using --with-system-tzdata, you'll

Re: [HACKERS] New timezones used in regression tests

2014-05-13 Thread Christoph Berg
Re: Robert Haas 2014-05-13 ca+tgmobvo--rcsrz-u5fma0mo9xvprptwevsw78odceqjcm...@mail.gmail.com On Mon, May 12, 2014 at 7:16 PM, Tom Lane t...@sss.pgh.pa.us wrote: I'm quite unimpressed by the dependency on Mars/Mons_Olympus, too ... that might not fail *today*, but considering it's a real

Re: [HACKERS] Updating config.guess/config.sub for ppc64le

2014-05-13 Thread Christoph Berg
Re: Tom Lane 2014-05-10 27476.1399729...@sss.pgh.pa.us Christoph Berg c...@df7cb.de writes: to support ppc64le, config.guess needs to be updated. The attached patch is what was reported to work for Ubuntu. Our normal procedure is o update config.guess and config.sub at the start

Re: [HACKERS] New timezones used in regression tests

2014-05-13 Thread Christoph Berg
Re: Alvaro Herrera 2014-05-13 20140513135526.gr6...@eldon.alvh.no-ip.org I especially like MTC, Mars Time Coordinated. But whatever scheme gets chosen, it won't be a standard 24h day, so PostgreSQL has a whole lot of different problems to solve than to fix that little Mars/Mons_Olympus gem

Re: [HACKERS] buildfarm / handling (undefined) locales

2014-05-13 Thread Christoph Berg
Re: Tom Lane 2014-05-13 27525.1400012...@sss.pgh.pa.us Heikki Linnakangas hlinnakan...@vmware.com writes: On 05/13/2014 09:58 PM, Tom Lane wrote: ... If so the issue is presumably that the environment variable(s) were set to incorrect values. While we *could* abort in that situation,

[HACKERS] 9.4 beta1 crash on Debian sid/i386

2014-05-13 Thread Christoph Berg
Building 9.4 beta1 on Debian sid/i386 fails during the regression tests. amd64 works fine, as does i386 on the released distributions. parallel group (11 tests): create_cast create_aggregate drop_if_exists typed_table create_function_3 vacuum constraints create_table_like triggers inherit

Re: [HACKERS] %d in log_line_prefix doesn't work for bg/autovacuum workers

2014-05-17 Thread Christoph Berg
Re: Tom Lane 2014-05-17 22961.1400343...@sss.pgh.pa.us I think the key issue comes down to this comment in RenameDatabase: * XXX Client applications probably store the current database somewhere, * so renaming it could cause confusion. On the other hand, there may not * be an

Re: [HACKERS] %d in log_line_prefix doesn't work for bg/autovacuum workers

2014-05-17 Thread Christoph Berg
Re: Andres Freund 2014-05-17 20140517203404.gb4...@awork2.anarazel.de For example, if we allow renaming active databases then the subprocesses in a parallel pg_dump or pg_restore could connect to the wrong database, ie not the one the leader process is connected to. The very best-case

[HACKERS] uuid-ossp (Re: [pgsql-packagers] Postgresapp 9.4 beta build ready)

2014-05-17 Thread Christoph Berg
[redirecting to -hackers] Re: Tom Lane 2014-05-15 31008.1400180...@sss.pgh.pa.us Sandeep Thakkar sandeep.thak...@enterprisedb.com writes: Yes, Jakob is right. On 9.4, we had to patch configure script along with uuid-ossp.c to resolve the uuid issue. I think we need to discuss this on the

Re: [HACKERS] %d in log_line_prefix doesn't work for bg/autovacuum workers

2014-05-17 Thread Christoph Berg
Re: Andres Freund 2014-05-17 20140517211930.ga10...@awork2.anarazel.de On 2014-05-17 23:10:42 +0200, Christoph Berg wrote: Given that there haven't been complaints in the past ten years about how you can't rename an active database, I'm OK personally with locking this down forever

Re: [HACKERS] 9.4 beta1 crash on Debian sid/i386

2014-05-17 Thread Christoph Berg
Re: Tom Lane 2014-05-14 1357.1400028...@sss.pgh.pa.us Christoph Berg c...@df7cb.de writes: Building 9.4 beta1 on Debian sid/i386 fails during the regression tests. amd64 works fine, as does i386 on the released distributions. It would appear that something is wrong with check_stack_depth

Re: [HACKERS] 9.4 beta1 crash on Debian sid/i386

2014-05-18 Thread Christoph Berg
Re: Tom Lane 2014-05-18 9058.1400385...@sss.pgh.pa.us Christoph Berg c...@df7cb.de writes: Re: Tom Lane 2014-05-14 1357.1400028...@sss.pgh.pa.us It would appear that something is wrong with check_stack_depth(), and/or getrlimit(RLIMIT_STACK) is lying to us about the available stack

Re: [HACKERS] 9.4 beta1 crash on Debian sid/i386

2014-05-18 Thread Christoph Berg
Re: Andres Freund 2014-05-18 20140518091445.gu23...@alap3.anarazel.de Did you measure how large the stack actually was when you got the SIGBUS? Should be possible to determine that by computing the offset using some local stack variable in one of the depeest stack frames. Looking at

Re: [HACKERS] 9.4 beta1 crash on Debian sid/i386

2014-05-19 Thread Christoph Berg
Re: Tom Lane 2014-05-18 26862.1400449...@sss.pgh.pa.us OK, so the problem is that getrlimit(RLIMIT_STACK) is lying to us about the available stack depth. I'd classify that as a kernel bug. I wonder if it's a different manifestation of this issue:

Re: [HACKERS] 9.4 beta1 crash on Debian sid/i386

2014-05-19 Thread Christoph Berg
Re: To Tom Lane 2014-05-19 20140519091808.ga7...@msgid.df7cb.de Re: Tom Lane 2014-05-18 26862.1400449...@sss.pgh.pa.us OK, so the problem is that getrlimit(RLIMIT_STACK) is lying to us about the available stack depth. I'd classify that as a kernel bug. I wonder if it's a different

Re: [HACKERS] 9.4 beta1 crash on Debian sid/i386

2014-05-19 Thread Christoph Berg
Re: Andres Freund 2014-05-19 20140519141221.gc5...@alap3.anarazel.de On 2014-05-19 09:53:11 -0400, Tom Lane wrote: I think throwing an error out of a SIGBUS handler is right out. There would be no way to know exactly what code we were interrupting. It's the same reason we don't let, eg,

Re: [HACKERS] 9.4 beta1 crash on Debian sid/i386

2014-05-19 Thread Christoph Berg
Re: To Tom Lane 2014-05-19 20140519144717.gg7...@msgid.df7cb.de Disabling -pie for all 32bit archs seems to be the way to go for us now. FTR, I've just had a look at armhf (arm-linux-gnueabihf), the address layout looks exactly the same there, and 9.3 crashes easily, so it's really a problem of

Re: [HACKERS] Allowing line-continuation in pgbench custom scripts

2014-05-26 Thread Christoph Berg
Re: Tom Lane 2014-05-26 26629.1401119...@sss.pgh.pa.us Yeah, that would be much cleaner. But that would require duplicating the lexing stuff to determine where quotes are and where commands end. There are already some cases where pgbench itself is the bottleneck; adding a lexing step

Re: [HACKERS] [PATCH] Replacement for OSSP-UUID for Linux and BSD

2014-05-26 Thread Christoph Berg
Re: Tom Lane 2014-05-25 12508.1401045...@sss.pgh.pa.us Matteo Beccati p...@beccati.com writes: here's the latest version of my uuid changes patch, according to proposal (2) from Tom in the thread about OSSP-UUID[1]. Hmm ... this is not actually what I had in mind. Unless I'm misreading

Re: [HACKERS] Shared memory changes in 9.4?

2014-06-12 Thread Christoph Berg
[redirecting to -hackers] Re: Robert Haas 2014-05-28 CA+TgmoaTcAd48zW3auWzGdHi_V+QwA5HVCTabqgTq=zlwpy...@mail.gmail.com On Tue, May 27, 2014 at 8:22 PM, Maciek Sakrejda m.sakre...@gmail.com wrote: On Mon, May 26, 2014 at 12:24 AM, Andres Freund and...@2ndquadrant.com wrote: Any chance

Re: [HACKERS] Shared memory changes in 9.4?

2014-06-12 Thread Christoph Berg
Re: Andres Freund 2014-06-12 20140612094112.gz8...@alap3.anarazel.de * Make initdb determine the best shm type for this platform and write it into postgresql.conf as it does now. * If no dynamic_shared_memory_type is found in the config, default to none. * Modify the three identical

Re: [HACKERS] postgresql.auto.conf read from wrong directory

2014-06-15 Thread Christoph Berg
Re: Amit Kapila 2014-06-13 CAA4eK1KLn1SmgVtd=5emabqxrrpveedtbuu94e-repmwxwv...@mail.gmail.com Agreed, I had mentioned in Notes section of document. Apart from that I had disallowed parameters that are excluded from postgresql.conf by initdb (Developer options) and they are recommended in user

Re: [HACKERS] postgresql.auto.conf read from wrong directory

2014-06-16 Thread Christoph Berg
Re: Amit Kapila 2014-06-16 CAA4eK1++wcFswhzH=92qiQFB=C0_Uy=mreadvhzxdrf3jow...@mail.gmail.com Developer options are mainly for debugging information or might help in one of the situations, so I thought somebody might not want them to be part of server configuration once they are set. We

[HACKERS] Is analyze_new_cluster.sh still useful?

2014-06-18 Thread Christoph Berg
Hi, now that we have vacuumdb --all --analyze-in-stages in 9.4, wouldn't it make sense to get rid of the analyze_new_cluster.sh file which pg_upgrade writes? The net content is a single line which could as well be printed by pg_upgrade itself. Instead of an lengthy explanation how to invoke that

Re: [HACKERS] Is analyze_new_cluster.sh still useful?

2014-06-20 Thread Christoph Berg
Re: Tom Lane 2014-06-18 21034.1403110...@sss.pgh.pa.us Christoph Berg christoph.b...@credativ.de writes: now that we have vacuumdb --all --analyze-in-stages in 9.4, wouldn't it make sense to get rid of the analyze_new_cluster.sh file which pg_upgrade writes? The net content is a single line

Re: [HACKERS] Is analyze_new_cluster.sh still useful?

2014-06-20 Thread Christoph Berg
Re: Jeff Janes 2014-06-20 CAMkU=1z3Edq+CNRo4F=jBEzXNMidSskdm=cpcaznogdy2si...@mail.gmail.com On Wed, Jun 18, 2014 at 8:41 AM, Christoph Berg christoph.b...@credativ.de wrote: Hi, now that we have vacuumdb --all --analyze-in-stages in 9.4, wouldn't it make sense to get rid

[HACKERS] postgresql.auto.conf and reload

2014-06-25 Thread Christoph Berg
I've just run into this: $ psql -p 5433 (that port is configured in postgresql.conf) # alter system set port = 5494; ... restart the server $ psql -p 5494 # select pg_reload_conf(); 2014-06-25 14:22:07 CEST [11297-4] LOG: received SIGHUP, reloading configuration files 2014-06-25 14:22:07

[HACKERS] ALTER SYSTEM RESET?

2014-06-25 Thread Christoph Berg
Hi, is there a reason there's no ALTER SYSTEM RESET? The natural idiom to reset SET statements is RESET guc;, I don't think SET guc = default; is in use much, so ALTER SYSTEM RESET guc; would be the natural way to try. Also, ALTER SYSTEM SET/RESET seems to be what oracle does:

Re: [HACKERS] postgresql.auto.conf and reload

2014-06-25 Thread Christoph Berg
Re: Amit Kapila 2014-06-25 caa4ek1log98jvfov9wztqpcdewja+5jr54ttpkiz3xbngjy...@mail.gmail.com On Wed, Jun 25, 2014 at 6:11 PM, Christoph Berg c...@df7cb.de wrote: I've just run into this: $ psql -p 5433 (that port is configured in postgresql.conf) # alter system set port = 5494

Re: [HACKERS] postgresql.auto.conf and reload

2014-06-25 Thread Christoph Berg
Re: Amit Kapila 2014-06-25 caa4ek1+f9ztogvvw-wyj2+vt0k8_jxtziqhp8ivb7wdo1w1...@mail.gmail.com The main reason behind such such a behaviour after restart is that there are duplicate entries, one in postgresql.conf and another in postgresql.conf. It always first read postgresql.conf and then

[HACKERS] [PATCH] log_{directory,filename} doc fixes

2014-06-25 Thread Christoph Berg
Hi, The defaults for log_directory and log_filename were undocumented, and the log_filename docs still refered to a config example that was removed with 8.4 deprecation of epoch-based logfilenames. Christoph -- c...@df7cb.de | http://www.df7cb.de/ diff --git a/doc/src/sgml/config.sgml

Re: [HACKERS] ALTER SYSTEM RESET?

2014-06-26 Thread Christoph Berg
Re: Amit Kapila 2014-06-26 caa4ek1+zt_uo-z7wjp2yznv7aytxgbqgp23wcmpub9sdmgy...@mail.gmail.com On Wed, Jun 25, 2014 at 9:56 PM, Vik Fearing vik.fear...@dalibo.com wrote: On 06/25/2014 03:04 PM, Amit Kapila wrote: Currently you can achieve that by ALTER SYSTEM RESET guc = Default;.

Re: [HACKERS] postgresql.auto.conf and reload

2014-06-26 Thread Christoph Berg
Re: Amit Kapila 2014-06-26 CAA4eK1+mUTjc=GXJK3bYtSwV2BmBni=phevbqlqkhduv9cw...@mail.gmail.com On Wed, Jun 25, 2014 at 7:52 PM, Christoph Berg c...@df7cb.de wrote: Re: Amit Kapila 2014-06-25 caa4ek1+f9ztogvvw-wyj2+vt0k8_jxtziqhp8ivb7wdo1w1...@mail.gmail.com I think maintaining values

Re: [HACKERS] ALTER SYSTEM RESET?

2014-06-28 Thread Christoph Berg
Re: Vik Fearing 2014-06-27 53ad15f7.2060...@dalibo.com On 06/27/2014 08:49 AM, Vik Fearing wrote: This third patch reformats the documentation in the way I expected it to be committed. Amit, I added this to the next commitfest with your name as reviewer.

Re: [HACKERS] NUMA packaging and patch

2014-07-01 Thread Christoph Berg
Re: Kevin Grittner 2014-06-09 1402267501.4.yahoomail...@web122304.mail.ne1.yahoo.com @@ -536,6 +539,24 @@ PGSharedMemoryCreate(Size size, bool makePrivate, int port, */ } +#ifdef USE_LIBNUMA + /* + * If this is not a private segment and we are using

Re: [HACKERS] NUMA packaging and patch

2014-07-01 Thread Christoph Berg
Re: Kevin Grittner 2014-07-01 1404213492.98740.yahoomail...@web122306.mail.ne1.yahoo.com Andres Freund and...@2ndquadrant.com wrote: On 2014-07-01 11:01:04 +0200, Christoph Berg wrote: How much difference would it make if numactl --interleave=all was used instead of using

Re: [HACKERS] /proc/self/oom_adj is deprecated in newer Linux kernels

2014-07-01 Thread Christoph Berg
Re: Tom Lane 2014-06-23 17054.1403542...@sss.pgh.pa.us While I'd love to reduce the number of future installations without this fix in place, I respect the decision to honor project policy. At the same time, this change does not break anything. It introduces new environment variables which

Re: [HACKERS] /proc/self/oom_adj is deprecated in newer Linux kernels

2014-07-02 Thread Christoph Berg
Re: Tom Lane 2014-07-01 20654.1404247...@sss.pgh.pa.us Yeah, I'm unexcited about this proposal. In any case, given the two existing APIs we have to deal with, allowing PG_OOM_ADJUST_VALUE to default to 0 is sane in both APIs but a default for the file name can work for only one. Nod. Fair

Re: [HACKERS] buildfarm and rolling release distros

2014-07-04 Thread Christoph Berg
Re: Craig Ringer 2014-07-02 53b39638.9010...@2ndquadrant.com +1. The buildfarm has one such member already, anchovy, and I recall it having given at least one helpful forewarning. It shows as Arch Linux testing [updated daily], which is sufficient annotation for me. Its failure rate

  1   2   3   4   >