Re: [HACKERS] Refectoring of receivelog.c

2016-03-11 Thread Daniel Gustafsson
> On 15 Feb 2016, at 14:46, Magnus Hagander wrote: > > On Mon, Feb 15, 2016 at 7:15 AM, Craig Ringer > wrote: > On 15 February 2016 at 04:48, Magnus Hagander > wrote:

[HACKERS] Unused macros in contrib code

2016-04-28 Thread Daniel Gustafsson
While doing some archaeology I came across a couple of macros in pgstattuple and pageinspect contrib code which seems to have been unused for some time. CHECK_PAGE_OFFSET_RANGE is unused in both modules and commit 6405842 which introduced contrib/pageinspect moved the code making

[HACKERS] Typo in execProcnode.c documentation

2016-04-26 Thread Daniel Gustafsson
Theres a tiny typo in the EXAMPLE section of the documentation in execProcnode.c: - * their work to the appopriate node support routines which may + * their work to the appropriate node support routines which may cheers ./daniel execProcnode-type.diff Description: Binary data -- Sent

[HACKERS] Bug in intarray bench script

2016-05-17 Thread Daniel Gustafsson
In the contrib/intarray benchmarking script bench.pl, the -e option to print the plan via EXPLAIN is using the DBI do() method which discards output resulting in nothing being printed. Judging by the usage help (“show explain”) I assume the intention is to print the plan to STDOUT when invoked

Re: [HACKERS] Subtle bug in autoconf flex version test

2016-05-02 Thread Daniel Gustafsson
> On 02 May 2016, at 15:38, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Daniel Gustafsson <dan...@yesql.se> writes: >> The PGAC_PATH_FLEX version test in config/programs.m4 tests the major and >> minor >> versions with = rather than == which unless

[HACKERS] Subtle bug in autoconf flex version test

2016-05-02 Thread Daniel Gustafsson
The PGAC_PATH_FLEX version test in config/programs.m4 tests the major and minor versions with = rather than == which unless I’m missing something is performing assignment rather than testing equality? The attached diff makes the test trigger the expected warning on major/minor version on my OS X

Re: [HACKERS] [PATCH] configure-time knob to set default ssl ciphers

2017-02-08 Thread Daniel Gustafsson
> On 08 Feb 2017, at 13:31, Pavel Raiskup wrote: > > On Wednesday, February 8, 2017 1:29:19 PM CET Pavel Raiskup wrote: >> On Wednesday, February 8, 2017 1:05:08 AM CET Tom Lane wrote: >>> Peter Eisentraut writes: On 2/7/17 11:21 AM,

Re: [HACKERS] removing tsearch2

2017-02-10 Thread Daniel Gustafsson
> On 10 Feb 2017, at 12:28, Robert Haas wrote: > > On Thu, Feb 9, 2017 at 7:37 PM, Andres Freund wrote: >> On 2017-02-09 19:19:21 -0500, Stephen Frost wrote: >>> * Robert Haas (robertmh...@gmail.com) wrote: On Thu, Feb 9, 2017 at 4:24 PM, Tom Lane

[HACKERS] Leftover member in openssl part of Port struct

2016-08-31 Thread Daniel Gustafsson
When SSL renegotiation was removed in 426746b9 the only consumer of the openssl specific count member in the Port struct was removed, but the member was left together with a few updates to it which are unused. Attached patch removes the leftovers which now serves no purpose unless I’m missing

Re: [HACKERS] Leftover member in openssl part of Port struct

2016-08-31 Thread Daniel Gustafsson
> On 31 Aug 2016, at 15:12, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Daniel Gustafsson <dan...@yesql.se> writes: >> When SSL renegotiation was removed in 426746b9 the only consumer of the >> openssl >> specific count member in the Port struct was remov

[HACKERS] Typo in filename identification

2016-09-11 Thread Daniel Gustafsson
The IDENTIFICATION filename in src/backend/storage/ipc/dsm_impl.c is incorrectly labelling the file dsm.c. Patch fixing the typo attached. cheers ./daniel typo-dsm_impl_identification.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

[HACKERS] WIP: Secure Transport support as OpenSSL alternative on macOS

2016-10-05 Thread Daniel Gustafsson
As noted in 77fb2321-9210-4ad4-b7fc-67623a583...@justatheory.com, OpenSSL is being somewhat dismantled on macOS starting with 10.11 El Capitan. To scratch my own itch I decided to take a stab at adding support for the Secure Transport library. The idea is to make it as much of a drop-in for the

Re: [HACKERS] WIP: Secure Transport support as OpenSSL alternative on macOS

2016-10-05 Thread Daniel Gustafsson
> On 05 Oct 2016, at 16:45, Stephen Frost <sfr...@snowman.net> wrote: > > Daniel, > > * Daniel Gustafsson (dan...@yesql.se) wrote: >> The main questions raised here are: is it of interest to support multiple SSL >> libraries given the additional support

[HACKERS] Incorrect comment/doc for poll_query_until

2016-10-04 Thread Daniel Gustafsson
Commit 2a0f89cd717ce6d raised the timeout in poll_query_until() to 180 seconds but left the documentation and comments at the previous value of 90 sec. Patch attached to update documentation and comment to match reality. cheers ./daniel poll_query_until_timeout_doc.diff Description: Binary

[HACKERS] Typo in libpq-int.h

2016-09-22 Thread Daniel Gustafsson
Ran into a typo in libpq-int.h while reading/hacking: - char *gsslib; /* What GSS librart to use ("gssapi" or + char *gsslib; /* What GSS library to use ("gssapi” or Patch attached. cheers ./daniel typo-libpq-int.diff

[HACKERS] Make flex/bison checks stricter in Git trees

2016-09-27 Thread Daniel Gustafsson
When running ./configure on a system without Flex/Bison it’s easy to miss the warning that flies past and then run into compilation error instead. When it happened to a colleague yesterday a brief discussion came to the conclusion that it would be neat it the flex and bison checks took the

Re: [HACKERS] Make flex/bison checks stricter in Git trees

2016-09-27 Thread Daniel Gustafsson
> On 27 Sep 2016, at 15:49, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Daniel Gustafsson <dan...@yesql.se> writes: >> When running ./configure on a system without Flex/Bison it’s easy to miss the >> warning that flies past and then run into compilation er

Re: [HACKERS] Radix tree for character conversion

2016-11-08 Thread Daniel Gustafsson
> On 08 Nov 2016, at 17:37, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> > wrote: > > On 10/31/16 12:11 PM, Daniel Gustafsson wrote: >> I took a small stab at doing some cleaning of the Perl scripts, mainly around >> using the more modern (well, modern as i

Re: [HACKERS] Radix tree for character conversion

2016-11-07 Thread Daniel Gustafsson
> On 07 Nov 2016, at 12:32, Daniel Gustafsson <dan...@yesql.se> wrote: > >> On 04 Nov 2016, at 08:34, Kyotaro HORIGUCHI >> <horiguchi.kyot...@lab.ntt.co.jp> wrote: >> >> I'm not sure how the discussion about this goes, these patches >> make

Re: [HACKERS] Radix tree for character conversion

2016-11-08 Thread Daniel Gustafsson
> On 08 Nov 2016, at 12:21, Kyotaro HORIGUCHI > wrote: > > Hello, this is the revising patch applies on top of the previous > patch. > > ... > > Finally the attached patch contains most of (virtually all of) > Daniel's suggestion and some modification by

Re: [HACKERS] Radix tree for character conversion

2016-11-07 Thread Daniel Gustafsson
> On 04 Nov 2016, at 08:34, Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> > wrote: > > Thank you for looling this. And thank you for taking the time to read my patches! > At Mon, 31 Oct 2016 17:11:17 +0100, Daniel Gustafsson <dan...@yesql.se> wrote &g

[HACKERS] Small typo in pageinspect heapfuncs

2016-10-26 Thread Daniel Gustafsson
Spotted a tiny typo in contrib/pageinspect/heapfuncs.c: s/accordindly/accordingly/ cheers ./daniel typo-pageinspect_heapfuncs.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Radix tree for character conversion

2016-10-31 Thread Daniel Gustafsson
> On 27 Oct 2016, at 09:23, Kyotaro HORIGUCHI > wrote: > > Hello, thank you very much for the work. My work became quite > easier with it. > > At Tue, 25 Oct 2016 12:23:48 +0300, Heikki Linnakangas > wrote in

Re: [HACKERS] perlcritic

2017-03-22 Thread Daniel Gustafsson
> On 21 Mar 2017, at 19:20, David Steele wrote: > > On 3/6/17 12:02 PM, Dagfinn Ilmari Mannsåker wrote: >> ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes: >> >>> Hi Peter, >>> >>> Peter Eisentraut writes: >>> I posted this

Re: [HACKERS] createlang/droplang deprecated

2017-03-23 Thread Daniel Gustafsson
> On 20 Mar 2017, at 01:37, Peter Eisentraut > wrote: > > On 3/18/17 09:00, Peter Eisentraut wrote: >> I just noticed that createlang and droplang have been listed as >> deprecated since PG 9.1. >> >> Do we dare remove them? > > Patch LGTM, +1 cheers

[HACKERS] Typo in libpq

2017-03-30 Thread Daniel Gustafsson
There seems to be a typo in libpq as per attached, “..we will loose error messages” should probably be “..we will lose error messages”. cheers ./daniel typo-libpq-loose.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

[HACKERS] Multiple TO version in ALTER EXTENSION UPDATE

2017-03-29 Thread Daniel Gustafsson
While reading I noticed that we allow multiple TO in ALTER EXTENSION UPDATE, and defer throwing a syntax error until command processing. Is there a reason for deferring and not handling it in gram.y directly as in the attached patch since it is in fact a syntax error? It yields a different

Re: [HACKERS] perlcritic

2017-03-23 Thread Daniel Gustafsson
> On 21 Mar 2017, at 19:20, David Steele wrote: > > On 3/6/17 12:02 PM, Dagfinn Ilmari Mannsåker wrote: >> ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes: >> >>> Hi Peter, >>> >>> Peter Eisentraut writes: >>> I posted this

[HACKERS] Use American English spelling in pg_waldump error message

2017-03-29 Thread Daniel Gustafsson
We use “unrecognize” rather than “unrecognise” in all other error messages in the tree, the attached patch fixes the one place where the latter spelling was used. cheers ./daniel pg_waldump_errmsg.patch Description: Binary data -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Size vs size_t

2017-03-20 Thread Daniel Gustafsson
> On 16 Mar 2017, at 23:20, Tom Lane wrote: > > Thomas Munro writes: >> Naive replacement in new files (present in master but not in 9.6) with >> the attached script, followed by a couple of manual corrections where >> Size was really an

Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

2017-04-04 Thread Daniel Gustafsson
> On 04 Apr 2017, at 05:52, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > > Daniel Gustafsson wrote: >> Testing DefElem options is done with both strcmp() and pg_strcasecmp() a bit >> mixed. Since the option defnames are all lowercased, either via IDENT, >

[HACKERS] Refactoring identifier checks to consistently use strcmp

2017-04-03 Thread Daniel Gustafsson
Testing DefElem options is done with both strcmp() and pg_strcasecmp() a bit mixed. Since the option defnames are all lowercased, either via IDENT, keyword rules or “by hand” with makeString(), using strcmp() is safe (and assumed to be so in quite a lot of places). While it’s not incorrect per

Re: [HACKERS] Old versions of Test::More

2017-04-21 Thread Daniel Gustafsson
> On 21 Apr 2017, at 15:08, Andrew Dunstan > wrote: > > As we discovered yesterday via jacana, very old versions of Test::More > don't support the note() function. It therefore seems prudent to specify > a minimum version number for the module in those scripts

Re: [HACKERS] A note about debugging TAP failures

2017-04-22 Thread Daniel Gustafsson
> On 22 Apr 2017, at 23:25, Tom Lane wrote: > > Andres Freund writes: >> On 2017-04-22 16:22:59 -0400, Tom Lane wrote: >>> In the particular case I was interested in here, the test script thought >>> everything was successful :-(. I'm working on fixing

Re: [HACKERS] A note about debugging TAP failures

2017-04-22 Thread Daniel Gustafsson
> On 23 Apr 2017, at 00:06, Andres Freund <and...@anarazel.de> wrote: > > On 2017-04-22 23:59:11 +0200, Daniel Gustafsson wrote: >> Since we have the name of the running testscript, can’t we just add that to >> the >> tempdir to make the name more descriptiv

Re: [HACKERS] psql's \d and \dt are sending their complaints to different output files

2017-07-28 Thread Daniel Gustafsson
> On 27 Jul 2017, at 19:40, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Daniel Gustafsson <dan...@yesql.se> writes: >>> On 19 Jun 2017, at 17:32, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> So, if we're getting into enforcing consistency in descri

[HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative

2017-08-03 Thread Daniel Gustafsson
In https://postgr.es/m/69db7657-3f9d-4d30-8a4b-e06034251...@yesql.se I presented a WIP patch for adding support for the Apple Secure Transport SSL library on macOS as, an alternative to OpenSSL. That patch got put on the backburner for a bit, but I’ve now found the time to make enough progress to

Re: [HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative

2017-08-03 Thread Daniel Gustafsson
> On 03 Aug 2017, at 19:27, Michael Paquier <michael.paqu...@gmail.com> wrote: > > On Thu, Aug 3, 2017 at 12:02 PM, Daniel Gustafsson <dan...@yesql.se> wrote: >> In https://postgr.es/m/69db7657-3f9d-4d30-8a4b-e06034251...@yesql.se I >> presented a WIP patch for ad

Re: [HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative

2017-08-03 Thread Daniel Gustafsson
> On 03 Aug 2017, at 13:06, Heikki Linnakangas <hlinn...@iki.fi> wrote: > > On 08/03/2017 01:02 PM, Daniel Gustafsson wrote: >> >> The frontend has support for using PEM files for certificates and keys. It >> can >> also look up the key for the certifi

Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

2017-08-17 Thread Daniel Gustafsson
> On 16 Aug 2017, at 17:51, Tom Lane wrote: > > Heikki Linnakangas writes: >> This no longer works: > >> postgres=# CREATE TEXT SEARCH DICTIONARY public.simple_dict ( >> TEMPLATE = pg_catalog.simple, >> "STOPWORds" = english >> ); >> ERROR:

Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode

2017-06-28 Thread Daniel Gustafsson
> On 14 Jun 2017, at 06:04, Michael Paquier wrote: > > On Tue, Jun 13, 2017 at 4:50 PM, Craig Ringer wrote: >> On 13 June 2017 at 14:33, Michael Paquier wrote: >>> Those come from stop_streaming in pg_receivewal.c.

Re: [HACKERS] A note about debugging TAP failures

2017-04-24 Thread Daniel Gustafsson
> On 23 Apr 2017, at 15:05, Craig Ringer <craig.rin...@2ndquadrant.com> wrote: > > On 23 Apr. 2017 10:32, "Michael Paquier" <michael.paqu...@gmail.com > <mailto:michael.paqu...@gmail.com>> wrote: > On Sun, Apr 23, 2017 at 7:48 AM, Daniel Gustafsson

Re: [HACKERS] A note about debugging TAP failures

2017-04-25 Thread Daniel Gustafsson
> On 24 Apr 2017, at 17:19, Craig Ringer <craig.rin...@2ndquadrant.com> wrote: > > On 24 April 2017 at 20:01, Daniel Gustafsson <dan...@yesql.se> wrote: > >> I’m np Perl expert though so there might be better/cleaner ways to achieve >> this, in test

Re: [HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative

2017-08-20 Thread Daniel Gustafsson
> On 19 Aug 2017, at 23:13, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > > On Sun, Aug 20, 2017 at 8:10 AM, Thomas Munro > <thomas.mu...@enterprisedb.com <mailto:thomas.mu...@enterprisedb.com>> wrote: >> On Fri, Aug 18, 2017 at 2:14 AM, Danie

[HACKERS] Typo in json.c

2017-05-18 Thread Daniel Gustafsson
Spotted while reading code, patch attached. cheers ./daniel typo-json.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Optional message to user when terminating/cancelling backend

2017-06-21 Thread Daniel Gustafsson
> On 21 Jun 2017, at 16:30, Yugo Nagata <nag...@sraoss.co.jp> wrote: > > On Wed, 21 Jun 2017 12:06:33 +0900 > Michael Paquier <michael.paqu...@gmail.com> wrote: > >> On Tue, Jun 20, 2017 at 3:24 AM, Daniel Gustafsson <dan...@yesql.se> wrote: >>>

Re: [HACKERS] psql's \d and \dt are sending their complaints to different output files

2017-06-26 Thread Daniel Gustafsson
> On 19 Jun 2017, at 17:32, Tom Lane wrote: > > So, if we're getting into enforcing consistency in describe.c, there's > lots to do. > > * listDbRoleSettings does this for a server too old to have the desired > feature: > > fprintf(pset.queryFout, >

Re: [HACKERS] Optional message to user when terminating/cancelling backend

2017-06-26 Thread Daniel Gustafsson
> On 22 Jun 2017, at 17:52, Dilip Kumar <dilipbal...@gmail.com> wrote: > > On Thu, Jun 22, 2017 at 7:18 PM, Daniel Gustafsson <dan...@yesql.se> wrote: >> Good point. I’ve attached a new version which issues a NOTICE on truncation >> and also addresses all oth

[HACKERS] Optional message to user when terminating/cancelling backend

2017-06-19 Thread Daniel Gustafsson
When terminating, or cancelling, a backend it’s currently not possible to let the signalled session know *why* it was dropped. This has nagged me in the past and now it happened to come up again, so I took a stab at this. The attached patch implements the ability to pass an optional text message

Re: [HACKERS] Multiple TO version in ALTER EXTENSION UPDATE

2017-06-22 Thread Daniel Gustafsson
> On 22 Jun 2017, at 17:02, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Robert Haas <robertmh...@gmail.com> writes: >> On Wed, Mar 29, 2017 at 11:13 AM, Daniel Gustafsson <dan...@yesql.se> wrote: >>> While reading I noticed that we allow multiple TO in

Re: [HACKERS] Optional message to user when terminating/cancelling backend

2017-06-22 Thread Daniel Gustafsson
> On 22 Jun 2017, at 10:24, Yugo Nagata <nag...@sraoss.co.jp> wrote: > > On Thu, 22 Jun 2017 09:24:54 +0900 > Michael Paquier <michael.paqu...@gmail.com> wrote: > >> On Wed, Jun 21, 2017 at 11:42 PM, Daniel Gustafsson <dan...@yesql.se&

[HACKERS] Bug when dumping "empty" operator classes

2017-05-26 Thread Daniel Gustafsson
While hacking on pg_upgrade in downstream Greenplum I ran into an error which seems like an old, and obscure, bug in pg_dump (unrelated to pg_upgrade). pg_dump generates incorrect SQL for an operator class which has no operators or procedures, and which has the same column and storage types.

Re: [HACKERS] Bug when dumping "empty" operator classes

2017-05-26 Thread Daniel Gustafsson
> On 26 May 2017, at 17:08, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Daniel Gustafsson <dan...@yesql.se> writes: >> While hacking on pg_upgrade in downstream Greenplum I ran into an error which >> seems like an old, and obscure, bug in pg_dump (unrelated to

Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256

2017-05-30 Thread Daniel Gustafsson
> On 30 May 2017, at 18:25, Michael Paquier wrote: > > On macos though it is another story, I am not seeing anything: > https://developer.apple.com/reference/security/secure_transport#symbols The Secure Transport documentation unfortunately excel at being incomplete

[HACKERS] Typo in comment in ecpg datetime.c

2017-06-15 Thread Daniel Gustafsson
Spotted s/fiedls/fields/ in src/interfaces/ecpg/pgtypeslib/datetime.c per the attached patch. cheers ./daniel typo-ecpg_datetime.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

[HACKERS] Typos in comments

2017-06-17 Thread Daniel Gustafsson
Spotted one “paramter” typo and git grep found two more, patch attached with s/paramter/parameter/ for these. cheers ./daniel typo-paramter.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256

2017-05-30 Thread Daniel Gustafsson
> On 30 May 2017, at 16:50, Tom Lane wrote: > > Robert Haas writes: >> On Sat, May 27, 2017 at 5:59 PM, Álvaro Hernández Tortosa >> wrote: >>> - tls-unique, as you mentioned, uses two undocumented APIs. This raises a >>> small flag

Re: [HACKERS] VACUUM and ANALYZE disagreeing on what reltuples means

2017-09-15 Thread Daniel Gustafsson
> On 06 Sep 2017, at 09:45, Haribabu Kommi wrote: > > On Tue, Jul 25, 2017 at 9:33 PM, Tomas Vondra > wrote: > On 7/25/17 12:55 AM, Tom Lane wrote: > Tomas Vondra

Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

2017-09-15 Thread Daniel Gustafsson
> On 09 Sep 2017, at 06:05, Thomas Munro wrote: > > On Sat, Sep 2, 2017 at 5:22 AM, Peter Eisentraut > wrote: >> >> + --if-exists >> + >> + >> +Do not error out when --drop-slot or >> --start are >>

Re: [HACKERS] [PATCH] Off-by-one error in logical slot resource retention

2017-09-15 Thread Daniel Gustafsson
> On 01 Sep 2017, at 14:28, Aleksander Alekseev > wrote: > > The following review has been posted through the commitfest application: > make installcheck-world: not tested > Implements feature: not tested > Spec compliant: not tested > Documentation:

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

2017-09-13 Thread Daniel Gustafsson
> On 15 May 2017, at 07:26, Michael Paquier wrote: > > On Tue, May 2, 2017 at 2:28 AM, Pierre Ducroquet wrote: > >> I will submit this patch in the current commit fest. > > I have not spotted any flaws in the refactored logic. This patch no

Re: [HACKERS] Renaming PG_GETARG functions (was Re: PG_GETARG_GISTENTRY?)

2017-09-15 Thread Daniel Gustafsson
> On 12 Sep 2017, at 22:07, Tom Lane wrote: > > [ changing subject line to possibly draw more attention ] > > Mark Dilger writes: >>> On Apr 5, 2017, at 9:23 AM, Tom Lane wrote: >>> In short, if you are supposed to write >>>

Re: [HACKERS] Statement-level rollback

2017-09-15 Thread Daniel Gustafsson
> On 01 Sep 2017, at 13:44, Simon Riggs wrote: > > On 14 August 2017 at 23:58, Peter Eisentraut > wrote: >> On 2/28/17 02:39, Tsunakawa, Takayuki wrote: >>> The code for stored functions is not written yet, but I'd like your >>> feedback

Re: [HACKERS] SQL/JSON in PostgreSQL

2017-09-15 Thread Daniel Gustafsson
> On 15 Aug 2017, at 04:30, Peter Eisentraut > wrote: > > On 3/15/17 11:56, David Steele wrote: >>> This patch has been moved to CF 2017-07. >> >> I did not manage to move this patch when I said had. It is now moved. > > Unsurprisingly, this patch needs a

Re: [HACKERS] Allow INSTEAD OF DELETE triggers to modify the tuple for RETURNING

2017-09-15 Thread Daniel Gustafsson
> On 05 Sep 2017, at 10:44, Haribabu Kommi wrote: > > On Mon, Aug 14, 2017 at 6:48 AM, Marko Tiikkaja > wrote: > On Fri, Jul 1, 2016 at 2:12 AM, I wrote: > Currently the tuple returned by INSTEAD OF triggers on DELETEs is only used

Re: [HACKERS] postgres_fdw: evaluate placeholdervars on remote server

2017-09-15 Thread Daniel Gustafsson
> On 15 Aug 2017, at 01:00, Peter Eisentraut > wrote: > > On 4/3/17 22:00, Etsuro Fujita wrote: >> On 2017/04/04 3:21, Andres Freund wrote: >>> On 2017-02-28 21:45:22 +0900, Etsuro Fujita wrote: Here is a patch for $subject. >>> >>> This is a nontrivial

Re: [HACKERS] Should we cacheline align PGXACT?

2017-09-18 Thread Daniel Gustafsson
> On 16 Sep 2017, at 01:51, Alexander Korotkov <a.korot...@postgrespro.ru> > wrote: > > On Tue, Sep 5, 2017 at 2:47 PM, Daniel Gustafsson <dan...@yesql.se > <mailto:dan...@yesql.se>> wrote: > > On 04 Apr 2017, at 14:58, David Steele <da...@pgmasters.ne

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-09-18 Thread Daniel Gustafsson
> On 18 Sep 2017, at 15:31, Jan Michálek wrote: > > I have`t any new version recently, because i was waiting for new version. But > I will have some time on this in next months. How many time I have to next > freeze? The next commitfest runs from 2017-11-01 to

Re: [HACKERS] Repetitive code in RI triggers

2017-09-19 Thread Daniel Gustafsson
> On 11 Apr 2017, at 03:41, Peter Eisentraut > wrote: > > On 4/10/17 11:55, Ildar Musin wrote: >> I was looking through the RI triggers code recently and noticed a few >> almost identical functions, e.g. ri_restrict_upd() and >> ri_restrict_del(). The

[HACKERS] Commitfest 201709 update

2017-09-21 Thread Daniel Gustafsson
all for your contributions to PostgreSQL! Sincerely Daniel Gustafsson CFM201709 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] PoC: full merge join on comparison clause

2017-09-20 Thread Daniel Gustafsson
> On 19 Sep 2017, at 15:18, Ashutosh Bapat > wrote: > > On Fri, Aug 25, 2017 at 10:11 PM, Alexander Kuzmenkov > wrote: >> Here is a new version of the patch, rebased to 749c7c41 and with some >> cosmetic changes. >> > > I looked at

Re: [HACKERS] postgres_fdw: evaluate placeholdervars on remote server

2017-09-15 Thread Daniel Gustafsson
> On 15 Sep 2017, at 17:19, Robert Haas <robertmh...@gmail.com> wrote: > > On Fri, Sep 15, 2017 at 10:15 AM, Daniel Gustafsson <dan...@yesql.se> wrote: >> Have you had a chance to look at this such that we can expect a rebased >> version >> of this patch

[HACKERS] Commitfest 201709 Progress

2017-09-08 Thread Daniel Gustafsson
We are now a few days in on Commitfest 201709 and there has been lots of activity on the patches. 22% of the patches have been committed* with another 10% being marked Ready for Committer. Thank you all for the hard work! There is still a lot to do though, this fest has a recordbreaking 256

Re: [HACKERS] PoC plpgsql - possibility to force custom or generic plan

2017-09-08 Thread Daniel Gustafsson
> On 08 Sep 2017, at 19:14, Simon Riggs wrote: > > On 6 September 2017 at 07:43, Robert Haas wrote: > >> LET custom_plan_tries = 0 IN SELECT ... > > Tom has pointed me at this proposal, since on another thread I asked > for something very similar.

Re: [HACKERS] Copyright in partition.h and partition.c

2017-09-06 Thread Daniel Gustafsson
> On 06 Sep 2017, at 02:56, Amit Langote wrote: > > On 2017/09/05 21:14, Tom Lane wrote: >> Amit Langote writes: >>> On 2017/09/05 15:48, Etsuro Fujita wrote: Here is the copyright in partition.h: * Copyright (c)

Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

2017-09-05 Thread Daniel Gustafsson
> On 17 Aug 2017, at 11:08, Daniel Gustafsson <dan...@yesql.se> wrote: > >> On 16 Aug 2017, at 17:51, Tom Lane <t...@sss.pgh.pa.us> wrote: >> >> Heikki Linnakangas <hlinn...@iki.fi> writes: >>> This no longer works: >> >&g

Re: [HACKERS] plpgsql - additional extra checks

2017-09-12 Thread Daniel Gustafsson
> On 08 Apr 2017, at 15:46, David Steele wrote: > >> On 1/13/17 6:55 AM, Marko Tiikkaja wrote: >>> On Fri, Jan 13, 2017 at 2:46 AM, Jim Nasby >> > wrote: >>> >>>On 1/11/17 5:54 AM, Pavel Stehule wrote: >>> >>>

Re: [HACKERS] Small patch for pg_basebackup argument parsing

2017-09-12 Thread Daniel Gustafsson
> On 05 Jul 2017, at 08:32, Michael Paquier wrote: > > On Wed, Jul 5, 2017 at 2:57 PM, Ryan Murphy wrote: >> I tried to apply your patch to test it (though reading Robert's last comment >> it seems we wish to have it adjusted before

Re: [HACKERS] Patches that don't apply or don't compile: 2017-09-12

2017-09-12 Thread Daniel Gustafsson
> On 12 Sep 2017, at 23:54, Tomas Vondra wrote: > > On 09/12/2017 04:14 PM, Aleksander Alekseev wrote: >> Hello, hackers! >> >> Thanks to the work of Thomas Munro now we have a CI for the patches on >> the commitfest [1]. Naturally there is still room for

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-09-12 Thread Daniel Gustafsson
> On 08 May 2017, at 12:02, Fabien COELHO > wrote: > > Hello Jan, > > Please give a number to submitted patches. I think that this was v3. > > The patch does NOT fix various issues I pointed out in my previous review: > > - tabs introduced in

Re: [HACKERS] PATCH: psql show index with type info

2017-09-12 Thread Daniel Gustafsson
> On 18 Apr 2017, at 05:13, Amos Bird wrote: > > Ah, thanks for the suggestions. I'll revise this patch soon :) Have you had a chance to revise the patch to address the review comments such that the patch can move forward during this Commitfest? cheers ./daniel -- Sent

Re: [HACKERS] Faster methods for getting SPI results

2017-09-12 Thread Daniel Gustafsson
> On 12 Sep 2017, at 23:00, Tom Lane wrote: > > Chapman Flack writes: >> On 09/12/2017 03:41 PM, Tom Lane wrote: >>> So the conclusion at the end of the last commitfest was that this patch >>> should be marked Returned With Feedback, and no new work

Re: [HACKERS] [WIP] RE: DECLARE STATEMENT setting up a connection in ECPG

2017-09-12 Thread Daniel Gustafsson
> On 30 Mar 2017, at 09:11, Ideriha, Takeshi > wrote: > > Thank you for prompt check! > > >As per above test steps, it doesn't produce the results and doesn't > >generate the error also. I feel this needs to be fixed. > > >As we are at the end of commitfest,

Re: [HACKERS] Replication status in logical replication

2017-09-12 Thread Daniel Gustafsson
> On 30 May 2017, at 19:55, Peter Eisentraut > wrote: > > On 5/29/17 22:56, Noah Misch wrote: >> On Fri, May 19, 2017 at 11:33:48AM +0900, Masahiko Sawada wrote: >>> On Wed, Apr 12, 2017 at 5:31 AM, Simon Riggs wrote: Looks like a

Re: [HACKERS] Patches that don't apply or don't compile: 2017-09-12

2017-09-13 Thread Daniel Gustafsson
> On 13 Sep 2017, at 11:49, Aleksander Alekseev > wrote: > > Hi Tomas, > > I appreciate your feedback, although it doesn't seem to be completely > fair. I would like to stress one thing (and I am speaking only for myself here), this has been feedback and not

Re: [HACKERS] A note about debugging TAP failures

2017-09-05 Thread Daniel Gustafsson
> On 05 Sep 2017, at 18:37, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> > wrote: > > On 4/25/17 11:00, Daniel Gustafsson wrote: >> Makes sense, assuming a “clean slate” to run on seems a reasonable assumption >> for the test and it makes for simpler

Re: [HACKERS] Making clausesel.c Smarter

2017-09-07 Thread Daniel Gustafsson
> On 06 Sep 2017, at 07:13, David Rowley <david.row...@2ndquadrant.com> wrote: > > On 6 September 2017 at 00:43, Daniel Gustafsson <dan...@yesql.se> wrote: >> This patch was moved to the currently open Commitfest. Given the above >> comment, is the last patch i

Re: [HACKERS] Crash on promotion when recovery.conf is renamed

2017-10-01 Thread Daniel Gustafsson
> On 02 Sep 2017, at 14:17, Michael Paquier wrote: > > On Fri, Sep 1, 2017 at 7:17 PM, Thomas Munro > wrote: >> On Sat, Aug 26, 2017 at 7:32 AM, Robert Haas wrote: >>> On Sat, Apr 8, 2017 at 10:05 AM, David Steele

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

2017-10-01 Thread Daniel Gustafsson
> On 11 Apr 2017, at 10:55, Etsuro Fujita wrote: > > On 2017/04/07 22:54, Arthur Zakirov wrote: >> Marked the patch as "Ready for Commiter". But the patch should be >> commited only after the patch [1]. > > Thanks for reviewing! I'll continue to work on this for

Re: [HACKERS] issue: record or row variable cannot be part of multiple-item INTO list

2017-10-01 Thread Daniel Gustafsson
> On 20 Sep 2017, at 01:05, David G. Johnston > wrote: > > On Tue, Sep 19, 2017 at 11:29 AM, Tom Lane > wrote: > ​T​hat​ ​doesn't work today, and this patch doesn't fix it, but it does create > enough confusion that

Re: [HACKERS] Small patch for pg_basebackup argument parsing

2017-10-01 Thread Daniel Gustafsson
> On 18 Sep 2017, at 23:18, Pierre Ducroquet wrote: > > On Monday, September 18, 2017 5:13:38 PM CEST Tom Lane wrote: >> Ryan Murphy writes: >>> Looked thru the diffs and it looks fine to me. >>> Changing a lot of a integer/long arguments that were

Re: [HACKERS] pgbench: faster version of tpcb-like transaction

2017-10-01 Thread Daniel Gustafsson
> On 27 Aug 2017, at 08:37, Fabien COELHO wrote: > > > About the patch: > > I'm generally in favor of providing more options to pgbench, especially if it > can give optimization ideas to the performance conscious user. > > I think that the name should be

Re: [HACKERS] Statement-level rollback

2017-10-01 Thread Daniel Gustafsson
> On 15 Sep 2017, at 16:19, Daniel Gustafsson <dan...@yesql.se> wrote: > >> On 01 Sep 2017, at 13:44, Simon Riggs <si...@2ndquadrant.com> wrote: >> >> On 14 August 2017 at 23:58, Peter Eisentraut >> <peter.eisentr...@2ndquadrant.com> wrote:

Re: [HACKERS] CLUSTER command progress monitor

2017-10-01 Thread Daniel Gustafsson
> On 12 Sep 2017, at 14:57, Tatsuro Yamada wrote: > > On 2017/09/12 21:20, Tatsuro Yamada wrote: >> On 2017/09/11 23:38, Robert Haas wrote: >>> On Sun, Sep 10, 2017 at 10:36 PM, Tatsuro Yamada >>> wrote: Thanks for the comment.

Re: [HACKERS] Optional message to user when terminating/cancelling backend

2017-10-01 Thread Daniel Gustafsson
> On 28 Sep 2017, at 14:55, Yugo Nagata <nag...@sraoss.co.jp> wrote: > > On Sun, 3 Sep 2017 22:47:10 +0200 > Daniel Gustafsson <dan...@yesql.se> wrote: > > I have reviewed your latest patch. > > I can apply this to the master branch and build t

Re: [HACKERS] PATCH: psql show index with type info

2017-10-01 Thread Daniel Gustafsson
> On 13 Sep 2017, at 01:24, Daniel Gustafsson <dan...@yesql.se> wrote: > >> On 18 Apr 2017, at 05:13, Amos Bird <amosb...@gmail.com> wrote: >> >> Ah, thanks for the suggestions. I'll revise this patch soon :) > > Have you had a chance to revis

Re: [HACKERS] Vacuum: allow usage of more than 1GB of work mem

2017-10-01 Thread Daniel Gustafsson
> On 18 Aug 2017, at 13:39, Claudio Freire wrote: > > On Fri, Apr 7, 2017 at 10:51 PM, Claudio Freire > wrote: >> Indeed they do, and that's what motivated this patch. But I'd need >> TB-sized tables to set up something like that. I don't have

Re: [HACKERS] [PATCH] Off-by-one error in logical slot resource retention

2017-10-01 Thread Daniel Gustafsson
> On 15 Sep 2017, at 13:26, Daniel Gustafsson <dan...@yesql.se> wrote: > >> On 01 Sep 2017, at 14:28, Aleksander Alekseev <a.aleks...@postgrespro.ru> >> wrote: >> >> The following review has been posted through the commitfest application: >> ma

Re: [HACKERS] ANALYZE command progress checker

2017-10-01 Thread Daniel Gustafsson
> On 05 Apr 2017, at 03:17, Masahiko Sawada wrote: > > On Wed, Apr 5, 2017 at 1:49 AM, Robert Haas wrote: >> On Tue, Apr 4, 2017 at 4:57 AM, Amit Langote >> wrote: >>> Hmm, you're right. It could be counted with a

Re: [HACKERS] Push down more UPDATEs/DELETEs in postgres_fdw

2017-10-01 Thread Daniel Gustafsson
> On 08 Apr 2017, at 16:14, David Steele wrote: > > On 3/22/17 6:20 AM, Etsuro Fujita wrote: >> On 2017/02/22 19:57, Rushabh Lathia wrote: >>> Marked this as Ready for Committer. >> >> I noticed that this item in the CF app was incorrectly marked as >> Committed. This

  1   2   >