Re: [HACKERS] pg_stop_backup(wait_for_archive := true) on standby server

2017-07-24 Thread David Steele
On 7/23/17 11:48 PM, Masahiko Sawada wrote: On Sat, Jul 22, 2017 at 8:04 AM, Stephen Frost wrote: I started discussing this with David off-list and he'd like a chance to review it in a bit more detail (he's just returning from being gone for a few weeks). That review will

Re: [HACKERS] pg_stop_backup(wait_for_archive := true) on standby server

2017-07-24 Thread David Steele
On 7/24/17 12:28 PM, Stephen Frost wrote: * David Steele (da...@pgmasters.net) wrote: While this patch brings pg_stop_backup() in line with the documentation, it also introduces a behavioral change compared to 9.6. Currently, the default 9.6 behavior on a standby is to return immediately

Re: [HACKERS] pg_stop_backup(wait_for_archive := true) on standby server

2017-07-24 Thread David Steele
On 7/24/17 3:28 PM, David Steele wrote: Yes, and this is another behavioral change to consider -- one that is more likely to impact users than the change to pg_stop_backup(). If pg_basebackup is not currently waiting for WAL on a standby (but does on a primary) then that's pretty serious

Re: [HACKERS] Update low-level backup documentation to match actual behavior

2017-08-18 Thread David Steele
Robert, Thanks for reviewing! On 8/18/17 2:45 PM, Robert Haas wrote: > - the next WAL segment. The reason for the switch is to arrange for > + the next WAL segment when run on a primary. On a standby you can call > + pg_switch_wal on the primary to perform a manual > + switch.

Re: [HACKERS] Update low-level backup documentation to match actual behavior

2017-08-18 Thread David Steele
On 8/18/17 3:00 PM, Robert Haas wrote: > > If you update the patch I'll apply it to 11 and 10. Attached is the updated patch. I didn't like the vague "there can be some issues on the server if it crashes during the backup" so I added a new paragraph at the appropriate step to give a more

Re: [HACKERS] additional contrib test suites

2017-09-14 Thread David Steele
On 9/8/17 1:32 PM, Peter Eisentraut wrote: > > Yes, some of the error messages had changed. Fixed patches attached. Patches apply and all tests pass. A few comments: * [PATCH v2 1/7] adminpack: Add test suite There are no regular tests for pg_logdir_ls(). It looks like TAP tests would be

Re: [HACKERS] additional contrib test suites

2017-09-16 Thread David Steele
On 9/15/17 6:52 PM, Michael Paquier wrote: > On Sat, Sep 16, 2017 at 5:15 AM, Tom Lane wrote: >> >> Noting that mandrill is showing yet a different failure, one that I think >> is inherent to chkpass: >> >> CREATE TABLE test (i int, p chkpass); >> INSERT INTO test VALUES

Re: [HACKERS] Show backtrace when tap tests fail

2017-09-19 Thread David Steele
On 9/19/17 5:25 PM, Tom Lane wrote: Andres Freund writes: On 2017-09-19 17:15:21 -0400, Tom Lane wrote: Meh --- Carp::Always isn't standard either, so I think this is just extra complication with little value-add. Let's just do the Devel::Confess incantation as Dagfinn

Re: [HACKERS] Creating backup history files for backups taken from standbys

2017-09-18 Thread David Steele
Hi Michael, On 8/31/17 11:56 PM, Michael Paquier wrote: > Here is an updated patch with refreshed documentation, as a result of > 449338c which was discussed in thread > https://www.postgresql.org/message-id/d4d951b9-89c0-6bc1-b6ff-d0b2dd5a8...@pgmasters.net. > I am just outlining the fact that

Re: [HACKERS] Creating backup history files for backups taken from standbys

2017-09-18 Thread David Steele
On 9/18/17 7:26 PM, Michael Paquier wrote: > On Tue, Sep 19, 2017 at 8:14 AM, David Steele <da...@pgmasters.net> wrote: >> On 8/31/17 11:56 PM, Michael Paquier wrote: >>> Here is an updated patch with refreshed documentation, as a result of >>> 449338c which

Re: [HACKERS] Show backtrace when tap tests fail

2017-09-20 Thread David Steele
On 9/20/17 6:26 AM, Dagfinn Ilmari Mannsåker wrote: > Craig Ringer <cr...@2ndquadrant.com> writes: > >> On 20 September 2017 at 06:36, David Steele <da...@pgmasters.net> wrote: >> >>> >>> I just use: >>> >>> $SIG{__DIE__} = su

Re: [HACKERS] OpenFile() Permissions Refactor

2017-09-13 Thread David Steele
Hi Peter, Here's a new patch based on your review. Where I had a question I made a choice as described below: On 9/1/17 1:58 PM, David Steele wrote: > On 9/1/17 1:15 PM, Peter Eisentraut wrote: >> On 8/29/17 12:15, David Steele wrote: >> >> I wonder whether we even need

Re: [HACKERS] OpenFile() Permissions Refactor

2017-09-24 Thread David Steele
On 9/23/17 10:22 AM, Peter Eisentraut wrote: > On 9/13/17 10:26, David Steele wrote: >> Here's a new patch based on your review. Where I had a question I made >> a choice as described below: > > I have committed the changes to the file APIs and a fix for the umask > sa

Re: [HACKERS] Update low-level backup documentation to match actual behavior

2017-08-24 Thread David Steele
Hi Michael, Thanks for reviewing! Sorry for the late response, those eclipses don't just chase themselves... On 8/20/17 10:22 PM, Michael Paquier wrote: > On Fri, Aug 18, 2017 at 3:35 AM, David Steele <da...@pgmasters.net> wrote: > > + Prior to PostgreSQL 9.6, this &g

Re: [HACKERS] Update low-level backup documentation to match actual behavior

2017-08-25 Thread David Steele
On 8/25/17 3:26 PM, Robert Haas wrote: On Fri, Aug 25, 2017 at 3:21 PM, David Steele <da...@pgmasters.net> wrote: No problem. I'll base it on your commit to capture any changes you made. Thanks, but you incorporated everything I wanted in response to my first review -- so I didn't

Re: [HACKERS] Update low-level backup documentation to match actual behavior

2017-08-25 Thread David Steele
On 8/24/17 7:36 PM, Michael Paquier wrote: > > True as well. The patch looks good to me. If a committer does not show > up soon, it may be better to register that in the CF and wait. I am > not sure that adding an open item is suited, as docs have the same > problem on 9.6. Robert said he would

Re: [HACKERS] Update low-level backup documentation to match actual behavior

2017-08-25 Thread David Steele
On 8/25/17 3:13 PM, Robert Haas wrote: > On Fri, Aug 25, 2017 at 3:10 PM, David Steele <da...@pgmasters.net> wrote: >> >> Robert said he would commit this so I expect he'll do that if he doesn't >> have any objections to the changes. >> >> Robert, if you w

[HACKERS] Update low-level backup documentation to match actual behavior

2017-08-17 Thread David Steele
As discussed in [1] our low-level backup documentation does not quite match the actual behavior of the functions on primary vs. standby. Since it appears we have decided that the remaining behavioral differences after 52f8a59dd953c68 are bugs in the documentation, the attached is a first pass at

[HACKERS] Rename RECOVERYXLOG to RECOVERYWAL?

2017-09-01 Thread David Steele
I searched the various threads on the xlog -> wal rename and I couldn't find any specific mention of why this was not renamed. I have attached a patch in case it was an oversight rather than left as-is on purpose. Thanks, -- -David da...@pgmasters.net diff --git

Re: [HACKERS] OpenFile() Permissions Refactor

2017-09-01 Thread David Steele
On 9/1/17 1:15 PM, Peter Eisentraut wrote: > On 8/29/17 12:15, David Steele wrote: > > I wonder whether we even need that much flexibility. We already set a > global umask, so we could just open all files with 0666 and let the > umask sort it out. Then we don't need all the *

Re: [HACKERS] Rename RECOVERYXLOG to RECOVERYWAL?

2017-09-01 Thread David Steele
On 9/1/17 2:06 PM, Robert Haas wrote: > On Fri, Sep 1, 2017 at 12:57 PM, David Steele <da...@pgmasters.net> wrote: >> I searched the various threads on the xlog -> wal rename and I couldn't >> find any specific mention of why this was not renamed. >> >

Re: [HACKERS] Rename RECOVERYXLOG to RECOVERYWAL?

2017-09-02 Thread David Steele
On 9/1/17 7:53 PM, Michael Paquier wrote: > On Sat, Sep 2, 2017 at 3:06 AM, Robert Haas wrote: >> I don't think this really buys us anything. If we'd applied it to v10 >> maybe, but what do we get out of whacking it around now? >> >> "Consistency", I hear you cry! Fair

[HACKERS] Exclude pg_internal.init from base backup

2017-09-02 Thread David Steele
Hackers, The cache in pg_internal.init was reused in days of yore but has been rebuilt on postmaster startup since v8.1. It appears there is no reason for this file to be backed up. I also moved the RELCACHE_INIT_FILENAME constant to relcache.h to avoid duplicating the string. I'll add this to

Re: [HACKERS] Update low-level backup documentation to match actual behavior

2017-08-30 Thread David Steele
Hi Michael, Thanks for reviewing! On 8/29/17 9:44 PM, Michael Paquier wrote: > On Tue, Aug 29, 2017 at 10:59 PM, David Steele <da...@pgmasters.net> wrote: >> >> Attached is the 9.6 patch. It required a bit more work in func.sgml >> than I was expecting so have a cl

Re: [HACKERS] Update low-level backup documentation to match actual behavior

2017-08-29 Thread David Steele
Hi Robert, On 8/25/17 4:03 PM, David Steele wrote: > On 8/25/17 3:26 PM, Robert Haas wrote: >> On Fri, Aug 25, 2017 at 3:21 PM, David Steele <da...@pgmasters.net> >> wrote: >>> No problem.  I'll base it on your commit to capture any changes you >>> m

Re: [HACKERS] Update low-level backup documentation to match actual behavior

2017-08-31 Thread David Steele
On 8/31/17 4:04 PM, Robert Haas wrote: > On Wed, Aug 30, 2017 at 8:37 PM, Michael Paquier > wrote: >> Thanks for the new version. This looks fine to me. > > Committed to REL9_6_STABLE with minor wordsmithing. The edits look good to me. Thanks, Robert! -- -David

[HACKERS] OpenFile() Permissions Refactor

2017-08-29 Thread David Steele
Hackers, While working on the patch to allow group reads of $PGDATA I refactored the various OpenFile() functions to use default/global permissions rather than permissions defined in each call. I think the patch stands on its own regardless of whether we accept the patch to allow group

Re: [HACKERS] Exclude pg_internal.init from base backup

2017-11-07 Thread David Steele
On 11/7/17 11:03 AM, Simon Riggs wrote: > On 5 November 2017 at 11:55, Magnus Hagander wrote: >> >> So +1 for documenting the difference in how these are handled, as this is >> important to know for somebody writing an external tool for it. > > Changes made, moving to commit

Re: [HACKERS] WIP: Restricting pg_rewind to data/wal dirs

2017-10-31 Thread David Steele
On 10/30/17 6:36 AM, Michael Paquier wrote: > On Mon, Oct 30, 2017 at 10:15 AM, Chris Travers >> >> How does rep mgr or other programs using pg_rewind know what to exclude? > > Good question. Answers could come from folks such as David Steele > (pgBackRest) or Marco (bar

Re: [HACKERS] Timeline ID in backup_label file

2017-10-26 Thread David Steele
On 10/25/17 10:10 PM, Craig Ringer wrote: > On 26 October 2017 at 02:50, Michael Paquier > wrote: >> >> I would find interesting to add at the bottom of the backup_label file >> a new field called "START TIMELINE: %d" to put this information in a >> more understandable

Re: [HACKERS] Redesigning checkpoint_segments

2015-02-04 Thread David Steele
could otherwise be a low-traffic database. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] tablespaces inside $PGDATA considered harmful

2015-01-30 Thread David Steele
. If the user really wants tablespaces in $PGDATA they can always change the links manually in the filesystem and deal with any consequences on their own. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-02 Thread David Steele
covers most use cases and would certainly be a big step forward for Postgres. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Fwd: [GENERAL] 4B row limit for CLOB tables

2015-02-03 Thread David Steele
you described, right? EXTENDED is the default for most TOAST-able types and is still subject to TOAST_TUPLE_THRESHOLD which is normally 2K. EXTERNAL is the same but with no compression. See: http://www.postgresql.org/docs/9.4/static/storage-toast.html -- - David Steele da...@pgmasters.net

Re: [HACKERS] Redesigning checkpoint_segments

2015-02-05 Thread David Steele
more of them out there. I wouldn't be opposed to min_wal_size = -1 meaning same as max_wal_size though. +1 for min_wal_size. Like Josh, I can think of instances where this would be good. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Fwd: [GENERAL] 4B row limit for CLOB tables

2015-02-03 Thread David Steele
On 2/3/15 5:27 PM, Jim Nasby wrote: On 2/3/15 9:50 AM, David Steele wrote: EXTENDED is the default for most TOAST-able types and is still subject to TOAST_TUPLE_THRESHOLD which is normally 2K. EXTERNAL is the same but with no compression. See: http://www.postgresql.org/docs/9.4/static

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-08 Thread David Steele
On 2/2/15 3:49 PM, David Steele wrote: The role-base approach being considered may strike some as a misuse of the role system, but to my eye it is syntactically very close to how Oracle does auditing prior to 12c. Say you wanted to audit selects on the table hr.employee: Oracle: AUDIT

Re: [HACKERS] pg_upgrade and rsync

2015-01-22 Thread David Steele
is not *guaranteed* to work unless checksums are used. This may seem like an edge case, but for a small, active database it looks like it could be a real issue. -- - David Steele da...@pgmasters.net -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] pg_upgrade and rsync

2015-01-22 Thread David Steele
the master and run rsync again. However, at that point, you might as well just take a base backup and be done with it. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-17 Thread David Steele
it would be easy for a superuser to disable. Normal users can be configured to not have that capability, so auditing them is reliable. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-17 Thread David Steele
changes are needed prior to commit? I've incorporated most of Stephen's changes but I won't have time to get another patch out today. However, since most of his comments were about comments, I'd be happy to have your review as is and I appreciate your feedback. -- - David Steele da...@pgmasters.net

Re: [HACKERS] Issue installing doc tools on OSX

2015-02-16 Thread David Steele
On 2/16/15 6:10 PM, Florian Pflug wrote: On Feb16, 2015, at 23:18 , Peter Eisentraut pete...@gmx.net wrote: On 2/15/15 9:23 PM, David Steele wrote: That seems a bit incredible, since port should be able to resolve the dependencies by itself. I suggest that this should be reported as a bug

Re: [HACKERS] pg_upgrade and rsync

2015-02-19 Thread David Steele
to clarify the procedure. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-02-18 Thread David Steele
On 2/18/15 8:25 AM, Simon Riggs wrote: On 15 February 2015 at 02:34, David Steele da...@pgmasters.net wrote: I've posted a couple of messages over the last few weeks about the work I've been doing on the pg_audit extension. The lack of response could be due to either universal acclaim

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-18 Thread David Steele
Hi Fujii, Thanks for taking a look at the patch. Comments below: On 2/18/15 6:11 AM, Fujii Masao wrote: On Wed, Feb 18, 2015 at 1:26 AM, David Steele da...@pgmasters.net wrote: On 2/17/15 10:23 AM, Simon Riggs wrote: I vote to include pgaudit in 9.5, albeit with any changes. In particular

Re: [HACKERS] pg_upgrade and rsync

2015-01-27 Thread David Steele
. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pg_upgrade and rsync

2015-01-27 Thread David Steele
but something closer to the source would be even better. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pg_upgrade and rsync

2015-01-26 Thread David Steele
tests to show the rsync vulnerability and another to show that this can affect a running database. However, to reproduce it reliably you need to force a checkpoint or have them happening pretty close together. -- - David Steele da...@pgmasters.ne signature.asc Description: OpenPGP digital

Re: [HACKERS] pg_upgrade and rsync

2015-01-27 Thread David Steele
that support millisecond mod times, at least it was true on Ubuntu 12.04 running ext4. Even on my laptop there is a full half-second of vulnerability for rsync. Faster systems may have a larger window. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

[HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-02-14 Thread David Steele
to the Commitfest. I'll do everything I can to address the concerns of the community and I'm happy to provide more examples as needed. I'm hoping the sgml docs I've provided with the patch will cover any questions, but of course feedback is always appreciated. -- - David Steele da...@pgmasters.net diff --git

[HACKERS] Issue installing doc tools on OSX

2015-02-15 Thread David Steele
libxslt openjade opensp To: sudo port install docbook-dsssl docbook-sgml-4.2 docbook-xml-4.2 docbook-xsl libxslt opensp openjade I didn't capture the error message unfortunately, but it was more or less: unresolved dependency opensp while installing openjade. Patch is attached. -- - David Steele

Re: [HACKERS] Issue installing doc tools on OSX

2015-02-15 Thread David Steele
On 2/15/15 7:50 PM, Peter Eisentraut wrote: On 2/15/15 6:31 PM, David Steele wrote: I had a problem installing the doc tools following the directions for OSX at http://www.postgresql.org/docs/9.4/static/docguide-toolsets.html. I'm running OSX Yosemite. I got it to work by changing

Re: [HACKERS] Allow snapshot too old error, to prevent bloat

2015-02-19 Thread David Steele
setting, and reload again. While I think pg_dump is a great solution for small to medium installations, there are a number of excellent file-based backup options available. Anyone who is seriously worried about bloat (or locking) should be looking to those solutions. -- - David Steele da

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-19 Thread David Steele
On 2/18/15 10:29 PM, Fujii Masao wrote: On Thu, Feb 19, 2015 at 12:25 AM, David Steele da...@pgmasters.net wrote: The pg_audit doesn't log BIND parameter values when prepared statement is used. Seems this is an oversight of the patch. Or is this intentional? It's actually intentional

Re: [HACKERS] Order of enforcement of CHECK constraints?

2015-03-22 Thread David Steele
by the user to force order when desired. Not sure if that's as important for check constraints as it is for triggers but it might be useful, even if only for things like unit tests. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] recovery_target_time ignored ?

2015-03-24 Thread David Steele
On 3/24/15 6:12 AM, Venkata Balaji N wrote: On Tue, Mar 24, 2015 at 9:54 AM, David Steele da...@pgmasters.net mailto:da...@pgmasters.net wrote: On 3/23/15 12:42 AM, Venkata Balaji N wrote: Hi, Assuming that this might require a patch, i am posting this in pgsql

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-03-24 Thread David Steele
when data is added or removed from a table. In essence, it is a query even if it does not return row data. If that sounds paranoid, well, auditing is all about paranoia! -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-03-24 Thread David Steele
On Wed, Mar 25, 2015 at 12:38 AM, David Steele da...@pgmasters.net wrote: 2. OBJECT auditing does not work before adding acl info to pg_class.rel_acl. In following situation, pg_audit can not audit OBJECT log. $ cat postgresql.conf | grep audit shared_preload_libraries = 'pg_audit

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-03-25 Thread David Steele
On 3/25/15 7:46 AM, Sawada Masahiko wrote: On Wed, Mar 25, 2015 at 12:23 PM, David Steele da...@pgmasters.net wrote: On Wed, Mar 25, 2015 at 12:38 AM, David Steele da...@pgmasters.net wrote: 2. OBJECT auditing does not work before adding acl info to pg_class.rel_acl. In following situation

Re: [HACKERS] Relation extension scalability

2015-03-30 Thread David Steele
. Large tables in a database are generally in the minority and known in advance. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] collations in shared catalogs?

2015-03-04 Thread David Steele
Hi Robert, On 3/4/15 10:14 AM, Robert Haas wrote: On Wed, Feb 25, 2015 at 7:54 PM, David Steele da...@pgmasters.net wrote: +1 on 128/256 character names. /me runs and hides. /stands brazenly in the open and volunteers to try it if I don't get clobbered within seconds. I think

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-23 Thread David Steele
On 2/18/15 10:25 AM, David Steele wrote: On 2/18/15 6:11 AM, Fujii Masao wrote: The pg_audit doesn't log BIND parameter values when prepared statement is used. Seems this is an oversight of the patch. Or is this intentional? It's actually intentional - following the model I talked about

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-02-23 Thread David Steele
. -- - David Steele da...@pgmasters.net diff --git a/contrib/Makefile b/contrib/Makefile index 195d447..d8e75f4 100644 --- a/contrib/Makefile +++ b/contrib/Makefile @@ -29,6 +29,7 @@ SUBDIRS = \ pageinspect \ passwordcheck \ pg_archivecleanup

Re: [HACKERS] Question about durability and postgresql.

2015-02-20 Thread David Steele
page writes. This setting can lead to a corrupt database on a system failure. I'd use the checkpoint settings above to reduce full-page writes instead and see how that works out. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Raspberry PI vs Raspberry PI 2: time to compile backend code

2015-02-23 Thread David Steele
and a similar class 10 card (30MB/s but the I/O is not the bottleneck). Nice! Looks like Moore's Law works even on tight budgets. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-02-24 Thread David Steele
On 2/23/15 10:59 AM, David Steele wrote: On 2/17/15 10:34 AM, Stephen Frost wrote: There seems to be a number of places which are 'pgaudit' and a bunch that are 'pg_audit'. I'm guessing you were thinking 'pg_audit', but it'd be good to clean up and make them all consistent. Fixed, though I

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-26 Thread David Steele
On 2/25/15 11:40 PM, Alvaro Herrera wrote: Fujii Masao wrote: On Tue, Feb 24, 2015 at 1:29 AM, David Steele da...@pgmasters.net wrote: 1) Follow Oracle's as session option and only log each statement type against an object the first time it happens in a session. This would greatly reduce

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-26 Thread David Steele
On 2/25/15 10:42 PM, Fujii Masao wrote: On Tue, Feb 24, 2015 at 1:29 AM, David Steele da...@pgmasters.net wrote: On 2/18/15 10:25 AM, David Steele wrote: On 2/18/15 6:11 AM, Fujii Masao wrote: The pg_audit doesn't log BIND parameter values when prepared statement is used. Seems

Re: [HACKERS] collations in shared catalogs?

2015-02-25 Thread David Steele
in the security label docs is over half the length of a name field already..). Now if we increased name to 128 characters... +1 on 128/256 character names. /me runs and hides. /stands brazenly in the open and volunteers to try it if I don't get clobbered within seconds. -- - David Steele da

Re: [HACKERS] logical column ordering

2015-02-26 Thread David Steele
. The function is attached if anyone is interested. -- - David Steele da...@pgmasters.net / CATALOG_TABLE_COLUMN_MOVE Function create or replace

Re: [HACKERS] pg_upgrade and rsync

2015-01-29 Thread David Steele
. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pg_upgrade and rsync

2015-01-29 Thread David Steele
, streaming replication (unless it is synchronous) would be crazy without doing WAL backup. Maybe that's just me. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pg_upgrade and rsync

2015-01-29 Thread David Steele
On 1/29/15 7:55 PM, Jim Nasby wrote: On 1/29/15 6:25 PM, David Steele wrote: Safe backups can be done without LSNs provided you are willing to trust your timestamps. Which AFAICT simply isn't safe to do at all... except maybe with the manifest stuff you've talked about? Yes - that's what

Re: [HACKERS] pg_upgrade and rsync

2015-01-29 Thread David Steele
and far between. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pg_upgrade and rsync

2015-01-29 Thread David Steele
anymore. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pg_upgrade and rsync

2015-01-29 Thread David Steele
On 1/29/15 8:09 PM, Jim Nasby wrote: On 1/29/15 7:02 PM, David Steele wrote: On 1/29/15 7:55 PM, Jim Nasby wrote: On 1/29/15 6:25 PM, David Steele wrote: Safe backups can be done without LSNs provided you are willing to trust your timestamps. Which AFAICT simply isn't safe to do at all

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-03-23 Thread David Steele
formalized and MemoryContextRegisterResetCallback() is used to cleanup the stack on errors. Let me know what you think. -- - David Steele da...@pgmasters.net diff --git a/contrib/Makefile b/contrib/Makefile index 195d447..d8e75f4 100644 --- a/contrib/Makefile +++ b/contrib/Makefile @@ -29,6 +29,7

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-03-23 Thread David Steele
On 3/23/15 1:39 PM, Sawada Masahiko wrote: On Tue, Mar 24, 2015 at 1:40 AM, David Steele da...@pgmasters.net wrote: I have prepared a patch that brings event triggers and deparse back to pg_audit based on the Alvaro's dev/deparse branch at git://git.postgresql.org/git/2ndquadrant_bdr.git

Re: [HACKERS] recovery_target_time ignored ?

2015-03-23 Thread David Steele
' You have '2015-03-23 10:00:26 GMT-10' in recovery.conf but the log says 'starting point-in-time recovery to 2015-03-23 10:00:26+10'. Note the - vs +. Could you check your log and recovery.conf and make sure the timezone offsets are actually different? -- - David Steele da...@pgmasters.net

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-03 Thread David Steele
On 4/3/15 3:59 AM, Sawada Masahiko wrote: On Thu, Apr 2, 2015 at 2:46 AM, David Steele da...@pgmasters.net wrote: Let me know if you see any other issues. I pulled HEAD, and then tried to compile source code after applied following deparsing utility command patch without #0001 and #0002

Re: [HACKERS] tablespaces inside $PGDATA considered harmful

2015-04-23 Thread David Steele
of directory manipulation before upgrading - and that's only for the people who have put tablespaces in $PGDATA. I've never seen it before, but I have no doubt that it happens. I can see how it might make a weird sort of sense depending on the level of experience. -- - David Steele da...@pgmasters.net

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-20 Thread David Steele
and/or the Why pg_audit? section of the pg_audit documentation. I agree that it may make sense in the future to merge session logging into log_statements, but for now it does provide important additional functionality for creating audit logs. Regards, -- - David Steele da...@pgmasters.net

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-04-28 Thread David Steele
: http://www.postgresql.org/message-id/20150428145626.2632.75287.p...@coridan.postgresql.org -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-04-28 Thread David Steele
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed Looks good overall, but make installcheck-world does not

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-28 Thread David Steele
On 4/28/15 2:14 AM, Sawada Masahiko wrote: On Fri, Apr 24, 2015 at 3:23 AM, David Steele da...@pgmasters.net wrote: I've also added some checking to make sure that if anything looks funny on the stack an error will be generated. Thanks for the feedback! Thank you for updating the patch

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-04-29 Thread David Steele
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed Looks good - ready for committer. The new status of this

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-04-29 Thread David Steele
On 4/29/15 5:16 PM, Robert Haas wrote: On Fri, Apr 24, 2015 at 2:40 PM, David Steele da...@pgmasters.net wrote: para The view structnamepg_file_settings/structname provides access to run-time parameters that are defined in configuration files via SQL. In contrast

Re: [HACKERS] CTE optimization fence on the todo list?

2015-05-01 Thread David Steele
. An enable_cte_optimization GUC would serve to keep old code from breaking while giving new users/queries the advantage of optimization. I'm not sure it's worth adding the complexity, though. In my experience not that many developers use CTEs. -- - David Steele da...@pgmasters.net signature.asc

Re: [HACKERS] CTE optimization fence on the todo list?

2015-05-01 Thread David Steele
when appropriate. However, when I really need optimization across boundaries I just use a subquery. It doesn't seem like there's much to be gained in terms of net functionality. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-04-27 Thread David Steele
with spaces. guc_array-value = guc_strdup(FATAL, item-value); warning: squelched 2 whitespace errors warning: 7 lines add whitespace errors. I'm sure the committer would appreciate it if you'd clean those up. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-05-01 Thread David Steele
On 5/1/15 5:58 AM, Sawada Masahiko wrote: On Fri, May 1, 2015 at 6:24 AM, David Steele da...@pgmasters.net wrote: May 15th is the feature freeze, so that does give a little time. It's not clear to me what a self-contained part of the patch would be. If you have specific ideas on what could

Re: [HACKERS] deparsing utility commands

2015-05-11 Thread David Steele
. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-05-07 Thread David Steele
would not reduce the amount of code significantly. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] deparsing utility commands

2015-04-14 Thread David Steele
, I see no barriers to committing patches 0001 and 0002. I'd love to see this functionality in 9.5. Regards, -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-15 Thread David Steele
have added a few parenthetical statements to the docs that should make them clearer. I also took your suggestion and added a view regression test. Both are in patch v9 which I attached to my previous email on this thread. Thank you for taking the time to have a look. -- - David Steele da

Re: [HACKERS] PATCH: default_index_tablespace

2015-04-16 Thread David Steele
so this is not usually a big deal - but sometimes it is. Trying to get a tablespace clause on every index in the build scripts is a real PITA. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-14 Thread David Steele
CF is a very bad time to be behind HEAD. Fixed in attached v8 patch. -- - David Steele da...@pgmasters.net diff --git a/contrib/Makefile b/contrib/Makefile index d63e441..ed9cf6a 100644 --- a/contrib/Makefile +++ b/contrib/Makefile @@ -28,6 +28,7 @@ SUBDIRS = \ oid2name

Re: [HACKERS] Turning off HOT/Cleanup sometimes

2015-04-14 Thread David Steele
have allowed vacuum to come in and do the job without affecting performance of the main job. I think that in batch-oriented databases this patch will definitely be a boon to performance. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-06 Thread David Steele
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 4/6/15 4:34 PM, Peter Eisentraut wrote: On 2/14/15 9:34 PM, David Steele wrote: The patch I've attached satisfies the requirements that I've had from customers in the past. What I'm missing is a more precise description/documentation

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-06 Thread David Steele
that functionality put back before it gets committed, if that occurs. Bringing this back would be easy (it actually requires removing, not adding code) but I'd prefer to make it configurable. - -- - - David Steele da...@pgmasters.net -BEGIN PGP SIGNATURE- Version: GnuPG v2

  1   2   3   4   5   6   >