Re: [HACKERS] Redesigning checkpoint_segments

2015-02-04 Thread David Steele
could otherwise be a low-traffic database. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] tablespaces inside $PGDATA considered harmful

2015-01-30 Thread David Steele
. If the user really wants tablespaces in $PGDATA they can always change the links manually in the filesystem and deal with any consequences on their own. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-02 Thread David Steele
covers most use cases and would certainly be a big step forward for Postgres. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Fwd: [GENERAL] 4B row limit for CLOB tables

2015-02-03 Thread David Steele
you described, right? EXTENDED is the default for most TOAST-able types and is still subject to TOAST_TUPLE_THRESHOLD which is normally 2K. EXTERNAL is the same but with no compression. See: http://www.postgresql.org/docs/9.4/static/storage-toast.html -- - David Steele da...@pgmasters.net

Re: [HACKERS] Redesigning checkpoint_segments

2015-02-05 Thread David Steele
more of them out there. I wouldn't be opposed to min_wal_size = -1 meaning same as max_wal_size though. +1 for min_wal_size. Like Josh, I can think of instances where this would be good. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Fwd: [GENERAL] 4B row limit for CLOB tables

2015-02-03 Thread David Steele
On 2/3/15 5:27 PM, Jim Nasby wrote: On 2/3/15 9:50 AM, David Steele wrote: EXTENDED is the default for most TOAST-able types and is still subject to TOAST_TUPLE_THRESHOLD which is normally 2K. EXTERNAL is the same but with no compression. See: http://www.postgresql.org/docs/9.4/static

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-08 Thread David Steele
On 2/2/15 3:49 PM, David Steele wrote: The role-base approach being considered may strike some as a misuse of the role system, but to my eye it is syntactically very close to how Oracle does auditing prior to 12c. Say you wanted to audit selects on the table hr.employee: Oracle: AUDIT

Re: [HACKERS] pg_upgrade and rsync

2015-01-22 Thread David Steele
is not *guaranteed* to work unless checksums are used. This may seem like an edge case, but for a small, active database it looks like it could be a real issue. -- - David Steele da...@pgmasters.net -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] pg_upgrade and rsync

2015-01-22 Thread David Steele
the master and run rsync again. However, at that point, you might as well just take a base backup and be done with it. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-17 Thread David Steele
it would be easy for a superuser to disable. Normal users can be configured to not have that capability, so auditing them is reliable. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-17 Thread David Steele
changes are needed prior to commit? I've incorporated most of Stephen's changes but I won't have time to get another patch out today. However, since most of his comments were about comments, I'd be happy to have your review as is and I appreciate your feedback. -- - David Steele da...@pgmasters.net

Re: [HACKERS] Issue installing doc tools on OSX

2015-02-16 Thread David Steele
On 2/16/15 6:10 PM, Florian Pflug wrote: On Feb16, 2015, at 23:18 , Peter Eisentraut pete...@gmx.net wrote: On 2/15/15 9:23 PM, David Steele wrote: That seems a bit incredible, since port should be able to resolve the dependencies by itself. I suggest that this should be reported as a bug

Re: [HACKERS] pg_upgrade and rsync

2015-02-19 Thread David Steele
to clarify the procedure. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-02-18 Thread David Steele
On 2/18/15 8:25 AM, Simon Riggs wrote: On 15 February 2015 at 02:34, David Steele da...@pgmasters.net wrote: I've posted a couple of messages over the last few weeks about the work I've been doing on the pg_audit extension. The lack of response could be due to either universal acclaim

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-18 Thread David Steele
Hi Fujii, Thanks for taking a look at the patch. Comments below: On 2/18/15 6:11 AM, Fujii Masao wrote: On Wed, Feb 18, 2015 at 1:26 AM, David Steele da...@pgmasters.net wrote: On 2/17/15 10:23 AM, Simon Riggs wrote: I vote to include pgaudit in 9.5, albeit with any changes. In particular

Re: [HACKERS] pg_upgrade and rsync

2015-01-27 Thread David Steele
. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pg_upgrade and rsync

2015-01-27 Thread David Steele
but something closer to the source would be even better. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pg_upgrade and rsync

2015-01-26 Thread David Steele
tests to show the rsync vulnerability and another to show that this can affect a running database. However, to reproduce it reliably you need to force a checkpoint or have them happening pretty close together. -- - David Steele da...@pgmasters.ne signature.asc Description: OpenPGP digital

Re: [HACKERS] pg_upgrade and rsync

2015-01-27 Thread David Steele
that support millisecond mod times, at least it was true on Ubuntu 12.04 running ext4. Even on my laptop there is a full half-second of vulnerability for rsync. Faster systems may have a larger window. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

[HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-02-14 Thread David Steele
to the Commitfest. I'll do everything I can to address the concerns of the community and I'm happy to provide more examples as needed. I'm hoping the sgml docs I've provided with the patch will cover any questions, but of course feedback is always appreciated. -- - David Steele da...@pgmasters.net diff --git

[HACKERS] Issue installing doc tools on OSX

2015-02-15 Thread David Steele
libxslt openjade opensp To: sudo port install docbook-dsssl docbook-sgml-4.2 docbook-xml-4.2 docbook-xsl libxslt opensp openjade I didn't capture the error message unfortunately, but it was more or less: unresolved dependency opensp while installing openjade. Patch is attached. -- - David Steele

Re: [HACKERS] Issue installing doc tools on OSX

2015-02-15 Thread David Steele
On 2/15/15 7:50 PM, Peter Eisentraut wrote: On 2/15/15 6:31 PM, David Steele wrote: I had a problem installing the doc tools following the directions for OSX at http://www.postgresql.org/docs/9.4/static/docguide-toolsets.html. I'm running OSX Yosemite. I got it to work by changing

Re: [HACKERS] Allow snapshot too old error, to prevent bloat

2015-02-19 Thread David Steele
setting, and reload again. While I think pg_dump is a great solution for small to medium installations, there are a number of excellent file-based backup options available. Anyone who is seriously worried about bloat (or locking) should be looking to those solutions. -- - David Steele da

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-19 Thread David Steele
On 2/18/15 10:29 PM, Fujii Masao wrote: On Thu, Feb 19, 2015 at 12:25 AM, David Steele da...@pgmasters.net wrote: The pg_audit doesn't log BIND parameter values when prepared statement is used. Seems this is an oversight of the patch. Or is this intentional? It's actually intentional

Re: [HACKERS] Order of enforcement of CHECK constraints?

2015-03-22 Thread David Steele
by the user to force order when desired. Not sure if that's as important for check constraints as it is for triggers but it might be useful, even if only for things like unit tests. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] recovery_target_time ignored ?

2015-03-24 Thread David Steele
On 3/24/15 6:12 AM, Venkata Balaji N wrote: On Tue, Mar 24, 2015 at 9:54 AM, David Steele da...@pgmasters.net mailto:da...@pgmasters.net wrote: On 3/23/15 12:42 AM, Venkata Balaji N wrote: Hi, Assuming that this might require a patch, i am posting this in pgsql

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-03-24 Thread David Steele
when data is added or removed from a table. In essence, it is a query even if it does not return row data. If that sounds paranoid, well, auditing is all about paranoia! -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-03-24 Thread David Steele
On Wed, Mar 25, 2015 at 12:38 AM, David Steele da...@pgmasters.net wrote: 2. OBJECT auditing does not work before adding acl info to pg_class.rel_acl. In following situation, pg_audit can not audit OBJECT log. $ cat postgresql.conf | grep audit shared_preload_libraries = 'pg_audit

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-03-25 Thread David Steele
On 3/25/15 7:46 AM, Sawada Masahiko wrote: On Wed, Mar 25, 2015 at 12:23 PM, David Steele da...@pgmasters.net wrote: On Wed, Mar 25, 2015 at 12:38 AM, David Steele da...@pgmasters.net wrote: 2. OBJECT auditing does not work before adding acl info to pg_class.rel_acl. In following situation

Re: [HACKERS] Relation extension scalability

2015-03-30 Thread David Steele
. Large tables in a database are generally in the minority and known in advance. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] collations in shared catalogs?

2015-03-04 Thread David Steele
Hi Robert, On 3/4/15 10:14 AM, Robert Haas wrote: On Wed, Feb 25, 2015 at 7:54 PM, David Steele da...@pgmasters.net wrote: +1 on 128/256 character names. /me runs and hides. /stands brazenly in the open and volunteers to try it if I don't get clobbered within seconds. I think

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-23 Thread David Steele
On 2/18/15 10:25 AM, David Steele wrote: On 2/18/15 6:11 AM, Fujii Masao wrote: The pg_audit doesn't log BIND parameter values when prepared statement is used. Seems this is an oversight of the patch. Or is this intentional? It's actually intentional - following the model I talked about

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-02-23 Thread David Steele
. -- - David Steele da...@pgmasters.net diff --git a/contrib/Makefile b/contrib/Makefile index 195d447..d8e75f4 100644 --- a/contrib/Makefile +++ b/contrib/Makefile @@ -29,6 +29,7 @@ SUBDIRS = \ pageinspect \ passwordcheck \ pg_archivecleanup

Re: [HACKERS] Question about durability and postgresql.

2015-02-20 Thread David Steele
page writes. This setting can lead to a corrupt database on a system failure. I'd use the checkpoint settings above to reduce full-page writes instead and see how that works out. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Raspberry PI vs Raspberry PI 2: time to compile backend code

2015-02-23 Thread David Steele
and a similar class 10 card (30MB/s but the I/O is not the bottleneck). Nice! Looks like Moore's Law works even on tight budgets. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-02-24 Thread David Steele
On 2/23/15 10:59 AM, David Steele wrote: On 2/17/15 10:34 AM, Stephen Frost wrote: There seems to be a number of places which are 'pgaudit' and a bunch that are 'pg_audit'. I'm guessing you were thinking 'pg_audit', but it'd be good to clean up and make them all consistent. Fixed, though I

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-26 Thread David Steele
On 2/25/15 11:40 PM, Alvaro Herrera wrote: Fujii Masao wrote: On Tue, Feb 24, 2015 at 1:29 AM, David Steele da...@pgmasters.net wrote: 1) Follow Oracle's as session option and only log each statement type against an object the first time it happens in a session. This would greatly reduce

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-26 Thread David Steele
On 2/25/15 10:42 PM, Fujii Masao wrote: On Tue, Feb 24, 2015 at 1:29 AM, David Steele da...@pgmasters.net wrote: On 2/18/15 10:25 AM, David Steele wrote: On 2/18/15 6:11 AM, Fujii Masao wrote: The pg_audit doesn't log BIND parameter values when prepared statement is used. Seems

Re: [HACKERS] collations in shared catalogs?

2015-02-25 Thread David Steele
in the security label docs is over half the length of a name field already..). Now if we increased name to 128 characters... +1 on 128/256 character names. /me runs and hides. /stands brazenly in the open and volunteers to try it if I don't get clobbered within seconds. -- - David Steele da

Re: [HACKERS] logical column ordering

2015-02-26 Thread David Steele
. The function is attached if anyone is interested. -- - David Steele da...@pgmasters.net / CATALOG_TABLE_COLUMN_MOVE Function create or replace

Re: [HACKERS] pg_upgrade and rsync

2015-01-29 Thread David Steele
. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pg_upgrade and rsync

2015-01-29 Thread David Steele
, streaming replication (unless it is synchronous) would be crazy without doing WAL backup. Maybe that's just me. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pg_upgrade and rsync

2015-01-29 Thread David Steele
On 1/29/15 7:55 PM, Jim Nasby wrote: On 1/29/15 6:25 PM, David Steele wrote: Safe backups can be done without LSNs provided you are willing to trust your timestamps. Which AFAICT simply isn't safe to do at all... except maybe with the manifest stuff you've talked about? Yes - that's what

Re: [HACKERS] pg_upgrade and rsync

2015-01-29 Thread David Steele
and far between. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pg_upgrade and rsync

2015-01-29 Thread David Steele
anymore. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] pg_upgrade and rsync

2015-01-29 Thread David Steele
On 1/29/15 8:09 PM, Jim Nasby wrote: On 1/29/15 7:02 PM, David Steele wrote: On 1/29/15 7:55 PM, Jim Nasby wrote: On 1/29/15 6:25 PM, David Steele wrote: Safe backups can be done without LSNs provided you are willing to trust your timestamps. Which AFAICT simply isn't safe to do at all

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-03-23 Thread David Steele
formalized and MemoryContextRegisterResetCallback() is used to cleanup the stack on errors. Let me know what you think. -- - David Steele da...@pgmasters.net diff --git a/contrib/Makefile b/contrib/Makefile index 195d447..d8e75f4 100644 --- a/contrib/Makefile +++ b/contrib/Makefile @@ -29,6 +29,7

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-03-23 Thread David Steele
On 3/23/15 1:39 PM, Sawada Masahiko wrote: On Tue, Mar 24, 2015 at 1:40 AM, David Steele da...@pgmasters.net wrote: I have prepared a patch that brings event triggers and deparse back to pg_audit based on the Alvaro's dev/deparse branch at git://git.postgresql.org/git/2ndquadrant_bdr.git

Re: [HACKERS] recovery_target_time ignored ?

2015-03-23 Thread David Steele
' You have '2015-03-23 10:00:26 GMT-10' in recovery.conf but the log says 'starting point-in-time recovery to 2015-03-23 10:00:26+10'. Note the - vs +. Could you check your log and recovery.conf and make sure the timezone offsets are actually different? -- - David Steele da...@pgmasters.net

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-03 Thread David Steele
On 4/3/15 3:59 AM, Sawada Masahiko wrote: On Thu, Apr 2, 2015 at 2:46 AM, David Steele da...@pgmasters.net wrote: Let me know if you see any other issues. I pulled HEAD, and then tried to compile source code after applied following deparsing utility command patch without #0001 and #0002

Re: [HACKERS] tablespaces inside $PGDATA considered harmful

2015-04-23 Thread David Steele
of directory manipulation before upgrading - and that's only for the people who have put tablespaces in $PGDATA. I've never seen it before, but I have no doubt that it happens. I can see how it might make a weird sort of sense depending on the level of experience. -- - David Steele da...@pgmasters.net

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-20 Thread David Steele
and/or the Why pg_audit? section of the pg_audit documentation. I agree that it may make sense in the future to merge session logging into log_statements, but for now it does provide important additional functionality for creating audit logs. Regards, -- - David Steele da...@pgmasters.net

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-04-24 Thread David Steele
| 3 | log_timezone| US/Eastern /db/postgresql.auto.conf | 3 | 4 | max_connections | 200 -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-04-28 Thread David Steele
: http://www.postgresql.org/message-id/20150428145626.2632.75287.p...@coridan.postgresql.org -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-04-28 Thread David Steele
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed Looks good overall, but make installcheck-world does not

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-28 Thread David Steele
On 4/28/15 2:14 AM, Sawada Masahiko wrote: On Fri, Apr 24, 2015 at 3:23 AM, David Steele da...@pgmasters.net wrote: I've also added some checking to make sure that if anything looks funny on the stack an error will be generated. Thanks for the feedback! Thank you for updating the patch

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-04-29 Thread David Steele
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed Looks good - ready for committer. The new status of this

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-04-29 Thread David Steele
On 4/29/15 5:16 PM, Robert Haas wrote: On Fri, Apr 24, 2015 at 2:40 PM, David Steele da...@pgmasters.net wrote: para The view structnamepg_file_settings/structname provides access to run-time parameters that are defined in configuration files via SQL. In contrast

Re: [HACKERS] CTE optimization fence on the todo list?

2015-05-01 Thread David Steele
. An enable_cte_optimization GUC would serve to keep old code from breaking while giving new users/queries the advantage of optimization. I'm not sure it's worth adding the complexity, though. In my experience not that many developers use CTEs. -- - David Steele da...@pgmasters.net signature.asc

Re: [HACKERS] CTE optimization fence on the todo list?

2015-05-01 Thread David Steele
when appropriate. However, when I really need optimization across boundaries I just use a subquery. It doesn't seem like there's much to be gained in terms of net functionality. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-04-27 Thread David Steele
with spaces. guc_array-value = guc_strdup(FATAL, item-value); warning: squelched 2 whitespace errors warning: 7 lines add whitespace errors. I'm sure the committer would appreciate it if you'd clean those up. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-05-01 Thread David Steele
On 5/1/15 5:58 AM, Sawada Masahiko wrote: On Fri, May 1, 2015 at 6:24 AM, David Steele da...@pgmasters.net wrote: May 15th is the feature freeze, so that does give a little time. It's not clear to me what a self-contained part of the patch would be. If you have specific ideas on what could

Re: [HACKERS] deparsing utility commands

2015-05-11 Thread David Steele
. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-05-07 Thread David Steele
would not reduce the amount of code significantly. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] deparsing utility commands

2015-04-14 Thread David Steele
, I see no barriers to committing patches 0001 and 0002. I'd love to see this functionality in 9.5. Regards, -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-15 Thread David Steele
have added a few parenthetical statements to the docs that should make them clearer. I also took your suggestion and added a view regression test. Both are in patch v9 which I attached to my previous email on this thread. Thank you for taking the time to have a look. -- - David Steele da

Re: [HACKERS] PATCH: default_index_tablespace

2015-04-16 Thread David Steele
so this is not usually a big deal - but sometimes it is. Trying to get a tablespace clause on every index in the build scripts is a real PITA. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-14 Thread David Steele
CF is a very bad time to be behind HEAD. Fixed in attached v8 patch. -- - David Steele da...@pgmasters.net diff --git a/contrib/Makefile b/contrib/Makefile index d63e441..ed9cf6a 100644 --- a/contrib/Makefile +++ b/contrib/Makefile @@ -28,6 +28,7 @@ SUBDIRS = \ oid2name

Re: [HACKERS] Turning off HOT/Cleanup sometimes

2015-04-14 Thread David Steele
have allowed vacuum to come in and do the job without affecting performance of the main job. I think that in batch-oriented databases this patch will definitely be a boon to performance. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-06 Thread David Steele
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 4/6/15 4:34 PM, Peter Eisentraut wrote: On 2/14/15 9:34 PM, David Steele wrote: The patch I've attached satisfies the requirements that I've had from customers in the past. What I'm missing is a more precise description/documentation

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-06 Thread David Steele
that functionality put back before it gets committed, if that occurs. Bringing this back would be easy (it actually requires removing, not adding code) but I'd prefer to make it configurable. - -- - - David Steele da...@pgmasters.net -BEGIN PGP SIGNATURE- Version: GnuPG v2

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-06 Thread David Steele
On 4/6/15 8:40 AM, Sawada Masahiko wrote: On Fri, Apr 3, 2015 at 10:01 PM, David Steele da...@pgmasters.net wrote: On 4/3/15 3:59 AM, Sawada Masahiko wrote: On Thu, Apr 2, 2015 at 2:46 AM, David Steele da...@pgmasters.net wrote: Let me know if you see any other issues. I pulled HEAD

Re: [HACKERS] deparsing utility commands

2015-04-08 Thread David Steele
the first set)? -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-01 Thread David Steele
Hi Sawada, On 3/25/15 9:24 AM, David Steele wrote: On 3/25/15 7:46 AM, Sawada Masahiko wrote: 2. I got ERROR when executing function uses cursor. 1) create empty table (hoge table) 2) create test function as follows. create function test() returns int as $$ declare cur1 cursor

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-01 Thread David Steele
On 3/23/15 12:40 PM, David Steele wrote: On 3/23/15 1:31 AM, Abhijit Menon-Sen wrote: I'm experimenting with a few approaches to do this without reintroducing switch statements to test every command. That will require core changes, but I think we can find an acceptable arrangement. I'll post

Re: [HACKERS] Change pg_cancel_*() to ignore current backend

2015-05-20 Thread David Steele
either. +1. I agree that cancelling/killing your own process should not be the default behavior. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] Change pg_cancel_*() to ignore current backend

2015-05-20 Thread David Steele
On 5/20/15 10:09 AM, Tom Lane wrote: David Steele da...@pgmasters.net writes: +1. I agree that cancelling/killing your own process should not be the default behavior. I think backwards compatibility probably trumps that argument. I have no objection to providing a different call

Re: [HACKERS] [COMMITTERS] pgsql: Add pg_audit, an auditing extension

2015-06-09 Thread David Steele
disappointed yet determined. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP digital signature

Re: [HACKERS] [CORE] postpone next week's release

2015-05-31 Thread David Steele
On 5/31/15 11:49 AM, Noah Misch wrote: On Sat, May 30, 2015 at 09:51:04PM -0400, David Steele wrote: On 5/30/15 8:38 PM, Joshua D. Drake wrote: On 05/30/2015 03:48 PM, David Steele wrote: I would argue Heikki's WAL stuff is a perfect case for releasing a public alpha/beta soon. I'd love

Re: [HACKERS] pg_xlog - pg_xjournal?

2015-06-01 Thread David Steele
On 6/1/15 4:42 PM, Joel Jacobson wrote: Also ... if we were to rename it, it should be pg_wal or pg_xact. Please let's not add yet another term for the WAL. I like pg_wal. It's correct and suitably mysterious. -- - David Steele da...@pgmasters.net signature.asc Description: OpenPGP

Re: [HACKERS] Test code is worth the space

2015-08-13 Thread David Steele
On 8/12/15 9:24 PM, Stephen Frost wrote: * Michael Paquier (michael.paqu...@gmail.com) wrote: On Thu, Aug 13, 2015 at 5:54 AM, Stephen Frost wrote: The regression tests included in pgBackRest (available here: https://github.com/pgmasters/backrest) go through a number of different recovery

Re: [HACKERS] Test code is worth the space

2015-08-13 Thread David Steele
On 8/12/15 9:32 PM, Robert Haas wrote: On Wed, Aug 12, 2015 at 9:24 PM, Stephen Frost sfr...@snowman.net wrote: * Michael Paquier (michael.paqu...@gmail.com) wrote: Interesting. Do you mind if I pick up from it some ideas for the in-core replication test suite based on TAP stuff? That's still

Re: [HACKERS] Test code is worth the space

2015-08-13 Thread David Steele
On 8/13/15 9:55 AM, Andres Freund wrote: On 2015-08-13 09:32:02 -0400, David Steele wrote: On 8/12/15 9:32 PM, Robert Haas wrote: On Wed, Aug 12, 2015 at 9:24 PM, Stephen Frost sfr...@snowman.net wrote: Certainly don't mind at all, entirely open source under the MIT license. Why not the PG

[HACKERS] Archiving done right

2015-08-21 Thread David Steele
I split this into a new thread to talk about archiving best practices. On 8/18/15 2:25 PM, Stephen Frost wrote: * Stephen Frost (sfr...@snowman.net) wrote: * Robert Haas (robertmh...@gmail.com) wrote: On Mon, Aug 17, 2015 at 2:50 PM, Peter Eisentraut pete...@gmx.net wrote: The commit message

Re: [HACKERS] Declarative partitioning

2015-08-20 Thread David Steele
On 8/20/15 5:45 AM, Amit Langote wrote: On 2015-08-20 PM 06:27, Pavan Deolasee wrote: On Tue, Aug 18, 2015 at 4:00 PM, Amit Langote langote_amit...@lab.ntt.co.jp wrote: PARTITION BY LIST ON (name) PARTITION BY RANGE ON (year, month) PARTITION BY LIST ON ((lower(left(name, 2))) PARTITION

Re: [HACKERS] remove wal_level archive

2015-11-02 Thread David Steele
On 11/2/15 12:21 AM, Craig Ringer wrote: On 1 September 2015 at 10:39, Peter Eisentraut wrote: So we've had several rounds of discussions about simplifying replication configuration in general and the wal_level setting in particular. [0][1] [snip] Bike-shedding: In this

Re: [HACKERS] Request: pg_cancel_backend variant that handles 'idle in transaction' sessions

2015-11-05 Thread David Steele
On 11/4/15 4:55 PM, Stephen Frost wrote: > * Joe Conway (m...@joeconway.com) wrote: >> On 11/04/2015 01:24 PM, Alvaro Herrera wrote: >>> I agree with Pavel. Having a transaction timeout just does not make any >>> sense. I can see absolutely no use for it. An idle-in-transaction >>> timeout, on

Re: [HACKERS] Request: pg_cancel_backend variant that handles 'idle in transaction' sessions

2015-11-05 Thread David Steele
On 11/5/15 10:10 AM, Alvaro Herrera wrote: David Steele wrote: The important thing about this implementation was that nothing was terminated unless it had exceed a timeout AND was blocking another process. This seems a nice idea, but you need to take the effect on vacuum of idle-in-xact

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread David Steele
On 9/22/15 11:00 AM, Andrew Dunstan wrote: On 09/22/2015 10:29 AM, Geoff Winkless wrote: ‚Äč That's your opinion; my opinion remains otherwise. It's not "perfectly reasonable" to abuse the plural because some 1960s feminazis either misunderstood or didn't like the fact that (because of history)

[HACKERS] [PROPOSAL] Client Log Output Filtering

2015-11-25 Thread David Steele
Currently log messages generated by pgaudit can be made visible to the client simply by altering client_min_messages. While this has not been a showstopper for anyone it's ideal, either. The client authentication code sets the global variable ClientAuthInProgress which causes ereport() to

Re: [HACKERS] [COMMITTERS] pgsql: Add pg_audit, an auditing extension

2015-11-20 Thread David Steele
Hi Thom, On 11/18/15 8:54 AM, Thom Brown wrote: On 10 June 2015 at 14:41, Noah Misch <n...@leadboat.com> wrote: On Tue, Jun 09, 2015 at 03:54:59PM -0400, David Steele wrote: I've certainly had quite the experience as a first-time contributor working on this patch. Perhaps I bit off mor

Re: [HACKERS] Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

2015-11-19 Thread David Steele
On 11/19/15 11:05 AM, Robert Haas wrote: > On Wed, Nov 18, 2015 at 10:21 AM, Alvaro Herrera > wrote: >> In my days of Perl, it was starting to become frowned upon to call >> subroutines without parenthesizing arguments. Is that no longer the >> case? Because I notice

Re: [HACKERS] [COMMITTERS] pgsql: Add pg_audit, an auditing extension

2015-11-21 Thread David Steele
On 11/21/15 2:47 PM, Noah Misch wrote: > On Fri, Nov 20, 2015 at 12:11:00PM -0500, David Steele wrote: >> I fixed many of the issues that caused complaints at the end of the 9.5 >> cycle, but there are still two remaining items I would want to address >> before

Re: [HACKERS] Additional role attributes && superuser review

2015-11-19 Thread David Steele
On 11/19/15 2:13 AM, Michael Paquier wrote: > On Thu, Nov 19, 2015 at 7:10 AM, Stephen Frost wrote: >> * Michael Paquier (michael.paqu...@gmail.com) wrote: >>> It seems weird to not have a dedicated role for pg_switch_xlog. >> >> I didn't add a pg_switch_xlog default role in this patch series, but

Re: [HACKERS] [GENERAL] Permission Denied Error on pg_xlog/RECOVERYXLOG file

2016-06-03 Thread David Steele
On 6/3/16 4:13 PM, Robert Haas wrote: > On Fri, Jun 3, 2016 at 2:12 PM, Andres Freund wrote: >> On 2016-06-03 14:00:00 -0400, Robert Haas wrote: >>> On Fri, May 27, 2016 at 8:44 PM, Andres Freund wrote: I'm not convinced of that. Hiding unexpected

Re: [HACKERS] Confusing recovery message when target not hit

2016-06-11 Thread David Steele
On 6/11/16 8:22 AM, Michael Paquier wrote: > On Sat, Jun 11, 2016 at 9:44 AM, Thom Brown wrote: >> It may be the wrong way of going about it, but you get the idea of what I'm >> suggesting we output instead. > > Surely things could be better. So +1 to be more verbose here. > > +

Re: [HACKERS] [PROPOSAL] Client Log Output Filtering

2016-01-14 Thread David Steele
On 1/11/16 6:50 PM, Alvaro Herrera wrote: David Steele wrote: The patch creates a new counter to separate the log filtering from the authentication functionality. This makes it possible to get the same filtering in other parts of the code (or extensions) without abusing

Re: [HACKERS] Updated backup APIs for non-exclusive backups

2016-02-10 Thread David Steele
On 2/10/16 7:46 AM, Magnus Hagander wrote: > Per discussion at the developer meeting in Brussels, here's a patch that > makes some updates to the backup APIs, to support non-exclusive backups > without using pg_basebackup. <...> This sounds like a great idea and I have signed up to review. > * A

Re: [HACKERS] Updated backup APIs for non-exclusive backups

2016-02-10 Thread David Steele
On 2/10/16 9:44 AM, Stephen Frost wrote: > * Magnus Hagander (mag...@hagander.net) wrote: >> On Wed, Feb 10, 2016 at 2:46 PM, Andres Freund wrote: >>> On 2016-02-10 13:46:05 +0100, Magnus Hagander wrote: * If the client disconnects with a non-exclusive backup running, the

Re: [HACKERS] Updated backup APIs for non-exclusive backups

2016-02-10 Thread David Steele
On 2/10/16 11:01 AM, Andres Freund wrote: > On 2016-02-10 16:50:26 +0100, Magnus Hagander wrote: >>> I would be happy to see the time-stamp returned from the >>> pg_start_backup() function as well. It's a bigger change, but once >>> pg_start_backup() returns multiple columns it will be easier to

  1   2   3   4   5   6   >