Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-11 Thread Jeffrey Walton
On Mon, Nov 11, 2013 at 5:29 PM, Peter Geoghegan p...@heroku.com wrote: On Mon, Nov 11, 2013 at 2:18 PM, Kevin Grittner kgri...@ymail.com wrote: I'm currently capturing a text version of all the warnings from this. Will gzip and post when it finishes. It's generating a lot of warnings; I

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-11 Thread Jeffrey Walton
On Mon, Nov 11, 2013 at 5:18 PM, Kevin Grittner kgri...@ymail.com wrote: [moving the discussion to pgsql-hackers] Jeffrey Walton noloa...@gmail.com wrote: ... ## # Sanitizers make distclean export DYLD_FALLBACK_LIBRARY_PATH=/usr/local/lib/clang/3.3/lib/darwin/ export CC=/usr

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-11 Thread Jeffrey Walton
On Mon, Nov 11, 2013 at 5:51 PM, Peter Geoghegan p...@heroku.com wrote: On Mon, Nov 11, 2013 at 2:45 PM, Jeffrey Walton noloa...@gmail.com wrote: I think you are right. Coverity is a very nice tool, and Clang has some growing to do. To be fair to the LLVM/Clang guys, it's not as if static

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-11 Thread Jeffrey Walton
On Mon, Nov 11, 2013 at 6:01 PM, Kevin Grittner kgri...@ymail.com wrote: Peter Geoghegan p...@heroku.com wrote: Kevin Grittner kgri...@ymail.com wrote: I'm currently capturing a text version of all the warnings from this. Will gzip and post when it finishes. It's generating a lot of

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-12 Thread Jeffrey Walton
On Tue, Nov 12, 2013 at 9:38 AM, Tom Lane t...@sss.pgh.pa.us wrote: ... One thought for the Clang people is that most of the reports such as null pointer dereference presumably mean I think I see an execution path whereby we could get here with a null pointer. If so, it'd be awfully helpful

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-12 Thread Jeffrey Walton
On Tue, Nov 12, 2013 at 3:25 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-11-12 15:17:18 -0500, Jeffrey Walton wrote: On Tue, Nov 12, 2013 at 9:38 AM, Tom Lane t...@sss.pgh.pa.us wrote: ... One thought for the Clang people is that most of the reports such as null pointer

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-12 Thread Jeffrey Walton
On Tue, Nov 12, 2013 at 9:38 AM, Tom Lane t...@sss.pgh.pa.us wrote: Kevin Grittner kgri...@ymail.com writes: Does anything stand out as something that is particularly worth looking into? Does anything here seem worth assuming is completely bogus because of the Coverity and Valgrind passes?

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-12 Thread Jeffrey Walton
On Tue, Nov 12, 2013 at 3:35 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-11-12 15:33:13 -0500, Jeffrey Walton wrote: On Tue, Nov 12, 2013 at 3:25 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-11-12 15:17:18 -0500, Jeffrey Walton wrote: ... It might not recognize our

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-12 Thread Jeffrey Walton
On Tue, Nov 12, 2013 at 6:04 PM, Kevin Grittner kgri...@ymail.com wrote: Peter Eisentraut pete...@gmx.net wrote: I have tracked scan-build for some time, and I'm sure that almost all of these bugs are false positives at this point. From poking around, I agree. One particular error I noticed

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-12 Thread Jeffrey Walton
On Tue, Nov 12, 2013 at 5:19 PM, Peter Eisentraut pete...@gmx.net wrote: On 11/12/13, 8:18 AM, Kevin Grittner wrote: Here is the summary of what was reported: All Bugs: 313 Does anything stand out as something that is particularly worth looking into? Does anything here seem worth assuming

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-12 Thread Jeffrey Walton
On Tue, Nov 12, 2013 at 7:11 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Kevin Grittner escribió: These both seemed legitimate to me. Patch attached. Any objections to applying it? I realize the memory leak is a tiny one in the regression testing code, so it could never amount to

Re: [HACKERS] fe-secure.c and SSL/TLS

2013-11-29 Thread Jeffrey Walton
Hi Marko, Forgive me for cherry picking two of these... I think Postgres uses SSL_VERIFY_PEER + SSL_set_verify() callback instead. At least for me, the psql -d dbname=foo sslmode=verify-ca fails when cert does not match. I can't comment on the use of psql. My apologies for my ignorance.

Re: [HACKERS] fe-secure.c and SSL/TLS

2013-11-30 Thread Jeffrey Walton
accept my apologies. Jeff On Fri, Nov 29, 2013 at 7:14 PM, Marko Kreen mark...@gmail.com wrote: On Fri, Nov 29, 2013 at 06:01:01PM -0500, Jeffrey Walton wrote: I know of no other ways to check the result of OpenSSL's chain validation. The open question (for me) is where are SSL_get_verify_result

Re: [HACKERS] fe-secure.c and SSL/TLS

2013-11-30 Thread Jeffrey Walton
-0500, Jeffrey Walton wrote: I know of no other ways to check the result of OpenSSL's chain validation. The open question (for me) is where are SSL_get_verify_result/X509_V_OK checked? Neither show up in the Postgres sources. According to SSL_set_verify manpage, you are perhaps talking about

Re: [HACKERS] fe-secure.c and SSL/TLS

2013-11-30 Thread Jeffrey Walton
= /lib/x86_64-linux-gnu/libz.so.1 (0x7f1e06142000) /lib64/ld-linux-x86-64.so.2 (0x7f1e06f6d000) Gotta love back patching and broken versioning ;) Jeff On Sat, Nov 30, 2013 at 4:12 AM, Marko Kreen mark...@gmail.com wrote: On Sat, Nov 30, 2013 at 03:46:06AM -0500, Jeffrey Walton wrote