Re: [HACKERS] [PATCH] pg_sleep(interval)

2014-02-02 Thread Julien Rouhaud
Hi It seems like pg_sleep_until() has issues if used within a transaction, as it uses now() and not clock_timestamp(). Please find attached a patch that solves this issue. For consistency reasons, I also modified pg_sleep_for() to also use clock_timestamp. Regards On Fri, Jan 31, 2014 at 2:12

[HACKERS] [TODO] Track number of files ready to be archived in pg_stat_archiver

2014-08-21 Thread Julien Rouhaud
Hello, Attached patch implements the following TODO item : Track number of WAL files ready to be archived in pg_stat_archiver However, it will track the total number of any file ready to be archived, not only WAL files. Please let me know what you think about it. Regards. -- Julien Rouhaud

Re: [HACKERS] [TODO] Track number of files ready to be archived in pg_stat_archiver

2014-08-27 Thread Julien Rouhaud
Le 25/08/2014 19:00, Gilles Darold a écrit : Le 21/08/2014 10:17, Julien Rouhaud a écrit : Hello, Attached patch implements the following TODO item : Track number of WAL files ready to be archived in pg_stat_archiver However, it will track the total number of any file ready to be archived

Re: [HACKERS] [TODO] Track number of files ready to be archived in pg_stat_archiver

2014-08-29 Thread Julien Rouhaud
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 28/08/2014 05:58, Michael Paquier a écrit : On Thu, Aug 28, 2014 at 7:37 AM, Julien Rouhaud julien.rouh...@dalibo.com wrote: Attached v2 patch implements this approach. All the work is still done in pg_stat_get_archiver, as I don't think

Re: [HACKERS] [TODO] Track number of files ready to be archived in pg_stat_archiver

2014-10-21 Thread Julien Rouhaud
On Tue, Oct 21, 2014 at 7:35 AM, Brightwell, Adam adam.brightw...@crunchydatasolutions.com wrote: Julien, The following is an initial review: Thanks for the review. * Applies cleanly to master (f330a6d). * Regression tests updated and pass, including 'check-world'. * Documentation

Re: [HACKERS] split builtins.h to quote.h

2014-11-06 Thread Julien Rouhaud
using quote_* functions. Otherwise it looks ready to commit. Regards. - -- Julien Rouhaud http://dalibo.com - http://dalibo.org -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAEBAgAGBQJUW6wEAAoJELGaJ8vfEpOqCn4H/AydFB5ERI0x9R6l8T/Qkx9/ Tm0ZgSSsfG39lHkbspZaUwTxmNPam1

Re: [HACKERS] [TODO] Track number of files ready to be archived in pg_stat_archiver

2014-12-13 Thread Julien Rouhaud
on current head. Regards. - -- Julien Rouhaud http://dalibo.com - http://dalibo.org -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAEBAgAGBQJUjFLWAAoJELGaJ8vfEpOqV9AIAI1yTUYqiB8rMJpfM47IHiM6 92fRNJ7sGwuFKD7Vb2gcMuRLelhFVRevJ7tjhggci8Y36j6YDXgqz74kTjkXvcjN /SlyS2CIcSleWwvJ2A

Re: [HACKERS] adding more information about process(es) cpu and memory usage

2015-04-25 Thread Julien Rouhaud
://github.com/dalibo/pg_stat_kcache). Michael also wrote an article on this topic some weeks ago (http://michael.otacoo.com/postgresql-2/postgres-calculate-cpu-usage-process/). Regards -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing list (pgsql-hackers

[HACKERS] pg_stat_archiver issue with aborted archiver

2015-06-06 Thread Julien Rouhaud
. Regards. -- Julien Rouhaud http://dalibo.com - http://dalibo.org *** a/src/backend/postmaster/pgarch.c --- b/src/backend/postmaster/pgarch.c *** *** 578,585 pgarch_archiveXlog(char *xlog) * * Per the Single Unix Spec, shells report exit status 128 when

Re: [HACKERS] pg_stat_archiver issue with aborted archiver

2015-06-08 Thread Julien Rouhaud
Le 08/06/2015 05:56, Michael Paquier a écrit : On Sun, Jun 7, 2015 at 1:11 AM, Julien Rouhaud julien.rouh...@dalibo.com wrote: I just noticed that if the archiver aborts (for instance if the archive_command exited with a return code 127), pg_stat_archiver won't report those failed attempts

Re: [HACKERS] Comfortably check BackendPID with psql

2015-07-05 Thread Julien Rouhaud
. -- Julien Rouhaud http://dalibo.com - http://dalibo.org *** a/doc/src/sgml/ref/psql-ref.sgml --- b/doc/src/sgml/ref/psql-ref.sgml *** *** 3365,3370 testdb=gt; userinputINSERT INTO my_table VALUES (:'content');/userinput --- 3365,3377 /varlistentry

Re: [HACKERS] auto_explain sample rate

2015-07-05 Thread Julien Rouhaud
. --- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] [PERFORM] intel s3500 -- hot stuff

2015-07-18 Thread Julien Rouhaud
On 18/07/2015 12:03, Julien Rouhaud wrote: On 10/12/2014 17:52, Jeff Janes wrote: On Tue, Dec 9, 2014 at 12:43 PM, Bruce Momjian br...@momjian.us mailto:br...@momjian.us wrote: On Mon, Dec 8, 2014 at 03:40:43PM -0600, Merlin Moncure wrote: Did not see consistent measurable gains

Re: [HACKERS] [BUGS] BUG #12989: pg_size_pretty with negative values

2015-11-03 Thread Julien Rouhaud
On 03/11/2015 04:06, Robert Haas wrote: > On Sat, Oct 31, 2015 at 2:25 PM, Julien Rouhaud > <julien.rouh...@dalibo.com> wrote: >> I just reviewed your patch, everything looks fine for me. Maybe some >> minor cosmetic changes could be made to avoid declaring too m

Re: [HACKERS] Change behavior of (m)xid_age

2015-11-07 Thread Julien Rouhaud
tended. I change the status to ready for committer. > (do we care about commutativity with int = xid and int <> xid?). > >> (another one for <>(xid,int) which mirrors the =(xid,int) we >> already have). > > To which one are you referring here? > > > >

Re: [HACKERS] [BUGS] BUG #12989: pg_size_pretty with negative values

2015-10-31 Thread Julien Rouhaud
pretty(-1 * size) FROM >> (SELECT 100::numeric) foo(size); pg_size_pretty | >> pg_size_pretty + 91 TB | >> -91 TB (1 row) > > > The patch contains two tests (pg_size_pretty_bigint and > pg_size_pretty_numeric), to ver

Re: [HACKERS] pg_stat_statements query jumbling question

2015-10-31 Thread Julien Rouhaud
query. However, logical replication schemes do not promise to keep replicas identical in all relevant details, so queryid will not be a useful identifier for accumulating costs across a set of logical replicas. If in doubt, direct testing is recommended." Regards. > Regards, - --

Re: [HACKERS] Comfortably check BackendPID with psql

2015-07-07 Thread Julien Rouhaud
Le 07/07/2015 13:41, Andres Freund a écrit : On 2015-07-05 14:11:38 +0200, Julien Rouhaud wrote: Tiny for me too, but I sometimes had the need. I can't really see any good reason not to add a %p escape to psql's PROMPT, so I'm attaching a simple patch to implement it. Unless someone objects

Re: [HACKERS] auto_explain sample rate

2015-07-07 Thread Julien Rouhaud
On 05/07/2015 18:22, Julien Rouhaud wrote: On 03/06/2015 15:00, Craig Ringer wrote: On 3 June 2015 at 20:04, Andres Freund and...@anarazel.de mailto:and...@anarazel.de wrote: On 2015-06-03 18:54:24 +0800, Craig Ringer wrote: OK, here we go. Hm. Wouldn't random sampling

[HACKERS] Outdated documentation for PageHeaderData

2015-09-05 Thread Julien Rouhaud
Hi, I just noticed that part of storage.sgml was not updated when 9.3 introduced checksum (and removed pd_tli from PageHeaderData). Here's a simple patch to fix that. Regards. -- Julien Rouhaud http://dalibo.com - http://dalibo.org diff --git a/doc/src/sgml/storage.sgml b/doc/src/sgml

Re: [HACKERS] Allow a per-tablespace effective_io_concurrency setting

2015-09-02 Thread Julien Rouhaud
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 02/09/2015 18:06, Tomas Vondra wrote: > Hi > > On 09/02/2015 03:53 PM, Andres Freund wrote: >> >> Hi, >> >> On 2015-07-18 12:17:39 +0200, Julien Rouhaud wrote: >>> I didn't know that the thread mus

Re: [HACKERS] Allow a per-tablespace effective_io_concurrency setting

2015-09-02 Thread Julien Rouhaud
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/09/2015 15:53, Andres Freund wrote: > On 2015-07-18 12:17:39 +0200, Julien Rouhaud wrote: > > You also didn't touch /* * How many buffers PrefetchBuffer callers > should try to stay ahead of their * ReadBuffer calls by. This is

Re: [HACKERS] Outdated documentation for PageHeaderData

2015-09-06 Thread Julien Rouhaud
On 06/09/2015 01:39, Michael Paquier wrote: > > On Sun, Sep 6, 2015 at 5:11 AM, Julien Rouhaud > <julien.rouh...@dalibo.com <mailto:julien.rouh...@dalibo.com>> wrote: > > I just noticed that part of storage.sgml was not updated when 9.3 > introduced che

Re: [HACKERS] Allow a per-tablespace effective_io_concurrency setting

2015-09-06 Thread Julien Rouhaud
Hi, Please find attached a v2 of the patch. See below for changes. On 02/09/2015 15:53, Andres Freund wrote: > > Hi, > > On 2015-07-18 12:17:39 +0200, Julien Rouhaud wrote: >> I didn't know that the thread must exists on -hackers to be able to add >> a commitf

Re: [HACKERS] Allow a per-tablespace effective_io_concurrency setting

2015-09-08 Thread Julien Rouhaud
On 08/09/2015 18:00, Alvaro Herrera wrote: > Julien Rouhaud wrote: >> Hi, >> >> Please find attached a v2 of the patch. See below for changes. > > Pushed after smallish tweaks. Please test to verify I didn't break > anything. > I just tried with all the cases I

Re: [HACKERS] On-demand running query plans using auto_explain and signals

2015-11-30 Thread Julien Rouhaud
auto_explain.publish_plans.patch and 0002-Add-SHM-table-of-contents-to-the-explain-DSM.patch) are still needed reviews, since multiple refactoring ideas and objections have been raised since. Regards. -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] gincostestimate and hypothetical indexes

2015-11-30 Thread Julien Rouhaud
. -- Julien Rouhaud http://dalibo.com - http://dalibo.org diff --git a/src/backend/utils/adt/selfuncs.c b/src/backend/utils/adt/selfuncs.c index 37fad86..24ffa3a 100644 --- a/src/backend/utils/adt/selfuncs.c +++ b/src/backend/utils/adt/selfuncs.c @@ -101,6 +101,7 @@ #include #include "a

Re: [HACKERS] Postgres_FDW optimizations

2015-12-02 Thread Julien Rouhaud
> > > > -- > View this message in context: > http://postgresql.nabble.com/Postgres-FDW-optimizations-tp5875911.html > Sent from the PostgreSQL - hackers mailing list archive at Nabble.com. > > -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Disabling an index temporarily

2015-12-12 Thread Julien Rouhaud
.postgresql.org/message-id/pine.lnx.4.64.0910062354510.6...@sn.sai.msu.ru This also has the advantage of not needing an exclusive lock on the index. -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] gincostestimate and hypothetical indexes

2015-11-30 Thread Julien Rouhaud
On 01/12/2015 00:37, Tom Lane wrote: > Julien Rouhaud <julien.rouh...@dalibo.com> writes: >> I figured out that it's not possible to use a hypothetical gin index, as >> the gincostestimate function try to retrieve some statistical data from >> the index meta page. >

Re: [HACKERS] Removing Functionally Dependent GROUP BY Columns

2016-01-12 Thread Julien Rouhaud
+ var = (Var *) tle->expr; + + if (!IsA(var, Var)) + continue; + [...] if var isn't a Var, it needs to be added in new_groupby. + /* XXX do we to alter tleSortGroupRef to remove gaps? */ no idea on that :/ -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Rename max_parallel_degree?

2016-06-11 Thread Julien Rouhaud
PFA a patch to fix this open item. I used the GUC name provided in the 9.6 open item page (max_parallel_workers), with a default value of 4. Value 0 is another way to disable parallel query. -- Julien Rouhaud http://dalibo.com - http://dalibo.org diff --git a/doc/src/sgml/config.sgml b/doc/src/

Re: [HACKERS] Rename max_parallel_degree?

2016-06-11 Thread Julien Rouhaud
On 11/06/2016 23:37, Julien Rouhaud wrote: > On 09/06/2016 16:04, Robert Haas wrote: >> >> OK, I pushed this after re-reviewing it and fixing a number of >> oversights. There remains only the task of adding max_parallel_degree >> as a system-wide limit (as opposed

Re: [HACKERS] Rename max_parallel_degree?

2016-06-13 Thread Julien Rouhaud
On 13/06/2016 03:16, Robert Haas wrote: > On Sat, Jun 11, 2016 at 6:24 PM, Julien Rouhaud > <julien.rouh...@dalibo.com> wrote: >> On 11/06/2016 23:37, Julien Rouhaud wrote: >>> On 09/06/2016 16:04, Robert Haas wrote: >>>> There remains only the task of addi

Re: [HACKERS] Rename max_parallel_degree?

2016-06-14 Thread Julien Rouhaud
On 14/06/2016 04:09, Robert Haas wrote: > On Mon, Jun 13, 2016 at 5:42 AM, Julien Rouhaud > <julien.rouh...@dalibo.com> wrote: >> Agreed, and fixed in attached v3. > > I don't entirely like the new logic in > RegisterDynamicBackgroundWorker. I'm not that happy with it

Re: [HACKERS] Rename max_parallel_degree?

2016-06-15 Thread Julien Rouhaud
On 15/06/2016 17:49, Robert Haas wrote: > On Tue, Jun 14, 2016 at 7:10 AM, Julien Rouhaud > <julien.rouh...@dalibo.com> wrote: >>> I don't entirely like the new logic in >>> RegisterDynamicBackgroundWorker. >> >>> I wonder if we can't drive this off &

Re: [HACKERS] Rename max_parallel_degree?

2016-06-15 Thread Julien Rouhaud
On 15/06/2016 18:14, Julien Rouhaud wrote: > On 15/06/2016 17:49, Robert Haas wrote: >> On Tue, Jun 14, 2016 at 7:10 AM, Julien Rouhaud >> <julien.rouh...@dalibo.com> wrote: >>>> I don't entirely like the new logic in >>>> RegisterDynamicBackgrou

Re: [HACKERS] GIN pending list clean up exposure to SQL

2016-01-10 Thread Julien Rouhaud
g whitespaces in the documentation diff. Regards. > Cheers, > > Jeff > > > > -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Removing Functionally Dependent GROUP BY Columns

2016-01-14 Thread Julien Rouhaud
On 14/01/2016 01:30, David Rowley wrote: > Many thanks for the thorough review! > And thanks for the patch and fast answer! > On 12 January 2016 at 23:37, Julien Rouhaud <julien.rouh...@dalibo.com > <mailto:julien.rouh...@dalibo.com>> wrote: > &g

Re: [HACKERS] Removing Functionally Dependent GROUP BY Columns

2016-01-14 Thread Julien Rouhaud
On 14/01/2016 14:04, Geoff Winkless wrote: > On 14 January 2016 at 11:19, Julien Rouhaud <julien.rouh...@dalibo.com> wrote: >> + /* don't try anything unless there's two Vars */ >> + if (varlist == NULL || list_length(varlist) < 2) >> +

Re: [HACKERS] Removing Functionally Dependent GROUP BY Columns

2016-01-14 Thread Julien Rouhaud
On 14/01/2016 14:29, Geoff Winkless wrote: > On 14 January 2016 at 13:16, Julien Rouhaud <julien.rouh...@dalibo.com> wrote: >> You're absolutely right, but in this case the comment is more like a >> reminder of a bigger comment few lines before that wasn't quoted in my

Re: [HACKERS] GIN pending list clean up exposure to SQL

2016-01-15 Thread Julien Rouhaud
On 15/01/2016 22:59, Jeff Janes wrote: > On Sun, Jan 10, 2016 at 4:24 AM, Julien Rouhaud > <julien.rouh...@dalibo.com> wrote: >> On 29/12/2015 00:30, Jeff Janes wrote: >>> On Wed, Nov 25, 2015 at 9:29 AM, Jeff Janes <jeff.ja...@gmail.com> wrote: >&g

Re: [HACKERS] Removing Functionally Dependent GROUP BY Columns

2016-01-14 Thread Julien Rouhaud
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 14/01/2016 23:05, David Rowley wrote: > On 15 January 2016 at 00:19, Julien Rouhaud > <julien.rouh...@dalibo.com <mailto:julien.rouh...@dalibo.com>> > wrote: > > > +* Technically we could look at UNIQ

Re: [HACKERS] Rename max_parallel_degree?

2016-06-27 Thread Julien Rouhaud
ad barrier here, so that this check doesn't get >> reordered with the for loop below it. You mean between the end of this block and the for loop? (Sorry, I'm not at all familiar with the pg_barrier mechanism). >> Also, see if you find the code >> more readable by moving the after && part of check to next line. I think I'll just pgindent the file. -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Rename max_parallel_degree?

2016-06-26 Thread Julien Rouhaud
On 26/06/2016 08:37, Amit Kapila wrote: > On Sat, Jun 25, 2016 at 2:27 PM, Julien Rouhaud > <julien.rouh...@dalibo.com> wrote: >>> >> >> It's better thanks. Should we document somewhere the link between this >> parameter and custom dynamic background work

Re: [HACKERS] Rename max_parallel_degree?

2016-06-25 Thread Julien Rouhaud
On 25/06/2016 09:33, Amit Kapila wrote: > On Wed, Jun 15, 2016 at 11:43 PM, Julien Rouhaud > <julien.rouh...@dalibo.com> wrote: >> >> Attached v4 implements the design you suggested, I hope everything's ok. >> > > Few review comments: > Thanks

Re: [HACKERS] GIN pending list clean up exposure to SQL

2016-01-27 Thread Julien Rouhaud
On 27/01/2016 10:27, Fujii Masao wrote: > On Mon, Jan 25, 2016 at 3:54 PM, Jeff Janes <jeff.ja...@gmail.com> > wrote: >> On Wed, Jan 20, 2016 at 6:17 AM, Fujii Masao >> <masao.fu...@gmail.com> wrote: >>> On Sat, Jan 16, 2016 at 7:42 AM, Julien Rouhaud

[HACKERS] create opclass documentation outdated

2016-02-25 Thread Julien Rouhaud
Hello, I just saw that the CREATE OPERATOR CLASS documentation doesn't mention that BRIN indexes also support the STORAGE parameter. Patch attached. Regards -- Julien Rouhaud http://dalibo.com - http://dalibo.org diff --git a/doc/src/sgml/ref/create_opclass.sgml b/doc/src/sgml/ref

Re: [HACKERS] create opclass documentation outdated

2016-02-25 Thread Julien Rouhaud
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 25/02/2016 23:12, Vik Fearing wrote: > On 02/25/2016 09:13 PM, Julien Rouhaud wrote: >> Hello, >> >> I just saw that the CREATE OPERATOR CLASS documentation doesn't >> mention that BRIN indexes also support the STORAGE

Re: [HACKERS] Publish autovacuum informations

2016-02-29 Thread Julien Rouhaud
cuum, and as an example a quick proof of concept extension that use them and allow to see what are the autovacuum worker todo list, skipped tables and so on. I'm not really sure about which information should be provided, so I'm open to any suggestion to improve this. -- Julien Rouhaud http:/

Re: [HACKERS] Publish autovacuum informations

2016-02-29 Thread Julien Rouhaud
On 29/02/2016 20:20, Fabrízio de Royes Mello wrote: > > On Mon, Feb 29, 2016 at 3:04 PM, Julien Rouhaud > <julien.rouh...@dalibo.com <mailto:julien.rouh...@dalibo.com>> wrote: >> >> On 04/06/2015 22:10, Guillaume Lelarge wrote: >> > 2015-01-05

Re: [HACKERS] GIN pending list clean up exposure to SQL

2016-01-22 Thread Julien Rouhaud
ed by Alvaro and Jaime earlier in this thread (http://www.postgresql.org/message-id/20151119161846.GK614468@alvherre.pgsql), as ginInsertCleanup() can be called concurrently. Also, since 38710a374ea the ginInsertCleanup() call must be fixed: - ginInsertCleanup(, false, true, ); + ginInsertC

Re: [HACKERS] Removing Functionally Dependent GROUP BY Columns

2016-01-23 Thread Julien Rouhaud
ork on regression test cases >> seems indicated. > > The history behind that is that at one point during developing the > patch that test had started failing due to the group by item being > removed therefore allowing the join removal conditions to be met. On > testing again with the old t

Re: [HACKERS] Removing Functionally Dependent GROUP BY Columns

2016-01-23 Thread Julien Rouhaud
On 23/01/2016 14:51, David Rowley wrote: > On 24 January 2016 at 00:56, Julien Rouhaud <julien.rouh...@dalibo.com> wrote: >> I wonder if in remove_useless_groupby_columns(), in the foreach loop you >> could change the >> >> + if (bms_subset_compare(pk

Re: [HACKERS] auto_explain sample rate

2016-02-16 Thread Julien Rouhaud
On 25/08/2015 14:45, Michael Paquier wrote: > On Fri, Jul 17, 2015 at 2:53 PM, Craig Ringer <cr...@2ndquadrant.com> wrote: >> On 7 July 2015 at 21:37, Julien Rouhaud <julien.rouh...@dalibo.com> wrote: >> >>> Well, I obviously missed that pg_srand48() is only

Re: [HACKERS] auto_explain sample rate

2016-02-16 Thread Julien Rouhaud
On 16/02/2016 22:51, Alvaro Herrera wrote: > Julien Rouhaud wrote: > > Hijacking this macro is just too obscure: > >> #define auto_explain_enabled() \ >> (auto_explain_log_min_duration >= 0 && \ >> - (nesting_level == 0 || auto_explain_log_ne

Re: [HACKERS] Publish autovacuum informations

2016-03-01 Thread Julien Rouhaud
On 01/03/2016 20:29, Jim Nasby wrote: > On 3/1/16 8:37 AM, Julien Rouhaud wrote: >>> > >>> >We understood (IMHO is an interesting idea) but as Michael said >>> hooks is >>> >for a general purpose. So can you demonstrate other use cases for this >&

Re: [HACKERS] auto_explain sample rate

2016-03-10 Thread Julien Rouhaud
On 10/03/2016 04:37, Petr Jelinek wrote: > On 17/02/16 01:17, Julien Rouhaud wrote: >> >> Agreed, it's too obscure. Attached v4 fixes as you said. >> > > Seems to be simple enough patch and works. However I would like > documentation to say that the range is

Re: [HACKERS] Choosing parallel_degree

2016-03-18 Thread Julien Rouhaud
On 18/03/2016 00:56, Tom Lane wrote: > Julien Rouhaud <julien.rouh...@dalibo.com> writes: >> Shouldn't we also check "parallel_degree < max_worker_process" ? > >> There's no need to compute any further than that. I think the best fix >>

Re: [HACKERS] Choosing parallel_degree

2016-03-18 Thread Julien Rouhaud
On 16/03/2016 18:42, Robert Haas wrote: > On Wed, Mar 16, 2016 at 1:23 PM, Julien Rouhaud > <julien.rouh...@dalibo.com> wrote: >> On 16/03/2016 17:55, Robert Haas wrote: >>> On Wed, Mar 16, 2016 at 12:47 PM, Julien Rouhaud >>> <julien.rouh...

Re: [HACKERS] Choosing parallel_degree

2016-03-15 Thread Julien Rouhaud
GUC documentation, because I didn't really see a good way to explain it. I'd e happy to improve it if needed. Also, to make this parameter easier to tune for users, perhaps we could divide the default value by 3 and use it as is in the first iteration in create_parallel_path() ? Also, global max_parallel_d

Re: [HACKERS] Minor bug affecting ON CONFLICT lock wait log messages

2016-03-15 Thread Julien Rouhaud
ouldn't be > hard to review. > + reason_wait = indexInfo->ii_ExclusionOps ? + XLTW_RecheckExclusionConstr : XLTW_InsertIndex; Shouldn't it be set to XLTW_InsertIndexUnique instead? Otherwise the patch seems ok to me. > Thanks > -

Re: [HACKERS] Minor bug affecting ON CONFLICT lock wait log messages

2016-03-15 Thread Julien Rouhaud
On 15/03/2016 14:18, Stephen Frost wrote: > * Julien Rouhaud (julien.rouh...@dalibo.com) wrote: >> On 15/03/2016 03:30, Peter Geoghegan wrote: >>> On Mon, Mar 7, 2016 at 1:46 PM, Peter Geoghegan <p...@heroku.com> wrote: >>>> Attached patch fixes a bug report

Re: [HACKERS] auto_explain sample rate

2016-03-11 Thread Julien Rouhaud
add a specific test for this case to spare a random() call, but I fear it'd be overkill. Maybe it's better to document that the good way to deactivate auto_explain is to set auto_explain.log_min_duration to -1. -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers

Re: [HACKERS] auto_explain sample rate

2016-03-12 Thread Julien Rouhaud
uses >> for the same thing. That'd be more consistent. > > I like that idea. It seems like slightly better terminology. > I like it too. I also just noticed that I duplicated the var type by mistake in the documentation :/ Attached patch fixes both. -- Julien Rouhaud http://da

Re: [HACKERS] auto_explain sample rate

2016-03-11 Thread Julien Rouhaud
On 11/03/2016 15:11, Magnus Hagander wrote: > > > On Fri, Mar 11, 2016 at 3:03 PM, Magnus Hagander <mag...@hagander.net > <mailto:mag...@hagander.net>> wrote: > > > > On Fri, Mar 11, 2016 at 2:51 PM, Julien Rouhaud > <julien.rouh...@dalibo.com

Re: [HACKERS] Choosing parallel_degree

2016-03-16 Thread Julien Rouhaud
On 16/03/2016 05:45, James Sewell wrote: > On Wed, Mar 16, 2016 at 11:26 AM, Julien Rouhaud > <julien.rouh...@dalibo.com <mailto:julien.rouh...@dalibo.com>>wrote: > > > I'm not too familiar with parallel planning, but I tried to implement > both in att

Re: [HACKERS] Publish autovacuum informations

2016-03-30 Thread Julien Rouhaud
"TODO list", and after > every (auto)vacuum. The main issue I see with an event trigger based solution is that you'll always have to create them and the needed objects on every database. Another issue is that both of these approach are not intended to give a global overview but per-database stat

Re: [HACKERS] Choosing parallel_degree

2016-04-06 Thread Julien Rouhaud
On 06/04/2016 07:38, Amit Kapila wrote: > On Tue, Apr 5, 2016 at 11:55 PM, Julien Rouhaud >> >> In alter_table.sgml, I didn't comment the lock level needed to modify >> parallel_degree since it requires an access exclusive lock for now. >> While thinking about it, I thi

Re: [HACKERS] Choosing parallel_degree

2016-04-05 Thread Julien Rouhaud
et '(' which means with rel->pages. Refer multiline condition in > near by code. Or you can run pgindent. I ran pgindent, fixed. > B. The comment above this condition needs slight adjustment as per new > condition. > Also fixed. > 4. > +intparallel_degree; /* max num

Re: [HACKERS] Choosing parallel_degree

2016-04-11 Thread Julien Rouhaud
arallel_degree =262143; > SET > postgres=# > > postgres=# explain analyze verbose select * from abd where n<=1; > ERROR: requested shared memory size overflows size_t > > if we remove the analyze keyword then query running successfully. > > Expected = Is it not better to throw the error at the time of setting > max_parallel_degree, if not supported ? +1 -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Choosing parallel_degree

2016-04-12 Thread Julien Rouhaud
On 11/04/2016 22:53, Julien Rouhaud wrote: > On 11/04/2016 17:44, Robert Haas wrote: >> >> We should probably add the number of workers actually obtained to the >> EXPLAIN ANALYZE output. That's been requested before. >> > > If it's not too late for 9.6, it woul

Re: [HACKERS] Choosing parallel_degree

2016-04-11 Thread Julien Rouhaud
On 11/04/2016 17:44, Robert Haas wrote: > On Mon, Apr 11, 2016 at 11:27 AM, Julien Rouhaud > <julien.rouh...@dalibo.com> wrote: >> On 11/04/2016 15:56, tushar wrote: >>> >>> I am assuming parallel_degree=0 is as same as not using it , i.e >>> cre

Re: [HACKERS] Choosing parallel_degree

2016-03-19 Thread Julien Rouhaud
On 16/03/2016 18:42, Robert Haas wrote: > On Wed, Mar 16, 2016 at 1:23 PM, Julien Rouhaud > <julien.rouh...@dalibo.com> wrote: >> On 16/03/2016 17:55, Robert Haas wrote: >>> On Wed, Mar 16, 2016 at 12:47 PM, Julien Rouhaud >>> <julien.rouh...

Re: [HACKERS] Choosing parallel_degree

2016-03-19 Thread Julien Rouhaud
On 17/03/2016 12:21, David Rowley wrote: > On 18 March 2016 at 00:13, Julien Rouhaud <julien.rouh...@dalibo.com> wrote: >> With the current threshold, you need a table bigger than 8 MB to be able >> to force parallel workers. I'm not sure there'll be benefits for >>

Re: [HACKERS] Choosing parallel_degree

2016-03-19 Thread Julien Rouhaud
On 17/03/2016 02:07, James Sewell wrote: > > On Thu, Mar 17, 2016 at 5:05 AM, Julien Rouhaud > <julien.rouh...@dalibo.com <mailto:julien.rouh...@dalibo.com>> wrote: > > > attached v3 drops the GUC part. > > > This looks good good. I do think that

Re: [HACKERS] Choosing parallel_degree

2016-03-20 Thread Julien Rouhaud
On 16/03/2016 17:16, Robert Haas wrote: > On Tue, Mar 15, 2016 at 8:26 PM, Julien Rouhaud > <julien.rouh...@dalibo.com <mailto:julien.rouh...@dalibo.com>> wrote: > > On 15/03/2016 21:12, Robert Haas wrote: > > On Mon, Mar 14, 2016 at 9:25 PM, D

Re: [HACKERS] Choosing parallel_degree

2016-03-22 Thread Julien Rouhaud
On 21/03/2016 20:38, Julien Rouhaud wrote: > On 21/03/2016 05:18, James Sewell wrote: >> OK cool, thanks. >> >> Can we remove the minimum size limit when the per table degree setting >> is applied? >> >> This would help for tables with 2 - 1000 pages com

Re: [HACKERS] Choosing parallel_degree

2016-03-19 Thread Julien Rouhaud
On 17/03/2016 11:23, Julien Rouhaud wrote: > On 17/03/2016 02:07, James Sewell wrote: >> >> On Thu, Mar 17, 2016 at 5:05 AM, Julien Rouhaud >> <julien.rouh...@dalibo.com <mailto:julien.rouh...@dalibo.com>> wrote: >> >> >> attached v3 drop

Re: [HACKERS] Choosing parallel_degree

2016-03-19 Thread Julien Rouhaud
On 16/03/2016 17:55, Robert Haas wrote: > On Wed, Mar 16, 2016 at 12:47 PM, Julien Rouhaud > <julien.rouh...@dalibo.com> wrote: >> Something like a "min_parallel_degree" then ? > > Why not just parallel_degree without any prefix? As in, when scanning >

Re: [HACKERS] Publish autovacuum informations

2016-03-02 Thread Julien Rouhaud
On 02/03/2016 07:30, Michael Paquier wrote: > On Tue, Mar 1, 2016 at 11:37 PM, Julien Rouhaud wrote: >> I'm not sure what are the fancy things that Michael had in mind with >> exposing the private structure. Michael, was it something like having >> the ability to change some

Re: [HACKERS] Publish autovacuum informations

2016-03-04 Thread Julien Rouhaud
On 03/03/2016 10:54, Kyotaro HORIGUCHI wrote: > Hello, > > At Wed, 2 Mar 2016 17:48:06 -0600, Jim Nasby <jim.na...@bluetreble.com> wrote > in <56d77bb6.6080...@bluetreble.com> >> On 3/2/16 10:48 AM, Julien Rouhaud wrote: >>> Good point, I don't see a lot o

Re: [HACKERS] Publish autovacuum informations

2016-03-01 Thread Julien Rouhaud
On 01/03/2016 07:50, Michael Paquier wrote: > On Tue, Mar 1, 2016 at 4:38 AM, Julien Rouhaud > <julien.rouh...@dalibo.com> wrote: >> On 29/02/2016 20:20, Fabrízio de Royes Mello wrote: >>> >>> On Mon, Feb 29, 2016 at 3:04 PM, Julien Rouhaud >>> &

Re: [HACKERS] Publish autovacuum informations

2016-03-04 Thread Julien Rouhaud
On 04/03/2016 23:34, Michael Paquier wrote: > On Sat, Mar 5, 2016 at 6:52 AM, Julien Rouhaud > <julien.rouh...@dalibo.com> wrote: >> Very good suggestion. >> >> I think the most productive way to work on this is to start a wiki page >> to summarize what's the a

Re: [HACKERS] Publish autovacuum informations

2016-03-01 Thread Julien Rouhaud
On 01/03/2016 13:47, Fabrízio de Royes Mello wrote: > On Tue, Mar 1, 2016 at 8:44 AM, Julien Rouhaud > <julien.rouh...@dalibo.com <mailto:julien.rouh...@dalibo.com>> wrote: >> >> On 01/03/2016 07:50, Michael Paquier wrote: >> > On Tue, Mar 1, 2016 at 4:

Re: [HACKERS] Choosing parallel_degree

2016-04-03 Thread Julien Rouhaud
On 22/03/2016 07:58, Julien Rouhaud wrote: > On 21/03/2016 20:38, Julien Rouhaud wrote: >> On 21/03/2016 05:18, James Sewell wrote: >>> OK cool, thanks. >>> >>> Can we remove the minimum size limit when the per table degree setting >>> is applied? >

Re: [HACKERS] Choosing parallel_degree

2016-04-04 Thread Julien Rouhaud
e freeze is now very close. If this GUC is still wanted, >> should I add this patch to the next commitfest? >> > > I am hoping that this will be committed to 9.6, but I think it is good > to register it in next CF. > So attached v6 fixes all the problems above. I'll ad

Re: [HACKERS] Choosing parallel_degree

2016-04-04 Thread Julien Rouhaud
On 04/04/2016 17:03, Julien Rouhaud wrote: > On 04/04/2016 08:55, Amit Kapila wrote: > > Thanks for the review! > >> Few comments: >> 1. >> + limited according to the >> >> A. typo. >>/gux-max-parallel-degree/guc-max-parallel-degree &

Re: [HACKERS] Choosing parallel_degree

2016-03-21 Thread Julien Rouhaud
that. It also makes sure that the chosen parallel_degree won't be more than the relation's estimated number of pages. -- Julien Rouhaud http://dalibo.com - http://dalibo.org diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_table.sgml index cd234db..80e1f09 10064

Re: [HACKERS] Choosing parallel_degree

2016-04-13 Thread Julien Rouhaud
On 13/04/2016 19:17, Robert Haas wrote: > On Tue, Apr 12, 2016 at 6:31 PM, Julien Rouhaud > <julien.rouh...@dalibo.com> wrote: >> On 11/04/2016 22:53, Julien Rouhaud wrote: >>> On 11/04/2016 17:44, Robert Haas wrote: >>>> We should probably add

Re: [HACKERS] pg9.6 segfault using simple query (related to use fk for join estimates)

2016-04-29 Thread Julien Rouhaud
On 29/04/2016 18:05, Tom Lane wrote: > Julien Rouhaud <julien.rouh...@dalibo.com> writes: >> The segfault is caused by quals_match_foreign_key() calling get_leftop() >> and get_rightop() on a ScalarArrayOpExpr node. > >> Reordering the common fields o

Re: [HACKERS] pg9.6 segfault using simple query (related to use fk for join estimates)

2016-04-29 Thread Julien Rouhaud
the get_*op() work with either (as in attached patch) fixes the issue. I'm not sure that assuming this compatibility is the right way to fix this though. -- Julien Rouhaud http://dalibo.com - http://dalibo.org diff --git a/src/include/nodes/primnodes.h b/src/include/nodes/primnodes.h index 1ffc0a1..dffe129

[HACKERS] max_worker_processes missing some documentation

2016-05-02 Thread Julien Rouhaud
I noticed that postgresql.conf.sample doesn't say that changing max_worker_processes requires a restart. Patch attached. -- Julien Rouhaud http://dalibo.com - http://dalibo.org diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample index

[HACKERS] Memory leak when querying GIN indexes

2016-04-14 Thread Julien Rouhaud
. I'm not at all familiar with GIN code, but naive attached patch seems to fix the issue and not break anything. I can reproduce this issue up to 9.4. Regards -- Julien Rouhaud http://dalibo.com - http://dalibo.org diff --git a/src/backend/access/gin/ginget.c b/src/backend/access/gin/ginget.c index b

Re: [HACKERS] Memory leak in GIN index build

2016-04-16 Thread Julien Rouhaud
On 16/04/2016 20:45, Tom Lane wrote: > Julien Rouhaud <julien.rouh...@dalibo.com> writes: > >> Also, in dataPlaceToPageLeaf() and ginVacuumPostingTreeLeaf(), shouldn't >> the START_CRIT_SECTION() calls be placed before the xlog code? > > Yeah, they should. Evident

[HACKERS] Memory leak in GIN index build

2016-04-16 Thread Julien Rouhaud
, in dataPlaceToPageLeaf() and ginVacuumPostingTreeLeaf(), shouldn't the START_CRIT_SECTION() calls be placed before the xlog code? Regards. -- Julien Rouhaud http://dalibo.com - http://dalibo.org generate_data.pl Description: Perl program -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Memory leak in GIN index build

2016-04-18 Thread Julien Rouhaud
noted that some of the coding-rule > violations seem to be new in 9.5, so the problems may be less severe in > 9.4 --- the memory leak definitely exists there, though. > -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Small issues in syncrep.c

2016-08-10 Thread Julien Rouhaud
rep code, so I don't >> see any reason to keep the code as it currently is in 9.5/9.6. >> >> Any objections to backpatching this to 9.5 and 9.6? > > None from here. > same here. -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers maili

Re: [HACKERS] [PROPOSAL] timestamp informations to pg_stat_statements

2016-07-17 Thread Julien Rouhaud
oes that, assuming you're using a 9.4+ server. -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Rename max_parallel_degree?

2016-06-29 Thread Julien Rouhaud
On 29/06/2016 06:29, Amit Kapila wrote: > On Wed, Jun 29, 2016 at 2:57 AM, Julien Rouhaud > <julien.rouh...@dalibo.com> wrote: >> >> Thanks a lot for the help! >> >> PFA v6 which should fix all the issues mentioned. > > Couple of minor suggestions.

  1   2   >