width=0)
Index Cond: ((proname = 'my'::name) AND (proname 'mz'::name))
(4 rows)
--
Rushabh Lathia
www.EnterpriseDB.com
the query it seems that we should execute ExecQual as we having
bitmpaqual on the BitmapHeap node (Not quite sure). And when I manually
did recheck = ture, query working fine and as expected.
Regards.
Rushabh
www.EnterpriseDB.com
On Wed, Nov 19, 2008 at 4:26 PM, Rushabh Lathia [EMAIL PROTECTED]wrote
correct/expected Datum representation of the int64.
postgres.h
#ifdef USE_FLOAT8_BYVAL
#define Int64GetDatum(X) ((Datum) SET_8_BYTES(X))
#else
extern Datum Int64GetDatum(int64 X);
#endif
When I tried the same case with --disable-float8-byval option, test running
as expected.
Regards,
Rushabh
I think we need to create ISBN type ( contrib/isn/isn.sql.in) with flag
PASSBYVALUE flag when flag USE_FLOAT8_BYVAL is set.
-Regards,
Rushabh
On Fri, Nov 28, 2008 at 10:29 PM, Tom Lane [EMAIL PROTECTED] wrote:
Rushabh Lathia [EMAIL PROTECTED] writes:
Following test end up with the server
,
Rushabh Lathia
(www.EnterpriseDB.com)
diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c
index 276c7e1..a067309 100644
--- a/contrib/dblink/dblink.c
+++ b/contrib/dblink/dblink.c
@@ -2083,6 +2083,11 @@ get_tuple_of_interest(Oid relid, int2vector *pkattnums, int16 pknumatts, char
:
nestjoinOK = false;
..
}
wondering why ?
Regards,
Rushabh Lathia
[EMAIL PROTECTED]
(10,10);
myfunc
--
200
(1 row)
I think second function should replace the old definition of the function,
inputs ?
Thanks,
Rushabh Lathia
www.EnterpriseDB.com
On Thu, Dec 11, 2008 at 12:33 PM, Peter Eisentraut [EMAIL PROTECTED] wrote:
Rushabh Lathia wrote:
Hi,
Testcase: (8.4 CVS head)
CREATE OR REPLACE FUNCTION myfunc(y int)
RETURNS INTEGER AS $$
select 100;
$$ language sql;
CREATE OR REPLACE FUNCTION myfunc(y int
On Thu, Dec 11, 2008 at 12:40 PM, Pavel Stehule [EMAIL PROTECTED]wrote:
Hello
2008/12/11 Rushabh Lathia [EMAIL PROTECTED]:
Hi,
Testcase: (8.4 CVS head)
CREATE OR REPLACE FUNCTION myfunc(y int)
RETURNS INTEGER AS $$
select 100;
$$ language sql
On Thu, Dec 11, 2008 at 12:59 PM, Pavel Stehule [EMAIL PROTECTED]wrote:
2008/12/11 Rushabh Lathia [EMAIL PROTECTED]:
On Thu, Dec 11, 2008 at 12:40 PM, Pavel Stehule [EMAIL PROTECTED]
wrote:
Hello
when you created function, we cannot check defaults, because we don't
know
as the input args here is timestamp...
inputs?
Thanks,
Rushabh Lathia
www.EnterpriseDB.com
...@gmx.net wrote:
On Monday 15 December 2008 15:43:00 Tom Lane wrote:
Peter Eisentraut pete...@gmx.net writes:
Rushabh Lathia wrote:
I think this should not return error as the input args here is
timestamp... inputs?
In theory yes, but it's currently not that smart.
This is truly
16, 2008 at 12:26 PM, Pavel Stehule pavel.steh...@gmail.comwrote:
Hello
I'll write patch that block creating all ambiguous overloading.
Regards
Pavel Stehule
2008/12/16 Rushabh Lathia rushabh.lat...@gmail.com:
Another issue found on CVS head
CREATE USER test WITH PASSWORD 'test
On Tue, Dec 16, 2008 at 5:35 PM, Pavel Stehule pavel.steh...@gmail.comwrote:
2008/12/16 Rushabh Lathia rushabh.lat...@gmail.com:
When we find the (pathpos prevResult-pathpos) into
FuncnameGetCandidates(), we just replacing the prevResult with the
newResult.
While replacing
)
+ if (rsinfo.returnMode == SFRM_ValuePerCall ||
+ (!fcache-func.fn_retset
hasSetArg))
{
if (*isDone != ExprEndResult)
{
Thanks,
Rushabh Lathia
On Thu, Dec 18, 2008 at 11:54 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Rushabh Lathia rushabh.lat...@gmail.com writes:
Another issue found on CVS head
...
postgres= select f_test(10);
ERROR: cache lookup failed for type 2139062142
I had some difficulty reproducing this locally
DEFAULT f1())
RETURNS VARCHAR AS
$$
BEGIN
RETURN p2;
END;
$$ LANGUAGE plpgsql;
postgres=# select f2(10);
f2
(1 row)
When we run the f2() it should return the output as the defvalue of f1()
function, but its returning null.
Thanks,
Rushabh Lathia
www.EnterpriseDB.com
;
}
Another fix would be to add check for parseTree into
analyze_requires_snapshot().
Thanks ,
Rushabh Lathia
www.EnterpriseDB.com
import java.sql.Connection;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
import java.sql.*;
public class Test
that error coming from date_in() -
DecodeDateTime(). Problem here is whenever any space comes in the date
ParseDateTime() unable to break string into tokens based on a date/time
context.
--
Rushabh Lathia
www.EnterpriseDB.com
On Thu, Jun 11, 2009 at 12:02 AM, Peter Eisentraut pete...@gmx.net wrote:
On Wednesday 10 June 2009 17:10:42 Tom Lane wrote:
Rushabh Lathia rushabh.lat...@gmail.com writes:
Getting error while trying to insert date with the format
'dd-month-'
, 'day-mm-' (format which add
,
Rushabh Lathia
www.EnterpriseDB.com
On Mon, Aug 20, 2012 at 9:28 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Rushabh Lathia rushabh.lat...@gmail.com writes:
ALTER TABLE ADD Constraints PRIMARY KEY on inheritance table not getting
route to child table.
Right.
But when we do ALTER TABLE DROP Constraint on the same, it complains
those that were created by actual cursor commands.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
--
Rushabh Lathia
assertion_pg.patch
Query
from the utility stmt. To get the Query stmt from Utilty command it calls
UtilityContainsQuery().
Into UtilityContainsQuery() we need to handle ExplainStmt properlly for the
the SELECT INTO so that it returns proper contained Query Stmt.
PFA patch for the same.
Thanks,
--
Rushabh Lathia
call for such value
on windows it ending up with error invalid input syntax for type double
precision: as strtod() not able to understand such values.
I added to check into pgstatindex() to avoid 0/0 situation and issue got
fixed.
PFA patch for the same.
Thanks,
Rushabh Lathia
EnterpriseDB
;
a
---
Sat Mar 11 23:58:48 *1* IST
(1 row)
Looking at the code, it seems like for Postgres,MDY datestyle DecodeDateTime()
doesn't handle date properly if year is greater then 4 digits (greater then
). Do you see this as bug or expected output ?
Regards,
Rushabh Lathia
ending up with following:
elog(ERROR, CURRENT OF cannot be executed);
should we change this to ereport() or is there some other fix that we
should make?
Regards,
Rushabh Lathia
www.EnterpriseDB.com
.
Regards,
Rushabh Lathia
EnterpriseDB http://www.enterprisedb.com/, The Enterprise
PostgreSQLhttp://www.enterprisedb.com/
company.
Index: src/backend/utils/error/elog.c
===
RCS file: /repositories/postgreshome/cvs/pgsql/src/backend/utils
On Fri, Apr 1, 2011 at 7:26 PM, Robert Haas robertmh...@gmail.com wrote:
On Fri, Apr 1, 2011 at 9:14 AM, Rushabh Lathia rushabh.lat...@gmail.com
wrote:
On windows when we run edb-postgres.exe ...
Did you intend to send this to an EDB-internal mailing list?
Oops sorry, initially we found
On Fri, Apr 1, 2011 at 6:51 PM, Magnus Hagander mag...@hagander.net wrote:
On Fri, Apr 1, 2011 at 15:14, Rushabh Lathia rushabh.lat...@gmail.com
wrote:
Problem:
On windows when we run postgres.exe without any command line args, its
getting crash or its showing error
On Fri, Apr 1, 2011 at 8:23 PM, Rushabh Lathia rushabh.lat...@gmail.comwrote:
On Fri, Apr 1, 2011 at 6:51 PM, Magnus Hagander mag...@hagander.netwrote:
On Fri, Apr 1, 2011 at 15:14, Rushabh Lathia rushabh.lat...@gmail.com
wrote:
Problem:
On windows when we run postgres.exe
On Fri, Apr 1, 2011 at 11:31 PM, Magnus Hagander mag...@hagander.netwrote:
On Fri, Apr 1, 2011 at 16:56, Rushabh Lathia rushabh.lat...@gmail.com
wrote:
On Fri, Apr 1, 2011 at 8:23 PM, Rushabh Lathia rushabh.lat...@gmail.com
wrote:
On Fri, Apr 1, 2011 at 6:51 PM, Magnus Hagander
Pavel Stehule
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
--
Rushabh Lathia
get_diagnostics_context_initial_v2.patch
Description: Binary data
--
Sent via pgsql-hackers
();
https://github.com/orafce/orafce/blob/master/utility.c
2013/6/24 Rushabh Lathia rushabh.lat...@gmail.com:
Hi,
Use of this feature is to get call stack for debugging without raising
exception. This definitely seems very useful.
Here are my comments about the submitted patch:
Patch
.
Regards
Pavel
Pavel
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
--
Rushabh Lathia
On Tue, Jun 25, 2013 at 2:41 PM, Pavel Stehule pavel.steh...@gmail.comwrote:
2013/6/25 Rushabh Lathia rushabh.lat...@gmail.com:
Hi Pavel,
I gone through the discussion over here and found that with this patch we
enable the new error fields in plpgsql. Its a simple patch to expose
On Tue, Jun 25, 2013 at 11:09 AM, Pavel Stehule pavel.steh...@gmail.comwrote:
2013/6/25 Rushabh Lathia rushabh.lat...@gmail.com:
On Tue, Jun 25, 2013 at 1:47 AM, Pavel Stehule pavel.steh...@gmail.com
wrote:
Hello
This is fragment ofmy old code from orafce package
On Wed, Jun 26, 2013 at 5:11 PM, Pavel Stehule pavel.steh...@gmail.comwrote:
2013/6/26 Rushabh Lathia rushabh.lat...@gmail.com:
On Tue, Jun 25, 2013 at 11:09 AM, Pavel Stehule pavel.steh...@gmail.com
wrote:
2013/6/25 Rushabh Lathia rushabh.lat...@gmail.com:
On Tue
Latest patch looks good to me.
Regards,
Rushabh
On Wed, Jun 26, 2013 at 11:21 PM, Pavel Stehule pavel.steh...@gmail.comwrote:
Hello
updated patch with some basic doc
Regards
Pavel
2013/6/26 Rushabh Lathia rushabh.lat...@gmail.com:
On Wed, Jun 26, 2013 at 5:11 PM, Pavel
://www.enterprisedb.com
--
Rushabh Lathia
pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
--
Rushabh Lathia
of the pgstattuple function ? would be really helpful for future
understanding
purpose.
Thanks,
On Tue, Jul 16, 2013 at 11:42 AM, Satoshi Nagayasu sn...@uptime.jp wrote:
Hi Rushabh,
(2013/07/16 14:58), Rushabh Lathia wrote:
Hello Satoshi,
I assigned myself for the reviewer of this patch. Issue
Technologies, LLC. http://www.uptime.jp
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Thanks,
Rushabh Lathia
)
PFA patch and share your input/suggestions.
(With patch make check running fine without additional failures)
Regards,
Rushabh Lathia
www.EnterpriseDB.com
timestamptz_fix.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
On Thu, Aug 15, 2013 at 1:08 AM, Tom Lane t...@sss.pgh.pa.us wrote:
Rushabh Lathia rushabh.lat...@gmail.com writes:
PFA patch and share your input/suggestions.
I think this needs review. Please add it to the next commitfest.
Done.
Here is latest patch with testcase added to regression
On Mon, Sep 16, 2013 at 7:22 PM, Haribabu kommi
haribabu.ko...@huawei.comwrote:
*On *14 August 2013 Rushabh Lathia wrote:**
** **
postgres=# create table test ( a timestamptz);
CREATE TABLE
** **
-- Date with year 1000
postgres=# insert into test values ( 'Sat Mar 11
--
Rushabh Lathia
www.EnterpriseDB.com
sys_col_constr_v2.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
,
Rushabh Lathia
www.EnterpriseDB.com
On Sun, Aug 25, 2013 at 8:31 PM, Pavel Stehule pavel.steh...@gmail.comwrote:
Hello
here is a patch
it introduce a load_lo and make_lo functions
postgres=# select make_lo(decode('ff00','hex'));
make_lo
─
24629
(1 row)
Time: 40.724 ms
On Thu, Sep 19, 2013 at 10:19 PM, Pavel Stehule pavel.steh...@gmail.comwrote:
Hello
here is patch
Looks good.
Marking it as Ready for Committer.
Regards
Pavel
2013/9/19 Pavel Stehule pavel.steh...@gmail.com
2013/9/19 Rushabh Lathia rushabh.lat...@gmail.com
Hi Pavel,
I
Sorry for delay in reply.
On Tue, Sep 17, 2013 at 6:23 PM, Haribabu kommi
haribabu.ko...@huawei.comwrote:
On Tue, 17 September 2013 14:33 Rushabh Lathia wrote:
On Mon, Sep 16, 2013 at 7:22 PM, Haribabu kommi
haribabu.ko...@huawei.com wrote:
***On *14 August 2013 Rushabh Lathia
http://enterprisedb.com
+ It's impossible for everything to be true. +
--
Rushabh Lathia
timestamptz_fix_with_testcase_v3.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
On Fri, Oct 4, 2013 at 11:35 PM, Bruce Momjian br...@momjian.us wrote:
On Fri, Oct 4, 2013 at 10:19:38AM +, Haribabu kommi wrote:
On 03 October 2013 19:30 Bruce Momjian wrote:
On Thu, Oct 3, 2013 at 11:54:14AM +0530, Rushabh Lathia wrote:
Thanks Bruce.
Yes for me main
On Tue, Oct 8, 2013 at 1:34 AM, Robert Haas robertmh...@gmail.com wrote:
On Mon, Oct 7, 2013 at 12:41 AM, Rushabh Lathia
rushabh.lat...@gmail.com wrote:
Hmm right it has some inconsistency when year length is 6. But the patch
is based on assumption that 5-digit number is a year, because YMD
/
PostgreSQL Development, 24x7 Support, Training Services
--
Rushabh Lathia
. Here error coming with PL block contains an Exception
block (as incase there is an exception block, it calls
RollbackAndReleaseCurrentSubTransaction).
Do you think we should detoast the local variable before
RollbackAndReleaseCurrentSubTransaction ? Or any other options ?
Regards,
Rushabh
and Volatility is nice to have info
into \do+.
Marking it as ready for committer.
Regards,
Rushabh Lathia
www.EnterpriseDB.com
On Fri, Jan 10, 2014 at 7:12 AM, Marko Tiikkaja ma...@joh.to wrote:
Hi,
Here's a patch for $SUBJECT, displaying information which I find quite
tedious to locate using
the issue by adding ExecConstraints() call for foreign table
and
now test behaving as expected. PFA patch for the same.
Regards,
Rushabh Lathia
www.EnterpriseDB.com
diff --git a/src/backend/executor/nodeModifyTable.c b/src/backend/executor/nodeModifyTable.c
index 6f0f47e..240126c 100644
--- a/src
Please consider attached patch here as earlier attached wrong patch.
Sorry for the inconvenience.
On Mon, Jan 20, 2014 at 1:21 PM, Rushabh Lathia rushabh.lat...@gmail.comwrote:
Hello,
Please consider the following test:
create database foo;
\c foo
create table foo_test ( a int );
\c
On Mon, Jan 20, 2014 at 8:52 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Rushabh Lathia rushabh.lat...@gmail.com writes:
As per the PG documentation it says that foreign table do support the
NOT NULL, NULL and DEFAULT.
There has been a great deal of debate about what constraints on foreign
Hello,
I started reviewing the patch. Go through the original mail thread to
understand
the need of fix and the actual problem.
http://www.postgresql.org/message-id/20121002155857.ge30...@momjian.us
Patch is using pg_valid_server_encoding() to compare the encoding which
looks
more correct. Did
is
not real probably but it is not nice anyway..
Rather cleaning the patch once more, attached,
Pavel
--
Rushabh Lathia
subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
--
Rushabh Lathia
www.EnterpriseDB.com
15:13, Rushabh Lathia wrote:
Hello All,
I assigned my self as reviewer of the patch. I gone through the
mail chain discussion and in that question has been raised about
the feature and its implementation, so would like to know what is
the current status of this project/patch.
Regards
mailto:gavinflo...@archidevsys.co.nz wrote:
On 27/06/14 00:12, Rushabh Lathia wrote:
INSERT INTO dept VALUES (10,'ACCOUNTING','NEW YORK') returning
primary key, dname;
I think allowing other columns with PRIMARY KEY would be more
useful syntax.
Even in later versions
On Thu, Jul 3, 2014 at 6:56 AM, Ian Barwick i...@2ndquadrant.com wrote:
On 01/07/14 21:00, Rushabh Lathia wrote:
I spent some more time on the patch and here are my review comments.
.) Patch gets applied through patch -p1 (git apply fails)
.) trailing whitespace in the patch at various
to ignore the
plain meaning of the term generated key.
regards, tom lane
--
Rushabh Lathia
On Mon, Jul 7, 2014 at 5:50 PM, Robert Haas robertmh...@gmail.com wrote:
On Fri, Jul 4, 2014 at 12:36 AM, Rushabh Lathia
rushabh.lat...@gmail.com wrote:
On Fri, Jul 4, 2014 at 7:37 AM, Tom Lane t...@sss.pgh.pa.us wrote:
Tom Dunstan pg...@tomd.cc writes:
On 4 July 2014 00:07, Tom Lane t
---
PostgreSQL 9.0.18 on x86_64-unknown-linux-gnu, compiled by GCC gcc (GCC)
4.4.7 20120313 (Red Hat 4.4.7-4), 64-bit
(1 row)
postgres=# create type typ as ();
ERROR: syntax error at or near )
LINE 1: create type typ as ();
^
Regards,
Rushabh Lathia
PFA patch patch for the master branch.
On Thu, Oct 16, 2014 at 11:09 AM, Rushabh Lathia rushabh.lat...@gmail.com
wrote:
Hi All,
pg_dump binary-upgrade fail with segmentation fault for type without
element.
Consider the following testcase:
rushabh@postgresql$ ./db/bin/psql postgres
psql
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
--
Rushabh Lathia
Open Source Software Center
--
Rushabh Lathia
via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
--
Rushabh Lathia
Patch looks good, assigning to committer.
On Fri, Oct 31, 2014 at 8:36 AM, Fabrízio de Royes Mello
fabriziome...@gmail.com wrote:
On Mon, Oct 27, 2014 at 4:15 AM, Rushabh Lathia rushabh.lat...@gmail.com
wrote:
Hi All,
- Patch got applied cleanly.
- Regression make check run fine
pg_dump: finding the columns and types of table public.aa_tab_fkey
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
--
Rushabh Lathia
On Mon, Feb 23, 2015 at 7:45 PM, Michael Paquier michael.paqu...@gmail.com
wrote:
On Mon, Feb 23, 2015 at 5:57 PM, Rushabh Lathia rushabh.lat...@gmail.com
wrote:
Thanks to the easy handy testcase, was able to replicate the test
scenario
on my local environment. And yes tbinfo
supported OS.
If its by design then was should atleast change the hint into
ReplicationSlotValidateName() which says: "Replication slot names may only
contain letters, numbers, and the underscore character."
Comments ?
Regards,
Rushabh Lathia
www.EnterpriseDB.com
Thanks Andres.
PFA patch to fix the hint message.
On Fri, Sep 25, 2015 at 5:34 PM, Andres Freund <and...@anarazel.de> wrote:
> Hi,
>
> On 2015-09-25 17:32:39 +0530, Rushabh Lathia wrote:
> > I am just wondering why pg_create_physical_replication_slot() can't tak
Thanks Ashutosh.
Re-reviewed and Re-verified the patch, pg_sort_all_pd_v5.patch
looks good to me.
On Fri, Nov 27, 2015 at 3:02 PM, Ashutosh Bapat <
ashutosh.ba...@enterprisedb.com> wrote:
> Thanks Rushabh for your review and comments.
>
> On Thu, Nov 26, 2015 at 5:39 PM,
queue.
PFA to fix the same.
Regards,
Rushabh Lathia
www.EnterpriseDB.com
diff --git a/src/backend/executor/tqueue.c b/src/backend/executor/tqueue.c
index d625b0d..276956e 100644
--- a/src/backend/executor/tqueue.c
+++ b/src/backend/executor/tqueue.c
@@ -535,7 +535,7 @@ TupleQueueReaderNext
the attislocal = false check.
> Regards,
> Amul Sul
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
>
--
Rushabh Lathia
www.EnterpriseDB.com
nd making
completely out of dml_is_pushdown_safe(). Please correct me
.) Documentation for the new API is missing (fdw-callbacks).
Regards,
On Fri, Dec 25, 2015 at 3:30 PM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp>
wrote:
> On 2015/12/24 4:34, Robert Haas wrote:
>
>> On We
ow.
>
> OK, cool.
>
> I went over this patch in some detail today and did a lot of cosmetic
> cleanup. The results are attached. I'm fairly happy with this
> version, but let me know what you think. Of course, feedback from
> others is more than welcome also.
>
>
Had a quick look at the patch changes and also performed basic
sanity check. Patch looks good to me.
Thanks.
--
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Rushabh Lathia
www.EnterpriseDB.com
; PlanDMLPushdown, if having the clause, so that we do nothing at
> ModifyTable.)
>
> void
> EndDMLPushdown (ForeignScanState *node);
>
> This finishes the DML pushdown, like EndForeignScan.
>
+1.
I like idea of separate FDW API for the DML Pushdown. Was thinking can't we
can re-use the IterateForeignScan(ForeignScanState *node) rather then
introducing IterateDMLPushdown(ForeignScanState *node) new API ?
> I'm attaching a WIP patch, which only includes changes to the core. I'm
> now working on the postgres_fdw patch to demonstrate that these APIs work
> well, but I'd be happy if I could get any feedback earlier.
>
> Best regards,
> Etsuro Fujita
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
>
--
Rushabh Lathia
ner will spend time in explaining multiple queries, but it will be in
> better position to cost the usage. If use_remote_estimate is OFF, we will
> altogether loose chances of merge join, which doesn't look good to me. But
> a speculative costing done in this case can result in choosing
On Thu, Jan 7, 2016 at 6:15 PM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp>
wrote:
> On 2016/01/06 18:58, Rushabh Lathia wrote:
>
>> I started looking at updated patch and its definitely iked the new
>> approach.
>>
>
> Thanks for the review!
>
> Wit
ibited by PostgreSQL versions prior to 8.2.
And as above documentation clearly says that IS NULL and IS NOT NULL do not
always return inverse results for row-valued expressions. So need to change
the
deparse logic into postgres_fdw - how ? May be to use IS NULL rather then IS
NOT NULL?
Inp
On Thu, Jan 14, 2016 at 2:00 PM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp>
wrote:
> On 2016/01/12 20:31, Rushabh Lathia wrote:
>
>> On Thu, Jan 7, 2016 at 6:15 PM, Etsuro Fujita
>> <fujita.ets...@lab.ntt.co.jp <mailto:fujita.ets...@lab.ntt.co.jp>> wrote:
ltiple sortgroupref
labels.
If we revert the above commit, then the give test are running
as expected.
Regards,
Rushabh Lathia
www.EnterpriseDB.com
On Wed, Feb 3, 2016 at 3:31 PM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp>
wrote:
> On 2016/01/28 15:20, Rushabh Lathia wrote:
>
>> On Thu, Jan 28, 2016 at 11:33 AM, Etsuro Fujita
>> <fujita.ets...@lab.ntt.co.jp <mailto:fujita.ets...@lab.ntt.co.jp>> wrote:
&g
Fujita-san, I am attaching update version of the patch, which added
the documentation update.
Once we finalize this, I feel good with the patch and think that we
could mark this as ready for committer.
On Fri, Feb 5, 2016 at 5:33 PM, Rushabh Lathia <rushabh.lat...@gmail.com>
wrote:
>
&
On Wed, Feb 3, 2016 at 3:31 PM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp>
wrote:
> On 2016/01/28 15:20, Rushabh Lathia wrote:
>
>> On Thu, Jan 28, 2016 at 11:33 AM, Etsuro Fujita
>> <fujita.ets...@lab.ntt.co.jp <mailto:fujita.ets...@lab.ntt.co.jp>> wrote:
&g
On Fri, Feb 5, 2016 at 4:46 PM, Rushabh Lathia <rushabh.lat...@gmail.com>
wrote:
>
>
> On Wed, Feb 3, 2016 at 3:31 PM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp
> > wrote:
>
>> On 2016/01/28 15:20, Rushabh Lathia wrote:
>>
>>> On Thu, Jan 28,
On Thu, Jan 28, 2016 at 11:33 AM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp
> wrote:
> On 2016/01/27 21:23, Rushabh Lathia wrote:
>
>> If I understood correctly, above documentation means, that if FDW have
>> DMLPushdown APIs that is enough. But in reality thats
; +* we could possibly do something more efficient than using
>>> the full
>>> +* expression-eval machinery for this. But probably there
>>> would be little
>>> +* benefit, and it'd require postgres_fdw to know more than is
>>> desirable
>>> +
On Thu, Jan 21, 2016 at 3:20 PM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp>
wrote:
> On 2016/01/20 19:57, Rushabh Lathia wrote:
>
>> Overall I am quite done with the review of this patch. Patch is in good
>> shape and covered most of the things which been discussed earl
On Tue, Jan 26, 2016 at 4:15 PM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp>
wrote:
> On 2016/01/25 17:03, Rushabh Lathia wrote:
>
>> Here are couple of comments:
>>
>
> 1)
>>
>> int
>> IsForeignRelUpdatable (Relation rel);
>>
>
> Docu
On Fri, Jan 15, 2016 at 9:06 AM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp>
wrote:
> On 2016/01/14 21:36, Rushabh Lathia wrote:
>
>> On Thu, Jan 14, 2016 at 2:00 PM, Etsuro Fujita
>> <fujita.ets...@lab.ntt.co.jp <mailto:fujita.ets...@lab.ntt.co.jp>> wrote:
>
On Wed, Jan 27, 2016 at 2:50 PM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp>
wrote:
> On 2016/01/27 12:20, Etsuro Fujita wrote:
>
>> On 2016/01/26 22:57, Rushabh Lathia wrote:
>>
>>> On Tue, Jan 26, 2016 at 4:15 PM, Etsuro Fujita
>>> <f
On Fri, Feb 12, 2016 at 5:40 PM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp>
wrote:
> Hi Rushabh and Thom,
>
> Thanks for the review!
>
> On 2016/02/10 22:37, Thom Brown wrote:
>
>> On 10 February 2016 at 08:00, Rushabh Lathia <rushabh.lat...@gmail.com>
>>
that its not
importing the default expression from the foreign table. But question is
whether it should ?
inputs/thoughts ?
Regards,
Rushabh Lathia
www.EnterpriseDB.com
1 - 100 of 208 matches
Mail list logo