Re: [HACKERS] More nuclear options

2006-07-11 Thread Steve Singer
On Mon, 10 Jul 2006, Josh Berkus wrote: To be migrated to pgFoundry: dbmirror (need owner) I'll volunteer for this if no one else steps forward. I'm not planning on making any significant chances to dbmirror at this point stage but I can look after for the pgfoundry project.

[HACKERS] 8.2beta1 failure on IRIX

2006-10-01 Thread Steve Singer
I'm getting some failures in the regression tests on 8.2beta1 on IRIX. It looks like IRIX (or at least some versions) has a broken strtod. The float4 and float8 tests fail, I've attached a patch to tools/adt/float.c that fixes the problem along with the regression output. As a side note,could

Re: [HACKERS] 8.2beta1 failure on IRIX

2006-10-04 Thread Steve Singer
On Sun, 1 Oct 2006, Tom Lane wrote: Does this version of the patch address your concerns. Some searching of the net shows that this has been reported before. Once in the beta for 8.1 and again in January as bug #2192 (It looks like a patch was included then but wasn't applied). It seems

Re: [HACKERS] 8.2beta1 failure on IRIX

2006-10-05 Thread Steve Singer
On Wed, 4 Oct 2006, Tom Lane wrote: I've applied the patch and it seems to fix the problems. 8.2beta1 + the patch passes all of the regression tests on the IRIX box (accept the expected difference with the geometry test). I've applied the attached patch which merges ideas from your

Re: [HACKERS] dtester-0.1 released

2010-03-24 Thread Steve Singer
- The requested URL returned error: 500 Is your git server having issues or am I trying to get at the code in the wrong way. Thanks Regards Markus Wanner -- Steve Singer Afilias Canada Data Services Developer 416-673-1142 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] dtester-0.1 released

2010-03-26 Thread Steve Singer
for the http protocol to work? Or just once to initialize the repository? Note that the git protocol said to be is more efficient. At least that's what I've heard. You might want to use that instead (especially if http continues to pose problems). Kind Regards Markus Wanner -- Steve Singer

Re: [HACKERS] [rfc,patch] PL/Proxy in core

2008-05-17 Thread Steve Singer
On Thu, 15 May 2008, Marko Kreen wrote: On 5/15/08, Josh Berkus [EMAIL PROTECTED] wrote: Has PL/proxy been tested on other OSes? FreeBSD/Solaris/Windows? It definitely works on Linux and MacOS. I've seen ports for *BSD. I think any unix-like OS-es should work fine. I've compiled it with

Re: [HACKERS] [rfc,patch] PL/Proxy in core

2008-05-17 Thread Steve Singer
On Sat, 17 May 2008, Marko Kreen wrote: On 5/17/08, Steve Singer [EMAIL PROTECTED] wrote: Somewhat unrelated, I can see use-cases for replacing the call to random() with something that allows user defined polices for RUN ON ANY. Well, thats why the RUN ON userfunc(..); exists. Also notice

Re: [PATCHES] Re: [HACKERS] [GENERAL] plperl and regexps with accented characters - incompatible?

2007-12-01 Thread Steve Singer
On Sat, 1 Dec 2007, Tom Lane wrote: I wrote: I got around to trying it with a dusty 5.6.1 I have laying about on my HPPA machine, and the news is not good: CREATE LANGUAGE plperl dumps core deep inside libperl. With or without this patch. As best I can tell at the moment, I have not tested

Re: [HACKERS] Exposing the Xact commit order to the user

2010-05-26 Thread Steve Singer
' You could then move the work of figuring out the commit order onto the replica where you would combine the output of the WAL scanning process with the transaction data that has been copied to the replica. Jan -- Steve Singer Afilias Canada Data Services Developer 416-673-1142 -- Sent

[HACKERS] 9.0 beta2 pg_upgrade command line parsing

2010-06-15 Thread Steve Singer
': option.c:103: warning: comparison is always true due to limited range of data type getopt_long (both our version in ports and the gnu version) is defined to return an int. The attach patch allows me to get beyond the options loop under AIX. -- Steve Singer Afilias Canada Data Services Developer

[HACKERS] 9.0 beta2 pg_upgrade: malloc 0 bytes patch

2010-06-16 Thread Steve Singer
consisting of a single table to 9.0 on an AIX server. -- Steve Singer Afilias Canada Data Services Developer 416-673-1142 diff --git a/contrib/pg_upgrade/tablespace.c b/contrib/pg_upgrade/tablespace.c index 302eb0d..99a97e4 100644 --- a/contrib/pg_upgrade/tablespace.c +++ b/contrib/pg_upgrade

[HACKERS] stats collector connection refused on recv of test message

2010-06-20 Thread Steve Singer
On one of my machines I get LOG: could not receive test message on socket for statistics collector: Connection refused on startup. I noticed this testing 9.0 but when I went back to check I'm now getting it on 8.3 as well, disabling all of my iptables rules doesn't help. I've done some

Re: [HACKERS] Patch: psql \whoami option

2010-06-20 Thread Steve Singer
This is a review for the \whoami patch (changed to \conninfo). This review was done on the Feb 2 2010 version of the patch (rebased to head) that reflects some of the feedback from -hackers on the initial submission. The commitfest entry should be updated to reflect the most recent version

Re: [HACKERS] Patch: psql \whoami option

2010-07-18 Thread Steve Singer
On Sun, 18 Jul 2010, David Christensen wrote: It's helpful when you attach said patch. This has been rebased to current HEAD. One minor thing I noticed in the updated patch. You moved the '{' after the if(host) in command.c to it's own line(good) but you used spaces instead of tabstops

[HACKERS] HS/SR on AIX

2010-08-24 Thread Steve Singer
:../../../../src/backend/postgres.imp I'll try to look into this a bit more tomorrow or thursday. -- Steve Singer Afilias Canada Data Services Developer 416-673-1142 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] HS/SR on AIX

2010-08-25 Thread Steve Singer
Tom Lane wrote: Steve Singer ssin...@ca.afilias.info writes: I think I've been able to reproduce the issue floating around with streaming replication on AIX. Excellent, because we weren't getting much from the original reporter. I'm withdrawing my comment, today on a clean install

Re: [HACKERS] HS/SR on AIX

2010-08-25 Thread Steve Singer
Steve Singer wrote: Tom Lane wrote: Steve Singer ssin...@ca.afilias.info writes: I think I've been able to reproduce the issue floating around with streaming replication on AIX. I will do another clean build from the beta4 source tar to confirm that I'm not still having the issue but I'm

Re: [HACKERS] HS/SR on AIX

2010-08-27 Thread Steve Singer
on the replica does it make a difference? How about with a LIBPATH=/apps/pg_9.0_b4/lib/postgresql (I'm not exactly sure where libpq.a is on your install) Alanoly. -- Steve Singer Afilias Canada Data Services Developer 416-673-1142 -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Online base backup from the hot-standby

2012-01-19 Thread Steve Singer
On 12-01-17 05:38 AM, Fujii Masao wrote: On Fri, Jan 13, 2012 at 5:02 PM, Fujii Masaomasao.fu...@gmail.com wrote: The amount of code changes to allow pg_basebackup to make a backup from the standby seems to be small. So I ended up merging that changes and the infrastructure patch. WIP patch

Re: [HACKERS] Patch to add a primary key using an existing index

2011-01-16 Thread Steve Singer
- I wasn't able to find any issues in my testing I'm marking this as returned with feedback pending your answer on the possible memory leak above but I think the patch is very close to being ready. Steve Singer diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml

Re: [HACKERS] log_hostname and pg_stat_activity

2011-01-18 Thread Steve Singer
Here is my review for this patch Submission Review -Patch applies cleanly -Patch does not include documentation changes. At a minimum: update the table that lists what pg_stat_activity and pg_stat_replication includes in monitoring.sgml but I propose more below. -No

Re: [HACKERS] pl/python SPI in subtransactions

2011-01-25 Thread Steve Singer
On 10-12-23 08:45 AM, Jan Urbański wrote: Here's a patch implementing a executing SPI in an subtransaction mentioned in http://archives.postgresql.org/pgsql-hackers/2010-12/msg01991.php. It's an incremental patch on top of the plpython-refactor patch sent eariler. Git branch for this patch:

Re: [HACKERS] pl/python SPI in subtransactions

2011-01-29 Thread Steve Singer
On 11-01-27 04:33 PM, Jan Urbański wrote: Right, without the patch you can never catch errors originating from plpy.execute, so any error terminates the whole function, and so rolls back the statement. FWIW PL/Perl works the same: begin; create table foo(i int primary key); DO $$

Re: [HACKERS] pl/python SPI in subtransactions

2011-01-29 Thread Steve Singer
On 11-01-29 03:39 PM, Jan Urbański wrote: D'oh, you're right, thanks. Attached patch with fix. Curiosly, right now in master your example with plpy.prepare will result in savepoint being swallowed, but it's of course better to react with an error. Cheers, Jan This seems to fix it. You

Re: [HACKERS] pl/python explicit subtransactions

2011-02-02 Thread Steve Singer
On 11-01-27 05:11 PM, Jan Urbański wrote: On 23/12/10 15:32, Jan Urbański wrote: Here's a patch implementing explicitly starting subtransactions mentioned in http://archives.postgresql.org/pgsql-hackers/2010-12/msg01991.php. It's an incremental patch on top of the spi-in-subxacts patch sent

Re: [HACKERS] postponing some large patches to 9.2

2011-02-07 Thread Steve Singer
On 11-02-07 10:37 PM, Robert Haas wrote: - The PL/python extravaganza. I'm not really clear where we stand with this. There are a lot of patches here. Some of the patches have been committed a few others are ready (or almost ready) for a committer. The table function one is the only

Re: [HACKERS] pl/python explicit subtransactions

2011-02-07 Thread Steve Singer
On 11-02-06 11:40 AM, Jan Urbański wrote: PFA an updated patch with documentation. Yeah, changed them. Those changes look fine. The tests now pass. I've attached a new version of the patch that fixes a few typos/wording issues I saw in the documentation. I also changed the link to the

Re: [HACKERS] postponing some large patches to 9.2

2011-02-08 Thread Steve Singer
On 11-02-08 10:07 AM, Jan Urbański wrote: * custom SPI exceptions - I'd really like this one to go in, because it allows writing UPSERT-kind functions in PL/Python very easily, and it's just a handful of lines of code I will try to do a review of this one (probably tomorrow night) since

Re: [HACKERS] pl/python explicit subtransactions

2011-02-09 Thread Steve Singer
On 11-02-09 05:22 PM, Peter Eisentraut wrote: On tis, 2011-02-08 at 00:32 -0500, Steve Singer wrote: On 11-02-06 11:40 AM, Jan Urbański wrote: PFA an updated patch with documentation. Yeah, changed them. Those changes look fine. The tests now pass. I've attached a new version of the patch

Re: [HACKERS] log_hostname and pg_stat_activity

2011-02-10 Thread Steve Singer
On 11-02-10 10:13 AM, Robert Haas wrote: On Tue, Feb 1, 2011 at 1:33 PM, Robert Haasrobertmh...@gmail.com wrote: On Tue, Feb 1, 2011 at 1:09 PM, Peter Eisentrautpete...@gmx.net wrote: On tis, 2011-01-18 at 19:24 -0500, Steve Singer wrote: However if I connect with a line in pg_hba

Re: [HACKERS] log_hostname and pg_stat_activity

2011-02-10 Thread Steve Singer
On 11-02-10 10:32 AM, Robert Haas wrote: I was assuming those changes were sufficiently trivial that they could be made at commit-time, especially if Peter is committing it himself. Of course if he'd like a re-review, he can always post an updated patch, but I just thought that was overly

Re: [HACKERS] pl/python custom exceptions for SPI

2011-02-10 Thread Steve Singer
On 11-02-10 03:13 PM, Jan Urbański wrote: On 10/02/11 20:24, Peter Eisentraut wrote: Here is the rest of my review. Submission Review --- Patch applies cleanly. Documentation is still outstanding but Jan has promised it soon. Usability Review --- We don't

Re: [HACKERS] [PATCH 09/14] Adjust all *Satisfies routines to take a HeapTuple instead of a HeapTupleHeader

2012-11-16 Thread Steve Singer
On 12-11-14 08:17 PM, Andres Freund wrote: For the regular satisfies routines this is needed in prepareation of logical decoding. I changed the non-regular ones for consistency as well. The naming between htup, tuple and similar is rather confused, I could not find any consistent naming

Re: [HACKERS] logical changeset generation v3 - Source for Slony

2012-11-19 Thread Steve Singer
First, you can add me to the list of people saying 'wow', I'm impressed. The approach I am taking to reviewing this to try and answer the following question 1) How might a future version of slony be able to use logical replication as described by your patch and design documents and what

Re: [HACKERS] logical changeset generation v3 - Source for Slony

2012-11-19 Thread Steve Singer
On 12-11-18 11:07 AM, Andres Freund wrote: Hi Steve! I think we should provide some glue code to do this, otherwise people will start replicating all the bugs I hacked into this... More seriously: I think we should have support code here, no user will want to learn the intracacies of feedback

Re: [HACKERS] [PATCH 11/14] Introduce wal decoding via catalog timetravel

2012-12-02 Thread Steve Singer
On 12-11-14 08:17 PM, Andres Freund wrote: I am getting errors like the following when I try to use either your test_decoding plugin or my own (which does even less than yours) LOG: database system is ready to accept connections LOG: autovacuum launcher started WARNING: connecting to

Re: [HACKERS] [PATCH 11/14] Introduce wal decoding via catalog timetravel

2012-12-03 Thread Steve Singer
On 12-12-03 07:42 AM, Andres Freund wrote: Two things: 1) Which exact options are you using for pg_receivellog? Not -d replication by any chance? Yes that is exactly what I'md doing. Using a real database name instead makes this go away. Thanks This seems to produce exactly that kind off

Re: [HACKERS] [PATCH 11/14] Introduce wal decoding via catalog timetravel

2012-12-03 Thread Steve Singer
On 12-12-03 09:48 AM, Andres Freund wrote: On 2012-12-03 09:35:55 -0500, Steve Singer wrote: On 12-12-03 07:42 AM, Andres Freund wrote: Yes that is exactly what I'md doing. Using a real database name instead makes this go away. Was using replication an accident or do you think it makes sense

Re: [HACKERS] Logical decoding exported base snapshot

2012-12-11 Thread Steve Singer
On 12-12-11 06:52 PM, Andres Freund wrote: Hi, Problem 1: One problem I see is that while exporting a snapshot solves the visibility issues of the table's contents it does not protect against schema changes. I am not sure whether thats a problem. If somebody runs a CLUSTER or something

Re: [HACKERS] Logical decoding exported base snapshot

2012-12-13 Thread Steve Singer
On 12-12-12 06:20 AM, Andres Freund wrote: Possible solutions: 1) INIT_LOGICAL_REPLICATION waits for an answer from the client that confirms that logical replication initialization is finished. Before that the walsender connection cannot be used for anything else. 2) we remove the snapshot as

[HACKERS] AIX buildfarm member

2013-01-11 Thread Steve Singer
The only animal in the buildfarm running AIX is grebe (http://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=grebebr=HEAD) It is likely that the server running this animal will go away sometime this year and the machine replacing it isn't running AIX. If someone else in the community is

Re: [HACKERS] Re: [PATCH] unified frontend support for pg_malloc et al and palloc/pfree mulation (was xlogreader-v4)

2013-01-19 Thread Steve Singer
On 13-01-09 03:07 PM, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: Well, I *did* benchmark it as noted elsewhere in the thread, but thats obviously just machine (E5520 x 2) with one rather restricted workload (pgbench -S -jc 40 -T60). At least its rather palloc heavy. Here are

Re: [HACKERS] logical changeset generation v4

2013-01-19 Thread Steve Singer
On 13-01-14 08:38 PM, Andres Freund wrote: Hi everyone, Here is the newest version of logical changeset generation. 2) Currently the logical replication infrastructure assigns a 'slot-id' when a new replica is setup. That slot id isn't really nice (e.g. id-321578-3). It also requires that

Re: [HACKERS] Re: [PATCH] unified frontend support for pg_malloc et al and palloc/pfree mulation (was xlogreader-v4)

2013-01-21 Thread Steve Singer
On 13-01-21 02:28 AM, Andres Freund wrote: I haven't removed it from the patch afaik, so it would be great to get a profile here! Its only for xlogdump, but that tool helped me immensely and I don't want to maintain it independently... Here is the output from tprof Here is the baseline:

Re: [HACKERS] Re: [PATCH] unified frontend support for pg_malloc et al and palloc/pfree mulation (was xlogreader-v4)

2013-01-21 Thread Steve Singer
On 13-01-21 12:15 PM, Andres Freund wrote: On 2013-01-21 11:59:18 -0500, Steve Singer wrote: On 13-01-21 02:28 AM, Andres Freund wrote: I haven't removed it from the patch afaik, so it would be great to get a profile here! Its only for xlogdump, but that tool helped me immensely and I don't

Re: [HACKERS] logical changeset generation v4 - Heikki's thoughts about the patch state

2013-01-24 Thread Steve Singer
On 13-01-24 06:40 AM, Andres Freund wrote: Fair enough. I am also working on a user of this infrastructure but that doesn't help you very much. Steve Singer seemed to make some stabs at writing an output plugin as well. Steve, how far did you get there? I was able to get something

Re: [HACKERS] Event Triggers: adding information

2013-01-24 Thread Steve Singer
On 13-01-24 05:43 AM, Dimitri Fontaine wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Jan 21, 2013 at 12:27 PM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: - Context exposing and filtering I'm not feeling very sanguine about any of this. I feel strongly that we should try to

Re: [HACKERS] logical changeset generation v4 - Heikki's thoughts about the patch state

2013-01-26 Thread Steve Singer
On 13-01-24 11:15 AM, Steve Singer wrote: On 13-01-24 06:40 AM, Andres Freund wrote: Fair enough. I am also working on a user of this infrastructure but that doesn't help you very much. Steve Singer seemed to make some stabs at writing an output plugin as well. Steve, how far did you get

Re: [HACKERS] Event Triggers: adding information

2013-01-27 Thread Steve Singer
On 13-01-26 11:11 PM, Robert Haas wrote: On Fri, Jan 25, 2013 at 11:58 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: My understanding is that if the command string we give to event triggers is ambiguous (sub-object names, schema qualifications, etc), it comes useless for logical

Re: [HACKERS] logical changeset generation v4

2013-01-27 Thread Steve Singer
176087bacec6cbf0b86e4ffeb918f41b4a5b8d7a Mon Sep 17 00:00:00 2001 From: Steve Singer ssin...@ca.afilias.info Date: Sun, 27 Jan 2013 12:24:33 -0500 Subject: [PATCH] allow pg_receivellog to pass plugin options from the command line to the plugin --- src/bin/pg_basebackup/pg_receivellog.c | 14

Re: [HACKERS] logical changeset generation v4 - Heikki's thoughts about the patch state

2013-01-27 Thread Steve Singer
On 13-01-24 11:15 AM, Steve Singer wrote: On 13-01-24 06:40 AM, Andres Freund wrote: Fair enough. I am also working on a user of this infrastructure but that doesn't help you very much. Steve Singer seemed to make some stabs at writing an output plugin as well. Steve, how far did you get

Re: [HACKERS] logical changeset generation v4 - Heikki's thoughts about the patch state

2013-01-28 Thread Steve Singer
On 13-01-28 06:17 AM, Andres Freund wrote: Hi, 3. Pass the delete (with no key values) onto the replication client and let it deal with it (see 1 and 2) Hm. While I agree that nicer behaviour would be good I think the real enforcement should happen on a higher level, e.g. with event triggers

Re: [HACKERS] logical changeset generation v4

2013-01-28 Thread Steve Singer
On 13-01-28 06:23 AM, Andres Freund wrote: The CF is also there to find UI warts and such, so something like this seems perfectly fine. Even moreso as it doesn't look this will get into 9.3 anyway. I wanted to add such an option, but I was too lazy^Wbusy to think about the sematics. Your

Re: [HACKERS] canceling autovacuum task woes

2012-07-24 Thread Steve Singer
On 12-07-24 01:48 PM, Robert Haas wrote: I am running into a lot of customer situations where the customer reports that canceling autovacuum task shows up in the logs, and it's unclear whether this is happening often enough to matter, and even more unclear what's causing it. Could autovacuum

Re: [HACKERS] [PATCH 8/8] Introduce wal decoding via catalog timetravel

2012-10-11 Thread Steve Singer
On 12-10-11 06:27 PM, Josh Berkus wrote: On 10/10/12 7:26 PM, Bruce Momjian wrote: How does Slony write its changes without causing serialization replay conflicts? Since nobody from the Slony team answered this: a) Slony replicates *rows*, not *statements* True, but the proposed logical

Re: [HACKERS] [RFC][PATCH] wal decoding, attempt #2 - Design Documents (really attached)

2012-10-15 Thread Steve Singer
On 12-10-15 04:51 PM, Andres Freund wrote: Well, as a crosscheck, could you list your requirements? Do you need anything more than outputting data in a format compatible to whats stored in sl_log_*? You wouldn't have sl_actionseq, everything else should be there (Well, you would need to do

Re: [HACKERS] [RFC][PATCH] Logical Replication/BDR prototype and architecture

2012-06-13 Thread Steve Singer
On 12-06-13 07:27 AM, Andres Freund wrote: Its also available in the 'cabal-rebasing' branch on git.postgresql.org/users/andresfreund/postgres.git . That branch will modify history though. That branch has a merge error in f685a11ce43b9694cbe61ffa42e396c9fbc32b05 gcc -O2 -Wall

Re: [HACKERS] [RFC][PATCH] Logical Replication/BDR prototype and architecture

2012-06-16 Thread Steve Singer
On 12-06-15 04:03 PM, Robert Haas wrote: On Thu, Jun 14, 2012 at 4:13 PM, Andres Freundand...@2ndquadrant.com wrote: I don't plan to throw in loads of conflict resolution smarts. The aim is to get to the place where all the infrastructure is there so that a MM solution can be built by

Re: [HACKERS] [PATCH 10/16] Introduce the concept that wal has a 'origin' node

2012-06-17 Thread Steve Singer
On 12-06-13 01:27 PM, Andres Freund wrote: The previous mail contained a patch with a mismerge caused by reording commits. Corrected version attached. Thanks to Steve Singer for noticing this quickly. Attached is a more complete review of this patch. I agree that we will need to identify

Re: [HACKERS] [PATCH 10/16] Introduce the concept that wal has a 'origin' node

2012-06-18 Thread Steve Singer
On 12-06-18 07:30 AM, Andres Freund wrote: Hrmpf #666. I will go through through the series commit-by-commit again to make sure everything compiles again. Reordinging this late definitely wasn't a good idea... I pushed a rebased version with all those fixups (and removal of the zeroRecPtr

Re: [HACKERS] [PATCH 10/16] Introduce the concept that wal has a 'origin' node

2012-06-18 Thread Steve Singer
On 12-06-18 11:50 AM, Andres Freund wrote: Hi Simon, I think we need to agree on the parameter name. It currently is 'multimaster_node_id'. In the discussion with Steve we got to replication_node_id. I don't particularly like either. Other suggestions? Other things that come to mind (for

Re: [HACKERS] [PATCH 08/16] Introduce the ApplyCache module which can reassemble transactions from a stream of interspersed changes

2012-06-20 Thread Steve Singer
On 12-06-13 07:28 AM, Andres Freund wrote: From: Andres Freundand...@anarazel.de The individual changes need to be identified by an xid. The xid can be a subtransaction or a toplevel one, at commit those can be reintegrated by doing a k-way mergesort between the individual transaction.

Re: [HACKERS] [PATCH 08/16] Introduce the ApplyCache module which can reassemble transactions from a stream of interspersed changes

2012-06-25 Thread Steve Singer
On 12-06-21 04:37 AM, Andres Freund wrote: Hi Steve, Thanks! Attached is a detailed review of the patch. Very good analysis, thanks! Another reasons why we cannot easily do 1) is that subtransactions aren't discernible from top-level transactions before the top-level commit happens, we can

Re: [HACKERS] dblink crash on PPC

2011-05-27 Thread Steve Singer
On 11-05-27 12:35 PM, Tom Lane wrote: grebe, which is also a PPC64 machine, isn't showing the bug. And I just failed to reproduce the problem on a RHEL6 PPC64 box. About to go try it on RHEL5, which has a gcc version much closer to what wombat says it's using, but I'm not very hopeful about

Re: [HACKERS] pg_listener in 9.0

2011-06-01 Thread Steve Singer
On 11-06-01 09:30 AM, Christopher Browne wrote: On Wed, Jun 1, 2011 at 8:29 AM, Dave Pagedp...@pgadmin.org wrote: On Wed, Jun 1, 2011 at 12:27 PM, Andrew Dunstanand...@dunslane.net wrote: The whole point of the revamp was that pg_listener was a major performance bottleneck and needed to go,

Re: [HACKERS] patch for 9.2: enhanced errors

2011-06-18 Thread Steve Singer
. Everything I've mentioned above is a minor issue, I will move the patch to 'waiting for author' and wait for you to release an updated patch. Steve Singer -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] patch for 9.2: enhanced errors

2011-06-18 Thread Steve Singer
On 11-06-18 06:36 PM, Steve Singer wrote: On 11-06-08 04:14 PM, Pavel Stehule wrote: Here is my review of this patch Submission Review: The patch applies cleanly against master The patch does not include any documentation updates (see note below to update config.sgml

Re: [HACKERS] patch for 9.2: enhanced errors

2011-06-19 Thread Steve Singer
On Sun, 19 Jun 2011, Pavel Stehule wrote: Maybe there is second issue (little bit - performance - you have to call a output function), But I agree, so this information is very interesting and can help. I am concerned about the performance impact of doing that. Not all constraints are on

Re: [HACKERS] patch for 9.2: enhanced errors

2011-06-21 Thread Steve Singer
On 11-06-20 03:44 PM, Pavel Stehule wrote: Hello You need to update config.sgml at the same time you update this format. You need to append a , after application name but before constraintName. As it stands the CSV log has something like: .nbtinsert.c:433,psqla_pkey,public,a,a fixed

Re: [HACKERS] Online base backup from the hot-standby

2011-06-21 Thread Steve Singer
On 11-06-14 02:52 AM, Jun Ishiduka wrote: I still think that's headed in the wrong direction. (http://archives.postgresql.org/pgsql-hackers/2011-05/msg01405.php) Please check these mails, and teach the reason for content of the wrong direction.

Re: [HACKERS] Online base backup from the hot-standby

2011-06-23 Thread Steve Singer
On 11-06-23 02:41 AM, Jun Ishiduka wrote: I receive this mail, so I notice I do wrong recognition to what Heikki is proposing. my recognition: Before: * I thought Heikki proposes, Execute SQL(pg_start_backup('x'); copy the data directory and pg_stop_backup();) from the standby

Re: [HACKERS] Online base backup from the hot-standby

2011-06-24 Thread Steve Singer
On 11-06-24 12:41 AM, Jun Ishiduka wrote: The logic that not use pg_stop_backup() would be difficult, because pg_stop_backup() is used to identify minRecoveryPoint. Considering everything that has been discussed on this thread so far. Do you still think your patch is the best way to

Re: [HACKERS] libpq SSL with non-blocking sockets

2011-06-24 Thread Steve Singer
On 11-06-15 03:20 PM, Martin Pihlak wrote: Yes, that sounds like a good idea -- especially considering that COPY is not the only operation that can cause SSL_write retries. This is of course still work in progress, needs cleaning up and definitely more testing. But at this point before going

Re: [HACKERS] Online base backup from the hot-standby

2011-06-28 Thread Steve Singer
On 11-06-28 01:52 AM, Jun Ishiduka wrote: Considering everything that has been discussed on this thread so far. Do you still think your patch is the best way to accomplish base backups from standby servers? If not what changes do you think should be made? I reconsider the way to not use

Re: [HACKERS] libpq SSL with non-blocking sockets

2011-06-30 Thread Steve Singer
On 11-06-28 02:14 PM, Martin Pihlak wrote: Hmm, I thought I thought about that. There was a check in the original patch: if (conn-sslRetryBytes || (conn-outCount - remaining) 0) So if the SSL retry buffer was emptied it would return 1 if there was something left in the regular output buffer.

Re: [HACKERS] libpq SSL with non-blocking sockets

2011-07-02 Thread Steve Singer
On 11-06-28 02:14 PM, Martin Pihlak wrote: Thanks for the review! I have since simplified the patch to assume that partial SSL writes are disabled -- according to SSL_write(3) this is the default behaviour. Now the SSL retry buffer only holds the data to be retried, the remainder is moved to the

Re: [HACKERS] Online base backup from the hot-standby

2011-07-10 Thread Steve Singer
On 11-07-07 09:22 PM, Jun Ishiduka wrote: As you proposed, adding new field which stores the backup end location taken from minRecoveryPoint, into pg_control sounds good idea. Update patch. Here is a review of the updated patch This version of the patch adds a field into pg_controldata that

Re: [HACKERS] walprotocol.h vs frontends

2011-08-15 Thread Steve Singer
On 11-08-15 10:00 AM, Peter Geoghegan wrote: Without commenting on what should be done in your specific case, I wonder whether it's time to fully retire the deprecated double representation of timestamps. Is anyone actually expected to rely on their availability when 9.2 is released? This also

Re: [HACKERS] walprotocol.h vs frontends

2011-08-15 Thread Steve Singer
On 11-08-15 12:33 PM, Peter Geoghegan wrote: On 15 August 2011 16:56, Steve Singerssin...@ca.afilias.info wrote: This would mean that anyone using the floating point timestamps today won't be able to use pg_upgrade to upgrade to whichever version we remove them from. 8.3 had float based

Re: [HACKERS] Online base backup from the hot-standby

2011-08-16 Thread Steve Singer
On 11-08-16 02:09 AM, Jun Ishiduka wrote: Thanks. This has the following two problems. * pg_start_backup() must set 'on' to full_page_writes of the master that is actual writing of the WAL, but not the standby. Is there any way to tell from the WAL segments if they contain the full

[HACKERS] skip WAL on COPY patch

2011-08-23 Thread Steve Singer
The attached patch adds an option to the COPY command to skip writing WAL when the following conditions are all met: 1) The table is empty (zero size on disk) 2) The copy command can obtain an access exclusive lock on the table with out blocking. 3) The WAL isn't needed for replication For

Re: [HACKERS] skip WAL on COPY patch

2011-08-23 Thread Steve Singer
On 11-08-23 04:17 PM, Tom Lane wrote: Robert Haasrobertmh...@gmail.com writes: What I think would be really interesting is a way to make this work when the table *isn't* empty. In other words, have a COPY option that (1) takes an exclusive lock on the table, (2) writes the data being inserted

Re: [HACKERS] postgesql-9.0.4 compile on AIX 6.1 using gcc 4.4.6

2011-08-31 Thread Steve Singer
On 11-08-30 07:58 AM, Weiss, Wilfried wrote: Hello, I am just trying to compile postgresql-9.0.4 on AIX 6100-06-03-1048 using gcc 4.4.6. Unfortunately that was not all. There was also: [Bug target/46072] AIX linker chokes on debug info for uninitialized static variables This is an IBM

Re: [HACKERS] PL/Python result object str handler

2013-02-02 Thread Steve Singer
On 13-01-07 09:58 PM, Peter Eisentraut wrote: By implementing a str handler for the result object, it now prints something like PLyResult status=5 nrows=2 rows=[{'foo': 1, 'bar': '11'}, {'foo': 2, 'bar': '22'}] Patch attached for review. Here is a review: This patch adds a function that

Re: [HACKERS] json generation enhancements

2013-02-23 Thread Steve Singer
On 13-01-11 11:03 AM, Andrew Dunstan wrote: On 01/11/2013 11:00 AM, Andrew Dunstan wrote: I have not had anyone follow up on this, so I have added docs and will add this to the commitfest. Recap: This adds the following: json_agg(anyrecord) - json to_json(any) - json

Re: [HACKERS] json generation enhancements

2013-02-28 Thread Steve Singer
On 13-02-25 05:37 PM, Andrew Dunstan wrote: On 02/24/2013 01:09 AM, Steve Singer wrote: On 13-01-11 11:03 AM, Andrew Dunstan wrote: On 01/11/2013 11:00 AM, Andrew Dunstan wrote: I have not had anyone follow up on this, so I have added docs and will add this to the commitfest. Recap

Re: [HACKERS] transforms

2013-03-03 Thread Steve Singer
On 13-03-03 06:15 PM, Josh Berkus wrote: transforms=# create extension hstore_plperl; ERROR: could not load library /home/josh/pg93/lib/postgresql/hstore_plperl.so: /home/josh/pg93/lib/postgresql/hstore_plperl.so: undefined symbol: hstoreUniquePairs STATEMENT: create extension hstore_plperl;

Re: [HACKERS] transforms

2013-03-05 Thread Steve Singer
On 13-03-03 08:13 PM, Josh Berkus wrote: This (creating the extensions) works fine for me on a Ubuntu 10.x system Now if only we can work out the combinatorics issue ... The plpython2u extensions worked fine but I haven't been able to get this to work with plpython3u (python 3.1).

[HACKERS] pg_upgrade segfaults when given an invalid PGSERVICE value

2013-03-18 Thread Steve Singer
If you try running pg_upgrade with the PGSERVICE environment variable set to some invalid/non-existent service pg_upgrade segfaults Program received signal SIGSEGV, Segmentation fault. 0x0040bdd1 in check_pghost_envvar () at server.c:304 304 for (option = start;

Re: [HACKERS] pg_upgrade segfaults when given an invalid PGSERVICE value

2013-03-19 Thread Steve Singer
On 13-03-18 09:17 PM, Bruce Momjian wrote: On Mon, Mar 18, 2013 at 12:08:09PM -0400, Steve Singer wrote: If you try running pg_upgrade with the PGSERVICE environment variable set to some invalid/non-existent service pg_upgrade segfaults Program received signal SIGSEGV, Segmentation fault

Re: [HACKERS] pg_upgrade segfaults when given an invalid PGSERVICE value

2013-03-20 Thread Steve Singer
On 13-03-20 02:17 PM, Bruce Momjian wrote: On Wed, Mar 20, 2013 at 01:30:20PM -0400, Tom Lane wrote: While this surely isn't the nicest answer, it doesn't seem totally unreasonable to me. A bad service name indeed does not contribute anything to the set of defaults available. I think the

Re: [HACKERS] pg_upgrade segfaults when given an invalid PGSERVICE value

2013-03-25 Thread Steve Singer
On 13-03-20 05:54 PM, Tom Lane wrote: Steve Singer ssin...@ca.afilias.info writes: From a end-user expectations point of view I am okay with somehow marking the structure returned by PQconndefaults in a way that the connect calls will later fail. Unless the program changes the value

Re: [HACKERS] pg_upgrade segfaults when given an invalid PGSERVICE value

2013-03-28 Thread Steve Singer
On 13-03-26 12:40 AM, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: On Mon, Mar 25, 2013 at 07:07:42PM -0400, Tom Lane wrote: Well, plan B would be to invent a replacement function that does have the ability to return an error message, but that seems like a lot of work for a problem

Re: [HACKERS] Performance with the new security release?

2013-04-22 Thread Steve Singer
On 13-04-22 01:38 PM, Anne Rosset wrote: Hi, We are seeing some overall performance degradation in our application since we installed the security release. Other commits were also done at the same time in the application so we don't know yet if the degradation has any relationship with the

Re: [HACKERS] Performance with the new security release?

2013-04-22 Thread Steve Singer
this issue. I will dig into our logs to see for the query times. Thanks, Anne -Original Message- From: Steve Singer [mailto:st...@ssinger.info] Sent: Monday, April 22, 2013 12:59 PM To: Anne Rosset Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Performance with the new security

Re: [HACKERS] Performance with the new security release?

2013-04-22 Thread Steve Singer
and doing manual vacuums during those times. -Original Message- From: Steve Singer [mailto:st...@ssinger.info] Sent: Monday, April 22, 2013 1:26 PM To: Anne Rosset Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Performance with the new security release? On 13-04-22 04:15 PM, Anne

Re: [HACKERS] Performance with the new security release?

2013-04-23 Thread Steve Singer
but I haven't yet seen a patch. -Original Message- From: Steve Singer [mailto:st...@ssinger.info] Sent: Monday, April 22, 2013 4:35 PM To: Anne Rosset Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Performance with the new security release? On 13-04-22 04:41 PM, Anne Rosset

Re: [HACKERS] Performance with the new security release?

2013-04-23 Thread Steve Singer
really need to make sure). Thanks, Anne -Original Message- From: Steve Singer [mailto:st...@ssinger.info] Sent: Tuesday, April 23, 2013 6:33 AM To: Anne Rosset Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Performance with the new security release? On 13-04-22 11:46 PM, Anne

Re: [HACKERS] Re: [GENERAL] pg_upgrade fails, mismatch of relation OID - 9.1.9 to 9.2.4

2013-05-13 Thread Steve Singer
On 05/11/2013 04:58 PM, Bruce Momjian wrote: On Fri, May 10, 2013 at 08:03:38PM -0400, Bruce Momjian wrote: OK, this verifies that the table had a lot of DDL churn. I have no idea how to pursue this further because I am unsure how we are going to replicate the operations performed on this

  1   2   3   >