Re: [HACKERS] EXPLAIN BUFFERS

2009-12-07 Thread Takahiro Itagaki
... (2) 96 characters - Blocks Shared:hit=2 ... (3) 82 characters - Blocks Shared:(hit=2 ... (4) 82 characters - Blocks (shared hit=2 ... BTW, I found text is a *bad* format because it requires much discussion ;) We have a little choice in XML, JSON and YAML formats. Regards, --- Takahiro

Re: [HACKERS] YAML Was: CommitFest status/management

2009-12-08 Thread Takahiro Itagaki
, but we use only the basic parts. The parts will not be changed. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] EXPLAIN BUFFERS

2009-12-08 Thread Takahiro Itagaki
=364) (never executed) Blocks: (shared hit=0 read=0 written=0) (local hit=0 read=0 written=0) (temp read=0 written=0) Total runtime: 22.546 ms (13 rows) Regards, --- Takahiro Itagaki NTT Open Source Software Center explain_buffers_20091209.patch Description: Binary data

Re: [HACKERS] pgbench: new feature allowing to launch shell commands

2009-12-08 Thread Takahiro Itagaki
are also included in the length, so snprintf(commandShell, SHELL_COMMAND_SIZE, ...) would be ok. (removed -1) Other parts look fine, except an empty tag replaceable/ in the documentation. Is it a typo? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing

Re: [HACKERS] ProcessUtility_hook

2009-12-09 Thread Takahiro Itagaki
() should be called before the hook. Am I missing something? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] ProcessUtility_hook

2009-12-09 Thread Takahiro Itagaki
, DELETE, or SELECT tags. We can retrieve the number of rows from INSERT, UPDATE, and DELETE tags, but cannot from SELECT tag because the tag doesn't contain row numbers and also EState-es_processed is unavailable for EXECUTE commands. Regards, --- Takahiro Itagaki NTT Open Source Software Center

Re: [HACKERS] Largeobject Access Controls (r2460)

2009-12-09 Thread Takahiro Itagaki
is used in some places instead of SELECT DISTINCT loid FROM pg_largeobject. They return the same result, but the former will be faster because we don't use DISTINCT. pg_dump will be slightly accelerated by the new query. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via

[HACKERS] random() in multi-threaded pgbench

2009-12-09 Thread Takahiro Itagaki
://www.kernel.org/doc/man-pages/online/pages/man3/random_r.3.html Should we replace random() to random_r()? Some configure test might be needed. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] pgbench: new feature allowing to launch shell commands

2009-12-10 Thread Takahiro Itagaki
, --- Takahiro Itagaki NTT Open Source Software Center pgbenchshell_20091210.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Largeobject Access Controls (r2460)

2009-12-10 Thread Takahiro Itagaki
. short desc: Enables backward compatibility in privilege checks on large objects long desc: When turned on, privilege checks on large objects are disabled. Are those descriptions appropriate? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list

Re: [HACKERS] EXPLAIN BUFFERS

2009-12-10 Thread Takahiro Itagaki
on pgbench_accounts a (cost=0.00..2890.00 rows=10 width=97) (actual time=0.038..22.912 rows=10 loops=1) Filter: (a.abalance = 0) Buffers: shared hit=672 read=968 Total runtime: 116.058 ms (13 rows) Regards, --- Takahiro Itagaki NTT Open Source Software Center

Re: [HACKERS] YAML Was: CommitFest status/management

2009-12-10 Thread Takahiro Itagaki
, per the attached. Anyone want to argue? +1 to the fix. Typical usage of explain functions will be: 1. ExplainInitState() 2. (setup ExplainState) 3. ExplainBeginOutput() 4. ExplainXXX() except ExplainQuery() 5. ExplainEndOutput() Regards, --- Takahiro Itagaki NTT Open Source

Re: [HACKERS] Largeobject Access Controls (r2460)

2009-12-10 Thread Takahiro Itagaki
, mainly around tab-completion support in psql. # This is my first commit :) Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Largeobject Access Controls (r2460)

2009-12-10 Thread Takahiro Itagaki
KaiGai Kohei kai...@ak.jp.nec.com wrote: Tom Lane wrote: Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: structnamepg_largeobject/structname should not be readable by the public, since the catalog contains data in large objects of all users. This is going

Re: [HACKERS] Largeobject Access Controls (r2460)

2009-12-10 Thread Takahiro Itagaki
, but cannot read contents of tables without privilege. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Largeobject Access Controls (r2460)

2009-12-10 Thread Takahiro Itagaki
and no corresponding rows in pg_largeobject? Do we have a method to delete all rows in pg_largeobject but leave some metadata? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Largeobject Access Controls (r2460)

2009-12-11 Thread Takahiro Itagaki
to delete all corresponding tuples like as: DELETE FROM pg_largeobject WHERE loid = {obj_desc-id} Regards, --- Takahiro Itagaki NTT Open Source Software Center pgsql-blob-priv-fix_v2.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Largeobject Access Controls (r2460)

2009-12-11 Thread Takahiro Itagaki
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: In addition of the patch, we also need to fix pg_restore with --clean option. I added DropBlobIfExists() in pg_backup_db.c. A revised patch attached. Please check further mistakes. ...and here is an additional fix for contrib modules

Re: [HACKERS] Largeobject Access Controls and pg_migrator

2009-12-13 Thread Takahiro Itagaki
(). In the regular operation, it shall never happen. I think the omission is a reasonable optimization. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] Largeobject Access Controls (r2460)

2009-12-13 Thread Takahiro Itagaki
have corresponding tuples in pg_largeobject even for zero-length large objects. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] EXPLAIN BUFFERS

2009-12-13 Thread Takahiro Itagaki
() had been changed to set es.analyze if either log_analyze or log_buffers was set. Thanks. It was my bug. Could you apply the patch? Or, may I do by myself? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] EXPLAIN BUFFERS

2009-12-13 Thread Takahiro Itagaki
into shared buffers before runs. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] EXPLAIN BUFFERS

2009-12-13 Thread Takahiro Itagaki
Tom Lane t...@sss.pgh.pa.us wrote: Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: Should I add countBufferUsage boolean arguments to all places doInstrument booleans are currently used? This requires several minor modifications of codes in many places. Pushing extra arguments

Re: [HACKERS] EXPLAIN BUFFERS

2009-12-13 Thread Takahiro Itagaki
..580.642 rows=1000 loops=1) Buffers: shared hit=163935 Total runtime: 955.744 ms Regards, --- Takahiro Itagaki NTT Open Source Software Center explain_buffers_20091214.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Range types

2009-12-14 Thread Takahiro Itagaki
approach does not require additinal catalogs and syntax changes. It can be possible even on 8.4. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

[HACKERS] Crash on pg_ctl initdb without options

2009-12-14 Thread Takahiro Itagaki
, initdb, initdb (PostgreSQL) PG_VERSION \n); + if (pgdata_opt == NULL) + pgdata_opt = ; + if (post_opts == NULL) post_opts = ; Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] pgbench: new feature allowing to launch shell commands

2009-12-14 Thread Takahiro Itagaki
to avoid overhead. In normal workload, variables with the same names are re-used repeatedly. I don't think the additinal check would decrease performance of pgbench. Regards, --- Takahiro Itagaki NTT Open Source Software Center pgbenchshell_20091215.patch Description: Binary data

[HACKERS] New VACUUM FULL still needed?

2009-12-14 Thread Takahiro Itagaki
want to see HS. BTW, New VACUUM FULL patch is waiting for being applied. https://commitfest.postgresql.org/action/patch_view?id=202 But I heard HS is attempting to modify VFI in another way or remove it completely. Do we still need the patch, or reject it and fix VFI in HS? Regards, --- Takahiro

Re: [HACKERS] pgbench: new feature allowing to launch shell commands

2009-12-14 Thread Takahiro Itagaki
committing that one, and maybe we look at this whole variable name handling improvement as a separate patch later if you think it's worth pursuing? It's fine idea. I'll commit the previous lite version, and discuss whether we need the difference patch for fool proof. Regards, --- Takahiro Itagaki NTT

Re: [HACKERS] New VACUUM FULL

2009-12-15 Thread Takahiro Itagaki
, something like vacuumdb -f --threshold=some baseline might be useful for users running daily vacuumdb -f. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Largeobject Access Controls (r2460)

2009-12-16 Thread Takahiro Itagaki
. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Largeobject Access Controls (r2460)

2009-12-17 Thread Takahiro Itagaki
objects), gettext_noop(When turned on, privilege checks on large objects perform with backward compatibility as 8.4.x or earlier releases.) Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Largeobject Access Controls (r2460)

2009-12-17 Thread Takahiro Itagaki
it dumpBlobMetadata() or so? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Buffer statistics for pg_stat_statements

2009-12-18 Thread Takahiro Itagaki
commit fest. Comments welcome. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] LIKE INCLUDING COMMENTS code is a flight of fancy

2009-12-21 Thread Takahiro Itagaki
and composite type columns http://archives.postgresql.org/pgsql-hackers/2009-03/msg00931.php (XXX: Comments on composite type columns can work now?) Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Buffer statistics for pg_stat_statements

2009-12-22 Thread Takahiro Itagaki
Cedric Villemain cedric.villem...@dalibo.com wrote: Le vendredi 18 decembre 2009 09:44:40, Takahiro Itagaki a ecrit : I'd like to add per-query buffer usage into contrib/pg_stat_statements. Here is a patch to add buffer usage columns into pg_stat_statements. It also changes initialzation

Re: [HACKERS] New VACUUM FULL

2009-12-22 Thread Takahiro Itagaki
messages for VACUUM VERBOSE (and CLUSTER VERBOSE), though it might be adjusted in another patch. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] New VACUUM FULL

2009-12-22 Thread Takahiro Itagaki
the ALTER TABLE idea is not so bad because it does _not_ support database-wide maintenance. REWRITE is not the best maintenance in normal cases because a database should contain some rarely-updated tables. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers

[HACKERS] Verifying variable names in pgbench

2009-12-27 Thread Takahiro Itagaki
. $ pgbench -D var:name=value (global): invalid variable name 'var:name' It would help users to determine why their custom scripts failed when they misuse \setXXX :varname (the colon should be removed). Regards, --- Takahiro Itagaki NTT Open Source Software Center

Re: [HACKERS] Verifying variable names in pgbench

2010-01-03 Thread Takahiro Itagaki
function, like isLegalVariableName(). 3. In the department of nitpicking, I believe that the for loop test should be written as something like name[i] != '\0' rather than just name[i], for clarity. Adjusted. Regards, --- Takahiro Itagaki NTT Open Source Software Center

Re: [HACKERS] pg_read_file() and non-ascii input file

2010-01-03 Thread Takahiro Itagaki
'invalid.txt'; -- server-side copy from a local file. (the same message -- but the encoding should match with server_encoding) Regards, --- Takahiro Itagaki NTT Open Source Software Center pg_read_file_20100104.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] New VACUUM FULL

2010-01-03 Thread Takahiro Itagaki
(pg_database.datclsssnode, datprocnode etc.) What approach would be better? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] Buffer statistics for pg_stat_statements

2010-01-03 Thread Takahiro Itagaki
counters */, all the lines go past 80 columns. I wonder if it would be better to insert a line break just after the equals sign and indent the next line by an extra tab stop. See, e.g. src/backend/commands/user.c line 338. Ok, I'll adjust them so. Regards, --- Takahiro Itagaki NTT Open Source

Re: [HACKERS] Verifying variable names in pgbench

2010-01-04 Thread Takahiro Itagaki
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: We can remove the complexity if we give up showing the command (arg0) in error messages. Shall we remove it? Simplified patch attached. Here is the proposal for the arg0 issue. I added context argument to putVariable(). The context

Re: [HACKERS] Verifying variable names in pgbench

2010-01-04 Thread Takahiro Itagaki
, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] New VACUUM FULL

2010-01-05 Thread Takahiro Itagaki
because VACUUM FULL VERBOSE is less verbose than VFI VERBOSE for now. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Type modifiers for DOMAIN

2010-01-05 Thread Takahiro Itagaki
? This feature would be useful for migration from other DBMSes that have non-standard data types. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] Type modifiers for DOMAIN

2010-01-06 Thread Takahiro Itagaki
(VALUE ~ E'^\\d*$'); =# CREATE TABLE tbl (digit10 digit_varchar(10)); Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Bug with PATHs having non-ASCII characters

2010-01-06 Thread Takahiro Itagaki
for paths under $PGDATA because we only use ascii names in the server. I used a test with IS_HIGHBIT_SET in the attached patch, but I'm not sure whether it is the best method. Regards, --- Takahiro Itagaki NTT Open Source Software Center pgwin32_open.patch Description: Binary data

Re: [HACKERS] Buffer statistics for pg_stat_statements

2010-01-07 Thread Takahiro Itagaki
of the variables to adjust other fields. Are those changes ok? Regards, --- Takahiro Itagaki NTT Open Source Software Center pg_stat_statements_bufusage_20100107.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Buffer statistics for pg_stat_statements

2010-01-07 Thread Takahiro Itagaki
ahead and commit it. Thanks for your review. I committed it. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] new full vacuum doesn't work

2010-01-08 Thread Takahiro Itagaki
free_percent | 1.37 Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] new full vacuum doesn't work

2010-01-08 Thread Takahiro Itagaki
~ Pgbench sets the table's fillfactor to 10. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Fix for memory leak in dblink

2010-01-11 Thread Takahiro Itagaki
to return tuples for code refactoring. [1] http://archives.postgresql.org/pgsql-hackers/2009-06/msg01358.php [2] http://archives.postgresql.org/pgsql-hackers/2009-10/msg00292.php Regards, --- Takahiro Itagaki NTT Open Source Software Center dblink-memleak_20100112.patch Description: Binary data

[HACKERS] Pretty printed trigger in psql

2010-01-12 Thread Takahiro Itagaki
pg_get_triggerdef(pretty = true) in any programs, including pg_dump. Is this change ok? Regards, --- Takahiro Itagaki NTT Open Source Software Center pretty-printed-trigger_20100112.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] plpgsql: open for execute - add USING clause

2010-01-12 Thread Takahiro Itagaki
of read_sql_construct() in gram.y? It could simplify the code a bit. - I'd prefer to change the new argument for exec_dynquery_with_params() from char *portalname to const char *curname. Other than the above minor issues, this patch is ready to commit. Regards, --- Takahiro Itagaki NTT Open

Re: [HACKERS] NOT NULL violation and error-message

2010-01-12 Thread Takahiro Itagaki
), NameStr(rel-rd_att-attrs[attrChk - 1]-attname; } } Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] plpgsql: open for execute - add USING clause

2010-01-13 Thread Takahiro Itagaki
? Or, should we adjust them to use one of the formats? [pl_funcs.c] dump_dynexecute() dump_raise() printf(parameter %d: , i++); dump_dynfors() dump_open() dump_return_query() printf(parameter $%d: , i++); Regards, --- Takahiro Itagaki NTT

Re: [HACKERS] improving log management

2010-01-13 Thread Takahiro Itagaki
://wiki.postgresql.org/wiki/Logging_Brainstorm Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Pretty printed trigger in psql

2010-01-13 Thread Takahiro Itagaki
Tom Lane t...@sss.pgh.pa.us wrote: Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: The attached patch eliminates unneeded parentheses by using pg_get_triggerdef(pretty = true) in psql. Is this patch reversed? It seems so but the listed file timestamps don't match that idea

Re: [SPAM][HACKERS] Mammoth in Core?

2010-01-18 Thread Takahiro Itagaki
patch into several independent features, and submit them separately. It is much better if some of them can be shared by other replication projects. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Pretty printed trigger in psql

2010-01-18 Thread Takahiro Itagaki
patch is rebased to current CVS. Regards, --- Takahiro Itagaki NTT Open Source Software Center pretty-printed-trigger_20100119.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] Fix auto-prepare #2

2010-01-18 Thread Takahiro Itagaki
of ecpg_strdup() in ecpg_auto_prepare(). Prepared stetements also might leak in a error path. I tryd to fix both of them in the attached 6-pg85-fix-auto-prepare-multiconn-3.patch, but please recheck the issues. Regards, --- Takahiro Itagaki NTT Open Source Software Center 6-pg85-fix-auto

Re: [HACKERS] Fix auto-prepare #2

2010-01-20 Thread Takahiro Itagaki
it be const char * ? If the argument has a const, callers assume that they can pass a not-strdup'ed string as the argument. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-01-20 Thread Takahiro Itagaki
in BlobsInfo. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] About Our CLUSTER implementation is pessimal patch

2010-01-21 Thread Takahiro Itagaki
-path for tables clustered on a gist index? * I'd prefer to separate cost calculation routines from create_index_path() and cost_sort(), rather than using a dummy planner. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-01-21 Thread Takahiro Itagaki
by database user. Ah, I see. Then... What happen if we drop or rename roles who have large objects during pg_dump? Does the patch still work? It uses pg_get_userbyid(). Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] About Our CLUSTER implementation is pessimal patch

2010-01-21 Thread Takahiro Itagaki
. It would be better if planner module exports a cost estimate function for cluster. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] Partitioning syntax

2010-01-21 Thread Takahiro Itagaki
Robert Haas robertmh...@gmail.com wrote: people get bogged down and don't have time to finish the work. Ok, I moved this patch to the next commit fest for 9.1 alpha 1. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers

[HACKERS] Syntax supplements for SET options

2010-01-24 Thread Takahiro Itagaki
it if needed. The 3rd is relatively hard to fix because we need to adjust the syntax all of the kinds of columns options - STATISTICS, STORAGE, and generic options - without keywords confliction. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] Mammoth in Core?

2010-01-24 Thread Takahiro Itagaki
, the exported features would better to be stable enough and shared by several third-party tools. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] Mammoth in Core?

2010-01-24 Thread Takahiro Itagaki
personal goal, I think pgpool should be re-implemented on the layers of SQL/MED FDW or planner/executor hooks. I'd say the SQL/MED FDW apporach is one by one into core (from projects), and the hook apporach is external API (from core). Regards, --- Takahiro Itagaki NTT Open Source Software Center

Re: [HACKERS] Syntax supplements for SET options

2010-01-25 Thread Takahiro Itagaki
Robert Haas robertmh...@gmail.com wrote: With respect to tab completion, ALTER TABLESPACE x currently completes with only OWNER TO or RENAME TO; we need to add SET to that list. My bad. Ok, I'll go for it. I see non-tab-completion parts are too late for 9.0. Regards, --- Takahiro Itagaki

Re: [HACKERS] Review: listagg aggregate

2010-01-27 Thread Takahiro Itagaki
? They are almost internal names, but we could have more like string_agg_with_sep_transfn. Comments? Regards, --- Takahiro Itagaki NTT Open Source Software Center string_agg_20100128.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Review: listagg aggregate

2010-01-28 Thread Takahiro Itagaki
Pavel Stehule pavel.steh...@gmail.com wrote: 2010/1/28 Pavel Stehule pavel.steh...@gmail.com: 2010/1/28 David E. Wheeler da...@kineticode.com: On Jan 27, 2010, at 6:47 PM, Takahiro Itagaki wrote: * I think we cannot cache the delimiter at the first call. For example, SELECT

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-01-28 Thread Takahiro Itagaki
LARGEOBJECT (without a space) in user-visible messages, right? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-01-28 Thread Takahiro Itagaki
. Committed. Thanks. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] 64-bit size pgbench

2010-01-28 Thread Takahiro Itagaki
during dataload? It would be too verbose for large scale factor. I think a message every 1% is reasonable. if (j % 1 == 0) fprintf(stderr, INT64_FORMAT tuples done.\n, j); Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Review: listagg aggregate

2010-01-31 Thread Takahiro Itagaki
in bootstrap; it complains about duplicated function names. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-01-31 Thread Takahiro Itagaki
even if default or data-only Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-02-01 Thread Takahiro Itagaki
for normal tables? We should treat LO metadata as same as row-based ACLs. In my opinion, I'd like to treat them as part of data (not of schema). Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] New VACUUM FULL crashes on temp relations

2010-02-01 Thread Takahiro Itagaki
pattern drop table if exists footemp; create temp table footemp (col1 serial, col2 text); create index footemp_col1_idx on footemp (col1); cluster footemp using footemp_col1_idx; Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] New VACUUM FULL crashes on temp relations

2010-02-01 Thread Takahiro Itagaki
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: TRAP: FailedAssertion(!(typeNamespace == typ-typnamespace), File: pg_type.c, Line: 658) It comes from swapping toast relations: DEBUG: typeNamespace mismatch: 99 (pg_toast) vs. 16386 (pg_toast_temp_2) AFAICS, the assertion is broken

Re: [HACKERS] Review of Writeable CTE Patch

2010-02-03 Thread Takahiro Itagaki
; ERROR: syntax error at or near UNION * The patch includes regression tests, but no error cases in it. More test cases are needed for stupid queries. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] Re: [BUGS] BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION

2010-02-04 Thread Takahiro Itagaki
, i.e, 1/256 of the time.) Should it return the *next* reasonable log filename instead of FF? For example, 00020020 for the above case. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-02-04 Thread Takahiro Itagaki
. Is it really what you suggested, isn't it? I wonder we still need to have both BLOB ITEM and BLOB DATA even if we will take the all-or-nothing behavior. Can we handle BLOB's owner, acl, comment and data with one entry kind? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via

Re: [HACKERS] Writeable CTEs patch

2010-02-04 Thread Takahiro Itagaki
? + /para Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-02-09 Thread Takahiro Itagaki
, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] psql tab completion for DO blocks

2010-02-09 Thread Takahiro Itagaki
an additional Query_for_list_of_languages after LANGUAGE. BTW, I'm working on psql tab-completion adjustment for new syntax in 9.0. I'll send it soon. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

[HACKERS] psql tab-completion for new syntax

2010-02-09 Thread Takahiro Itagaki
with events The fix is not a stopper to alpha release, but I'd like to add it before beta release. Comments welcome. Regards, --- Takahiro Itagaki NTT Open Source Software Center psql-tab-completion_20100210.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-02-09 Thread Takahiro Itagaki
, binfo-dobj.name); And, I also noticed that lo_create() was not prefixed by pg_catalog., so I also add it. Thanks. Now the patch is ready to commit. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

[HACKERS] TRUNCATE+COPY optimization and --jobs=1 in pg_restore

2010-02-09 Thread Takahiro Itagaki
: ), fmtId(te-tag)); } Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] TRUNCATE+COPY optimization and --jobs=1 in pg_restore

2010-02-09 Thread Takahiro Itagaki
Tom Lane t...@sss.pgh.pa.us wrote: Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: We have an optimization to bulkload date in pg_restore, but the code only works in parallel restore (--jobs = 2). Why don't we do the same optimization in the serial restore (--jobs = 1

Re: [HACKERS] TRUNCATE+COPY optimization and --jobs=1 in pg_restore

2010-02-09 Thread Takahiro Itagaki
restore ignores errors, but it might make database inconsistent state. So, we'd better keep --single-transaction option to support all-or-nothing restore. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

[HACKERS] pg_restore --single-transaction and --clean

2010-02-09 Thread Takahiro Itagaki
IF EXISTS for cleanup commands in pg_restore? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] psql tab completion for DO blocks

2010-02-11 Thread Takahiro Itagaki
/sql-do.html Should we fix the documentation when we add the tab completion? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] psql tab completion for DO blocks

2010-02-14 Thread Takahiro Itagaki
David Fetter da...@fetter.org wrote: DO { [ LANGUAGE lang_name ] | code } ... Good catch :) The tab completion patch and documentation fix were committed. Thanks. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] [COMMITTERS] pgsql: Add psql tab completion for DO blocks.

2010-02-15 Thread Takahiro Itagaki
Tom Lane t...@sss.pgh.pa.us wrote: itag...@postgresql.org (Takahiro Itagaki) writes: This syntax synopsis is completely nuts: DO { [ LANGUAGE lang_name ] | code } ... I think that it would be logically correct without the square brackets, Oops, that's correct. but as a matter of clarity

Re: [HACKERS] ToDo: preload for fulltext dictionary

2010-02-15 Thread Takahiro Itagaki
dividing some MB of buffers will not be problem. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] psql tab-completion for new syntax

2010-02-15 Thread Takahiro Itagaki
USING BTREE TAB abalance aid bid filler= wrong, should be ( I adjusted previous_word() to split words not only with spaces but also with non-alphabets, and removed a hack with find_open_parenthesis(). Comments? Regards, --- Takahiro Itagaki NTT Open Source Software Center

  1   2   3   >