Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-24 Thread Vladimir Rusinov
t could also be done if there's desire for this. I'd like to have most user-visible changed checked in earlier. Stuff like internal refactoring can be done pretty much at any point in development cycle. -- Vladimir Rusinov Storage SRE, Google Ireland Google Ireland Ltd.,Gordon House, Barrow Stre

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-30 Thread Vladimir Rusinov
her things as well. -- Vladimir Rusinov Storage SRE, Google Ireland Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland Registered in Dublin, Ireland Registration Number: 368047 smime.p7s Description: S/MIME Cryptographic Signature

Re: [HACKERS] WIP: About CMake v2

2017-02-12 Thread Vladimir Rusinov
adable and writable and generally easy to debug. I'm not bold enough to propose PostgreSQL to use it, but I'd be happy to see ideas from it to be used elsewhere. -- Vladimir Rusinov Storage SRE, Google Ireland Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland Registered in Dublin,

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-18 Thread Vladimir Rusinov
it's trivial to work-around (symlinks, shell scripts, etc) and not so trivial to implement in a portable way. I'm used to workflows with lots of small commits, so I was not able to force myself to include all of the renames in one diff. -- Vladimir Rusinov Storage SRE, Google Ireland Google Irel

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-18 Thread Vladimir Rusinov
On Wed, Jan 18, 2017 at 12:28 PM, Michael Paquier <michael.paqu...@gmail.com > wrote: > On Wed, Jan 18, 2017 at 8:15 PM, Vladimir Rusinov <vrusi...@google.com> > wrote: > > On the topic of binaries, there's going to be another patch renaming > them. > > Those wil

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2016-12-14 Thread Vladimir Rusinov
On Wed, Dec 14, 2016 at 4:07 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 12/13/16 12:47 PM, Vladimir Rusinov wrote: > > Based on discussion in > > https://www.postgresql.org/message-id/CAE1wr-w% > 3DLE1cK5uG_rmAh-VBxc4_Bnw-gAE3qSqL-%3Dt

[HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2016-12-13 Thread Vladimir Rusinov
Based on discussion in https://www.postgresql.org/message-id/CAE1wr-w%3DLE1cK5uG_rmAh-VBxc4_Bnw-gAE3qSqL-%3DtWwvLvjQ%40mail.gmail.com . Tested via regression tests. To be applied in master only and to be included in 10.0. -- Vladimir Rusinov Storage SRE, Google Ireland Google Ireland Ltd

Re: [HACKERS] [PATCH] Remove trailing whitespaces from documentation

2016-12-14 Thread Vladimir Rusinov
sense to merge just these, as it will not help people with whitespace-eating editors. -- Vladimir Rusinov Storage SRE, Google Ireland Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland Registered in Dublin, Ireland Registration Number: 368047 smime.p7s Description: S/MIME Cryptographic Signature

Re: [HACKERS] [PATCH] Remove trailing whitespaces from documentation

2016-12-14 Thread Vladimir Rusinov
vior of psql and makes e.g. server tests depend not only server behavior but also on piece of irrelevant client-only code. I could imagine a test system that is both has more-or-less human-readable expected.out files and does not depend on exact decorations added by psql. -- Vladimir Rusinov Stora

Re: [HACKERS] Make pg_basebackup -x stream the default

2016-12-14 Thread Vladimir Rusinov
this a completely standalone backup. I suggest "method none" instead of "option none". I found the word "option" confusing in that sentence. -- Vladimir Rusinov Storage SRE, Google Ireland Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2016-12-15 Thread Vladimir Rusinov
> one > > huge patch submitted? > > Please yes. One change makes little sense. Ack. I was not sure what patch size is preferred here. Will continue with a patch in original thread later. Thanks for feedback! -- Vladimir Rusinov Storage SRE, Google Ireland Google Ireland Ltd.,G

Re: [HACKERS] [PATCH] Remove trailing whitespaces from documentation

2016-12-14 Thread Vladimir Rusinov
On Wed, Dec 14, 2016 at 4:50 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Vladimir Rusinov <vrusi...@google.com> writes: > > Therefore, I propose this patch. > > Right now is a really bad time to do that; what it will mostly accomplish > is to break back-patching o

Re: [HACKERS] [PATCH] Remove trailing whitespaces from documentation

2016-12-14 Thread Vladimir Rusinov
can handle trailing whitespaces in expected output files as a separate issue. One way to ease the pain is to remove trailing whitespaces in all supported branches via separate patches. -- Vladimir Rusinov Storage SRE, Google Ireland Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Irelan

[HACKERS] [PATCH] Remove trailing whitespaces from documentation

2016-12-14 Thread Vladimir Rusinov
They are considered bad practice in many style guides and many editors configured to stip them on every save. Such editors will produce spurious diffs when editing the documentation. Therefore, I propose this patch. -- Vladimir Rusinov Storage SRE, Google Ireland Google Ireland Ltd.,Gordon

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-11 Thread Vladimir Rusinov
as well. > As there are two school of thoughts on this thread, keeping your patch > with the compatibility table is the best move for now. Even if we end > up by having a version without aliases, that will be just code to > remove in the final version. > Indeed, it is trivial to kill aliases. New ve

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-12 Thread Vladimir Rusinov
down the thread: - no aliases: Stephen, Tom, David F, Vik, Bruce M, David Steele, Robert Haas => 7 - yes to aliases: Michael P, Andres, Peter E., Cynthia S, Jim N, Vladimir, Simon R => 7 - avoid renaming altogether: Fujii-san => 1 Duh. Folks, you are not making it easy. :) Looks like we ne

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-12 Thread Vladimir Rusinov
nd we add even more maintenance burden than just keeping aliases. -- Vladimir Rusinov Storage SRE, Google Ireland Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland Registered in Dublin, Ireland Registration Number: 368047 smime.p7s Description: S/MIME Cryptographic Signature

Re: [HACKERS] s/xlog/wal/ in tools and function names?

2016-12-02 Thread Vladimir Rusinov
On Fri, Dec 2, 2016 at 2:02 AM Michael Paquier <michael.paqu...@gmail.com> wrote: > On Fri, Dec 2, 2016 at 3:21 AM, Robert Haas <robertmh...@gmail.com> wrote: > > On Thu, Dec 1, 2016 at 10:29 AM, Vladimir Rusinov <vrusi...@google.com> > wrote: > >> I've f

Re: [HACKERS] pg_xlogdump follow into the future

2016-12-01 Thread Vladimir Rusinov
= LGTM Architecture review == n/a -- Vladimir Rusinov Bigtable SRE Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland Registered in Dublin, Ireland Registration Number: 368047 On Mon, Oct 3, 2016 at 5:44 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > O

[HACKERS] s/xlog/wal/ in tools and function names?

2016-12-01 Thread Vladimir Rusinov
ecievexlog to pg_revievewal (and others in bin/)? - rename pg_xlogdump to pg_waldump? - if we do rename, should we keep aliases for functions and symlinks for tools? - anything else? -- Vladimir Rusinov Storage SRE, Google Ireland Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland

Re: [HACKERS] s/xlog/wal/ in tools and function names?

2016-12-02 Thread Vladimir Rusinov
On Fri, Dec 2, 2016 at 1:59 PM Michael Paquier <michael.paqu...@gmail.com> wrote: > On Fri, Dec 2, 2016 at 8:28 PM, Vladimir Rusinov <vrusi...@google.com> > wrote: > > I guess it would make sense to do all of it in 10.0. > > I'm new here, so not very sure about

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-03 Thread Vladimir Rusinov
in 11.0. This way we are nicer to people who maintain their tools and read release notes via giving them more time, and nicer to ourselves via cleaning legacy stuff relatively soon. -- Vladimir Rusinov Storage SRE, Google Ireland Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4,

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-03 Thread Vladimir Rusinov
ing providers) and ask them to migrate to new function names. This is of course will not fix everything, but it would be a significant chunk. I suspect a lot of private tools/scripts borrow snippets from github as well. -- Vladimir Rusinov Storage SRE, Google Ireland Google Ireland Ltd.,Gordon Hou

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-05 Thread Vladimir Rusinov
'recovery' instead of 'xlog_replay' and used 'wal_file' instead of 'xlogfile'. Does it make sense? - Release notes. I was unable to find a draft for 10.0. How do I make sure these renames are not forgotten? -- Vladimir Rusinov Storage SRE, Google Ireland Google Ireland Ltd.,Gordon House, Barrow Street

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-09 Thread Vladimir Rusinov
ay_location| pg_last_wal_replay_location pg_switch_xlog | pg_switch_wal pg_xlog_location_diff | pg_wal_location_diff pg_xlog_replay_pause| pg_wal_replay_pause pg_xlog_replay_resume | pg_wal_replay_resume pg_xlogfile_name | pg_wal_file_n

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-09 Thread Vladimir Rusinov
pg_xlogfile_name_offset | pg_wal_file_name_offset -- Vladimir Rusinov Storage SRE, Google Ireland Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland Registered in Dublin, Ireland Registration Number: 368047 diff --git a/contrib/bloom/t/001_wal.pl b/contrib/bloom/t/001_wal.pl index 56c66

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2016-12-30 Thread Vladimir Rusinov
r it is worth maintaining function aliases. Assuming these are indeed trivial (can somebody point me to example?) I see roughly the same amount of downsides both ways. Having aliases raises additional questions: - do we keep them documented (probably not?) - do we keep them forever or kill in some fut

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2016-12-30 Thread Vladimir Rusinov
On Thu, Dec 29, 2016 at 5:59 PM, Stephen Frost <sfr...@snowman.net> wrote: > I have a pretty strong > feeling about this particular change being worthwhile and also pretty > long overdue. > Yeah, sorry for that. I should be able to make some progress early January. -- Vladim

Re: [HACKERS] Make pg_basebackup -x stream the default

2016-12-19 Thread Vladimir Rusinov
cleanly at head with all tests pass. I have no further comments, although since I'm not experienced Postgres reviewer, commiter may want to take another look before merging. -- Vladimir Rusinov Storage SRE, Google Ireland Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland Regis

Re: [HACKERS] Funny WAL corruption issue

2017-08-10 Thread Vladimir Rusinov
by checksums. I am not familiar with WAL protocol - do we have enough checksums when writing it out and on the wire? I suspect there are much more things PostgreSQL can do to be more resilient, and at least detect corruptions earlier. -- Vladimir Rusinov PostgreSQL SRE, Google Ireland Google Ireland