Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-02-01 Thread Michael Paquier
On Wed, Jan 29, 2014 at 3:03 AM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jan 28, 2014 at 3:42 AM, Fujii Masao masao.fu...@gmail.com wrote: On Sat, Jan 25, 2014 at 3:19 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Sat, Jan 25, 2014 at 5:41 AM, Fujii Masao

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-02-01 Thread Fujii Masao
On Sat, Feb 1, 2014 at 9:32 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Jan 29, 2014 at 3:03 AM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jan 28, 2014 at 3:42 AM, Fujii Masao masao.fu...@gmail.com wrote: On Sat, Jan 25, 2014 at 3:19 PM, Michael Paquier

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-02-01 Thread Gabriele Bartolini
Hi Michael and Fujii, Il 01/02/14 17:46, Fujii Masao ha scritto: I think that it's OK to add that as TODO item. There might be the system that the speed of WAL archiving is slower than that of WAL generation, at peak time. The DBA of that system might want to monitor the size of archive

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-02-01 Thread Michael Paquier
On Sun, Feb 2, 2014 at 2:43 AM, Gabriele Bartolini gabriele.bartol...@2ndquadrant.it wrote: Hi Michael and Fujii, Il 01/02/14 17:46, Fujii Masao ha scritto: I think that it's OK to add that as TODO item. There might be the system that the speed of WAL archiving is slower than that of WAL

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-30 Thread Fujii Masao
On Wed, Jan 29, 2014 at 12:35 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Jan 29, 2014 at 10:55 AM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Jan 29, 2014 at 3:07 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Anybody knows about this patch?

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-29 Thread Michael Paquier
On Sat, Jan 25, 2014 at 5:41 AM, Fujii Masao masao.fu...@gmail.com wrote: I think that it's time to rename all the variables related to pg_stat_bgwriter. For example, it's better to change PgStat_GlobalStats to PgStat_Bgwriter. I think that it's okay to make this change as separate patch,

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-29 Thread Michael Paquier
On Wed, Jan 29, 2014 at 10:38 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Sat, Jan 25, 2014 at 5:41 AM, Fujii Masao masao.fu...@gmail.com wrote: I think that it's time to rename all the variables related to pg_stat_bgwriter. For example, it's better to change PgStat_GlobalStats to

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-28 Thread Fujii Masao
On Tue, Jan 28, 2014 at 3:42 AM, Fujii Masao masao.fu...@gmail.com wrote: On Sat, Jan 25, 2014 at 3:19 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Sat, Jan 25, 2014 at 5:41 AM, Fujii Masao masao.fu...@gmail.com wrote: On Thu, Jan 23, 2014 at 4:10 PM, Michael Paquier

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-28 Thread Alvaro Herrera
Anybody knows about this patch? http://www.postgresql.org/message-id/508dfec9.4020...@uptime.jp -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-28 Thread Michael Paquier
On Wed, Jan 29, 2014 at 3:03 AM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jan 28, 2014 at 3:42 AM, Fujii Masao masao.fu...@gmail.com wrote: On Sat, Jan 25, 2014 at 3:19 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Sat, Jan 25, 2014 at 5:41 AM, Fujii Masao

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-28 Thread Fujii Masao
On Wed, Jan 29, 2014 at 3:07 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Anybody knows about this patch? http://www.postgresql.org/message-id/508dfec9.4020...@uptime.jp Though I'm not sure whether Nagayasu is still working on that patch, it's worth thinking to introduce that together

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-28 Thread Michael Paquier
On Wed, Jan 29, 2014 at 10:55 AM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Jan 29, 2014 at 3:07 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Anybody knows about this patch? http://www.postgresql.org/message-id/508dfec9.4020...@uptime.jp Though I'm not sure whether Nagayasu is

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-27 Thread Fujii Masao
On Sat, Jan 25, 2014 at 3:19 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Sat, Jan 25, 2014 at 5:41 AM, Fujii Masao masao.fu...@gmail.com wrote: On Thu, Jan 23, 2014 at 4:10 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Jan 9, 2014 at 6:36 AM, Gabriele Bartolini

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-26 Thread Michael Paquier
On Sat, Jan 25, 2014 at 3:19 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Sat, Jan 25, 2014 at 5:41 AM, Fujii Masao masao.fu...@gmail.com wrote: On Thu, Jan 23, 2014 at 4:10 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Jan 9, 2014 at 6:36 AM, Gabriele Bartolini

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-24 Thread Fujii Masao
On Thu, Jan 23, 2014 at 4:10 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Jan 9, 2014 at 6:36 AM, Gabriele Bartolini gabriele.bartol...@2ndquadrant.it wrote: Il 08/01/14 18:42, Simon Riggs ha scritto: Not sure I see why it needs to be an SRF. It only returns one row. Attached

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-24 Thread Michael Paquier
On Sat, Jan 25, 2014 at 5:41 AM, Fujii Masao masao.fu...@gmail.com wrote: On Thu, Jan 23, 2014 at 4:10 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Jan 9, 2014 at 6:36 AM, Gabriele Bartolini gabriele.bartol...@2ndquadrant.it wrote: Il 08/01/14 18:42, Simon Riggs ha scritto:

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-22 Thread Michael Paquier
On Thu, Jan 9, 2014 at 6:36 AM, Gabriele Bartolini gabriele.bartol...@2ndquadrant.it wrote: Il 08/01/14 18:42, Simon Riggs ha scritto: Not sure I see why it needs to be an SRF. It only returns one row. Attached is version 4, which removes management of SRF stages. I have been looking at v4 a

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-08 Thread Simon Riggs
On 4 January 2014 13:01, Gabriele Bartolini gabriele.bartol...@2ndquadrant.it wrote: I'd suggest making the view on top of an SRF like pg_stat_replication and pg_stat_activity (for example), instead of a whole lot of separate function calls like the older stats views. Ok, good idea. Not

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-08 Thread Magnus Hagander
On Wed, Jan 8, 2014 at 6:42 PM, Simon Riggs si...@2ndquadrant.com wrote: On 4 January 2014 13:01, Gabriele Bartolini gabriele.bartol...@2ndquadrant.it wrote: I'd suggest making the view on top of an SRF like pg_stat_replication and pg_stat_activity (for example), instead of a whole lot of

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-07 Thread Michael Paquier
On Mon, Jan 6, 2014 at 5:37 PM, Gabriele Bartolini gabriele.bartol...@2ndquadrant.it wrote: Hi Fabrizio, Il 05/01/14 20:46, Fabrizio Mello ha scritto: I don't see your code yet, but I would like to know if is possible to implement this view as an extension. I wanted to do it as an extension

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-06 Thread Gabriele Bartolini
Hi Fabrizio, Il 05/01/14 20:46, Fabrizio Mello ha scritto: I don't see your code yet, but I would like to know if is possible to implement this view as an extension. I wanted to do it as an extension - so that I could backport that to previous versions of Postgres. I do not think it is a

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-05 Thread Magnus Hagander
On Sat, Jan 4, 2014 at 2:01 PM, Gabriele Bartolini gabriele.bartol...@2ndquadrant.it wrote: Il 04/01/14 13:25, Magnus Hagander ha scritto: With those two, I think it would make much sense to have a view like this. Ok, I will prepare version 2 with those. Oh, and you need to change

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-05 Thread Gabriele Bartolini
Il 05/01/14 13:52, Magnus Hagander ha scritto: Yes, that's what I'm talking about. And just increment it by 1. Done. I am attaching version 2 of the patch, which now implements only one function (pg_stat_get_archiver()) and adds: * failed attempts * WAL of the last failed attempt * time of the

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-05 Thread Fabrizio Mello
Enviado via iPhone Em 05/01/2014, às 16:27, Gabriele Bartolini gabriele.bartol...@2ndquadrant.it escreveu: Il 05/01/14 13:52, Magnus Hagander ha scritto: Yes, that's what I'm talking about. And just increment it by 1. Done. I am attaching version 2 of the patch, which now implements only

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-04 Thread Magnus Hagander
On Sat, Jan 4, 2014 at 1:33 AM, Gabriele Bartolini gabriele.bartol...@2ndquadrant.it wrote: Hello, please find attached the patch that adds basic support for the pg_stat_archiver system view, which allows users that have continuous archiving procedures in place to keep track of some

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-04 Thread Gabriele Bartolini
Hi Magnus, Il 04/01/14 13:25, Magnus Hagander ha scritto: My first reaction was that exactly those two things were missing. And then I read your whole email :) :) With those two, I think it would make much sense to have a view like this. Ok, I will prepare version 2 with those. I'd

[HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-03 Thread Gabriele Bartolini
Hello, please find attached the patch that adds basic support for the pg_stat_archiver system view, which allows users that have continuous archiving procedures in place to keep track of some important metrics and information. Currently, pg_stat_archiver displays: * archived_wals: number of