Re: [HACKERS] \d+ for long view definitions?

2009-10-31 Thread Josh Berkus
diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c --- a/src/bin/psql/describe.c +++ b/src/bin/psql/describe.c @@ -1306,7 +1306,7 @@ describeOneTableDetails(const char *schemaname, printTableAddHeader(cont, headers[i], true, 'l'); /* Check if table is a view */ -

Re: [HACKERS] \d+ for long view definitions?

2009-10-29 Thread Peter Eisentraut
On tis, 2009-09-01 at 14:29 -0400, Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: I think we should always or never show the view definition, not sometimes. Yeah. I can live with \d not showing it and \d+ showing it --- as Peter already mentioned, that would be consistent with

Re: [HACKERS] \d+ for long view definitions?

2009-09-01 Thread Josh Berkus
On 8/31/09 1:13 PM, Peter Eisentraut wrote: I guess my premise is that if I use \d, I'm primarily interested in the column names and types. The view definition is secondary. If the view definition is a single line or uses a single table, it's interesting because it might describe something

Re: [HACKERS] \d+ for long view definitions?

2009-09-01 Thread Robert Haas
On Tue, Sep 1, 2009 at 1:31 PM, Josh Berkusj...@agliodbs.com wrote: On 8/31/09 1:13 PM, Peter Eisentraut wrote: I guess my premise is that if I use \d, I'm primarily interested in the column names and types.  The view definition is secondary.  If the view definition is a single line or uses a

Re: [HACKERS] \d+ for long view definitions?

2009-09-01 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: I think we should always or never show the view definition, not sometimes. Yeah. I can live with \d not showing it and \d+ showing it --- as Peter already mentioned, that would be consistent with \df behavior. Making it depend on the length is just

Re: [HACKERS] \d+ for long view definitions?

2009-09-01 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: I think we should always or never show the view definition, not sometimes. +1 And I also agree with Tom's point that we should fix the pager. The way that it works now is really annoying. +1 -Kevin -- Sent via pgsql-hackers mailing list

Re: [HACKERS] \d+ for long view definitions?

2009-09-01 Thread David Fetter
On Tue, Sep 01, 2009 at 02:29:12PM -0400, Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: I think we should always or never show the view definition, not sometimes. Yeah. I can live with \d not showing it and \d+ showing it --- as Peter already mentioned, that would be

Re: [HACKERS] \d+ for long view definitions?

2009-09-01 Thread Robert Haas
On Tue, Sep 1, 2009 at 3:01 PM, David Fetterda...@fetter.org wrote: On Tue, Sep 01, 2009 at 02:29:12PM -0400, Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: I think we should always or never show the view definition, not sometimes. Yeah.  I can live with \d not showing it and

Re: [HACKERS] \d+ for long view definitions?

2009-08-31 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On sön, 2009-08-30 at 18:43 -0400, Tom Lane wrote: Seems like a more general answer would be for \d output to go through the pager ... That should also be fixed, but I'm not sure if it really does it for me. Why not? Just quit out of the pager when

[HACKERS] \d+ for long view definitions?

2009-08-30 Thread Peter Eisentraut
Using \d on, say, information schema views is completely hilarious because the column name/data type information is usually scrolled off the screen by the immense view definition. Could we change this perhaps so that the full view definition is only shown with \d+ when the view definition is

Re: [HACKERS] \d+ for long view definitions?

2009-08-30 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: Using \d on, say, information schema views is completely hilarious because the column name/data type information is usually scrolled off the screen by the immense view definition. Could we change this perhaps so that the full view definition is only

Re: [HACKERS] \d+ for long view definitions?

2009-08-30 Thread Alvaro Herrera
Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: Using \d on, say, information schema views is completely hilarious because the column name/data type information is usually scrolled off the screen by the immense view definition. Could we change this perhaps so that the full view