Re: [HACKERS] Add value to error message when size extends

2014-01-20 Thread Tom Lane
Daniel Erez writes: > Many thanks for the prompt response and the suggestions! > So, regarding the issue of "production quality" you've mentioned, > we understand there are two remaining matters to address: > 1. debug_query_string: >As we can't rely on this flag, is there any alternative we c

Re: [HACKERS] Add value to error message when size extends

2014-01-20 Thread Daniel Erez
i Raudsepp" > Cc: "pgsql-hackers" , "Daniel Erez" > > Sent: Monday, January 20, 2014 2:32:57 AM > Subject: Re: [HACKERS] Add value to error message when size extends > > Hi Tom and Marti > Thank you so much for your respond. > > The solution To

Re: [HACKERS] Add value to error message when size extends

2014-01-19 Thread Maor Lipchuk
Hi Tom and Marti Thank you so much for your respond. The solution Tom proposed is much more better, and it will be a great solution for clarifying many issues regarding this error. Regards, Maor On 01/19/2014 10:00 PM, Tom Lane wrote: > Marti Raudsepp writes: >> On Sun, Jan 19, 2014 at 8:10 PM

Re: [HACKERS] Add value to error message when size extends

2014-01-19 Thread Tom Lane
Marti Raudsepp writes: > On Sun, Jan 19, 2014 at 8:10 PM, Tom Lane wrote: >> One thing that occurs to me just now is that perhaps we could report >> the failure as if it were a syntax error > That would be cool, if it can be made to work. Just as a five-minute proof-of-concept hack, attached is

Re: [HACKERS] Add value to error message when size extends

2014-01-19 Thread Tom Lane
Marti Raudsepp writes: > Agreed. But I think it would be useful to add the length of the string > being inserted; we already have it in the len variable. Hm, maybe, but I'm having a hard time visualizing cases in which it helps much. regards, tom lane -- Sent via pgsql

Re: [HACKERS] Add value to error message when size extends

2014-01-19 Thread Marti Raudsepp
On Sun, Jan 19, 2014 at 8:10 PM, Tom Lane wrote: > Complaining about a too-long varchar string in this style > seems practically guaranteed to violate that. Agreed. But I think it would be useful to add the length of the string being inserted; we already have it in the len variable. > One thing

Re: [HACKERS] Add value to error message when size extends

2014-01-19 Thread Tom Lane
Maor Lipchuk writes: > We have encountered an issue when executing an insert command, > when one of the values' length was bigger than the column size limitation. > the error message which been displayed was "value too long for type char..." > but there was no indication which value has exceeded

[HACKERS] Add value to error message when size extends

2014-01-19 Thread Maor Lipchuk
Hi all, We have encountered an issue when executing an insert command, when one of the values' length was bigger than the column size limitation. the error message which been displayed was "value too long for type char..." but there was no indication which value has exceeded the limited size. (Se