Re: [HACKERS] Adjusting index special storage for pg_filedump's convenience

2007-04-16 Thread Zdenek Kotala
Heikki Linnakangas wrote: That's a clever trick, but I can't help thinking we really should have an explicit field in the page header to indicate what kind of a page it is. It would make life simpler for any external tools that want to peek into pages, including migration utilities after a r

Re: [HACKERS] Adjusting index special storage for pg_filedump's convenience

2007-04-16 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > That's a clever trick, but I can't help thinking we really should have > an explicit field in the page header to indicate what kind of a page it > is. I think we should save the pd_flags field for cases where we really need it ...

Re: [HACKERS] Adjusting index special storage for pg_filedump's convenience

2007-04-16 Thread Heikki Linnakangas
Tom Lane wrote: Gavin Sherry <[EMAIL PROTECTED]> writes: On Mon, 9 Apr 2007, Tom Lane wrote: ... I don't see any way to make it completely bulletproof without enlarging the special space, which seems an unreasonable price to pay. But even one chance in 16K is way better than the current situat

Re: [HACKERS] Adjusting index special storage for pg_filedump's convenience

2007-04-09 Thread Tom Lane
Gavin Sherry <[EMAIL PROTECTED]> writes: > On Mon, 9 Apr 2007, Tom Lane wrote: >> ... I don't see any way to make it completely bulletproof >> without enlarging the special space, which seems an unreasonable price >> to pay. But even one chance in 16K is way better than the current >> situation.

Re: [HACKERS] Adjusting index special storage for pg_filedump's convenience

2007-04-09 Thread Gavin Sherry
On Mon, 9 Apr 2007, Tom Lane wrote: > We put in a workaround a long time ago to make it possible to tell the > difference between btree and hash special space, which are also the same > size: there's an unused 16 bits in hash special space that we fill with > a specific value. As of 8.2 this does

[HACKERS] Adjusting index special storage for pg_filedump's convenience

2007-04-09 Thread Tom Lane
Historically, pg_filedump http://sources.redhat.com/rhdb/utilities.html has relied on the size of a page's special space to determine which kind of index it is looking at (btree, hash, etc) so that it can dump the contents of the special space nicely. This is pretty ugly of course, but there isn't