Re: [HACKERS] Building pg_xlogdump reproducibly

2016-01-05 Thread Tom Lane
Christoph Berg writes: > Nod. Attached is a patch that covers all relevant $(wildcard) > occurrences in Makefiles for devel. Applied back to 9.3, which is as far as any of these cases exist. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgr

Re: [HACKERS] Building pg_xlogdump reproducibly

2016-01-05 Thread Tom Lane
Christoph Berg writes: > Re: Alvaro Herrera 2016-01-04 <20160104175623.GA170910@alvherre.pgsql> >> I don't see any other $(wildcard) used to build executables; it's used >> for tests and flags in many places, but that shouldn't matter. > Nod. Attached is a patch that covers all relevant $(wildcar

Re: [HACKERS] Building pg_xlogdump reproducibly

2016-01-05 Thread Christoph Berg
Re: Alvaro Herrera 2016-01-04 <20160104175623.GA170910@alvherre.pgsql> > > https://reproducible.debian.net/dbd/unstable/armhf/postgresql-9.4_9.4.5-2.diffoscope.html 9.5 was already tested as well, I just couldn't find the link yesterday: https://reproducible.debian.net/rb-pkg/experimental/armhf/p

Re: [HACKERS] Building pg_xlogdump reproducibly

2016-01-04 Thread Alvaro Herrera
Christoph Berg wrote: > Re: Andres Freund 2016-01-04 <20160104155125.gd28...@awork2.anarazel.de> > > That's probably not the only non-deterministic rule in postgres, given > > nobody paid attention tot that so far? At least transform modules added > > in 9.5 (hstore_plpython et al) look like they m

Re: [HACKERS] Building pg_xlogdump reproducibly

2016-01-04 Thread Christoph Berg
Re: Andres Freund 2016-01-04 <20160104155125.gd28...@awork2.anarazel.de> > That's probably not the only non-deterministic rule in postgres, given > nobody paid attention tot that so far? At least transform modules added > in 9.5 (hstore_plpython et al) look like they might similar issues. I was wo

Re: [HACKERS] Building pg_xlogdump reproducibly

2016-01-04 Thread David Fetter
On Mon, Jan 04, 2016 at 04:51:25PM +0100, Andres Freund wrote: > Hi, > > On 2016-01-04 15:59:46 +0100, Christoph Berg wrote: > > The list of objects used to link pg_xlogdump is coming from > > $(wildcard *desc.c) which returns them in filesystem order. This makes > > the build result depend on thi

Re: [HACKERS] Building pg_xlogdump reproducibly

2016-01-04 Thread Andres Freund
Hi, On 2016-01-04 15:59:46 +0100, Christoph Berg wrote: > The list of objects used to link pg_xlogdump is coming from > $(wildcard *desc.c) which returns them in filesystem order. This makes > the build result depend on this ordering, yielding different > compilation results. > -RMGRDESCSOURCES =

[HACKERS] Building pg_xlogdump reproducibly

2016-01-04 Thread Christoph Berg
The list of objects used to link pg_xlogdump is coming from $(wildcard *desc.c) which returns them in filesystem order. This makes the build result depend on this ordering, yielding different compilation results. This patch fixes the reproducibility issue: --- a/src/bin/pg_xlogdump/Makefile +++ b