Re: [HACKERS] DML and column cound in aggregated subqueries

2016-10-31 Thread Andres Freund
On 2016-10-31 09:35:57 -0400, Tom Lane wrote: > Andres Freund writes: > > this doesn't look right. The ctid shouldn't be in the aggregate output - > > after all it's pretty much meaningless here. > > I suspect it's being added to support EvalPlanQual row re-fetches. Hm, that doesn't seem particu

Re: [HACKERS] DML and column cound in aggregated subqueries

2016-10-31 Thread Tom Lane
Andres Freund writes: > this doesn't look right. The ctid shouldn't be in the aggregate output - > after all it's pretty much meaningless here. I suspect it's being added to support EvalPlanQual row re-fetches. > Casting a wider net: find_hash_columns() and it's subroutines seem like > pretty mu

[HACKERS] DML and column cound in aggregated subqueries

2016-10-31 Thread Andres Freund
Hi, while hacking up nodeAgg.c to use a dedicated slot/desc for the hashtable, an assert I placed brought up a weird case: regression[29535][1]=# EXPLAIN VERBOSE update bar set f2 = f2 + 100 where f1 in (select f1 from foo); ┌──