"Tom Lane" <[EMAIL PROTECTED]> writes:
> Gregory Stark <[EMAIL PROTECTED]> writes:
>> Testers here were having a hard time constructing test cases to reach some
>> lines touched by the varvarlena patch. Upon further investigation I'm
>> convinced they're unreachable.
>
> I'm not really happy with
Gregory Stark <[EMAIL PROTECTED]> writes:
> Testers here were having a hard time constructing test cases to reach some
> lines touched by the varvarlena patch. Upon further investigation I'm
> convinced they're unreachable.
I'm not really happy with any of this patch. ISTM that the stuff you
say
Sorry, meant to send the previous message to pgsql-patches.
Here's a version cut using cvs diff so it's usable with -p0
I added one more fixup. There was a silly test in toast_fetch_datum_slice()
which handled compressed datums. Returning a slice of a compressed datum is
nonsensical with toast s
Testers here were having a hard time constructing test cases to reach some
lines touched by the varvarlena patch. Upon further investigation I'm
convinced they're unreachable.
Some were added when I did packed varlena -- I've removed those. These lines
were actually necessary earlier but when we
