Re: [HACKERS] Equivalent of --enable-tap-tests in MSVC scripts

2016-03-04 Thread Michael Paquier
On Sat, Mar 5, 2016 at 1:16 AM, Craig Ringer wrote: > On 5 March 2016 at 00:10, Alvaro Herrera wrote: >> >> Craig Ringer wrote: >> >> > If it's the result of perltidy changing its mind about the formatting as >> > a >> > result of this change I

Re: [HACKERS] Equivalent of --enable-tap-tests in MSVC scripts

2016-03-04 Thread Craig Ringer
On 5 March 2016 at 00:10, Alvaro Herrera wrote: > Craig Ringer wrote: > > > If it's the result of perltidy changing its mind about the formatting as > a > > result of this change I guess we have to eyeroll and live with it. > perltidy > > leaves the file alone as it is

Re: [HACKERS] Equivalent of --enable-tap-tests in MSVC scripts

2016-03-04 Thread Alvaro Herrera
Craig Ringer wrote: > If it's the result of perltidy changing its mind about the formatting as a > result of this change I guess we have to eyeroll and live with it. perltidy > leaves the file alone as it is in the tree currently, so that be it. > > Gripe withdrawn, ready for committer IMO

Re: [HACKERS] Equivalent of --enable-tap-tests in MSVC scripts

2016-03-04 Thread Craig Ringer
On 2 March 2016 at 10:19, Michael Paquier wrote: > On Wed, Mar 2, 2016 at 12:40 AM, Andrew Dunstan > wrote: > > On 03/01/2016 08:00 AM, Michael Paquier wrote: > >> As of now the MSVC scripts control if TAP tests are enabled or not > >> using a

Re: [HACKERS] Equivalent of --enable-tap-tests in MSVC scripts

2016-03-01 Thread Michael Paquier
On Wed, Mar 2, 2016 at 12:40 AM, Andrew Dunstan wrote: > On 03/01/2016 08:00 AM, Michael Paquier wrote: >> As of now the MSVC scripts control if TAP tests are enabled or not >> using a boolean flag as $config->{tap_tests}. However, this flag is >> just taken into account in

Re: [HACKERS] Equivalent of --enable-tap-tests in MSVC scripts

2016-03-01 Thread Andrew Dunstan
On 03/01/2016 08:00 AM, Michael Paquier wrote: Hi all, As of now the MSVC scripts control if TAP tests are enabled or not using a boolean flag as $config->{tap_tests}. However, this flag is just taken into account in vcregress.pl, with the following issues: 1) config_default.pl does not list

Re: [HACKERS] Equivalent of --enable-tap-tests in MSVC scripts

2016-03-01 Thread Craig Ringer
On 1 March 2016 at 21:00, Michael Paquier wrote: > Hi all, > > As of now the MSVC scripts control if TAP tests are enabled or not > using a boolean flag as $config->{tap_tests}. However, this flag is > just taken into account in vcregress.pl, with the following issues:

[HACKERS] Equivalent of --enable-tap-tests in MSVC scripts

2016-03-01 Thread Michael Paquier
Hi all, As of now the MSVC scripts control if TAP tests are enabled or not using a boolean flag as $config->{tap_tests}. However, this flag is just taken into account in vcregress.pl, with the following issues: 1) config_default.pl does not list tap_tests, so it is unclear to users to enable