Re: [HACKERS] Existence check for suitable index in advance when concurrently refreshing.

2016-02-15 Thread Fujii Masao
On Wed, Feb 10, 2016 at 10:35 AM, Michael Paquier wrote: > On Wed, Feb 10, 2016 at 2:23 AM, Fujii Masao wrote: >> On Wed, Feb 10, 2016 at 2:21 AM, Fujii Masao wrote: >>> On Tue, Feb 9, 2016 at 9:11 PM, Michael Paquier >>>

Re: [HACKERS] Existence check for suitable index in advance when concurrently refreshing.

2016-02-09 Thread Michael Paquier
On Tue, Feb 9, 2016 at 4:27 PM, Fujii Masao wrote: > Thanks for updating the patch! > Attached is the updated version of the patch. > I removed unnecessary assertion check and change of source code > that you added, and improved the source comment. > Barring objection, I'll

Re: [HACKERS] Existence check for suitable index in advance when concurrently refreshing.

2016-02-09 Thread Fujii Masao
On Tue, Feb 9, 2016 at 9:11 PM, Michael Paquier wrote: > On Tue, Feb 9, 2016 at 4:27 PM, Fujii Masao wrote: >> Thanks for updating the patch! >> Attached is the updated version of the patch. >> I removed unnecessary assertion check and change of

Re: [HACKERS] Existence check for suitable index in advance when concurrently refreshing.

2016-02-09 Thread Fujii Masao
On Wed, Feb 10, 2016 at 2:21 AM, Fujii Masao wrote: > On Tue, Feb 9, 2016 at 9:11 PM, Michael Paquier > wrote: >> On Tue, Feb 9, 2016 at 4:27 PM, Fujii Masao wrote: >>> Thanks for updating the patch! >>> Attached is the

Re: [HACKERS] Existence check for suitable index in advance when concurrently refreshing.

2016-02-09 Thread Michael Paquier
On Wed, Feb 10, 2016 at 2:23 AM, Fujii Masao wrote: > On Wed, Feb 10, 2016 at 2:21 AM, Fujii Masao wrote: >> On Tue, Feb 9, 2016 at 9:11 PM, Michael Paquier >> wrote: >>> On Tue, Feb 9, 2016 at 4:27 PM, Fujii Masao

Re: [HACKERS] Existence check for suitable index in advance when concurrently refreshing.

2016-02-08 Thread Fujii Masao
On Thu, Jan 28, 2016 at 1:01 AM, Masahiko Sawada wrote: > On Wed, Jan 27, 2016 at 4:42 PM, Fujii Masao wrote: >> On Tue, Jan 26, 2016 at 9:33 PM, Masahiko Sawada >> wrote: >>> Hi all, >>> >>> In concurrently refreshing

Re: [HACKERS] Existence check for suitable index in advance when concurrently refreshing.

2016-01-27 Thread Masahiko Sawada
On Wed, Jan 27, 2016 at 4:42 PM, Fujii Masao wrote: > On Tue, Jan 26, 2016 at 9:33 PM, Masahiko Sawada > wrote: >> Hi all, >> >> In concurrently refreshing materialized view, we check whether that >> materialized view has suitable index(unique and

Re: [HACKERS] Existence check for suitable index in advance when concurrently refreshing.

2016-01-26 Thread Fujii Masao
On Tue, Jan 26, 2016 at 9:33 PM, Masahiko Sawada wrote: > Hi all, > > In concurrently refreshing materialized view, we check whether that > materialized view has suitable index(unique and not having WHERE > condition), after filling data to new snapshot >

[HACKERS] Existence check for suitable index in advance when concurrently refreshing.

2016-01-26 Thread Masahiko Sawada
Hi all, In concurrently refreshing materialized view, we check whether that materialized view has suitable index(unique and not having WHERE condition), after filling data to new snapshot (refresh_matview_datafill()). This logic leads to taking a lot of time until postgres returns ERROR log if