Re: [HACKERS] Fast Default WIP patch for discussion

2017-04-06 Thread Andres Freund
Hi, On 2017-04-05 22:31:15 -0700, Serge Rielau wrote: > Andres, > Yes, I still want to push this in. However I have not had time to get back to > it. I’m embarrassed to say that I don’t even know where the comments that > were issued occurred. > Cheers Serge You mean https://www.postgresql.org/

Re: [HACKERS] Fast Default WIP patch for discussion

2017-04-05 Thread Serge Rielau
Andres, Yes, I still want to push this in. However I have not had time to get back to it. I’m embarrassed to say that I don’t even know where the comments that were issued occurred. Cheers Serge via Newton Mail [https://cloudmagic.com/k/d/mailapp?ct=dx&cv=9.4.52&pv=10.11.6&source=email_footer_2

Re: [HACKERS] Fast Default WIP patch for discussion

2017-04-05 Thread Andres Freund
Hi Serge, On 2016-10-28 08:28:11 -0700, Serge Rielau wrote: > Time for me to dig into that then. Are you planning to update your POC at some point? This'd be a very welcome improvement. Regards, Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to y

Re: [HACKERS] Fast Default WIP patch for discussion

2016-12-01 Thread Haribabu Kommi
On Sat, Oct 29, 2016 at 2:28 AM, Serge Rielau wrote: > Time for me to dig into that then. > Closed in 2016-11 commitfest with "returned with feedback" status. Please feel free to update the status once you submit the updated patch. Regards, Hari Babu Fujitsu Australia

Re: [HACKERS] Fast Default WIP patch for discussion

2016-10-28 Thread Serge Rielau
> On Oct 28, 2016, at 5:46 AM, Robert Haas wrote: > > On Fri, Oct 21, 2016 at 7:15 PM, Serge Rielau wrote: >> Some key design points requiring discussion: >> 1. Storage of the “exist” (working name) default >> Right now the patch stores the default value in its binary form as it >> would be i

Re: [HACKERS] Fast Default WIP patch for discussion

2016-10-28 Thread Robert Haas
On Fri, Oct 21, 2016 at 7:15 PM, Serge Rielau wrote: > Some key design points requiring discussion: > 1. Storage of the “exist” (working name) default >Right now the patch stores the default value in its binary form as it > would be in the tuple into a BYTEA. >It would be feasible to store

Re: [HACKERS] Fast Default WIP patch for discussion

2016-10-28 Thread Robert Haas
On Wed, Oct 26, 2016 at 11:43 AM, Serge Rielau wrote: > Posting to this group on a Friday evening was obviously a Bad Idea(tm). :-) Not really. It's just that complex patches often don't get an immediate response because people are too busy to look at them and think about them in detail. If you

Re: [HACKERS] Fast Default WIP patch for discussion

2016-10-26 Thread Petr Jelinek
Hi, On 26/10/16 18:22, Serge Rielau wrote: > Euler, > > Thanks, I was previously told I should post a WIP patch here. > There are too many open issues to be near committing. > Anyway, I have created a patch. > https://commitfest.postgresql.org/11/843/# Adding to commitfest is act of asking for

Re: [HACKERS] Fast Default WIP patch for discussion

2016-10-26 Thread Serge Rielau
Euler, Thanks, I was previously told I should post a WIP patch here. There are too many open issues to be near committing. Anyway, I have created a patch. https://commitfest.postgresql.org/11/843/# Since this is my first time I do have a couple of questions: There are entries for a git and a wiki

Re: [HACKERS] Fast Default WIP patch for discussion

2016-10-26 Thread Euler Taveira
On 26-10-2016 12:43, Serge Rielau wrote: > Posting to this group on a Friday evening was obviously a Bad Idea(tm). :-) > Serge, add your patch to the next commitfest [1] so we don't forget to review it. [1] https://commitfest.postgresql.org/11/ -- Euler Taveira Timbira -

Re: [HACKERS] Fast Default WIP patch for discussion

2016-10-26 Thread Serge Rielau
Hackers, Posting to this group on a Friday evening was obviously a Bad Idea(tm). :-) Let me clarify that I’m at this point not looking for any detailed review. Rather I’m hoping to drive towards design decisions on the below. So any opining would be much appreciated. > On Oct 21, 2016, at 4:15 PM

[HACKERS] Fast Default WIP patch for discussion

2016-10-21 Thread Serge Rielau
As promised and requested find attached a work in progress patch for fast defaults.This is my first patch, I hope I used the right format…..The premise of the feature is to avoid a table rewrite when adding a column with a default.This is done by remembering the default value in pg_attribute instea