On 2015-07-17 19:57:22 +0100, Andrew Gierth wrote:
Attached is the current version of my fix (with Jeevan's regression
tests plus one of mine).
Pushed, thanks for the report and fix!
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
On 2015-07-17 11:37:26 +0530, Jeevan Chalke wrote:
However I wonder why we are supporting GROUPING SETS inside GROUPING SETS.
On Oracle, it is throwing an error.
We are not trying to be Oracle compatible, but just curious to know.
The SQL specification seems to be pretty unambigous about
Hello,
At Mon, 20 Jul 2015 15:45:21 +0530, Jeevan Chalke
jeevan.cha...@enterprisedb.com wrote in
CAM2+6=X9QWgbjJrR-dcLXh-RvvpGy=9enhuoghzrxhcj2kv...@mail.gmail.com
On Sat, Jul 18, 2015 at 12:27 AM, Andrew Gierth and...@tao11.riddles.org.uk
wrote:
Kyotaro == Kyotaro HORIGUCHI
On Sat, Jul 18, 2015 at 12:27 AM, Andrew Gierth and...@tao11.riddles.org.uk
wrote:
Kyotaro == Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp
writes:
Kyotaro Hello, this looks to be a kind of thinko. The attached patch
Kyotaro fixes it.
No, that's still wrong. Just knowing that there
On Wed, Jul 15, 2015 at 10:21 PM, Andrew Gierth and...@tao11.riddles.org.uk
wrote:
Jeevan == Jeevan Chalke jeevan.cha...@enterprisedb.com writes:
Jeevan Hi,
Jeevan It looks like we do support nested GROUPING SETS, I mean Sets
Jeevan withing Sets, not other types. However this nesting
Hello, this looks to be a kind of thinko. The attached patch
fixes it.
===
According to the comment of transformGroupingSet, it assumes that
the given GROUPING SETS node is already flatted out and
flatten_grouping_sets() does that. The details of the
transformation is described in the comment for
Kyotaro == Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp writes:
Kyotaro Hello, this looks to be a kind of thinko. The attached patch
Kyotaro fixes it.
No, that's still wrong. Just knowing that there is a List is not enough
to tell whether to concat it or append it.
Jeevan's original
Jeevan == Jeevan Chalke jeevan.cha...@enterprisedb.com writes:
Jeevan Hi,
Jeevan It looks like we do support nested GROUPING SETS, I mean Sets
Jeevan withing Sets, not other types. However this nesting is broken.
Good catch, but I'm not yet sure your fix is correct; I'll need to look
into
Hi,
It looks like we do support nested GROUPING SETS, I mean Sets withing
Sets, not other types. However this nesting is broken.
Here is the simple example where I would expect three rows in the
result. But unfortunately it is giving unrecognized node type
error. Which is something weird and
