Re: [HACKERS] Guarding against bugs-of-omission in initdb's setup_depend

2017-06-22 Thread Tom Lane
Robert Haas writes: > On Thu, Jun 22, 2017 at 2:11 PM, Tom Lane wrote: >> So I'm thinking about adding a regression test case, say in dependency.sql, >> that looks for unpinned objects with OIDs in the hand-assigned range, >> along the lines of this

Re: [HACKERS] Guarding against bugs-of-omission in initdb's setup_depend

2017-06-22 Thread Robert Haas
On Thu, Jun 22, 2017 at 2:11 PM, Tom Lane wrote: > While thinking about something else, it started to bother me that > initdb's setup_depend() function knows exactly which catalogs might > contain pinnable objects. It is not very hard to imagine that somebody > might add a

[HACKERS] Guarding against bugs-of-omission in initdb's setup_depend

2017-06-22 Thread Tom Lane
While thinking about something else, it started to bother me that initdb's setup_depend() function knows exactly which catalogs might contain pinnable objects. It is not very hard to imagine that somebody might add a DATA() line to, say, pg_transform.h and expect that the represented object could