Re: [HACKERS] GucContext of log_autovacuum

2007-09-10 Thread Bruce Momjian 

FYI, this has been committed by Tom.

---

ITAGAKI Takahiro wrote:
> The GucContext of log_autovacuum is PGC_BACKEND in the CVS HEAD,
> but should it be PGC_SIGHUP? We cannot modify the variable on-the-fly
> because the parameter is used only by autovacuum worker processes.
> The similar variables, like autovacuum_vacuum_scale_factor, are
> defined as PGC_SIGHUP.
> 
> 
> Index: src/backend/utils/misc/guc.c
> ===
> --- src/backend/utils/misc/guc.c  (head)
> +++ src/backend/utils/misc/guc.c  (working copy)
> @@ -1552,7 +1552,7 @@
>   },
>  
>   {
> - {"log_autovacuum", PGC_BACKEND, LOGGING_WHAT,
> + {"log_autovacuum", PGC_SIGHUP, LOGGING_WHAT,
>   gettext_noop("Sets the minimum execution time above 
> which autovacuum actions "
>"will be logged."),
>   gettext_noop("Zero prints all actions.  The default is 
> -1 (turning this feature off)."),
> 
> Regards,
> ---
> ITAGAKI Takahiro
> NTT Open Source Software Center
> 
> 
> ---(end of broadcast)---
> TIP 4: Have you searched our list archives?
> 
>http://archives.postgresql.org

-- 
  Bruce Momjian  <[EMAIL PROTECTED]>  http://momjian.us
  EnterpriseDB   http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster

Re: [HACKERS] GucContext of log_autovacuum

2007-09-09 Thread Tom Lane 
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes:
> The GucContext of log_autovacuum is PGC_BACKEND in the CVS HEAD,
> but should it be PGC_SIGHUP?

Indeed, and it was already documented as though it was SIGHUP, so this
is obviously just a typo.  Patch applied, thanks.

regards, tom lane

---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster

Re: [HACKERS] GucContext of log_autovacuum

2007-07-24 Thread Simon Riggs 
On Tue, 2007-07-24 at 13:50 +0900, ITAGAKI Takahiro wrote:
> The GucContext of log_autovacuum is PGC_BACKEND in the CVS HEAD,
> but should it be PGC_SIGHUP? We cannot modify the variable on-the-fly
> because the parameter is used only by autovacuum worker processes.
> The similar variables, like autovacuum_vacuum_scale_factor, are
> defined as PGC_SIGHUP.

Agreed, PGC_SIGHUP seems a much better setting. The PGC_BACKEND setting
originated with me and probably nobody thought to change that aspect of
the patch. 

-- 
  Simon Riggs
  EnterpriseDB  http://www.enterprisedb.com


---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster

[HACKERS] GucContext of log_autovacuum

2007-07-23 Thread ITAGAKI Takahiro 
The GucContext of log_autovacuum is PGC_BACKEND in the CVS HEAD,
but should it be PGC_SIGHUP? We cannot modify the variable on-the-fly
because the parameter is used only by autovacuum worker processes.
The similar variables, like autovacuum_vacuum_scale_factor, are
defined as PGC_SIGHUP.


Index: src/backend/utils/misc/guc.c
===
--- src/backend/utils/misc/guc.c(head)
+++ src/backend/utils/misc/guc.c(working copy)
@@ -1552,7 +1552,7 @@
},
 
{
-   {"log_autovacuum", PGC_BACKEND, LOGGING_WHAT,
+   {"log_autovacuum", PGC_SIGHUP, LOGGING_WHAT,
gettext_noop("Sets the minimum execution time above 
which autovacuum actions "
 "will be logged."),
gettext_noop("Zero prints all actions.  The default is 
-1 (turning this feature off)."),

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center


---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org