Re: [HACKERS] Ignore tablespace ACLs when ignoring schema ACLs

2017-02-05 Thread Noah Misch
On Sun, Feb 05, 2017 at 01:48:09PM -0500, Tom Lane wrote: > Noah Misch writes: > > On Sun, Feb 05, 2017 at 12:46:41PM -0500, Tom Lane wrote: > >> Is there any likely use-case for providing separate control flags for the > >> two permission checks? That would require an API change for DefineIndex,

Re: [HACKERS] Ignore tablespace ACLs when ignoring schema ACLs

2017-02-05 Thread Tom Lane
Noah Misch writes: > On Sun, Feb 05, 2017 at 12:46:41PM -0500, Tom Lane wrote: >> Is there any likely use-case for providing separate control flags for the >> two permission checks? That would require an API change for DefineIndex, >> making this considerably more invasive, so I'm not pushing for

Re: [HACKERS] Ignore tablespace ACLs when ignoring schema ACLs

2017-02-05 Thread Noah Misch
On Sun, Feb 05, 2017 at 12:46:41PM -0500, Tom Lane wrote: > Noah Misch writes: > > DefineIndex() has a check_rights argument that determines whether to > > perform a > > namespace ACL check. When ALTER TABLE ALTER TYPE rebuilds an index, it sets > > that flag. The theory goes that use of DROP I

Re: [HACKERS] Ignore tablespace ACLs when ignoring schema ACLs

2017-02-05 Thread Tom Lane
Noah Misch writes: > DefineIndex() has a check_rights argument that determines whether to perform a > namespace ACL check. When ALTER TABLE ALTER TYPE rebuilds an index, it sets > that flag. The theory goes that use of DROP INDEX and CREATE INDEX is a mere > implementation detail of ALTER TABLE

[HACKERS] Ignore tablespace ACLs when ignoring schema ACLs

2017-02-04 Thread Noah Misch
DefineIndex() has a check_rights argument that determines whether to perform a namespace ACL check. When ALTER TABLE ALTER TYPE rebuilds an index, it sets that flag. The theory goes that use of DROP INDEX and CREATE INDEX is a mere implementation detail of ALTER TABLE ALTER TYPE; the operation is