Re: [HACKERS] Incorrect mentions to pg_xlog in walmethods.c/h

2017-07-04 Thread Michael Paquier
On Wed, Jul 5, 2017 at 2:29 PM, Ryan Murphy wrote: > The following review has been posted through the commitfest application: > make installcheck-world: not tested > Implements feature: not tested > Spec compliant: not tested > Documentation:not tested > > This commit

Re: [HACKERS] Incorrect mentions to pg_xlog in walmethods.c/h

2017-07-04 Thread Ryan Murphy
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested This commit only affects comments, so I'm confident it doesn't break code, t

Re: [HACKERS] Incorrect mentions to pg_xlog in walmethods.c/h

2017-06-30 Thread Michael Paquier
On Sat, Jul 1, 2017 at 3:41 AM, Peter Eisentraut wrote: > On 6/27/17 01:26, Michael Paquier wrote: >> I have noticed $subject. A patch is attached. Those comments are not >> completely wrong either as pg_basebackup can generate pg_xlog as well, >> still I would recommend to just mention "pg_wal".

Re: [HACKERS] Incorrect mentions to pg_xlog in walmethods.c/h

2017-06-30 Thread Peter Eisentraut
On 6/27/17 01:26, Michael Paquier wrote: > I have noticed $subject. A patch is attached. Those comments are not > completely wrong either as pg_basebackup can generate pg_xlog as well, > still I would recommend to just mention "pg_wal". committed -- Peter Eisentraut http://www.2ndQu

[HACKERS] Incorrect mentions to pg_xlog in walmethods.c/h

2017-06-26 Thread Michael Paquier
Hi all, I have noticed $subject. A patch is attached. Those comments are not completely wrong either as pg_basebackup can generate pg_xlog as well, still I would recommend to just mention "pg_wal". Thanks, -- Michael walmethods-comments.patch Description: Binary data -- Sent via pgsql-hackers