Re: [HACKERS] JsonbValue to Jsonb conversion

2014-10-13 Thread Pavel Stehule
Hi I am working on review of this patch. There is new warnings: jsonb.c: In function ‘jsonb_agg_transfn’: jsonb.c:1540:20: warning: assignment makes pointer from integer without a cast v.val.numeric = DirectFunctionCall1(numeric_uplus, NumericGetDatum(v.val.numeric));

Re: [HACKERS] JsonbValue to Jsonb conversion

2014-10-13 Thread Andrew Dunstan
On 10/13/2014 06:41 AM, Pavel Stehule wrote: Hi I am working on review of this patch. The patch attached to the message you are replying to was never intended to be reviewed. It was only given by way of illustration of a technique. The original patch to be reviewed is on the message

Re: [HACKERS] JsonbValue to Jsonb conversion

2014-10-13 Thread Pavel Stehule
2014-10-13 15:45 GMT+02:00 Andrew Dunstan and...@dunslane.net: On 10/13/2014 06:41 AM, Pavel Stehule wrote: Hi I am working on review of this patch. The patch attached to the message you are replying to was never intended to be reviewed. It was only given by way of illustration of a

Re: [HACKERS] JsonbValue to Jsonb conversion

2014-10-13 Thread Tom Lane
Pavel Stehule pavel.steh...@gmail.com writes: I checked this last version - warning is out, but SIGFAULT on jsonb test is there .. I rechecked it with clang compiler, but result is same Stack trace please? regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] JsonbValue to Jsonb conversion

2014-10-13 Thread Pavel Stehule
2014-10-13 16:19 GMT+02:00 Tom Lane t...@sss.pgh.pa.us: Pavel Stehule pavel.steh...@gmail.com writes: I checked this last version - warning is out, but SIGFAULT on jsonb test is there .. I rechecked it with clang compiler, but result is same Stack trace please? (gdb) bt #0

Re: [HACKERS] JsonbValue to Jsonb conversion

2014-10-13 Thread Pavel Stehule
Hi A JsonSemAction sem is not well initialized a array_element_start is not initialized and enforces sigfault on my comp *** ./utils/adt/jsonb.c.orig2014-10-13 16:37:00.479708142 +0200 --- ./utils/adt/jsonb.c2014-10-13 16:36:33.704650644 +0200 *** *** 786,791 ---

Re: [HACKERS] JsonbValue to Jsonb conversion

2014-10-13 Thread Pavel Stehule
2014-10-13 15:45 GMT+02:00 Andrew Dunstan and...@dunslane.net: On 10/13/2014 06:41 AM, Pavel Stehule wrote: Hi I am working on review of this patch. The patch attached to the message you are replying to was never intended to be reviewed. It was only given by way of illustration of a

[HACKERS] JsonbValue to Jsonb conversion

2014-09-23 Thread Dmitry Dolgov
Hi all, I'm faced with some troubles about the jsonb implementation, and I hope I'll get little advice =) If I understand correctly, an abstract function for jsonb modification should have the following stages: Jsonb - JsonbValue - Modification - JsonbValue - Jsonb One can convert the

Re: [HACKERS] JsonbValue to Jsonb conversion

2014-09-23 Thread Andrew Dunstan
On 09/23/2014 12:23 PM, Dmitry Dolgov wrote: Hi all, I'm faced with some troubles about the jsonb implementation, and I hope I'll get little advice =) If I understand correctly, an abstract function for jsonb modification should have the following stages: Jsonb - JsonbValue - Modification