Re: [HACKERS] Let psql process files with 4,294,967,295 lines

2006-08-11 Thread Bruce Momjian
Patch applied. Thanks. Unnecessary #include file removed. --- David Fetter wrote: On Sun, Jul 30, 2006 at 05:40:16PM -0400, Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: David Fetter wrote: This

Re: [HACKERS] Let psql process files with 4,294,967,295 lines

2006-08-03 Thread Bruce Momjian
[ Tom's include adjustment added.] Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it.

[HACKERS] Let psql process files with 4,294,967,295 lines

2006-07-30 Thread David Fetter
Folks, I just ran across an issue where in psql, people can get the line number in the file so long as it is under 2^32-1 lines long, but once it gets larger than that, it's hosed. This patch changes the data type from unsigned int to unsigned long long, which is probably not the correct thing

Re: [HACKERS] Let psql process files with 4,294,967,295 lines

2006-07-30 Thread Alvaro Herrera
David Fetter wrote: Hi, I just ran across an issue where in psql, people can get the line number in the file so long as it is under 2^32-1 lines long, but once it gets larger than that, it's hosed. This patch changes the data type from unsigned int to unsigned long long, which is probably

Re: [HACKERS] Let psql process files with 4,294,967,295 lines

2006-07-30 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: David Fetter wrote: This patch changes the data type from unsigned int to unsigned long long, which is probably not the correct thing in order to get 64-bit arithmetic, but I figure it's good enough to get a discussion started. The only thing I can

Re: [HACKERS] Let psql process files with 4,294,967,295 lines

2006-07-30 Thread David Fetter
On Sun, Jul 30, 2006 at 05:40:16PM -0400, Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: David Fetter wrote: This patch changes the data type from unsigned int to unsigned long long, which is probably not the correct thing in order to get 64-bit arithmetic, but I figure it's

Re: [HACKERS] Let psql process files with 4,294,967,295 lines

2006-07-30 Thread Tom Lane
David Fetter [EMAIL PROTECTED] writes: + #include pg_config.h You should not need that. All PG code assumes that c.h and its inclusions have already been read. regards, tom lane ---(end of broadcast)--- TIP 6: explain