Re: [HACKERS] Locale dependency in new postgres_fdw test

2017-07-21 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> We could stabilize this test result by forcing lc_messages = C in >> the foreign server options. However, that would lose regression >> coverage of situations where the remote locale is different, which >> doesn't seem like a

Re: [HACKERS] Locale dependency in new postgres_fdw test

2017-07-21 Thread Alvaro Herrera
Tom Lane wrote: > We could stabilize this test result by forcing lc_messages = C in > the foreign server options. However, that would lose regression > coverage of situations where the remote locale is different, which > doesn't seem like a terribly good thing. I don't understand what is the

Re: [HACKERS] Locale dependency in new postgres_fdw test

2017-07-21 Thread Tom Lane
I wrote: > I had not realized (or forgot) that postgres_fdw allows the remote > end to run in whatever lc_messages locale is default for the remote > installation. It's a bit surprising that none of the existing test > cases expose any remote-side messages directly, but evidently not. > We could

[HACKERS] Locale dependency in new postgres_fdw test

2017-07-21 Thread Tom Lane
So 8bf58c0d9 immediately blew up in the buildfarm, with eg this on jaguarundi: *** *** 130,136 ALTER SERVER loopback OPTIONS (SET dbname 'no such database'); SELECT c3, c4 FROM ft1 ORDER BY c3, c1 LIMIT 1; -- should fail ERROR: could not connect to server "loopback" !