Re: [HACKERS] Mention to pg_backup in pg_dump.c

2016-10-13 Thread Michael Paquier 
On Fri, Oct 14, 2016 at 5:08 AM, Tom Lane  wrote:
> Michael Paquier  writes:
>> I just bumped into the following thing in pg_dump.c:
>> /* Set default options based on progname */
>> if (strcmp(progname, "pg_backup") == 0)
>> format = "c";
>> As far as I can see this comes from e8f69be0 dated of 2000. Couldn't
>> this be removed? I have never seen traces of pg_backup in the code.
>
> Looks dead to me too --- deleted.

Thanks.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Mention to pg_backup in pg_dump.c

2016-10-13 Thread Tom Lane 
Michael Paquier  writes:
> I just bumped into the following thing in pg_dump.c:
> /* Set default options based on progname */
> if (strcmp(progname, "pg_backup") == 0)
> format = "c";
> As far as I can see this comes from e8f69be0 dated of 2000. Couldn't
> this be removed? I have never seen traces of pg_backup in the code.

Looks dead to me too --- deleted.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Mention to pg_backup in pg_dump.c

2016-10-12 Thread Michael Paquier 
Hi all,

I just bumped into the following thing in pg_dump.c:
/* Set default options based on progname */
if (strcmp(progname, "pg_backup") == 0)
format = "c";
As far as I can see this comes from e8f69be0 dated of 2000. Couldn't
this be removed? I have never seen traces of pg_backup in the code.

Regards,
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers