Re: [HACKERS] Multiple false-positive warnings from Valgrind

2017-04-05 Thread Noah Misch
On Wed, Mar 29, 2017 at 12:34:52PM +0900, Michael Paquier wrote: > On Thu, Mar 23, 2017 at 5:15 PM, Michael Paquier > wrote: > > On Tue, Mar 21, 2017 at 10:57 PM, Aleksander Alekseev > > wrote: > >> Recently I've decided to run PostgreSQL

Re: [HACKERS] Multiple false-positive warnings from Valgrind

2017-04-01 Thread Michael Paquier
On Sat, Apr 1, 2017 at 2:51 PM, Noah Misch wrote: > Does this remove the noise under --with-openssl? > > --- a/src/port/pg_strong_random.c > +++ b/src/port/pg_strong_random.c > @@ -104,7 +104,10 @@ pg_strong_random(void *buf, size_t len) > */ > #if

Re: [HACKERS] Multiple false-positive warnings from Valgrind

2017-03-31 Thread Noah Misch
On Fri, Mar 31, 2017 at 04:40:07PM +0300, Aleksander Alekseev wrote: > > > And it seems to me that this is caused by the routines of OpenSSL. > > > When building without --with-openssl, using the fallback > > > implementations of SHA256 and RAND_bytes I see no warnings generated > > > by

Re: [HACKERS] Multiple false-positive warnings from Valgrind

2017-03-31 Thread Aleksander Alekseev
Hi Kyotaro, > > And it seems to me that this is caused by the routines of OpenSSL. > > When building without --with-openssl, using the fallback > > implementations of SHA256 and RAND_bytes I see no warnings generated > > by scram_build_verifier... I think it makes most sense to discard that > >

Re: [HACKERS] Multiple false-positive warnings from Valgrind

2017-03-28 Thread Kyotaro HORIGUCHI
At Wed, 29 Mar 2017 12:34:52 +0900, Michael Paquier wrote in > On Thu, Mar 23, 2017 at 5:15 PM, Michael Paquier > wrote: > > On Tue, Mar 21, 2017 at 10:57 PM, Aleksander

Re: [HACKERS] Multiple false-positive warnings from Valgrind

2017-03-28 Thread Michael Paquier
On Thu, Mar 23, 2017 at 5:15 PM, Michael Paquier wrote: > On Tue, Mar 21, 2017 at 10:57 PM, Aleksander Alekseev > wrote: >> Recently I've decided to run PostgreSQL under Valgrind according to wiki >> description [1]. Lots of warnings are

Re: [HACKERS] Multiple false-positive warnings from Valgrind

2017-03-23 Thread Michael Paquier
On Tue, Mar 21, 2017 at 10:57 PM, Aleksander Alekseev wrote: > Recently I've decided to run PostgreSQL under Valgrind according to wiki > description [1]. Lots of warnings are generated [2] but it is my > understanding that all of them are false-positive. For instance

[HACKERS] Multiple false-positive warnings from Valgrind

2017-03-21 Thread Aleksander Alekseev
Hello. I need a little help. Recently I've decided to run PostgreSQL under Valgrind according to wiki description [1]. Lots of warnings are generated [2] but it is my understanding that all of them are false-positive. For instance I've found these two reports particularly interesting: ```